[erlang-questions] Controversial subject of the day: tabs and spaces for indentation

Benoit Chesneau <>
Thu Feb 6 10:44:07 CET 2014


On Thu, Feb 6, 2014 at 10:41 AM, Lukas Larsson <> wrote:

> On Thu, Feb 6, 2014 at 10:34 AM, Benoit Chesneau <>wrote:
>
>> On Thu, Feb 6, 2014 at 10:31 AM, Lukas Larsson <> wrote:
>>
>>> On Thu, Feb 6, 2014 at 9:38 AM, Loïc Hoguin <> wrote:
>>>
>>>>
>>>> Plus this doesn't help your code get merged at all. If you submit code
>>>> with broken whitespace, then tools will also display this whitespace
>>>> change. You can of course hide whitespace changes, but the problem is that
>>>> whitespace does matter in some places, so you're basically hiding
>>>> potentially important information by doing that.
>>>>
>>>> This is in my opinion the reason why it would be a very bad thing to do
>>> a huge commit that changes the current whitespace format of a project to
>>> another. It is already very hard to figure out what change could have
>>> caused a bug without having to deal with whitespace changes in the middle
>>> of a diff.
>>>
>>
>> well then commit a whitespace change diff, then the change you really
>> wanted to make. It of course requires to have a standard defined at first :)
>>
>> For single commits this would work, but will not work when I want to do
> "git diff OTP_R14B03..OTP_17.0-rc1"
>


Ah sure, but I never heard of any good solution to fix the past in one
pass. Imo  slowly fixing step by step, changees by changes would be enough.
At list the large diff expose the issue for those who care.

- benoit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20140206/13c5f589/attachment.html>


More information about the erlang-questions mailing list