<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 6, 2014 at 10:41 AM, Lukas Larsson <span dir="ltr"><<a href="mailto:lukas@erlang.org" target="_blank">lukas@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">On Thu, Feb 6, 2014 at 10:34 AM, Benoit Chesneau <span dir="ltr"><<a href="mailto:bchesneau@gmail.com" target="_blank">bchesneau@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div>On Thu, Feb 6, 2014 at 10:31 AM, Lukas Larsson <span dir="ltr"><<a href="mailto:lukas@erlang.org" target="_blank">lukas@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Thu, Feb 6, 2014 at 9:38 AM, Loïc Hoguin <span dir="ltr"><<a href="mailto:essen@ninenines.eu" target="_blank">essen@ninenines.eu</a>></span> wrote:<br>
</div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Plus this doesn't help your code get merged at all. If you submit code with broken whitespace, then tools will also display this whitespace change. You can of course hide whitespace changes, but the problem is that whitespace does matter in some places, so you're basically hiding potentially important information by doing that.<br>
<br></blockquote></div><div>This is in my opinion the reason why it would be a very bad thing to do a huge commit that changes the current whitespace format of a project to another. It is already very hard to figure out what change could have caused a bug without having to deal with whitespace changes in the middle of a diff. </div>
</div></div></div></blockquote><div><br></div></div></div><div>well then commit a whitespace change diff, then the change you really wanted to make. It of course requires to have a standard defined at first :)</div><span><font color="#888888"><div>
<br></div></font></span></div></div></div></blockquote></div></div><div>For single commits this would work, but will not work when I want to do "git diff OTP_R14B03..OTP_17.0-rc1"</div></div></div></div></blockquote>
<div><br></div><div><br></div><div>Ah sure, but I never heard of any good solution to fix the past in one pass. Imo slowly fixing step by step, changees by changes would be enough. At list the large diff expose the issue for those who care.</div>
<div><br></div><div>- benoit</div><div><br></div><div> </div></div></div></div>