[erlang-patches] Fix wrong spec for ets:new/2 in HiPE/dialyzer

Jesper Louis Andersen <>
Thu Dec 16 13:24:40 CET 2010


On Thu, Dec 16, 2010 at 10:20, Kostis Sagonas <> wrote:
>
> Your Erlang code is ok, but please change some things in the comment:
>
>  - adding extra spaces and the trailing | in the line which reads:
>        Option = Type | Access |  named_table  |  {keypos,Pos}  |
>   is totally unnecessary -- and the | is arguably wrong there

Good catch, fixed.

>  - use boolean() instead of bool() and integer() instead of int().
>   The OTP documentation should be updated to use the proper names
>   of these types.

Fixed in the comments. I agree that there is a need to walk through
the documentation and update any appearance of bool() with boolean().
Part of the reason bool() is still used by people is due to this
terminology use in documentation. A quick git grep on bool\(\) suggest
that there are around 3000 places to fix, as an upper bound (there may
be considerably less, but not more). A daunting task, if one also need
to check formatting.

> If you do these changes, your patch can be included as is in 'dev'.

I'll let cooking be up to you to decide :) Personally I was aiming for
a cooking in 'pu' first - mind you, I have not executed the test cases
on it, partially because I don't know what tests to narrow it down to.
It would seem easy to include in 'pu' for a batch of testing and then
just grad it to 'dev'. But as I said, your call.

Ammended patch is refetchable at,

git fetch git://github.com/jlouis/otp.git fix-hipe-spec-ets-new


-- 
J.


More information about the erlang-patches mailing list