[erlang-patches] Fix GCC detection in ERTS' Makefiles

Jean-Sébastien Pédron <>
Fri Dec 18 09:44:18 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17.12.2009 09:16, Björn Gustavsson wrote:
> 1. Is there any good reason to have two commits? It seems to me
> that the commits should be combined to one using 'git rebase -i HEAD~2'.

I just changed my approach because the first commit was GCC-centric. I
did what you suggested and squashed the second commit into the first one.

> 2. Is it really necessary to change Makefiles that don't actually use
> the CC_NAME variable (such as lib/orber/c_src/Makefile)?

I will remove the unnecessary ones. I did it in order for other
Makefiles to be "ready" if a test is included :)

- --
Jean-Sébastien Pédron
http://www.dumbbell.fr/

PGP Key: http://www.dumbbell.fr/pgp/pubkey.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksrQOIACgkQa+xGJsFYOlOyHgCdFJF5QMnuVQb+xVen7jWWRPV3
ujoAoJNUXNBsPykVE2SJqb156PsmFGVk
=LhwT
-----END PGP SIGNATURE-----


More information about the erlang-patches mailing list