[erlang-patches] Fix GCC detection in ERTS' Makefiles

Björn Gustavsson <>
Fri Dec 18 10:08:56 CET 2009


2009/12/18 Jean-Sébastien Pédron <>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 17.12.2009 09:16, Björn Gustavsson wrote:
>> 1. Is there any good reason to have two commits? It seems to me
>> that the commits should be combined to one using 'git rebase -i HEAD~2'.
>
> I just changed my approach because the first commit was GCC-centric. I
> did what you suggested and squashed the second commit into the first one.

Thanks!

>> 2. Is it really necessary to change Makefiles that don't actually use
>> the CC_NAME variable (such as lib/orber/c_src/Makefile)?
>
> I will remove the unnecessary ones. I did it in order for other
> Makefiles to be "ready" if a test is included :)

Yes, I understand.

Actually, I think that you can keep all changes to the Makefiles
in the erts application, and only remove the changes in all other
applications.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list