[erlang-patches] Fix GCC detection in ERTS' Makefiles

Björn Gustavsson <>
Thu Dec 17 09:16:57 CET 2009


On Wed, Dec 16, 2009 at 11:13 PM, Jean-Sébastien Pédron
<> wrote:
> I propose a fix for this, described on this article:
> http://wiki.github.com/dumbbell/otp/gcc-detection-in-makefiles
>
> The patch is available in my "gcc_detection" branch:
> git fetch git://github.com/dumbbell/otp.git gcc_detection
>

Thanks! Included in 'pu'.

I have two questions.

1. Is there any good reason to have two commits? It seems to me
that the commits should be combined to one using 'git rebase -i HEAD~2'.

2. Is it really necessary to change Makefiles that don't actually use
the CC_NAME variable (such as lib/orber/c_src/Makefile)?
It would be much easier for us to accept the patch if it only changed
the Makefiles that actually tests for gcc (for technical reasons; in
the background we still use Clearcase and some of the applications
are maintained on branches that are common to several major
releases of Erlang/OTP).

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list