[erlang-questions] Would like some feedback

[Frans Schneider]

Thank you all for taking the time to look at my code. Very much appreciated!

Cheers,

Frans


On 11/25/2015 01:13 PM, Jesper Louis Andersen wrote:
>
> On Tue, Nov 24, 2015 at 7:18 PM, Frans Schneider <schneider@REDACTED 
> <mailto:schneider@REDACTED>> wrote:
>
>     So, any comments are most welcome.
>
>
> Small nitpick as well: You want to put your curve25519 and hkdf 
> libraries as dependencies in the .app.src. If you build a release with 
> axolotl, then this is needed to automatically include those 
> dependencies, and they are necessary to make the program run.
>
> You also need to supply any other dependencies, like mnesia there.
>
> As Sergej writes, you can win a lot by splitting off dependencies on 
> mnesia and also split protocol encoding/decoding from session 
> handling. That way, it becomes easier to adapt the protocol to other 
> systems. When you have easy concurrency, it is often alluring to use 
> it in every project you see. But beware, since it also tend to bind 
> you into a specific architecture.
>
>
>
> -- 
> J.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20151126/b14c7f19/attachment.htm>