[erlang-questions] Feedback on the code, please? :)
Peter Mechlenborg
pmm@REDACTED
Mon Jul 25 23:34:51 CEST 2011
Hi Mikhail
One comment on your code. I always put the function clauses for the
base-case at the top and I think this is the norm. Others will hopefully
correct me if I am mistaken.
Other than that I don't have much to comment. It looks good in my eyes.
You can find a modified version of you code here:
https://gist.github.com/1105252
Not sure if it is better than your version, though.
Best regards,
-- Peter Mechlenborg
On Mon, Jul 25, 2011 at 9:27 PM, Mikhail Sobolev
<mikhail.sobolev@REDACTED>wrote:
> Hi,
>
> I have written a simple tool for finding duplicate files in the given
> set of directories[1]. I'd appreciate if somebody could have a look
> and comment on the code :)
>
> --
> Misha (learning erlang)
>
> [1] https://github.com/sa2ajj/dups/blob/master/dups
> _______________________________________________
> erlang-questions mailing list
> erlang-questions@REDACTED
> http://erlang.org/mailman/listinfo/erlang-questions
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20110725/20f2de6e/attachment.htm>
More information about the erlang-questions
mailing list