Hi Mikhail<div><br></div><div>One comment on your code. I always put the function clauses for the base-case at the top and I think this is the norm. Others will hopefully correct me if I am mistaken.</div><div><br></div>
<div>Other than that I don't have much to comment. It looks good in my eyes.</div><div><br></div><div>You can find a modified version of you code here:</div><div><a href="https://gist.github.com/1105252">https://gist.github.com/1105252</a></div>
<div>Not sure if it is better than your version, though.</div><div><br></div><div>Best regards,</div><div><br></div><div> -- Peter Mechlenborg</div><div><br></div><div><div class="gmail_quote">On Mon, Jul 25, 2011 at 9:27 PM, Mikhail Sobolev <span dir="ltr"><<a href="mailto:mikhail.sobolev@gmail.com">mikhail.sobolev@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi,<br>
<br>
I have written a simple tool for finding duplicate files in the given<br>
set of directories[1]. I'd appreciate if somebody could have a look<br>
and comment on the code :)<br>
<font color="#888888"><br>
--<br>
Misha (learning erlang)<br>
<br>
[1] <a href="https://github.com/sa2ajj/dups/blob/master/dups" target="_blank">https://github.com/sa2ajj/dups/blob/master/dups</a><br>
_______________________________________________<br>
erlang-questions mailing list<br>
<a href="mailto:erlang-questions@erlang.org">erlang-questions@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-questions" target="_blank">http://erlang.org/mailman/listinfo/erlang-questions</a><br>
</font></blockquote></div><br></div>