[erlang-questions] 'cannot' /= 'can not'

[Raimo Niskanen]

On Tue, Jul 31, 2018 at 08:22:16PM +0200, empro2@REDACTED wrote:
> Am Mon, 30 Jul 2018 10:56:15 +0200
> schrieb Raimo Niskanen
> <raimo+erlang-questions@REDACTED>:
> 
> > Thank you for the review!
> 
> Not at all! least I could do having brought this up.
> 
> 
> > I think now is a better time than most, thanks to being
> > vacation time...
> 
> I wonder what to do with the notes I took while at it.
> 
>  - EEP: overkill, completely wrong place.
> 
>  - erlang-patches? The things there do look different.
> 
>  - bugs.erlang.org: as an improvement? and then each one
>    separately? there is nothing like it (yet)(?)
> 
> I noted down 4 and a half cases in which the change itself
> seems to be of little use. As I could not make much sense of
> the text in these cases (using only the extended diff
> contexts) my "suggestions" are no more than possibly helpful
> phrasings.

I would say that the appropriate way would be to fork the project at GitHub
and to submit pull request / a pull request.  Documentation improvements
are a good thing.

I also noted that in some of the places the "cannot" change was only a tiny
improvement and that the surrounding text really would benefit from being
reworked.

But I wanted my pull request to only change one thing, not only according to
our pull request guidelines...

Thank you for pointing at the bad wordings below, we'll see if someone
steps up.  Now they at least are on record. 

/ Raimo


> 
> The notes are down below my name, introduced by
> ===, [comments in square brackets].
> 
> I have no experience with projects of that size and no idea
> about the hassle : gain ratio.
> 
> Michael
> 
> 
> === erts/emulator/beam/erl_db_tree.c 3129
> https://github.com/erlang/otp/pull/1891/files#diff-30fdd1356f85b600e88e98de46e5a338
> 
> 	+	erts_fprintf(stderr," cannot match lesser
> 	  than ");
> 
> less than [This is the half one: not misleading, but seems
> so basic a message that it might be desirable to have
> "correct".]
> 
> 
> === erts/doc/src/notes.xml 9902
> https://github.com/erlang/otp/pull/1891/files#diff-eb82a09c6aefc9ef174ead9c8181a141
> 
> and there
> 
> === lib/stdlib/doc/src/notes.xml 3657
> https://github.com/erlang/otp/pull/1891/files#diff-4e42fb7d23d206e8b0fcbfd4858b1672
> 
> 	<p> To roughly the old behaviour, to not wait for
> 	ports and async threads operations when you exit the
> 	emulator, you use erlang:halt/2 with an integer
> 	first argument and an option list containing
> 	{flush,false} as the second argument. Note that now
> 	is flushing not dependant of the
> 	-	   exit code, and you can not only flush
> 	  async threads
> 	+	   exit code, and you cannot only flush
> 	  async threads
> 	operations which we deemed as a strange behaviour
> 	anyway. </p>
> 
> To roughly approximate the old behaviour,[?]
> which was to not wait ... when you exit the emulator,[?]
> use erlang:halt/2 [without the "you"?]
> Note that flushing does not depend on the exit code anymore
> [??]
> and you are no longer restricted to flushing async threads
> operations only[?]
> , a restriction we deemed strange anyway.[?, useful?
> replace with:]
> ; now you can flush sync ones too.[?]
> 
> 
> === lib/observer/src/observer_wx.erl 809
> https://github.com/erlang/otp/pull/1891/files#diff-ebe399fc76aff158ba9cb898ccfba2d2
> 
> 	    %% If already started, somebody else may use it.
> 	+   %% We cannot use it too, as far log file would
> 	  be overriden. Not fair.
> 
> somebody else may be using it.[But is this about using it
> at all? or about preventing the start of a second one?]
> 
> We must not start a second one[?],
> as that would overwrite the remote log file.[?]
> 
> 
> === lib/odbc/doc/src/notes_history.xml 196
> https://github.com/erlang/otp/pull/1891/files#diff-c673d56ed2511271ba68533de94c9b13
> 
> 	+   connection cannot be established. No
> 	  connection no process it is expected.
> 
> No connection, no process; just as one would expect.[??]
> 
> 
> -- 
> 
> Reasonable is that which cannot be criticised reasonably.
> 
> 
> 
> 
> 
> 
> 
> 
> 

-- 

/ Raimo Niskanen, Erlang/OTP, Ericsson AB