[erlang-questions] OTP-compliant patches

Steve Vinoski <>
Fri Feb 7 14:49:40 CET 2014


On Fri, Feb 7, 2014 at 2:42 AM, Vlad Dumitrescu <> wrote:

> Hi,
>
> Just so that I make sure I understand correctly, in the light of the
> flame war that I recently started :-\
>
> The documentation says
>
> > Make sure your changes follow the coding and indentation style of the
> code surrounding your
> > changes. (At some point in the future, there will be a style guide,
> either included in the
> > documentation or on some web site, but it is not ready yet.)
>
> So if the local indentation is not what erlang-mode would give, then I
> still have to manually adjust it to match what already was there. Is
> that correct?
>

IMO yes, that's correct. BTW this approach is typical of most software
projects -- I recall being taken to task for breaking this rule way back in
1987, a lesson I've never forgotten.


> Since I've had some diff look ok in emacs but not on github (or the
> other way around, I don't remember exactly), which one is the
> reference in case of mismatch?
>

Of course, the typical reason for edits looking incorrect on github is
using spaces where you need tabs for vice versa. Unfortunately, some files
use a mixture of tabs and spaces, with some lines using tabs for leading
whitespace and others using only spaces. My approach of dynamically setting
the emacs indent-tabs-mode variable locally in the buffer based on
searching the file for leading tabs upon opening it often works but isn't
foolproof, since localized areas of the file might use spaces rather than
tabs or vice versa. The only way I'm aware of to be fully sure that I'm
respecting existing whitespace practices in the files I edit is to visually
check the diffs.

--steve
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20140207/1a880e25/attachment.html>


More information about the erlang-questions mailing list