[erlang-questions] FOP (was: Re: Trace-Driven Development)

Henning Diedrich <>
Thu Jun 7 12:40:42 CEST 2012


Sorry for hitting a merry tone. I realize this was inappropriate  ;-)

If it's wrong for OTP I think for other purposes it's still pretty neat.

 From the flames in this thread, maybe OTP would care to reconsider.

It's easy to look at the actual patch, the diff, at github and heal the 
history later.

Henning

On 6/7/12 12:18 PM, Anthony Ramine wrote:
> Editing directly from GitHub makes you unable to check that you wrote 
> lines too long (under 80 columns).
> Also it produces nondescript branch names like "patch-1".
>
> Furthermore, Erlang/OTP explicitely forbid pull requests for contribution.
>
> For all these points, I would say it's not neat at all.
>
> --
> Anthony Ramine
>
> Le 7 juin 2012 à 12:06, H. Diedrich a écrit :
>
>> I think github-online editing worked, quite nicely even.
>>
>> The process seems tedious but what you get for free is quite nice.
>>
>> https://github.com/erlang/otp/pull/24
>>
>> You  click "edit this file", it creates a github fork for you.
>> When you change and click "save" the changes are saved to your fork.
>> Then you are automatically put on the screen where you send a pull 
>> request.
>> As for example the link above.
>>
>> Pretty neat in my view. Absolutely usable so far. A fully documented 
>> and repository-based, click-and-point patching process.
>>
>> Henning
>>
>> Magnus Henoch schrieb:
>>> ----- Original Message -----
>>>    
>>>> On 7 June 2012 12:23, OvermindDL1<>  wrote:
>>>>      
>>>>> On Wed, Jun 6, 2012 at 7:50 AM, Michael Turner
>>>>> <>  wrote:
>>>>>        
>>>>>>> and nobody
>>>>>>> bothers to correct the mistakes.
>>>>>>>            
>>>>>> Not "nobody". For example, I'm one of those weird people who will
>>>>>> spend 30 seconds to sign up for almost any wiki I see a typo in.
>>>>>>          
>>>>> For what it is worth, I am one as well.  Some sort of user-editable
>>>>> documentation (even something that I could comment on like the
>>>>> Haskell
>>>>> one) would be nice.
>>>>>        
>>>> One very easy to implement solution would be to put the sources of
>>>> the
>>>> document into GitHub and use pull requests. This is especially handy
>>>> these days, given that GitHub supports in-browser editing.
>>>>      
>>>
>>> So I decided to try this out.  I went to
>>> https://github.com/erlang/otp/blob/maint/lib/et/doc/src/et_intro.xml  ,
>>> clicked "Edit this file", removed the stray apostrophe on line 43,
>>> typed in a commit message, and clicked "Propose file change".  I got
>>> a very fancy 500 error page that changes perspective when I move the
>>> mouse; no sign of anything being committed to my otp fork on Github.
>>>
>>> Is there a workaround for that?
>>>
>>> Regards,
>>>    
>>
>> _______________________________________________
>> erlang-questions mailing list
>>  <mailto:>
>> http://erlang.org/mailman/listinfo/erlang-questions
>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20120607/93fdae26/attachment.html>


More information about the erlang-questions mailing list