<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000066">
<div class="moz-cite-prefix">Sorry for hitting a merry tone. I
realize this was inappropriate ;-)<br>
<br>
If it's wrong for OTP I think for other purposes it's still pretty
neat.<br>
<br>
From the flames in this thread, maybe OTP would care to
reconsider.<br>
<br>
It's easy to look at the actual patch, the diff, at github and
heal the history later.<br>
<br>
Henning<br>
<br>
On 6/7/12 12:18 PM, Anthony Ramine wrote:<br>
</div>
<blockquote
cite="mid:7EC5BEC3-3B2D-445C-92F3-E3C21F416459@gmail.com"
type="cite">Editing directly from GitHub makes you unable to check
that you wrote lines too long (under 80 columns).
<div>Also it produces nondescript branch names like "patch-1".</div>
<div><br>
</div>
<div>Furthermore, Erlang/OTP explicitely forbid pull requests for
contribution.</div>
<div><br>
</div>
<div>For all these points, I would say it's not neat at all.</div>
<div> <br>
<div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse:
separate; color: rgb(0, 0, 0); font-family: Helvetica;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-border-horizontal-spacing: 0px;
-webkit-border-vertical-spacing: 0px;
-webkit-text-decorations-in-effect: none;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; font-size: medium; ">
<div>--</div>
<div>Anthony Ramine</div>
<div><br>
</div>
</span></div>
<div>
<div>Le 7 juin 2012 à 12:06, H. Diedrich a écrit :</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div bgcolor="#ffffff" text="#000000">
I think github-online editing worked, quite nicely even.<br>
<br>
The process seems tedious but what you get for free is
quite nice.<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://github.com/erlang/otp/pull/24">https://github.com/erlang/otp/pull/24</a><br>
<br>
You click "edit this file", it creates a github fork for
you.<br>
When you change and click "save" the changes are saved to
your fork.<br>
Then you are automatically put on the screen where you
send a pull
request.<br>
As for example the link above.<br>
<br>
Pretty neat in my view. Absolutely usable so far. A fully
documented
and repository-based, click-and-point patching process.<br>
<br>
Henning<br>
<br>
Magnus Henoch schrieb:
<blockquote
cite="mid:336ca0d8-0c5b-447d-940a-6b9f1d4dcbe4@knuth"
type="cite">
<pre wrap="">----- Original Message -----
</pre>
<blockquote type="cite">
<pre wrap="">On 7 June 2012 12:23, OvermindDL1 <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:overminddl1@gmail.com"><overminddl1@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Wed, Jun 6, 2012 at 7:50 AM, Michael Turner
<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:michael.eugene.turner@gmail.com"><michael.eugene.turner@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">and nobody
bothers to correct the mistakes.
</pre>
</blockquote>
<pre wrap="">Not "nobody". For example, I'm one of those weird people who will
spend 30 seconds to sign up for almost any wiki I see a typo in.
</pre>
</blockquote>
<pre wrap="">For what it is worth, I am one as well. Some sort of user-editable
documentation (even something that I could comment on like the
Haskell
one) would be nice.
</pre>
</blockquote>
<pre wrap="">One very easy to implement solution would be to put the sources of
the
document into GitHub and use pull requests. This is especially handy
these days, given that GitHub supports in-browser editing.
</pre>
</blockquote>
<pre wrap=""><!---->
So I decided to try this out. I went to
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://github.com/erlang/otp/blob/maint/lib/et/doc/src/et_intro.xml">https://github.com/erlang/otp/blob/maint/lib/et/doc/src/et_intro.xml</a> ,
clicked "Edit this file", removed the stray apostrophe on line 43,
typed in a commit message, and clicked "Propose file change". I got
a very fancy 500 error page that changes perspective when I move the
mouse; no sign of anything being committed to my otp fork on Github.
Is there a workaround for that?
Regards,
</pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
erlang-questions mailing list<br>
<a moz-do-not-send="true"
href="mailto:erlang-questions@erlang.org">erlang-questions@erlang.org</a><br>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-questions">http://erlang.org/mailman/listinfo/erlang-questions</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<br>
</body>
</html>