[erlang-questions] Possible enhancement for Makefile.in of R14B01

[Niclas Axelsson]

On 12/10/2010 03:47 PM, Boris Mühmer wrote:
> I just completed my "Pull Request"... Hopefully I did it right!
>
>
>    - boris
>
>
> Am Freitag, den 10.12.2010, 10:36 -0330 schrieb Alain O'Dea:
>    
>> I like this fix.  If you are comfortable using Git, I suggest sending
>> this as a Pull Request to http://github.com/erlang/otp as it will make
>> integration easier :)
>>
>> On Friday, December 10, 2010, Boris Mühmer<boris.muehmer@REDACTED>  wrote:
>>      
>>> After still having problems with installing the R14B01 release from
>>> source using _my_ scripts (1st I thought it is "sudo", than "make" and
>>> at last "env"), I made the following patch to "Makefile.in":
>>>
>>> The output of "diff otp_src_R14B01/Makefile.in
>>> otp_src_R14B01-1/Makefile.in" is:
>>>
>>> 412c412
>>> <        $(ERL_TOP)/lib/erl_docgen/priv/bin/xref_mod_app.escript -topdir
>>> $(ERL_TOP) -outfile $(ERL_TOP)/make/$(TARGET)/mod2app.xml
>>> ---
>>>        
>>>>        $(ERL_TOP)/bin/escript
>>>>          
>>> $(ERL_TOP)/lib/erl_docgen/priv/bin/xref_mod_app.escript -topdir
>>> $(ERL_TOP) -outfile $(ERL_TOP)/make/$(TARGET)/mod2app.xml
>>>
>>> It basically only adds "$(ERL_TOP)/bin/escript" to the call of
>>> "xref_mod_app.escript" and thus forces the system to use the escript
>>> from the source directory, because "env" may fall back to an old
>>> "escript" (if it can find one at all!) which fails to locate/include the
>>> file "xmerl/include/xmerl.hrl".
>>>
>>> I am not sure if this modification should be included in the official
>>> distribution... and what the proper way is... (About to check the FAQs).
>>>
>>>
>>>    - boris
>>>
>>>
>>> ________________________________________________________________
>>> erlang-questions (at) erlang.org mailing list.
>>> See http://www.erlang.org/faq.html
>>> To unsubscribe; mailto:erlang-questions-unsubscribe@REDACTED
>>>
>>>
>>>        
>
>
> ________________________________________________________________
> erlang-questions (at) erlang.org mailing list.
> See http://www.erlang.org/faq.html
> To unsubscribe; mailto:erlang-questions-unsubscribe@REDACTED
>    
Hi Boris,
It's great that you want to submit patches, but please do not use pull 
request to submit it.
Instead you should follow the instructions on 
https://github.com/erlang/otp/wiki/Submitting-patches.

Regards,
Niclas Axelsson, Erlang/OTP