[erlang-patches] Allow rb to use any io_device/registered name instead of only filename path
Mon Jul 15 16:34:40 CEST 2013
On 2013-07-15 15:26, Björn-Egil Dahlberg wrote:
> On 2013-07-14 00:04, PAILLEAU Eric wrote:
>> Le 13/07/2013 21:54, PAILLEAU Eric a écrit :
>>> Le 09/07/2013 09:21, Siri Hansen a écrit :
>>>> Eric, I'm sorry for the delay! I've looked at your patch again, and I
>>>> think it looks good now. I would like you to amend your commits
>>>> into one
>>>> single commit since keeping them separate does not add any value imo.
>>> Hello Siri,
>>> no problem for the delay, I was busy too.
>>> I squashed the last commits into the first.
>>> I will try to add tests in the rb_SUITE, and then come back to you.
>> Hello Siri,
>> Adding tests in rb_SUITE was easier than I thought .
>> ct_run is ok and everything merged into a single commit.
>> Please refetch .
>> Best regards
Your branch failed to build the documentation. I added this to your branch:
/ldisk/egil/community-patches/otp-patches $ git diff
diff --git a/lib/sasl/doc/src/rb.xml b/lib/sasl/doc/src/rb.xml
index bfde58e..b94914d 100644
@@ -138,7 +138,6 @@
<fsummary>Log reports list</fsummary>
> Siri is on vacation (most of otp is on vacation). Reviewing will be
> resumed once they are back.
> // Björn-Egil
>> erlang-patches mailing list
> erlang-patches mailing list
More information about the erlang-patches