[erlang-patches] Bug fixes for cover

Fredrik <>
Thu Jan 10 10:45:20 CET 2013


Hello,
Your patch has been into review and the feedback you got back was that 
everything looks good but you have to remove the '?line' macros, because 
they are not used and thus has no effect anymore.
Please fix this and give me a notice when it is done

BR Fredrik Gustafsson
Erlang OTP Team
On 11/28/2012 02:11 PM, José Valim wrote:
> Hello,
>
> I am sending a couple bug fixes for cover.
>
> I have broken those fixes into three granular commits.
> The commit messages contains the rationale behind them.
>
> One of the commits changes cover to get the source from
> "Module:module_info(compile)" if the current heuristic that
> traverses directories fails. In my opinion, we could rely
> solely on the source information and remove the heuristic
> completely but I have kept the current heuristic as the first
> mechanism in order to minimize the impact of the changes.
>
> As such, I would appreciate if those changes could be merged
> into maint. :)
>
> git fetch git://github.com/josevalim/otp.git 
> <http://github.com/josevalim/otp.git> cover-patches
>
> https://github.com/josevalim/otp/compare/cover-patches
> https://github.com/josevalim/otp/compare/cover-patches.patch
>
> Thank you,
>
>
> *José Valim*
> www.plataformatec.com.br <http://www.plataformatec.com.br/>
> Skype: jv.ptec
> Founder and Lead Developer
>
>
>
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130110/f81aa691/attachment-0001.html>


More information about the erlang-patches mailing list