<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
Your patch has been into review and the feedback you got back was
that everything looks good but you have to remove the '?line'
macros, because they are not used and thus has no effect anymore.<br>
Please fix this and give me a notice when it is done<br>
<br>
BR Fredrik Gustafsson<br>
Erlang OTP Team<br>
On 11/28/2012 02:11 PM, José Valim wrote:
<blockquote
cite="mid:CAGnRm4L7yBjKKKARZ42NaOQ+Q9ug+1LBAqRj5_efnr_dNWSygQ@mail.gmail.com"
type="cite">
<div>Hello,</div>
<div><br>
</div>
<div>I am sending a couple bug fixes for cover.</div>
<div><br>
</div>
<div>I have broken those fixes into three granular commits.</div>
<div>The commit messages contains the rationale behind them.</div>
<div><br>
</div>
<div>One of the commits changes cover to get the source from</div>
<div>"Module:module_info(compile)" if the current heuristic that</div>
<div>traverses directories fails. In my opinion, we could rely</div>
<div>solely on the source information and remove the heuristic</div>
<div>completely but I have kept the current heuristic as the first</div>
<div>mechanism in order to minimize the impact of the changes.</div>
<div><br>
</div>
<div>As such, I would appreciate if those changes could be merged</div>
<div>into maint. :)</div>
<div><br>
</div>
<div>git fetch git://<a moz-do-not-send="true"
href="http://github.com/josevalim/otp.git">github.com/josevalim/otp.git</a>
cover-patches</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://github.com/josevalim/otp/compare/cover-patches">https://github.com/josevalim/otp/compare/cover-patches</a></div>
<div><a moz-do-not-send="true"
href="https://github.com/josevalim/otp/compare/cover-patches.patch">https://github.com/josevalim/otp/compare/cover-patches.patch</a></div>
<div><br>
</div>
<div>Thank you,</div>
<div><br>
</div>
<div><br>
</div>
<div><span style="font-size:13px">
<div><span
style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse"><b>José
Valim</b></span></div>
<div>
<span
style="font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">
<div><span
style="font-family:verdana,sans-serif;font-size:x-small"><a
moz-do-not-send="true"
href="http://www.plataformatec.com.br/"
style="color:rgb(42,93,176)" target="_blank">www.plataformatec.com.br</a></span></div>
<div><span
style="font-family:verdana,sans-serif;font-size:x-small">Skype:
jv.ptec</span></div>
<div><span
style="font-family:verdana,sans-serif;font-size:x-small">Founder
and Lead Developer</span></div>
</span></div>
</span></div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
erlang-patches mailing list
<a class="moz-txt-link-abbreviated" href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a>
<a class="moz-txt-link-freetext" href="http://erlang.org/mailman/listinfo/erlang-patches">http://erlang.org/mailman/listinfo/erlang-patches</a>
</pre>
</blockquote>
<br>
</body>
</html>