[erlang-patches] Change the return value of hipe_bifs:remove_refs_from/1

Kostis Sagonas <>
Tue Feb 19 11:16:28 CET 2013


On 02/18/2013 12:21 PM, Fredrik wrote:
>   On 02/13/2013 09:17 AM, Kostis Sagonas wrote:
>> Please include:
>>
>> git fetch git://github.com/kostis/otp.git hipe_bif-remove_refs_from
>>
>> Kostis
>> _______________________________________________
> Hello Kostis,
> Your patch seems to fail testcase:
> code_SUITE, ext_mod_dep
> With the reason:
>
> not_verified({'$M_EXPR','$F_EXPR',1}, [{lists,foreach,2},
>                                         {hipe_unified_loader,
>                                          mark_referred_from,1},
>                                         {hipe_unified_loader,get_refs_from,2},
>                                         ...
>                                         {code_server,loop,1},
>                                         {code_server,system_continue,3}])
>
>
> After discussions, after discussion you should either use a list
> comprehension here or add lists:foreach to the testcase.

Hi Fredrik,

I think I've fixed this particular test case (*). Please re-fetch.

Kostis

(*) On my PC there is another test of code_SUITE that's failing, but I 
do not understand why (or how it's related).  However, I am sure you 
will enlighten me if it also fails for you ;)


More information about the erlang-patches mailing list