[erlang-patches] Change the return value of hipe_bifs:remove_refs_from/1

Fredrik <>
Mon Feb 18 12:21:20 CET 2013


On 02/13/2013 09:17 AM, Kostis Sagonas wrote:
> Please include:
>
>   git fetch git://github.com/kostis/otp.git hipe_bif-remove_refs_from
>
> Kostis
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches
Hello Kostis,
Your patch seems to fail testcase:
code_SUITE, ext_mod_dep
With the reason:

not_verified({'$M_EXPR','$F_EXPR',1}, [{lists,foreach,2},
                                        {hipe_unified_loader,
                                         mark_referred_from,1},
                                        {hipe_unified_loader,get_refs_from,2},
                                        {hipe_unified_loader,load_common,4},
                                        {hipe_unified_loader,load_module,4},
                                        {hipe_unified_loader,load_native_code,
                                         2},
                                        {code_server,load_native_code,2},
                                        {code_server,try_load_module_1,5},
                                        {code_server,try_load_module,5},
                                        {code_server,do_load_binary,5},
                                        {code_server,handle_call,3},
                                        {code_server,loop,1},
                                        {code_server,system_continue,3}])


After discussions, after discussion you should either use a list 
comprehension here or add lists:foreach to the testcase.

-- 

BR Fredrik Gustafsson
Erlang OTP Team

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130218/0c9343ed/attachment-0001.html>


More information about the erlang-patches mailing list