[erlang-patches] trivial bug in jinterface

Fredrik <>
Fri Feb 1 11:24:57 CET 2013


On 02/01/2013 11:13 AM, Nico Kruber wrote:
> On Friday 01 Feb 2013 09:58:54 Vlad Dumitrescu wrote:
>> Hi!
>>
>> I found a small problem in jinterface. It has been around for a while now,
>> it happens in a corner case that probably nobody ever uses.
>>
>> In OtpErlangTuple(OtpErlangObject[], int, int), when the size of the slice
>> used is 0, then the elems fields remains uninitialized, it is the parameter
>> that gets assigned.
>>
>> I used master as base, I hope it's still possible to do that.
>>
>> git fetch git://github.com/vladdu/otp.git tuple_constructor_bug
>>
>> https://github.com/vladdu/otp/compare/tuple_constructor_bug
>> https://github.com/vladdu/otp/compare/tuple_constructor_bug.patch
>>
>> Given that there are no other tests for jinterface at this level, do you
>> want me to write one for this case?
>>
>> best regards,
>> Vlad
> your branch is outdated so the diff is not clean, i.e. contains a lot of other
> commits
> ->  please rebase your branch
> see https://github.com/erlang/otp/wiki/Submitting-patches
>
> it would probably also be good to base it on maint - but someone from the otp
> team needs to decide here :)
>
> your commit though seems reasonable
> https://github.com/vladdu/otp/commit/ee29a8aa733fbf1a1666b2f85a9fd6ff19d777b3
>
>
> Nico
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches
Hello,
Just rebase it on master will work fine for me.

-- 

BR Fredrik Gustafsson
Erlang OTP Team



More information about the erlang-patches mailing list