[erlang-patches] Implement add_report_sup_handler which calls gen_event:add_sup_handler

[Siri Hansen]

Hi Pedram!

After looking closer at what gen_event:add_sup_handler does, I see that it
sends a message if the handler is deleted. To avoid growing message queues,
this would have to be taken care of in the error_logger - which would
introduce the need to keep a state in the error_logger to know if the
deleted handler is supervised (and a message should be flushed) or not.

Could you please let us know a bit more about which problem the patch
should solve and possible use cases?

Regards
/siri


2013/4/9 Fredrik <fredrik@REDACTED>

>  On 04/09/2013 02:27 PM, Pedram Nimreezi wrote:
>
>  Following changes have been made..
> error_logger_SUITE tests added.
> error_logger module specs updated.
> better explanation added to commit message.
>
>  Branch rebased and updated. Thanks.
>
>
>  On Tue, Mar 12, 2013 at 11:03 AM, Pedram Nimreezi <mc@REDACTED>wrote:
>
>> Thank you for the update, I'll make the proper changes.
>>
>> On Tue, Mar 12, 2013 at 10:09 AM, Fredrik <fredrik@REDACTED> wrote:
>> > On 03/01/2013 08:15 PM, Pedram Nimreezi wrote:
>> >>
>> >> Hi,
>> >>
>> >> This patch adds add_report_sup_handler to the error_logger module
>> >>
>> >> To eliminate the need to go around the error_logger api, this patch
>> >> allows for a report_handler to be added via add_sup_handler.
>> >>
>> >> https://github.com/DeadZen/otp/compare/error-logger-sup_handler.patch
>> >> https://github.com/DeadZen/otp/compare/error-logger-sup_handler
>> >>
>> >> git fetch git://github.com/DeadZen/otp.git error-logger-sup_handler
>> >>
>> > Hello again,
>> > I've got some feedback on your patch.
>> > *The patch needs tests and documentation
>> > *The spec for add_report_sup_handler/1 is not sufficient, should it be
>> > "any()" really?
>> > *Your commit message is to short and needs further explanation.
>> >
>> >
>> > --
>> >
>> > BR Fredrik Gustafsson
>> > Erlang OTP Team
>> >
>> > _______________________________________________
>> > erlang-patches mailing list
>> > erlang-patches@REDACTED
>> > http://erlang.org/mailman/listinfo/erlang-patches
>>
>>
>>
>>   --
>> /* Sincerely
>> --------------------------------------------------------------
>> Pedram Nimreezi - Chief Technology Officer  */
>>
>> // The hardest part of design … is keeping features out. - Donald Norman
>>
>
>
>
>  --
> /* Sincerely
> --------------------------------------------------------------
> Pedram Nimreezi - Chief Technology Officer  */
>
>  // The hardest part of design … is keeping features out. - Donald Norman
>
>
>   Great,
> Re-fetched and assigned it for review again.
>
>
> --
>
> BR Fredrik Gustafsson
> Erlang OTP Team
>
>
> _______________________________________________
> erlang-patches mailing list
> erlang-patches@REDACTED
> http://erlang.org/mailman/listinfo/erlang-patches
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130410/11fd0313/attachment.htm>