<div dir="ltr"><div>Hi Pedram!</div><div><br></div><div>After looking closer at what gen_event:add_sup_handler does, I see that it sends a message if the handler is deleted. To avoid growing message queues, this would have to be taken care of in the error_logger - which would introduce the need to keep a state in the error_logger to know if the deleted handler is supervised (and a message should be flushed) or not.</div>
<div><br></div><div>Could you please let us know a bit more about which problem the patch should solve and possible use cases?</div><div><br></div><div style>Regards</div><div style>/siri</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">2013/4/9 Fredrik <span dir="ltr"><<a href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div><div class="h5">
On 04/09/2013 02:27 PM, Pedram Nimreezi wrote:
<blockquote type="cite">
<div dir="ltr">
<div><font face="arial, sans-serif">Following changes
have been made.. </font></div>
<div><font face="arial, sans-serif">error_logger_SUITE
tests added.</font></div>
<div><font face="arial, sans-serif">error_logger module
specs updated.</font></div>
<div><font face="arial, sans-serif">better explanation
added to commit message.</font></div>
<div><br>
</div>
<div>Branch rebased and updated. Thanks.</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
On Tue, Mar 12, 2013 at 11:03 AM, Pedram Nimreezi <span dir="ltr"><<a href="mailto:mc@majorcomputing.com" target="_blank">mc@majorcomputing.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thank you for the update, I'll make the proper changes.<br>
<div>
<div><br>
On Tue, Mar 12, 2013 at 10:09 AM, Fredrik <<a href="mailto:fredrik@erlang.org" target="_blank">fredrik@erlang.org</a>>
wrote:<br>
> On 03/01/2013 08:15 PM, Pedram Nimreezi wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> This patch adds add_report_sup_handler to the
error_logger module<br>
>><br>
>> To eliminate the need to go around the
error_logger api, this patch<br>
>> allows for a report_handler to be added via
add_sup_handler.<br>
>><br>
>> <a href="https://github.com/DeadZen/otp/compare/error-logger-sup_handler.patch" target="_blank">https://github.com/DeadZen/otp/compare/error-logger-sup_handler.patch</a><br>
>> <a href="https://github.com/DeadZen/otp/compare/error-logger-sup_handler" target="_blank">https://github.com/DeadZen/otp/compare/error-logger-sup_handler</a><br>
>><br>
>> git fetch git://<a href="http://github.com/DeadZen/otp.git" target="_blank">github.com/DeadZen/otp.git</a>
error-logger-sup_handler<br>
>><br>
> Hello again,<br>
> I've got some feedback on your patch.<br>
> *The patch needs tests and documentation<br>
> *The spec for add_report_sup_handler/1 is not
sufficient, should it be<br>
> "any()" really?<br>
> *Your commit message is to short and needs
further explanation.<br>
><br>
><br>
> --<br>
><br>
> BR Fredrik Gustafsson<br>
> Erlang OTP Team<br>
><br>
> _______________________________________________<br>
> erlang-patches mailing list<br>
> <a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a><br>
> <a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<br>
<br>
<br>
</div>
</div>
<div>
<div>--<br>
/* Sincerely<br>
--------------------------------------------------------------<br>
Pedram Nimreezi - Chief Technology Officer */<br>
<br>
// The hardest part of design … is keeping features
out. - Donald Norman<br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
/* Sincerely<br>
-------------------------------------------------------------- <br>
Pedram Nimreezi - Chief Technology Officer */
<div><br>
</div>
<div>
// The hardest part of design … is keeping features out. -
Donald Norman</div>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
</blockquote></div></div>
Great,<br>
Re-fetched and assigned it for review again.<div class="im"><br>
<br>
<pre cols="72">--
BR Fredrik Gustafsson
Erlang OTP Team</pre>
</div></div>
<br>_______________________________________________<br>
erlang-patches mailing list<br>
<a href="mailto:erlang-patches@erlang.org">erlang-patches@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><br>
<br></blockquote></div><br></div>