[erlang-patches] Fix 2 second delay after eval in shell running under ssh_cli

Bob Ippolito <>
Thu May 24 20:25:57 CEST 2012


Could you be more specific about which test(s) are failing?

Also, what's the procedure for building just the ssh application?
https://github.com/erlang/otp/wiki/Running-tests covers how to run tests
for a single application after building all of OTP, but not how to build it
again after making some changes.

On Thu, May 24, 2012 at 2:35 AM, Henrik Nord <> wrote:

>  This patch does not pass the test.
> We would like you to do the "more correct" fix as that is the better
> approach.
>
> Please run the tests and make sure they all pass and before submitting the
> patch.
>
>
> Thank you for the contribution!
>
>
>
> On 05/05/2012 04:02 AM, Bob Ippolito wrote:
>
> Fix 2 second delay after eval in shell running under ssh_cli
>
>  ssh_cli needs to reply to the tty_geometry message or else group
> will wait 2000 msec every time an expression is successfully
> evaluated in the shell.
>
>  A "more correct" fix might refactor io_request and io_requests to
> take Group as an argument so that it isn't special-cased in
> handle_msg.
>
>  git fetch git://github.com/etrepum/otp.git ssh_cli-tty_geometry
>
> *https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry*
> *https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry.patch
> *
>
>
> _______________________________________________
> erlang-patches mailing ://erlang.org/mailman/listinfo/erlang-patches
>
>
> --
> /Henrik Nord Erlang/OTP
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20120524/47715424/attachment.html>


More information about the erlang-patches mailing list