Could you be more specific about which test(s) are failing?<div><br></div><div>Also, what's the procedure for building just the ssh application? <a href="https://github.com/erlang/otp/wiki/Running-tests">https://github.com/erlang/otp/wiki/Running-tests</a> covers how to run tests for a single application after building all of OTP, but not how to build it again after making some changes.<br>
<br><div class="gmail_quote">On Thu, May 24, 2012 at 2:35 AM, Henrik Nord <span dir="ltr"><<a href="mailto:henrik@erlang.org" target="_blank">henrik@erlang.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
This patch does not pass the test.<br>
We would like you to do the "more correct" fix as that is the better
approach.<br>
<br>
Please run the tests and make sure they all pass and before
submitting the patch.<br>
<br>
<br>
Thank you for the contribution!<div class="im"><br>
<br>
<br>
On 05/05/2012 04:02 AM, Bob Ippolito wrote:
</div><blockquote type="cite"><div><div class="h5">
<div><font color="#222222" face="arial, sans-serif">Fix 2 second
delay after eval in shell running under ssh_cli</font></div>
<div><font color="#222222" face="arial, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, sans-serif">ssh_cli needs
to reply to the tty_geometry message or else group</font></div>
<div><font color="#222222" face="arial, sans-serif">will wait 2000
msec every time an expression is successfully</font></div>
<div><font color="#222222" face="arial, sans-serif">evaluated in
the shell.</font></div>
<div><font color="#222222" face="arial, sans-serif"><br>
</font></div>
<div><font color="#222222" face="arial, sans-serif">A "more
correct" fix might refactor io_request and io_requests to</font></div>
<div><font color="#222222" face="arial, sans-serif">take Group as
an argument so that it isn't special-cased in</font></div>
<div><font color="#222222" face="arial, sans-serif">handle_msg.</font></div>
<div><font color="#222222" face="arial, sans-serif"><br>
</font></div>
<span>git fetch </span><font color="#222222" face="arial,
sans-serif">git://<a href="http://github.com/etrepum/otp.git" target="_blank">github.com/etrepum/otp.git</a> ssh_cli-tty_geometry</font><br>
<br>
<font color="#1155cc" face="arial, sans-serif"><u><a href="https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry" target="_blank">https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry</a></u></font>
<div>
<font color="#1155cc"><u><font face="arial, sans-serif"><a href="https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry.patch" target="_blank">https://github.com/etrepum/otp/compare/maint...ssh_cli-tty_geometry.patch</a></font></u></font></div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>_______________________________________________
erlang-patches mailing list
<a href="mailto:erlang-patches@erlang.org" target="_blank">erlang-patches@erlang.org</a>
<a href="http://erlang.org/mailman/listinfo/erlang-patches" target="_blank">http://erlang.org/mailman/listinfo/erlang-patches</a><span class="HOEnZb"><font color="#888888">
</font></span></pre><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<pre cols="72">--
/Henrik Nord Erlang/OTP</pre>
</font></span></div>
</blockquote></div><br></div>