[erlang-patches] git pull requests

Henrik Nord <>
Tue Aug 16 09:26:35 CEST 2011



On 08/16/2011 08:13 AM, Anthony Ramine wrote:
> Hi,
>
> My understanding is that they won't use pull requests because they are
> impractical with regard to how they work with a 'proposed update' branch.
>
> Why issue a pull request if you are never to hit the merge button? The OTP
> team will never merge your branch into dev directly but they won't either
> test your branch alone, they will just let it bake into pu and maybe one day
> merge it into dev, I think there would be way too much pending pull requests
> on GitHub for this feature to be any useful.
>
> But that's just my two cents anyway.
>
> Le 16 août 2011 à 00:10, Garrett Smith a écrit :
>
>> In README.md:
>>
>> "We prefer to receive proposed updates via email on the erlang-patches
>> mailing list rather than through a pull request. Pull requests are not
>> practical because we have a strict policy never to merge any untested
>> changes to the development branch..."
>>
>> Apart from this statement being puzzling (pull requests don't prevent
>> testing prior to pushing to public repos), it seems like pull requests
>> are being used to submit patches.
>>
>> If git pull requests are acceptable, would it make sense to update README.md?
>>
>> I'd happily submit a pull request for this change, but, well :)
>>
>> Garrett
>> _______________________________________________
>> erlang-patches mailing list
>> 
>> http://erlang.org/mailman/listinfo/erlang-patches
Hello

We do not use pull requests for the reasons stated here amongst others.
We also want people to send them to the mailing list so that they are 
all preserved in the archives. This way if the patch is graduated, or 
rejected, others that come later can find this information. And will not 
try to patch something that we already rejected due to some reason or other.


The " it seems like pull requests are being used to submit patches." I 
can not explain what is seems like, but the only actions we have taken 
towards pull requests so far, as far as I know, is to close them and ask 
the submitter to send the patch through the mailing list.

Regards

-- 
/Henrik Nord Erlang/OTP



More information about the erlang-patches mailing list