[erlang-patches] [jinterface] added OtpMbox.hash()

Vlad Dumitrescu <>
Mon Sep 20 16:10:58 CEST 2010


2010/9/20 Björn Gustavsson <>:
> On Mon, Sep 20, 2010 at 3:00 PM, Vlad Dumitrescu <> wrote:
>> The OtpMbox class was missing the hash() method while overriding
>> equals(). This can cause problems when when using jinterface in a
>> larger Java application, for which there are currently no tests in
>> OTP.
>
> The motivation given above is much more useful
> if it is included in the commit message. See:

Fixed. sorry about that.

>> The fix is straightforward, if a test is required please let me
>> know.
>
> The reviewer will have to decide whether a test case is
> needed or not. Including a test with a bug fix will certainly
> increase the probability that we will include it.

Yes, I know, but in this case one has to start a Java application from
the OTP test suite, and handle that as a normal test case. I'm not
sure how the setup would have to be configured so that it works -- for
just this fix it's overkill, but if you think that testing jinterface
from the Java side is something that you will want to do, then it is
worth spending some effort on that. I am happily available to discuss
details. Maybe this can be handled outside the Erlang suite, with a
separate Java suite (the question is then if it's required to merge
the results into a single report).

regards,
Vlad


More information about the erlang-patches mailing list