[erlang-patches] [jinterface] added OtpMbox.hash()

Björn Gustavsson <>
Mon Sep 20 15:51:28 CEST 2010


On Mon, Sep 20, 2010 at 3:00 PM, Vlad Dumitrescu <> wrote:
> The OtpMbox class was missing the hash() method while overriding
> equals(). This can cause problems when when using jinterface in a
> larger Java application, for which there are currently no tests in
> OTP.

The motivation given above is much more useful
if it is included in the commit message. See:

http://github.com/erlang/otp/wiki/Writing-good-commit-messages

> The fix is straightforward, if a test is required please let me
> know.

The reviewer will have to decide whether a test case is
needed or not. Including a test with a bug fix will certainly
increase the probability that we will include it.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list