[erlang-patches] [PATCH 2/3] hipe: Do not auto-import min/2 and max/2

Kostis Sagonas <>
Mon Sep 13 17:20:22 CEST 2010


Tuncer Ayaz wrote:
> On Sun, Sep 12, 2010 at 11:20 PM, Mikael Pettersson wrote:
>> I initially thought that these min/max functions were local
>> function similar to the erlang ones (they didn't use to be
>> standard so we used to have to duplicate them), but the issue
>> in hipe_icode_type is that it explicitly imports min/max from
>> erl_types, and that explicit import triggers a warning due to
>> the newish auto-import from erlang.
>>
>> Given that I think your initial no_auto_import patch is Ok.
> 
> Isn't changing min() to erl_types:min() a cleaner change?

Absolutely.

A patch for this already appears in the hipe-fixes branch of my otp 
repository on github (http://github.com/kostis/otp/commits/hipe-fixes).

The relevant commit can be found at:

http://github.com/kostis/otp/commit/c244767dd19295812de33a038552853263727cc4

Kostis


More information about the erlang-patches mailing list