[erlang-patches] [PATCH 2/3] hipe: Do not auto-import min/2 and max/2

Tuncer Ayaz <>
Mon Sep 13 15:12:29 CEST 2010


On Sun, Sep 12, 2010 at 11:20 PM, Mikael Pettersson wrote:
>
> I initially thought that these min/max functions were local
> function similar to the erlang ones (they didn't use to be
> standard so we used to have to duplicate them), but the issue
> in hipe_icode_type is that it explicitly imports min/max from
> erl_types, and that explicit import triggers a warning due to
> the newish auto-import from erlang.
>
> Given that I think your initial no_auto_import patch is Ok.

Isn't changing min() to erl_types:min() a cleaner change?


More information about the erlang-patches mailing list