[erlang-patches] Serge's ei float patch

Steve Vinoski <>
Mon May 31 16:42:30 CEST 2010


2010/5/31 Björn-Egil Dahlberg <>:
> This looks good but I have some concerns:
>
>  - Aesthetics, coding convention: please refrain from C++ commenting.

Oops, I didn't even notice this in the original R12B-2 patch. Will fix.

>  - Distribution flags, the DFLAG_NEW_FLOATS option should be enabled in
>   lib/erl_interface/src/connect/ei_connect.c: static int
> send_name_or_challenge.
>   See lib/erl_interface/src/connect/ei_connect_int.h and
> lib/kernel/src/dist.hrl for some details.

Does the recv_challenge function in ei_connect.c need to verify that
DFLAG_NEW_FLOATS is set in the flags, treating it as an error if not
set (e.g. the same way DFLAG_EXTENDED_REFERENCES is handled)?

>  - I think that "legacy" should include this as well. It should, unless
> someone can think of a reason not to include it.

OK, I'll work on that.

> Anyway, with DFLAGS_NEW_FLOATS flag enabled the code would be tested as well
> which is a necessity in order for it to be included in the otp relase.

Which tests would exercise the DFLAGS_NEW_FLOATS flag?

Note that the code already submitted in this patch is definitely
tested by the erl_interface ei_print suite, since tests there were
failing with just the original R12B-2 patch.

thanks,
--steve


More information about the erlang-patches mailing list