[erlang-patches] New gen_stream behaviour

Raimo Niskanen <>
Tue May 18 14:33:14 CEST 2010


On Tue, May 18, 2010 at 10:21:40AM +0200, Raimo Niskanen wrote:
> On Mon, May 17, 2010 at 09:29:09AM -0700, Jay Nelson wrote:
> > 
> > On May 17, 2010, at 6:33 AM, Raimo Niskanen wrote:
> > >
> > >I do not think so since it does not affect the language
> > >nor the core modules. It may, however, need to be reviewed by
> > >the OTP technical board. We would also like community feedback
> > >on the behaviour of a new behaviour.
> > 
> > Please, absolutely.  I definitely want feedback.  I am sure that  
> > there are many improvements possible that I have not considered.
> > 
> > >>
> > >>git fetch git://github.com/jaynel/otp.git gen_stream
> > >
> > >Thanks. Included in 'pu' with whitespace fixes.
> > 
> > How is this done?   I did 'git diff --check' and didn't get  
> > anything.  How do you detect and fix whitespace issues?
> 
> There is a hook .git/hooks/pre-commit.sample
> that you rename to .git/hooks/pre-commit
> and then you can not commit any whitespace errors
> (some other problems are checked too).
> 
> The argument --check to git diff checks for whitespace errors.

Oops, you tried that, i realized. Sorry for sloppy reading.
Maybe you did `git diff --check' after commit. Then you
compared the head with the head. Before commit it should
work as intended. After commit you probably want
`git diff --check HEAD^' or against something older
than HEAD^ (the second to latest commit on current branch).

> 
> To fix I use git rebase --whitespace=fix
> 
> > 
> > jay
> 
> -- 
> 
> / Raimo Niskanen, Erlang/OTP, Ericsson AB
> 
> ________________________________________________________________
> erlang-patches (at) erlang.org mailing list.
> See http://www.erlang.org/faq.html
> To unsubscribe; mailto:

-- 

/ Raimo Niskanen, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list