[erlang-patches] Submitting patches via git format-patch/git am

Björn Gustavsson bgustavsson@REDACTED
Tue Feb 9 20:07:59 CET 2010


2010/2/9 Björn Gustavsson <bgustavsson@REDACTED>:
> On Tue, Feb 9, 2010 at 4:26 PM, Winston Smith
> <smith.winston.101@REDACTED> wrote:
>> I know that you suggest the best way to submit patches is to send a
>> link to a git repository that contains the patch(es), but do/will you
>> guys also accept patches via email in git "format-patch" form?
>
> We do.
>

When I said that, I assumed that you meant *inlined* patches.
Inlined patches in an email message can be reviewed and
commented on easily and a several patches in a series
can be saved to a mail folder and applied in one go.

I see no advantages with *attached* patches.

Was I too vague in my second paragraph? What I meant
was that we prefer to be able to do "git fetch", because
inlined patches may be corrupted by the email client and
we would constantly need to ask people to re-send them.

So if you know how to send patches inline without your
email client garbling them (or using "git send-email"),
feel free to send them that way. But please avoid
attached patches.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list