[erlang-patches] Fix handling of archive (.ez) files in code:clash/0

Björn Gustavsson <>
Fri Feb 5 14:45:14 CET 2010


2010/2/5 Tuncer Ayaz <>:

>> diff --git a/lib/kernel/test/code_SUITE.erl b/lib/kernel/test/code_SUITE.erl
>> index c8063ca..7712973 100644
>> --- a/lib/kernel/test/code_SUITE.erl
>> +++ b/lib/kernel/test/code_SUITE.erl
>> @@ -48,7 +48,7 @@ all(suite) ->
>>      delete, purge, soft_purge, is_loaded, all_loaded,
>>      load_binary, dir_req, object_code, set_path_file,
>>      pa_pz_option, add_del_path,
>> -     dir_disappeared, ext_mod_dep,
>> +     dir_disappeared, ext_mod_dep, clash,
>
> Interesting as this was part of the rebased tree
> to be found as
> http://github.com/tuncer/otp/commit/585f77
> and also in a previous state
> http://github.com/tuncer/otp/commit/5fcd29
>
> Maybe you took an earlier tree.

Yes, this is strange.

I fetched your branch early this morning.

>
> I've pushed a rebased atop of ccase/r13b04_dev tree
> with these changes but have to ask why we remove
> the two clauses. Every other test seems to have
> the suite and doc clause even if they only return []
> in both clauses.
>

Matter of taste.

"suite" is optional, so I see no reason to put it in
in new test cases. On the other hand, I don't find
it important enough to change old test cases.

"doc" is OK if it it actually gives more information
than the name of the test case. Since it didn't,
I ripped it out.

We currently do not have any tool that will
collect only document strings and produce
a nice report. I am not sure that anyone
is interested in such a report. The documentation
strings are usually not detailed enough to
be of any real use out-of-context.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list