[erlang-patches] Fix handling of archive (.ez) files in code:clash/0

Tuncer Ayaz <>
Fri Feb 5 13:08:07 CET 2010


2010/2/5 Björn Gustavsson <>:
> 2010/2/4 Tuncer Ayaz <>:
>> 2010/2/4 Björn Gustavsson <>:
>>> Thanks! Included in pu.
>>
>> Added tests for code:clash/0 to the same topic branch.
>>
>
> Looks good, with a few minor issues. The branch will
> probably graduate early next week.

Great, thanks for the quick review.
Many reltool, rebar and riak users will be thankful
if this gets included in R13B04 :).

> The following patch will be included in your branch
> when I'll push the pu branch later today. I intend to combine
> it with your commit before the branch is graduated.

Please see
http://github.com/tuncer/otp/commit/02d75ce
for a rebased tree with all the changes.

> (In separate commit I have also added a missing
> is_list(Config) guard test for another function in the
> same file.)

Thanks!

> ---
> Subject: [PATCH 1/2] fixup! fix minor issues
>
> To be combined with the previous commit.
>
> * Include the test in the all/1 function.
>
> * Add "when is_list(Config)" to make sure that the test
>  case properly ignores unknown atomic value.
>
> * Don't bother providing the 'doc' clause without any useful
>  information. Also omit the 'suite' clause.
> ---
>  lib/kernel/test/code_SUITE.erl |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lib/kernel/test/code_SUITE.erl b/lib/kernel/test/code_SUITE.erl
> index c8063ca..7712973 100644
> --- a/lib/kernel/test/code_SUITE.erl
> +++ b/lib/kernel/test/code_SUITE.erl
> @@ -48,7 +48,7 @@ all(suite) ->
>      delete, purge, soft_purge, is_loaded, all_loaded,
>      load_binary, dir_req, object_code, set_path_file,
>      pa_pz_option, add_del_path,
> -     dir_disappeared, ext_mod_dep,
> +     dir_disappeared, ext_mod_dep, clash,

Interesting as this was part of the rebased tree
to be found as
http://github.com/tuncer/otp/commit/585f77
and also in a previous state
http://github.com/tuncer/otp/commit/5fcd29

Maybe you took an earlier tree.

>      load_cached, start_node_with_cache, add_and_rehash,
>      where_is_file_no_cache, where_is_file_cached,
>      purge_stacktrace, mult_lib_roots, bad_erl_libs,
> @@ -545,10 +545,7 @@ add_del_path(Config) ->
>     ok.
>
>
> -
> -clash(suite) -> [];
> -clash(doc) -> ["clash"];
> -clash(Config) ->
> +clash(Config) when is_list(Config) ->
>     DDir = ?config(data_dir,Config)++"clash/",
>     P = code:get_path(),

I've pushed a rebased atop of ccase/r13b04_dev tree
with these changes but have to ask why we remove
the two clauses. Every other test seems to have
the suite and doc clause even if they only return []
in both clauses.


More information about the erlang-patches mailing list