[erlang-patches] patch - tab completion for quoted module and function names

Ulf Wiger <>
Fri Dec 18 09:14:27 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Indeed this was the problem - thanks.

(Silly me for thinking that 'git add' would work the same way
as 'svn add'...)

I have amended the branch and pushed my changes. Github now shows
the modified files in the source code browser.

BR,
Ulf W

Björn Gustavsson wrote:
> On Fri, Dec 18, 2009 at 12:18 AM, Ulf Wiger
> <> wrote:
>> I thought I needed to try out the new patch submission procedure.
>> This is also my first Git adventure - hope I didn't mess up too
>> badly. :)
>>
> 
> It seems that you have forgotten to include the actual changes to
> the edlin module. I only see updates to the test suite.
> 
> A common trap for beginners is to think that 'git add file'
> will include 'file' in the next commit. Actually, 'git add file'
> saves the *contents* of the file 'file' at the time the command
> is executed for inclusion in the next commit. (Not sure if that
> is what happened here; I am just guessing.)
> 
> The following wiki page may be of some use:
> 
> http://wiki.github.com/erlang/otp/refining-patches-using-git
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksrOeMACgkQtqqFieqzed2WigCgzSbj/KxPWeIIgFqaOh3dBJBF
EFEAnix5z+9M38mmTYONJmqklhOdpg6q
=15Ns
-----END PGP SIGNATURE-----


More information about the erlang-patches mailing list