[erlang-patches] patch - tab completion for quoted module and function names

Björn Gustavsson <>
Fri Dec 18 08:45:12 CET 2009


On Fri, Dec 18, 2009 at 12:18 AM, Ulf Wiger
<> wrote:
> I thought I needed to try out the new patch submission procedure.
> This is also my first Git adventure - hope I didn't mess up too
> badly. :)
>

It seems that you have forgotten to include the actual changes to
the edlin module. I only see updates to the test suite.

A common trap for beginners is to think that 'git add file'
will include 'file' in the next commit. Actually, 'git add file'
saves the *contents* of the file 'file' at the time the command
is executed for inclusion in the next commit. (Not sure if that
is what happened here; I am just guessing.)

The following wiki page may be of some use:

http://wiki.github.com/erlang/otp/refining-patches-using-git

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list