[erlang-bugs] Make build process more robust [resent]

Mikael Pettersson <>
Thu Dec 13 11:46:45 CET 2007


Christian Faulhammer writes:
 > Hi,
 > 
 > I sent in this patch before but there was neither a reaction nor
 > inclusion into 12B.  So I resend it: On failure the build should abort
 > with an error code, this does not happen everywhere, the attached patch
 > fixes one of them.
 > 
 > V-Li
 > 
 > -- 
 > Christian Faulhammer, Gentoo Lisp project
 > <URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
 > 
 > <URL:http://www.faulhammer.org/>
 > make sure errors actually get passed back up
 > 
 > --- make/otp_subdir.m
 > +++ make/otp_subdir.mk
 > @@ -44,7 +44,7 @@
 >  		    if test -f $$d/ignore_config_record.inf; then	\
 >  			xflag=$$tflag ;					\
 >  		    fi ;						\
 > -		    (cd $$d && $(MAKE) $$xflag $@) ;			\
 > +		    (cd $$d && $(MAKE) $$xflag $@) || exit $$? ;			\
 >  		fi ;							\
 >  	    fi ;							\
 >  	done ;								\

Normally I'd agree with you on this one, but the Erlang/OTP
build is known to be shaky and to fail in some IMO obscure
libraries in some environments. I wouldn't want the entire
build to fail in these cases.

Or do you volunteer to fix all build errors that result from this?



More information about the erlang-bugs mailing list