[erlang-questions] Adopting use Elvis

[Brujo Benavides]

I’m a bit biased here, as a maintainer of Elvis, but I can show you the current config we have for our public repos:
This one is for  <https://github.com/AdRoll/mero/blob/master/elvis.config>mero <https://github.com/AdRoll/mero/blob/master/elvis.config>
This one <https://github.com/AdRoll/spillway/blob/master/elvis.config> is for a much simpler library (spillway)
Personally, my favorite rules are DRY <https://github.com/inaka/elvis_core/wiki/Rules#dry> and god_modules <https://github.com/inaka/elvis_core/wiki/Rules#god-modules>. That ones help me a lot with refactoring.
But, I’m of course also very fond of this one :P <https://github.com/inaka/elvis_core/wiki/Rules#no-if-expression>

Brujo Benavides <http://about.me/elbrujohalcon>



> On 27 Sep 2019, at 04:42, Marc Worrell <marc@REDACTED> wrote:
> 
> Hi Zach,
> 
> In Zotonic we are using Elvis for simple checking.
> 
> We tried to only catch blatant problems or style diversions.
> Most useful are:
> 
> 	* Variable and function naming
> 	* Nesting level
> 
> Our line length of 110 is a compromise.
> I am ok with longer lines, though others in our team like punch card line lengths.
> 
> Our current config is here:
> 
> https://github.com/zotonic/zotonic/blob/master/elvis.config <https://github.com/zotonic/zotonic/blob/master/elvis.config>
> 
> Cheers,
> 
> Marc
> 
> 
>> On 26 Sep 2019, at 22:18, Zachary Kessin <zkessin@REDACTED <mailto:zkessin@REDACTED>> wrote:
>> 
>> HI Erlang Gang
>> 
>> My company is in the process of adopting Elvis for our code base, so far we have it on a few small projects and are finding it useful. But I had two questions:
>> 
>> What rules have people found most or least useful
>> Are there any rules that people have developed that are not part of the main Elvis package that we might want to look at?
>> 
>> Thanks
>> Zach
>> 
>> Zach Kessin 
>> 
>> ᐧ
>> _______________________________________________
>> erlang-questions mailing list
>> erlang-questions@REDACTED <mailto:erlang-questions@REDACTED>
>> http://erlang.org/mailman/listinfo/erlang-questions
> 
> _______________________________________________
> erlang-questions mailing list
> erlang-questions@REDACTED
> http://erlang.org/mailman/listinfo/erlang-questions

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-questions/attachments/20190927/40cfcb5e/attachment.htm>