From roger@REDACTED Mon Sep 7 20:58:34 2015 From: roger@REDACTED (Roger Lipscombe) Date: Mon, 7 Sep 2015 19:58:34 +0100 Subject: [erlang-patches] Allow raw options in ssl:listen Message-ID: I originally reported this in http://erlang.org/pipermail/erlang-questions/2014-October/081226.html; here's a patch against 18.0.3: diff --git a/lib/ssl/src/ssl.erl b/lib/ssl/src/ssl.erl index 9f2af73..19b091d 100644 --- a/lib/ssl/src/ssl.erl +++ b/lib/ssl/src/ssl.erl @@ -1169,6 +1169,8 @@ assert_proplist([]) -> assert_proplist([{Key,_} | Rest]) when is_atom(Key) -> assert_proplist(Rest); %% Handle exceptions +assert_proplist([{raw,_,_,_} | Rest]) -> + assert_proplist(Rest); assert_proplist([inet | Rest]) -> assert_proplist(Rest); assert_proplist([inet6 | Rest]) -> This affects both 17.x and 18.x. Is there any chance that this could be merged into both? Regards, Roger. From roger@REDACTED Mon Sep 7 21:07:33 2015 From: roger@REDACTED (Roger Lipscombe) Date: Mon, 7 Sep 2015 20:07:33 +0100 Subject: [erlang-patches] Allow raw options in ssl:listen In-Reply-To: References: Message-ID: On 7 September 2015 at 19:58, Roger Lipscombe wrote: > I originally reported this in > http://erlang.org/pipermail/erlang-questions/2014-October/081226.html; > here's a patch against 18.0.3: > [snip] ...and a PR: https://github.com/erlang/otp/pull/824 From henrik.x.nord@REDACTED Wed Sep 23 13:15:25 2015 From: henrik.x.nord@REDACTED (Henrik Nord X) Date: Wed, 23 Sep 2015 13:15:25 +0200 Subject: [erlang-patches] Erlang/OTP 18.1 has been released! Message-ID: <560289CD.4090703@ericsson.com> Erlang/OTP 18.1 is a service release on the 18 track with mostly bug fixes, but is does contain a number of new features and characteristics improvements as well. Some highlights of the release are: * ssl: Add possibility to downgrade an SSL/TLS connection to a tcp connection, and give back the socket control to a user process. * ssh: The following new key exchange algorithms are implemented:'ecdh-sha2-nistp256', 'ecdh-sha2-nistp384', 'ecdh-sha2-nistp521','diffie-hellman-group14-sha1', 'diffie-hellman-group-exchange-sha1' and 'diffie-hellman-group-exchange-sha256'. This raises the security level considerably. * kernel,stdlib,sasl: A mechanism for limiting the amount of text that the built-in error logger events will produce has been introduced. It is useful for limiting both the size of log files and the CPU time used to produce them. This mechanism is experimental in the sense that it may be changed based on feedback. See config parameter error_logger_format_depth in the Kernel application. You can find the Release Notes with more detailed info at http://www.erlang.org/download/ otp_src_18.1.readme You can download the full source distribution from http://www.erlang.org/download/otp_src_18.1.tar.gz Note: To unpack the TAR archive you need a GNU TAR compatible program. For installation instructions please read the README that is part of the distribution. You can also find the source code at github.com in the official Erlang repository. Git tag OTP-18.1 https://github.com/erlang/otp/tree/OTP-18.1 The Windows binary distributions can be downloaded from http://www.erlang.org/download/otp_win32_18.1.exe http://www.erlang.org/download/otp_win64_18.1.exe You can also download the complete HTML documentation or the Unix manual files http://www.erlang.org/download/otp_doc_html_18.1.tar.gz http://www.erlang.org/download/otp_doc_man_18.1.tar.gz You can also read the documentation on-line here: (see the Release Notes mentioned above for release notes which are not updated in the doc, but the new functionality is) http://www.erlang.org/doc/ We also want to thank those that sent us patches, suggestions and bug reports. The Erlang/OTP Team at Ericsson -------------- next part -------------- An HTML attachment was scrubbed... URL: From antti.siponen@REDACTED Tue Sep 29 23:29:59 2015 From: antti.siponen@REDACTED (Antti Siponen) Date: Tue, 29 Sep 2015 23:29:59 +0200 Subject: [erlang-patches] httpc crashing on particular urls Message-ID: Hello everybody, it is my first appearance on this mailing list so feel free to remind me of all the rules I possibly break... I noticed that in one specific case the inets:httpc request function fails to return a meaningful error and silently crashes instead. This seems to happen when the provided URL scheme is not http or https. I am just an Erlang beginner so I don't expect to be able to provide a good patch, but I have written up a mockup patch that does solve the issue, although the error message it produces is very likely not in line with the conventions used and the code itself is ugly and based only on guesswork from the surrouding code without any real understanding of what I am doing. Anyway to reproduce the bug you might try to execute the following request on httpc: httpc:request(get, {"broken://erlang.org:80", []}, [], [{sync,false}, {stream, self}, {receiver,fun(X)-> io:format("~p",[X])end}]). Instead of an error I get {ok, #Ref} and in the background a httpc crash. The same happens on sync requests as well and the erl shell hangs. The mock fix that I wrote is available here: https://github.com/lantti/otp/commit/8872f1ca2986757a670f386eba022481f126febc The main points there to notice are that the function socket_type() fails with a missing clause when an unrecognized URL scheme is introduced and that we are inside the httpc:init where failing is not allowed. So I fixed that by returning an error tuple instead and pattern matching against that tuple at the calling side. Maybe somebody here would like to take the time to actually write that fix properly. Thank you, Antti Siponen -------------- next part -------------- An HTML attachment was scrubbed... URL: From jesper.louis.andersen@REDACTED Wed Sep 30 12:55:22 2015 From: jesper.louis.andersen@REDACTED (Jesper Louis Andersen) Date: Wed, 30 Sep 2015 12:55:22 +0200 Subject: [erlang-patches] httpc crashing on particular urls In-Reply-To: References: Message-ID: On Tue, Sep 29, 2015 at 11:29 PM, Antti Siponen wrote: > The mock fix that I wrote is available here: > > https://github.com/lantti/otp/commit/8872f1ca2986757a670f386eba022481f126febc > Nice! While I am not an OTP developer, I know the OTP like to have test cases for fixes. So there is something to think about from the perspective of creating a PR. -- J. -------------- next part -------------- An HTML attachment was scrubbed... URL: