From vladdu55@REDACTED Thu Nov 13 12:01:43 2014 From: vladdu55@REDACTED (Vlad Dumitrescu) Date: Thu, 13 Nov 2014 12:01:43 +0100 Subject: [erlang-patches] [jinterface] add Eclipse projects and formatting settings Message-ID: The current Java codebase is not formatted according to the Java style guidelines (mostly the indentation is not 4 spaces per level and there is trailing whitespace). This adds Eclipse project files and formatting settings. The latter can be used as references for other IDEs. Also, the whole code is reformatted and cleaned up according to these settings, so that in the future the diffs will be meaningful. In short, the formatting style is: - indentation uses only spaces; each level is 4 positions - no trailing whitespace - mostly default Java style formatting (any difference is minor) - always use {} - use 'final' as much as possible git fetch git://github.com/vladdu/otp.git jinterface_format https://github.com/vladdu/otp/compare/erlang:maint...jinterface_format https://github.com/vladdu/otp/compare/erlang:maint...jinterface_format.patch regards, Vlad -------------- next part -------------- An HTML attachment was scrubbed... URL: From be.dmitry@REDACTED Wed Nov 19 02:23:05 2014 From: be.dmitry@REDACTED (Dmitry Belyaev) Date: Wed, 19 Nov 2014 12:23:05 +1100 Subject: [erlang-patches] [odbc] sign bug Message-ID: The regression was found in OTP-17.4 that makes odbc application unusable on the platforms where C `char` type is signed. The commands longer than 127 chars crash odbcserver port, e.g. a connection string with driver path and some additional parameters or a long query string. The changes have the test case, the fix and two warnings cleanups. https://github.com/erlang/otp/pull/539 git fetch git://github.com/RumataEstor/otp.git odbc-sign-bug https://github.com/RumataEstor/otp/compare/erlang:maint...odbc-sign-bug https://github.com/RumataEstor/otp/compare/erlang:maint...odbc-sign-bug.patch Best wishes, -- Dmitry Belyaev -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthias@REDACTED Thu Nov 20 22:29:34 2014 From: matthias@REDACTED (Matthias Lang) Date: Thu, 20 Nov 2014 22:29:34 +0100 Subject: [erlang-patches] What's the whitespace policy for patches? Message-ID: <20141120212934.GA26198@corelatus.se> Hi, Sorry to bother you with a trivial problem. What's the policy for whitespace changes in patches? Is it: 1. Don't introduce new bogus whitespace (e.g. trailing spaces), but don't fix existing bogus whitespace. We don't want unrelated changes in commits, even if it's just whitespace. or 2. Fixing bogus whitespace is fine, we all use 'git diff -w'. Eventually we'll be rid of it all. The 'Submitting Patches' wiki answers a related but different question: | Check for unnecessary whitespace before committing with git diff --check. https://github.com/erlang/otp/wiki/Submitting-patches I suspect it should actually say | Check for unnecessary whitespace _changes_ before... otherwise 'git diff --check' wouldn't make sense. Matt From henrik@REDACTED Fri Nov 21 09:48:21 2014 From: henrik@REDACTED (Henrik Nord) Date: Fri, 21 Nov 2014 09:48:21 +0100 Subject: [erlang-patches] What's the whitespace policy for patches? In-Reply-To: <20141120212934.GA26198@corelatus.se> References: <20141120212934.GA26198@corelatus.se> Message-ID: <546EFC55.6050806@erlang.org> Hello! Yes it is the first answer below: 1. Don't introduce new bogus whitespace (e.g. trailing spaces), but don't fix existing bogus whitespace. We don't want unrelated changes in commits, even if it's just whitespace. You are free to fix whitespace on the lines you are editing, but do not make wide sweeps fixing whitespace in areas you did not edit. On 2014-11-20 22:29, Matthias Lang wrote: > Hi, > > Sorry to bother you with a trivial problem. > > What's the policy for whitespace changes in patches? Is it: > > 1. Don't introduce new bogus whitespace (e.g. trailing spaces), > but don't fix existing bogus whitespace. We don't want > unrelated changes in commits, even if it's just whitespace. > > or 2. Fixing bogus whitespace is fine, we all use 'git diff -w'. > Eventually we'll be rid of it all. > > The 'Submitting Patches' wiki answers a related but different question: > > | Check for unnecessary whitespace before committing with git diff --check. > https://github.com/erlang/otp/wiki/Submitting-patches > > I suspect it should actually say > > | Check for unnecessary whitespace _changes_ before... > > otherwise 'git diff --check' wouldn't make sense. > > Matt > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP From vladdu55@REDACTED Fri Nov 28 11:05:37 2014 From: vladdu55@REDACTED (Vlad Dumitrescu) Date: Fri, 28 Nov 2014 11:05:37 +0100 Subject: [erlang-patches] [edoc] remove functionality related to packages Message-ID: Since packages are now removed, edoc has no need for functionality supporting them. The 'subpackages' option is left, since some projects use recursive source directories. Should it be renamed? Maybe later. There are also a few lines with only whitespace changes (under 2%). Is the rule about them to be enforced fully and drastically? :-) git fetch git://github.com/vladdu/otp.git edoc_remove_packages > > https://github.com/vladdu/otp/compare/erlang:master...edoc_remove_packages > https://github.com/vladdu/otp/compare/erlang > :master...edoc_remove_packages.patch regards, Vlad -------------- next part -------------- An HTML attachment was scrubbed... URL: