From vinoski@REDACTED Sat Mar 1 20:26:09 2014 From: vinoski@REDACTED (Steve Vinoski) Date: Sat, 1 Mar 2014 14:26:09 -0500 Subject: [erlang-patches] emacs erlang-mode keyword matching patch Message-ID: A user on IRC reported a problem with the indentation of the body of a function named catcher, and debugging showed it was because emacs erlang-mode was mistaking it for the catch keyword. This patch fixes it by improving keyword boundary matching, and also introduces an indentation regression test for it: https://github.com/erlang/otp/pull/258 --steve -------------- next part -------------- An HTML attachment was scrubbed... URL: From henrik@REDACTED Mon Mar 3 08:16:08 2014 From: henrik@REDACTED (Henrik Nord) Date: Mon, 3 Mar 2014 08:16:08 +0100 Subject: [erlang-patches] emacs erlang-mode keyword matching patch In-Reply-To: References: Message-ID: <53142C38.9030700@erlang.org> Thanks! On 2014-03-01 20:26, Steve Vinoski wrote: > A user on IRC reported a problem with the indentation of the body of a > function named catcher, and debugging showed it was because emacs > erlang-mode was mistaking it for the catch keyword. This patch fixes > it by improving keyword boundary matching, and also introduces an > indentation regression test for it: > > https://github.com/erlang/otp/pull/258 > > --steve > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From jean-sebastien.pedron@REDACTED Wed Mar 19 16:07:47 2014 From: jean-sebastien.pedron@REDACTED (=?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?=) Date: Wed, 19 Mar 2014 16:07:47 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 Message-ID: <5329B2C3.5010206@dumbbell.fr> Hi! Here's a small patch which fixes a 'function_clause' error when running systools:make_script/2 and there are duplicate modules. git fetch git://github.com/dumbbell/otp.git function_clause-in-systools_make-format_error https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch Thank you! -- Jean-S?bastien P?dron -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 899 bytes Desc: OpenPGP digital signature URL: From henrik@REDACTED Thu Mar 20 08:23:30 2014 From: henrik@REDACTED (Henrik Nord) Date: Thu, 20 Mar 2014 08:23:30 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: <5329B2C3.5010206@dumbbell.fr> References: <5329B2C3.5010206@dumbbell.fr> Message-ID: <532A9772.9070908@erlang.org> Thanks! We will take a look at it. I also created a pullrequest from your link down below. On 2014-03-19 16:07, Jean-S?bastien P?dron wrote: > Hi! > > Here's a small patch which fixes a 'function_clause' error when running > systools:make_script/2 and there are duplicate modules. > > git fetch git://github.com/dumbbell/otp.git > function_clause-in-systools_make-format_error > > https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error > https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch > > Thank you! > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From erlangsiri@REDACTED Thu Mar 20 11:15:38 2014 From: erlangsiri@REDACTED (Siri Hansen) Date: Thu, 20 Mar 2014 11:15:38 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: <532A9772.9070908@erlang.org> References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> Message-ID: The fix is good and will be included in OTP 17.0. It would be really good if you could add a test case for it also, so it does not happen again. Thanks! /siri@REDACTED 2014-03-20 8:23 GMT+01:00 Henrik Nord : > Thanks! > > We will take a look at it. > I also created a pullrequest from your link down below. > > > > > > On 2014-03-19 16:07, Jean-S?bastien P?dron wrote: > > Hi! > > Here's a small patch which fixes a 'function_clause' error when running > systools:make_script/2 and there are duplicate modules. > > git fetch git://github.com/dumbbell/otp.git > function_clause-in-systools_make-format_error > https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_errorhttps://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch > > Thank you! > > > > > _______________________________________________ > erlang-patches mailing listerlang-patches@REDACTED://erlang.org/mailman/listinfo/erlang-patches > > > -- > /Henrik Nord Erlang/OTP > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From vladdu55@REDACTED Fri Mar 21 21:29:06 2014 From: vladdu55@REDACTED (Vlad Dumitrescu) Date: Fri, 21 Mar 2014 21:29:06 +0100 Subject: [erlang-patches] (no subject) Message-ID: Documentation addition to specify that +fn* emulator flags affect even commad-line parameters and environment variables. Please note that I couldn't get the documentation build working on my machine, so I couldn't test that the link has the right target. git fetch git://github.com/vladdu/otp.git unicode_parameters_doc https://github.com/vladdu/otp/compare/erlang:master...unicode_parameters_doc https://github.com/vladdu/otp/compare/erlang:master...unicode_parameters_doc.patch -------------- next part -------------- An HTML attachment was scrubbed... URL: From jean-sebastien.pedron@REDACTED Mon Mar 24 15:30:46 2014 From: jean-sebastien.pedron@REDACTED (=?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?=) Date: Mon, 24 Mar 2014 15:30:46 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> Message-ID: <53304196.20909@dumbbell.fr> On 20.03.2014 11:15, Siri Hansen wrote: > It would be really good if you could add a test case for it also, so > it does not happen again. I pushed a second commit to the same branch to add a test case. Here's the branch information again, just in case: git fetch git://github.com/dumbbell/otp.git function_clause-in-systools_make-format_error https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch Thank you! -- Jean-S?bastien P?dron -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 899 bytes Desc: OpenPGP digital signature URL: From henrik@REDACTED Mon Mar 24 15:34:50 2014 From: henrik@REDACTED (Henrik Nord) Date: Mon, 24 Mar 2014 15:34:50 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: <53304196.20909@dumbbell.fr> References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> <53304196.20909@dumbbell.fr> Message-ID: <5330428A.3060204@erlang.org> Hi As I mentioned in the previous email, I created a pull request from your branch. Now that you are adding to it, It would be nice if you could create your own PR from your branch so that you can keep that up to date. Also, keep in mind the guidelines for writing good commit messages. https://github.com/erlang/otp/wiki/Writing-good-commit-messages Thank you for your contributions! On 2014-03-24 15:30, Jean-S?bastien P?dron wrote: > On 20.03.2014 11:15, Siri Hansen wrote: >> It would be really good if you could add a test case for it also, so >> it does not happen again. > I pushed a second commit to the same branch to add a test case. > > Here's the branch information again, just in case: > > git fetch git://github.com/dumbbell/otp.git > function_clause-in-systools_make-format_error > > https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error > https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch > > Thank you! > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From jean-sebastien.pedron@REDACTED Mon Mar 24 16:14:49 2014 From: jean-sebastien.pedron@REDACTED (=?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?=) Date: Mon, 24 Mar 2014 16:14:49 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: <5330428A.3060204@erlang.org> References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> <53304196.20909@dumbbell.fr> <5330428A.3060204@erlang.org> Message-ID: <53304BE9.50505@dumbbell.fr> On 24.03.2014 15:34, Henrik Nord wrote: > Now that you are adding to it, It would be nice if you could create your > own PR from your branch so that you can keep that up to date. Hi! That's what I tried before replying but GitHub reuses the current pull request. I'm not used to work with pull requests. What would you suggest? Do you want me to amend the commits (maybe squash them into one) and improve the commit message at the same time? -- Jean-S?bastien P?dron -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 899 bytes Desc: OpenPGP digital signature URL: From erlangsiri@REDACTED Mon Mar 24 17:13:54 2014 From: erlangsiri@REDACTED (Siri Hansen) Date: Mon, 24 Mar 2014 17:13:54 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: <53304BE9.50505@dumbbell.fr> References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> <53304196.20909@dumbbell.fr> <5330428A.3060204@erlang.org> <53304BE9.50505@dumbbell.fr> Message-ID: It's ok to use the current pull request. And yes, please squash the commits into one and fix the commit message (please read this page again, it's just been updated: https://github.com/erlang/otp/wiki/Writing-good-commit-messages) Thanks /siri 2014-03-24 16:14 GMT+01:00 Jean-S?bastien P?dron < jean-sebastien.pedron@REDACTED>: > On 24.03.2014 15:34, Henrik Nord wrote: > > Now that you are adding to it, It would be nice if you could create your > > own PR from your branch so that you can keep that up to date. > > Hi! > > That's what I tried before replying but GitHub reuses the current pull > request. > > I'm not used to work with pull requests. What would you suggest? Do you > want me to amend the commits (maybe squash them into one) and improve > the commit message at the same time? > > -- > Jean-S?bastien P?dron > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jean-sebastien.pedron@REDACTED Mon Mar 24 17:57:41 2014 From: jean-sebastien.pedron@REDACTED (=?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?=) Date: Mon, 24 Mar 2014 17:57:41 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> <53304196.20909@dumbbell.fr> <5330428A.3060204@erlang.org> <53304BE9.50505@dumbbell.fr> Message-ID: <53306405.2050401@dumbbell.fr> On 24.03.2014 17:13, Siri Hansen wrote: > It's ok to use the current pull request. And yes, please squash the > commits into one and fix the commit message (please read this page > again, it's just been > updated: https://github.com/erlang/otp/wiki/Writing-good-commit-messages) Ok, commits squashed and message changed. The new commit message guidelines are clearer, thanks. -- Jean-S?bastien P?dron -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 899 bytes Desc: OpenPGP digital signature URL: From erlangsiri@REDACTED Tue Mar 25 08:56:03 2014 From: erlangsiri@REDACTED (Siri Hansen) Date: Tue, 25 Mar 2014 08:56:03 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: <53306405.2050401@dumbbell.fr> References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> <53304196.20909@dumbbell.fr> <5330428A.3060204@erlang.org> <53304BE9.50505@dumbbell.fr> <53306405.2050401@dumbbell.fr> Message-ID: Great, thanks! /siri 2014-03-24 17:57 GMT+01:00 Jean-S?bastien P?dron < jean-sebastien.pedron@REDACTED>: > On 24.03.2014 17:13, Siri Hansen wrote: > > It's ok to use the current pull request. And yes, please squash the > > commits into one and fix the commit message (please read this page > > again, it's just been > > updated: https://github.com/erlang/otp/wiki/Writing-good-commit-messages > ) > > Ok, commits squashed and message changed. > > The new commit message guidelines are clearer, thanks. > > -- > Jean-S?bastien P?dron > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From fritchie@REDACTED Tue Mar 25 10:58:18 2014 From: fritchie@REDACTED (Scott Lystig Fritchie) Date: Tue, 25 Mar 2014 05:58:18 -0400 (EDT) Subject: [erlang-patches] Fix DTrace/SystemTap-related formatting Message-ID: pull-309-a@snookles.com Thanks to Michal Ptaszek for bringing this embarrassing formatting error to my attention. Many DTrace/SystemTap trace strings are incorrectly truncated at 4/8 bytes, depending on the CPU word size. This patch expands the work from commit d032e09 by zheng siyao. Michal's report to the erlang-bugs list can be found at: http://erlang.org/pipermail/erlang-bugs/2014-March/004250.html git fetch git://github.com/slfritchie/otp.git dtrace-formatting-refix https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix.patch It'd be really nice if this could squeak in before the 17 release is frozen. Many apologies if I've missed the deadline. -Scott From lukas@REDACTED Tue Mar 25 12:07:10 2014 From: lukas@REDACTED (Lukas Larsson) Date: Tue, 25 Mar 2014 12:07:10 +0100 Subject: [erlang-patches] Fix DTrace/SystemTap-related formatting References: pull-309-a@snookles.com Message-ID: <5331635E.9000701@erlang.org> Replying here as well for the record. A patch[1] has already been made by Michal Ptaszek. I've appended the non-overlapping parts of this patch to Michal's patch and merged to master for release in 17.0. Lukas [1]: https://github.com/erlang/otp/pull/292 On 25/03/14 10:58, Scott Lystig Fritchie wrote: > Thanks to Michal Ptaszek for bringing this embarrassing formatting > error to my attention. Many DTrace/SystemTap trace strings are > incorrectly truncated at 4/8 bytes, depending on the CPU word size. > This patch expands the work from commit d032e09 by zheng siyao. > > Michal's report to the erlang-bugs list can be found at: > http://erlang.org/pipermail/erlang-bugs/2014-March/004250.html > > git fetch git://github.com/slfritchie/otp.git dtrace-formatting-refix > > https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix > https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix.patch > > It'd be really nice if this could squeak in before the 17 release > is frozen. Many apologies if I've missed the deadline. > > -Scott > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > From vladdu55@REDACTED Wed Mar 26 22:14:30 2014 From: vladdu55@REDACTED (Vlad Dumitrescu) Date: Wed, 26 Mar 2014 22:14:30 +0100 Subject: [erlang-patches] debugger: logical error in int:i2/3 Message-ID: When called with a list of modules and there is an error with any of them, the final result should be 'error'. The wrong value was folded through Acc. git fetch git://github.com/vladdu/otp.git debugger_int_fix https://github.com/mygithub/otp/compare/erlang:master...debugger_int_fixhttps://github.com/mygithub/otp/compare/erlang:master...debugger_int_fix.patch -------------- next part -------------- An HTML attachment was scrubbed... URL: From erlangsiri@REDACTED Fri Mar 28 14:56:27 2014 From: erlangsiri@REDACTED (Siri Hansen) Date: Fri, 28 Mar 2014 14:56:27 +0100 Subject: [erlang-patches] sasl: Fix function_clause in systools_make:format_error/1 In-Reply-To: References: <5329B2C3.5010206@dumbbell.fr> <532A9772.9070908@erlang.org> <53304196.20909@dumbbell.fr> <5330428A.3060204@erlang.org> <53304BE9.50505@dumbbell.fr> <53306405.2050401@dumbbell.fr> Message-ID: This patch has been graduated! Thanks for your contribution! /siri 2014-03-25 8:56 GMT+01:00 Siri Hansen : > Great, thanks! /siri > > > 2014-03-24 17:57 GMT+01:00 Jean-S?bastien P?dron < > jean-sebastien.pedron@REDACTED>: > > On 24.03.2014 17:13, Siri Hansen wrote: >> > It's ok to use the current pull request. And yes, please squash the >> > commits into one and fix the commit message (please read this page >> > again, it's just been >> > updated: >> https://github.com/erlang/otp/wiki/Writing-good-commit-messages) >> >> Ok, commits squashed and message changed. >> >> The new commit message guidelines are clearer, thanks. >> >> -- >> Jean-S?bastien P?dron >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bduggan@REDACTED Mon Mar 31 11:11:01 2014 From: bduggan@REDACTED (Bernie Duggan) Date: Mon, 31 Mar 2014 09:11:01 +0000 Subject: [erlang-patches] Addition of AES-CFB8 cypher Message-ID: <31E741CCEAAEA641930B48274B5C9840BFC27140@SVLITMX02.shoretel.com> Hi OTP folks, I recently had cause to use the AES-CFB8 cypher which is currently missing from the crypto module. The attached patch (and associate pull request) adds support for it (assuming there's no reason that it was omitted originally, of course): https://github.com/bernardd/otp/compare/erlang:maint...aes-cfb-8 https://github.com/bernardd/otp/compare/erlang:maint...aes-cfb-8.patch Cheers, Bernard ________________________________ This e-mail and any attachments are confidential. If it is not intended for you, please notify the sender, and please erase and ignore the contents. -------------- next part -------------- An HTML attachment was scrubbed... URL: From bduggan@REDACTED Mon Mar 31 13:38:38 2014 From: bduggan@REDACTED (Bernie Duggan) Date: Mon, 31 Mar 2014 11:38:38 +0000 Subject: [erlang-patches] Fix SSL ETS table element leak and error cleanup In-Reply-To: <52F3557F.6060207@erlang.org> References: <52A69C3F.4020502@shoretel.com>,<52F3557F.6060207@erlang.org> Message-ID: <31E741CCEAAEA641930B48274B5C9840BFC2742C@SVLITMX02.shoretel.com> Hi Henrik, I've trimmed the patch down to just the one remaining problem and (after much boggling over the SSL unit test system) added a unit test that checks the fix. I've rebased it to 'maint' and created a pull request. You can see the change at: https://github.com/bernardd/otp/compare/erlang:maint...ssl_cert_cache_fix https://github.com/bernardd/otp/compare/erlang:maint...ssl_cert_cache_fix.patch Cheers, Bernard ________________________________________ From: Henrik Nord [henrik@REDACTED] Sent: Thursday, 6 February 2014 3:27 AM To: Bernie Duggan; erlang patches Subject: Re: [erlang-patches] Fix SSL ETS table element leak and error cleanup Hi! Patch solves two problems, one (trap exit) is already solved in R16B03. The other part of the patch we do want, but it should be ammended nice with a test case. On 2013-12-10 05:44, Bernard Duggan wrote: > Hi list, > The SSL library maintains an internal table of CA certificates > (ssl_otp_cacertificate_db). This is supposed to be cleaned up when the > last connection using a certificate closes, however there's two problems > in R16B02 (and in the current master branch on github): > > * When CA certificates are provided as binary blobs, rather than by > filename (ie, #ssl_options.cacerts is set, but #ssl_options.cacertfile > is not) the cleanup never occurs due to an incorrect pattern match in > tls_connection:handle_trusted_certs_db/1. This causes the table to grow > unchecked because each connection adds a new entry. > > * When the process exits abnormally, tls_connection:terminate/1 is never > called because the trap_exit process flag is not set and so similarly > the table (and everything else cleaned in terminate/1, for that matter) > is not cleaned up. This doesn't affect "normal" termination caused by > the connection closing because terminate/1 is called explicitly from > handle_sync_event/4, rather that relying on gen_fsm's automatic calling. > > Fixes for both are here: > > git fetch git://github.com/bernardd/otp ssl_cert_cache_fix > https://github.com/bernardd/otp/compare/erlang:master...ssl_cert_cache_fix > > > Credit goes to my colleague Nick Marino for doing the initial legwork to > track this down. > > Cheers, > > Bernard > > ________________________________ > > This e-mail and any attachments are confidential. If it is not > intended for you, please notify the sender, and please erase and > ignore the contents. > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP ________________________________ This e-mail and any attachments are confidential. If it is not intended for you, please notify the sender, and please erase and ignore the contents. From henrik@REDACTED Mon Mar 31 13:58:08 2014 From: henrik@REDACTED (Henrik Nord) Date: Mon, 31 Mar 2014 13:58:08 +0200 Subject: [erlang-patches] Fix SSL ETS table element leak and error cleanup In-Reply-To: <31E741CCEAAEA641930B48274B5C9840BFC2742C@SVLITMX02.shoretel.com> References: <52A69C3F.4020502@shoretel.com>, <52F3557F.6060207@erlang.org> <31E741CCEAAEA641930B48274B5C9840BFC2742C@SVLITMX02.shoretel.com> Message-ID: <53395850.1040104@erlang.org> Thanks! As we are already passed the codestop for 17.0 we will put this in the backlog for 17.1. Thank you for your contribution! On 2014-03-31 13:38, Bernie Duggan wrote: > Hi Henrik, > I've trimmed the patch down to just the one remaining problem and (after much boggling over the SSL unit test system) added a unit test that checks the fix. I've rebased it to 'maint' and created a pull request. You can see the change at: > > https://github.com/bernardd/otp/compare/erlang:maint...ssl_cert_cache_fix > https://github.com/bernardd/otp/compare/erlang:maint...ssl_cert_cache_fix.patch > > Cheers, > > Bernard > ________________________________________ > From: Henrik Nord [henrik@REDACTED] > Sent: Thursday, 6 February 2014 3:27 AM > To: Bernie Duggan; erlang patches > Subject: Re: [erlang-patches] Fix SSL ETS table element leak and error cleanup > > Hi! > > Patch solves two problems, one (trap exit) is already solved in R16B03. > > The other part of the patch we do want, but it should be ammended nice > with a test case. > > > > On 2013-12-10 05:44, Bernard Duggan wrote: >> Hi list, >> The SSL library maintains an internal table of CA certificates >> (ssl_otp_cacertificate_db). This is supposed to be cleaned up when the >> last connection using a certificate closes, however there's two problems >> in R16B02 (and in the current master branch on github): >> >> * When CA certificates are provided as binary blobs, rather than by >> filename (ie, #ssl_options.cacerts is set, but #ssl_options.cacertfile >> is not) the cleanup never occurs due to an incorrect pattern match in >> tls_connection:handle_trusted_certs_db/1. This causes the table to grow >> unchecked because each connection adds a new entry. >> >> * When the process exits abnormally, tls_connection:terminate/1 is never >> called because the trap_exit process flag is not set and so similarly >> the table (and everything else cleaned in terminate/1, for that matter) >> is not cleaned up. This doesn't affect "normal" termination caused by >> the connection closing because terminate/1 is called explicitly from >> handle_sync_event/4, rather that relying on gen_fsm's automatic calling. >> >> Fixes for both are here: >> >> git fetch git://github.com/bernardd/otp ssl_cert_cache_fix >> https://github.com/bernardd/otp/compare/erlang:master...ssl_cert_cache_fix >> >> >> Credit goes to my colleague Nick Marino for doing the initial legwork to >> track this down. >> >> Cheers, >> >> Bernard >> >> ________________________________ >> >> This e-mail and any attachments are confidential. If it is not >> intended for you, please notify the sender, and please erase and >> ignore the contents. >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > -- > /Henrik Nord Erlang/OTP > > > ________________________________ > > This e-mail and any attachments are confidential. If it is not intended for you, please notify the sender, and please erase and ignore the contents. -- /Henrik Nord Erlang/OTP