From antik@REDACTED Sat Dec 1 23:18:04 2012 From: antik@REDACTED (Ivan Dubovik) Date: Sun, 2 Dec 2012 00:18:04 +0200 Subject: [erlang-patches] SNMP performance optimization In-Reply-To: References: Message-ID: Hi. Any feedback on my patch? Ivan Dubovik 2012/11/17 Ivan Dubovik : > Hi. > > I have a lot of agents: > ets:i(). > id name type size mem owner > ---------------------------------------------------------------------------- > ... > snmpm_agent_table snmpm_agent_table set 42932 2287790 snmpm_config > > > Was: > fprof:analyse(). > ... > {[{{snmpm_server,agent_data,2}, 513,11826.813, 4.607}, > {undefined, 0, 0.446, 0.000}], > { {snmpm_config,agent_info,2}, 513,11827.259, 4.607}, % > [{{ets,match_object,2}, 513,11822.196,11524.680}, > {{ets,select_trap,1}, 0, 0.446, 0.373}, > {{snmpm_server,agent_data_item,2}, 1, 0.010, 0.008}]}. > ... > > Now: > {[{{snmpm_server,agent_data,2}, 906, 20.413, 6.341}], > { {snmpm_server,agent_data_item,2}, 906, 20.413, 6.341}, % > [{{snmpm_config,agent_info,2}, 906, 14.072, 7.743}]}. > > > > git fetch git://github.com/IvanDubovik/otp.git snmp_optimization > https://github.com/IvanDubovik/otp/compare/snmp_optimization > https://github.com/IvanDubovik/otp/compare/snmp_optimization.patch From n.oxyde@REDACTED Sun Dec 2 11:07:05 2012 From: n.oxyde@REDACTED (Anthony Ramine) Date: Sun, 2 Dec 2012 11:07:05 +0100 Subject: [erlang-patches] Print column numbers when compiling In-Reply-To: References: <610BC6F9-18BF-46A2-B487-492A9B41E42A@gmail.com> <4FCE3186.3000202@erlang.org> <5034FB10.7090804@erlang.org> <503CC79B.2020009@erlang.org> <50471240.3060005@erlang.org> <504DF309.2040900@erlang.org> <415229C2-452E-45FF-A207-69BD2212E2F5@gmail.com> <50519F42.7000109@erlang.org> <50598C38.8060506@erlang.org> <77306113-0789-4B6F-A45D-8304FFED5C39@gmail.com> Message-ID: Hi, I've made column numbers a non-optional thing in compile but still an option in epp; so that tools like edoc which don't need the full locations can get only the line numbers. Please refetch. -- Anthony Ramine From henrik@REDACTED Mon Dec 3 09:54:46 2012 From: henrik@REDACTED (Henrik Nord) Date: Mon, 3 Dec 2012 09:54:46 +0100 Subject: [erlang-patches] Print column numbers when compiling In-Reply-To: References: <4FCE3186.3000202@erlang.org> <5034FB10.7090804@erlang.org> <503CC79B.2020009@erlang.org> <50471240.3060005@erlang.org> <504DF309.2040900@erlang.org> <415229C2-452E-45FF-A207-69BD2212E2F5@gmail.com> <50519F42.7000109@erlang.org> <50598C38.8060506@erlang.org> <77306113-0789-4B6F-A45D-8304FFED5C39@gmail.com> Message-ID: <50BC68D6.2000501@erlang.org> On 12/02/2012 11:07 AM, Anthony Ramine wrote: > Hi, > > I've made column numbers a non-optional thing in compile but still an > option in epp; so that tools like edoc which don't need the full > locations can get only the line numbers. > > Please refetch. Will do, Thanks! > > -- > Anthony Ramine -- /Henrik Nord Erlang/OTP From henrik@REDACTED Mon Dec 3 10:01:08 2012 From: henrik@REDACTED (Henrik Nord) Date: Mon, 3 Dec 2012 10:01:08 +0100 Subject: [erlang-patches] SNMP performance optimization In-Reply-To: References: Message-ID: <50BC6A54.3020506@erlang.org> No not as of yet as I have not merged your patch to 'master-pu' before today. Thank you for your contribution! On 12/01/2012 11:18 PM, Ivan Dubovik wrote: > Hi. > > Any feedback on my patch? > > Ivan Dubovik > > 2012/11/17 Ivan Dubovik : >> Hi. >> >> I have a lot of agents: >> ets:i(). >> id name type size mem owner >> ---------------------------------------------------------------------------- >> ... >> snmpm_agent_table snmpm_agent_table set 42932 2287790 snmpm_config >> >> >> Was: >> fprof:analyse(). >> ... >> {[{{snmpm_server,agent_data,2}, 513,11826.813, 4.607}, >> {undefined, 0, 0.446, 0.000}], >> { {snmpm_config,agent_info,2}, 513,11827.259, 4.607}, % >> [{{ets,match_object,2}, 513,11822.196,11524.680}, >> {{ets,select_trap,1}, 0, 0.446, 0.373}, >> {{snmpm_server,agent_data_item,2}, 1, 0.010, 0.008}]}. >> ... >> >> Now: >> {[{{snmpm_server,agent_data,2}, 906, 20.413, 6.341}], >> { {snmpm_server,agent_data_item,2}, 906, 20.413, 6.341}, % >> [{{snmpm_config,agent_info,2}, 906, 14.072, 7.743}]}. >> >> >> >> git fetch git://github.com/IvanDubovik/otp.git snmp_optimization >> https://github.com/IvanDubovik/otp/compare/snmp_optimization >> https://github.com/IvanDubovik/otp/compare/snmp_optimization.patch > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP From n.oxyde@REDACTED Mon Dec 3 11:28:57 2012 From: n.oxyde@REDACTED (Anthony Ramine) Date: Mon, 3 Dec 2012 11:28:57 +0100 Subject: [erlang-patches] Optimize handling of local fun variables in v3_kernel In-Reply-To: <50B87C69.1030406@erlang.org> References: <50B87C69.1030406@erlang.org> Message-ID: <9FE06E4A-CFF9-4542-B22F-687F7D43CE7B@gmail.com> I've removed the second commit of this branch because I'm not happy with it and because it makes the mnesia test suites fail. Enabling propagatation of local function names should be another patch on its own, let's not put that in this branch. Please refetch. -- Anthony Ramine Le 30 nov. 2012 ? 10:29, Henrik Nord a ?crit : > in master-pu > On 11/10/2012 04:35 PM, Anthony Ramine wrote: >> Hi, >> >> This branch removes the so-called "reverse etha-conversion" from v3_kernel and >> replaces it by a proper call to the make_fun internal BIF without the need of a >> redundant lambda function every time the local fun variable is referenced. >> >> There may be some test suites related to this in lib/compiler/test/ >> but I couldn't >> find one; feel free to point me to them if any. >> >> https://github.com/nox/otp/compare/rm-reverse-eta-conversion >> https://github.com/nox/otp/compare/rm-reverse-eta-conversion.patch >> >> git fetch https://github.com/nox/otp/ rm-reverse-eta-conversion >> >> Regards, >> > > -- > /Henrik Nord Erlang/OTP > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From henrik@REDACTED Mon Dec 3 12:39:38 2012 From: henrik@REDACTED (Henrik Nord) Date: Mon, 3 Dec 2012 12:39:38 +0100 Subject: [erlang-patches] (no subject) In-Reply-To: References: Message-ID: <50BC8F7A.6080209@erlang.org> On 11/29/2012 08:22 AM, satoshi kinoshita wrote: > I found antoher 64bit related bug in odbcserver.c. > It affects only param_query for stored-procedure > with OUT parameter of SQL_C_SLONG type. Can you add a testcase for this problem? > > ---Patch-------------------------------------------------- > git fetch git://github.com/kinogmt/otp.git odbc64 > > https://github.com/kinogmt/otp/compare/maint...odbc64 > https://github.com/kinogmt/otp/compare/maint...odbc64.patch > ----------------------------------------------------------- > > Thanks, > Kinoshtia > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP From henrik@REDACTED Tue Dec 4 11:58:50 2012 From: henrik@REDACTED (Henrik Nord) Date: Tue, 4 Dec 2012 11:58:50 +0100 Subject: [erlang-patches] Enhancement of erl_prettypr In-Reply-To: <507D89F0.3090701@aleynikov.org> References: <507D89F0.3090701@aleynikov.org> Message-ID: <50BDD76A.3040305@erlang.org> Hi We have decided to drop this patch. we will also remove similar behaviour from erl_pp (which is the OTP equivalent to erl_prettypr), It does the wrong thing, and it does it in the wrong way at this moment. Thank you for your contribution! On 10/16/2012 06:23 PM, Serge Aleynikov wrote: > Enhancement of erl_prettypr to print binaries in human-readable form. > > git fetch git@REDACTED:saleyn/otp.git erl_prettypr > > https://github.com/saleyn/otp/compare/erl_prettypr > https://github.com/saleyn/otp/compare/erl_prettypr.patch > > Given an abstract syntax form of a binary, such as: > > 1> Form = erl_syntax:form_list(element(2, erl_parse:parse_exprs( > element(2, erl_scan:string( > > "<<84,104,105,115,32,105,115,32,97,32,98,105,110,97,114,121,10>>."))))). > > Before applying the patch the output of erl_prettypr:format/1 looks like > this: > > 2> erl_prettypr:format(Form). > "<<84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 98, 105,\n 110, 97, > 114, 121, 10>>" > > After applying the patch the output looks like this: > > 3> erl_prettypr:format(Form). > "<<\"This is a binary\\n\">>" > > The human-readable printing occurs only if erl_prettypr finds out that > the binary represents a printable list. > > Regards, > > Serge > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP From henrik@REDACTED Tue Dec 4 12:23:11 2012 From: henrik@REDACTED (Henrik Nord) Date: Tue, 4 Dec 2012 12:23:11 +0100 Subject: [erlang-patches] Reclaim the 'query' keyword In-Reply-To: <50B660BF.6060507@ninenines.eu> References: <50B660BF.6060507@ninenines.eu> Message-ID: <50BDDD1F.7000600@erlang.org> I Have now added this branch to 'master-pu' Thank you for your contribution! On 11/28/2012 08:06 PM, Lo?c Hoguin wrote: > Hello, > > I want to reclaim the 'query' word for everyone to use. This word is > much too important to keep it reserved forever. Use includes anything > you can query, from databases to web services to hardware. > > Since I was at it I also removed most of what remains from Mnemosyne. > What's left is the :- operator, and its associated rules. I didn't > want to remove these because they do relate to the Prolog origins of > the language and this was a too big decision for me to take. > > I tested most of the suites but since I wasn't able to run the test > suite entirely because Mnesia was timeouting all the time, I may have > forgotten something. > > So please: > > git fetch git://github.com/essen/otp.git forget-mnemosyne > > https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne > > https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne.patch > > > And keep me informed! > -- /Henrik Nord Erlang/OTP From serge@REDACTED Tue Dec 4 17:16:23 2012 From: serge@REDACTED (Serge Aleynikov) Date: Tue, 04 Dec 2012 11:16:23 -0500 Subject: [erlang-patches] Enhancement of erl_prettypr In-Reply-To: <50BDD76A.3040305@erlang.org> References: <507D89F0.3090701@aleynikov.org> <50BDD76A.3040305@erlang.org> Message-ID: <50BE21D7.4090109@aleynikov.org> Could you elaborate a little on why what the patch does it wrong? I.e. why representing binaries in a human-readable form is wrong? On 12/4/2012 5:58 AM, Henrik Nord wrote: > Hi > > We have decided to drop this patch. > > we will also remove similar behaviour from erl_pp (which is the OTP > equivalent to erl_prettypr), It does the wrong thing, and it does it in > the wrong way at this moment. > > > > Thank you for your contribution! > > > > On 10/16/2012 06:23 PM, Serge Aleynikov wrote: >> Enhancement of erl_prettypr to print binaries in human-readable form. >> >> git fetch git@REDACTED:saleyn/otp.git erl_prettypr >> >> https://github.com/saleyn/otp/compare/erl_prettypr >> https://github.com/saleyn/otp/compare/erl_prettypr.patch >> >> Given an abstract syntax form of a binary, such as: >> >> 1> Form = erl_syntax:form_list(element(2, erl_parse:parse_exprs( >> element(2, erl_scan:string( >> >> "<<84,104,105,115,32,105,115,32,97,32,98,105,110,97,114,121,10>>."))))). >> >> Before applying the patch the output of erl_prettypr:format/1 looks like >> this: >> >> 2> erl_prettypr:format(Form). >> "<<84, 104, 105, 115, 32, 105, 115, 32, 97, 32, 98, 105,\n 110, 97, >> 114, 121, 10>>" >> >> After applying the patch the output looks like this: >> >> 3> erl_prettypr:format(Form). >> "<<\"This is a binary\\n\">>" >> >> The human-readable printing occurs only if erl_prettypr finds out that >> the binary represents a printable list. >> >> Regards, >> >> Serge >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > From henrik@REDACTED Wed Dec 5 11:40:39 2012 From: henrik@REDACTED (Henrik Nord) Date: Wed, 5 Dec 2012 11:40:39 +0100 Subject: [erlang-patches] minor ftp and application_controller fixes In-Reply-To: <50779821.8000307@aleynikov.org> References: <50779821.8000307@aleynikov.org> Message-ID: <50BF24A7.8040400@erlang.org> Hello Since ~p causes line breaks that we don't want in the crash dump slogan, we don't want to take this directly, but the formatting of strings is still so tempting that we would really like a ~p with no line beak... Since there is no way to set line length to infinity, we need to just set it to "very long" - e.g. | lists:flatten(io_lib:format("~134217728p", [Term])) ||| I will update your patch accordingly, Thank you for your contribution! |||| On 10/12/2012 06:10 AM, Serge Aleynikov wrote: > 2. Fixed printout of application crash message on startup. > > git fetch git@REDACTED:saleyn/otp.git app_controller > > https://github.com/saleyn/otp/compare/app_controller > https://github.com/saleyn/otp/compare/app_controller.patch > > Regards, > > Serge > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From serge@REDACTED Wed Dec 5 16:10:53 2012 From: serge@REDACTED (Serge Aleynikov) Date: Wed, 05 Dec 2012 10:10:53 -0500 Subject: [erlang-patches] minor ftp and application_controller fixes In-Reply-To: <50BF24A7.8040400@erlang.org> References: <50779821.8000307@aleynikov.org> <50BF24A7.8040400@erlang.org> Message-ID: <50BF63FD.6000408@aleynikov.org> It makes sense. Thanks. On 12/5/2012 5:40 AM, Henrik Nord wrote: > Hello > > Since ~p causes line breaks that we don't want in the crash dump slogan, > we don't want to take this directly, but the formatting of strings is > still so tempting that we would really like a ~p with no line beak... > Since there is no way to set line length to infinity, we need to just > set it to "very long" - e.g. > > | lists:flatten(io_lib:format("~134217728p", [Term])) > > > ||| > > I will update your patch accordingly, Thank you for your contribution! > > > |||| > > On 10/12/2012 06:10 AM, Serge Aleynikov wrote: >> 2. Fixed printout of application crash message on startup. >> >> git fetch git@REDACTED:saleyn/otp.git app_controller >> >> https://github.com/saleyn/otp/compare/app_controller >> https://github.com/saleyn/otp/compare/app_controller.patch >> >> Regards, >> >> Serge >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > > -- > /Henrik Nord Erlang/OTP > From fdmanana@REDACTED Sun Dec 9 23:55:04 2012 From: fdmanana@REDACTED (Filipe David Manana) Date: Sun, 9 Dec 2012 22:55:04 +0000 Subject: [erlang-patches] Fix file descriptor leak when using async thread pool Message-ID: https://github.com/fdmanana/otp/compare/maint...fix_fd_leak_async_thread_pool.patch https://github.com/fdmanana/otp/compare/maint...fix_fd_leak_async_thread_pool git fetch git://github.com/fdmanana/otp.git fix_fd_leak_async_thread_pool -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men." From fdmanana@REDACTED Mon Dec 10 12:05:55 2012 From: fdmanana@REDACTED (Filipe David Manana) Date: Mon, 10 Dec 2012 11:05:55 +0000 Subject: [erlang-patches] Fix file descriptor leak when using async thread pool In-Reply-To: <50C5BD01.2060503@erlang.org> References: <50C5BD01.2060503@erlang.org> Message-ID: Rebased on top of master branch, as requested. New links: https://github.com/fdmanana/otp/compare/master...fix_fd_leak_async_thread_pool.patch https://github.com/fdmanana/otp/compare/master...fix_fd_leak_async_thread_pool git ?fetch ?git://github.com/fdmanana/otp.git ?fix_fd_leak_async_thread_pool On Mon, Dec 10, 2012 at 10:44 AM, Henrik Nord wrote: > can you rebase this ontop of master > Thank you! > > > > On 12/09/2012 11:55 PM, Filipe David Manana wrote: >> >> >> https://github.com/fdmanana/otp/compare/maint...fix_fd_leak_async_thread_pool.patch >> >> https://github.com/fdmanana/otp/compare/maint...fix_fd_leak_async_thread_pool >> >> git fetch git://github.com/fdmanana/otp.git >> fix_fd_leak_async_thread_pool >> >> > > -- > /Henrik Nord Erlang/OTP > -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men." From henrik@REDACTED Wed Dec 12 13:15:39 2012 From: henrik@REDACTED (Henrik Nord) Date: Wed, 12 Dec 2012 13:15:39 +0100 Subject: [erlang-patches] Deep list argument error under Windows in os:cmd/1 In-Reply-To: References: Message-ID: <50C8756B.3000309@erlang.org> Hi your test fails with: **** User 2012-12-10 23:03:01.060 **** os_SUITE:deep_list_command failed Reason: undef On 11/22/2012 09:02 AM, Aleksandr Vinokurov wrote: > Hi all, > > Maybe I'm doing smth. wrong -- why there is no reply to my patch? > > WBR, > Aleksandr Vinokurov > > > On 8 November 2012 14:11, Aleksandr Vinokurov > wrote: > > Because of leeway in implementing os:cmd/1 under different OS there is > a difference in results when calling it with deep list > argument. os:cmd/1 specifies io_lib:chars() type for its argument and > io_lib functions can produce deep lists inspite of io_lib:chars() > result type specification. This commit flattens the argument for > erlang:open_port/2 (which is used under Windows) and expands the > os_SUITE to regress the bug. > > git fetch git://github.com/aleksandr-vin/otp.git maint-fix-os-cmd-win > > or viewed here: > > https://github.com/aleksandr-vin/otp/compare/maint-fix-os-cmd-win > https://github.com/aleksandr-vin/otp/compare/maint-fix-os-cmd-win.patch > > -- > Aleksandr Vinokurov > +7 (921) 982-21-43 > @aleksandrvin > > > > > -- > ????????? ????????? > +7 (921) 982-21-43 > @aleksandrvin > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From mail@REDACTED Wed Dec 12 13:37:20 2012 From: mail@REDACTED (=?utf-8?Q?Philip_M=C3=BCller?=) Date: Wed, 12 Dec 2012 13:37:20 +0100 Subject: [erlang-patches] [patch] small correction to cover html output Message-ID: Hi everyone, somehow it bugged my that the cover html output isn't valid html. So I made this little patch: https://github.com/exterm/otp/commit/1cf989f81bd4299270416815d899974950a72ce1 I would be most humbled should it be accepted. Best regards Philip From henrik@REDACTED Wed Dec 12 14:29:07 2012 From: henrik@REDACTED (Henrik Nord) Date: Wed, 12 Dec 2012 14:29:07 +0100 Subject: [erlang-patches] [patch] small correction to cover html output In-Reply-To: References: Message-ID: <50C886A3.4030106@erlang.org> Hello I have added your patch to 'master-pu' I would also like to point out that there are instructions for sending in patches here: https://github.com/erlang/otp/wiki/Submitting-patches as we would like you to include a git fetch ulr as well as a preview url as such: git fetch https://github.com/exterm/otp correct_cover_html https://github.com/exterm/otp/compare/correct_cover_html https://github.com/exterm/otp/compare/correct_cover_html.patch Thank you for your contribution! On 12/12/2012 01:37 PM, Philip M?ller wrote: > Hi everyone, > > somehow it bugged my that the cover html output isn't valid html. > > So I made this little patch: > > https://github.com/exterm/otp/commit/1cf989f81bd4299270416815d899974950a72ce1 > > > I would be most humbled should it be accepted. > > Best regards > Philip > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP From nakai@REDACTED Wed Dec 12 14:38:14 2012 From: nakai@REDACTED (Ryosuke Nakai) Date: Wed, 12 Dec 2012 22:38:14 +0900 Subject: [erlang-patches] Fix public_key module document little typo Message-ID: Hi, A subjectPublicKeyInfo type of OTPTBSCertificate record is properly OTPSubjectPublicKeyInfo. Defined in the OTP-PKIX.asn1 are as follows. OTP-PKIX.asn1:: OTPTBSCertificate ::= SEQUENCE { ... subjectPublicKeyInfo OTPSubjectPublicKeyInfo, git fetch git://github.com/voluntas/otp.git vo-fix-doc-cert-records https://github.com/voluntas/otp/compare/fix-doc-cert-records https://github.com/voluntas/otp/compare/fix-doc-cert-records.patch __ NAKAI Ryosuke From fdmanana@REDACTED Thu Dec 13 06:00:29 2012 From: fdmanana@REDACTED (Filipe David Manana) Date: Thu, 13 Dec 2012 05:00:29 +0000 Subject: [erlang-patches] Fix memory leak when stopping file driver Message-ID: https://github.com/fdmanana/otp/compare/master...fix_file_driver_memory_leak.patch https://github.com/fdmanana/otp/compare/master...fix_file_driver_memory_leak git ?fetch ?git://github.com/fdmanana/otp.git ?fix_file_driver_memory_leak -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men." From max.lapshin@REDACTED Thu Dec 13 07:14:00 2012 From: max.lapshin@REDACTED (Max Lapshin) Date: Thu, 13 Dec 2012 09:14:00 +0300 Subject: [erlang-patches] Fix memory leak when stopping file driver In-Reply-To: References: Message-ID: Wow! How many problems have you found in this old and frequently used code. On Thu, Dec 13, 2012 at 9:00 AM, Filipe David Manana wrote: > > https://github.com/fdmanana/otp/compare/master...fix_file_driver_memory_leak.patch > > https://github.com/fdmanana/otp/compare/master...fix_file_driver_memory_leak > > git fetch git://github.com/fdmanana/otp.git fix_file_driver_memory_leak > > > -- > Filipe David Manana, > > "Reasonable men adapt themselves to the world. > Unreasonable men adapt the world to themselves. > That's why all progress depends on unreasonable men." > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > -------------- next part -------------- An HTML attachment was scrubbed... URL: From kostis@REDACTED Thu Dec 13 17:31:54 2012 From: kostis@REDACTED (Kostis Sagonas) Date: Thu, 13 Dec 2012 17:31:54 +0100 Subject: [erlang-patches] dist_util: A minor fix to prevent unwanted return Message-ID: <50CA02FA.1010709@cs.ntua.gr> Prevent an exported function from returning a tuple by mistake. Please include. git fetch git://github.com/kostis/otp.git dist_util-minor-fix Kostis From kostis@REDACTED Thu Dec 13 17:33:25 2012 From: kostis@REDACTED (Kostis Sagonas) Date: Thu, 13 Dec 2012 17:33:25 +0100 Subject: [erlang-patches] proplists: Correct some specs Message-ID: <50CA0355.2040204@cs.ntua.gr> Corrects some specs which use type variables erroneously. Please include: git fetch git://github.com/kostis/otp.git proplists-spec-cleanup Kostis From kostis@REDACTED Thu Dec 13 17:39:01 2012 From: kostis@REDACTED (Kostis Sagonas) Date: Thu, 13 Dec 2012 17:39:01 +0100 Subject: [erlang-patches] ssl: Clean up of specs and types Message-ID: <50CA04A5.4000605@cs.ntua.gr> Many specs and one type declaration of the 'ssl' application have been strengthened and the code has been fixed so that functions do not return values when they do not have to. Also, those functions that have to return some values these values are not unmatched. Please include: git fetch git://github.com/kostis/otp.git ssl-fix-most-unmatched_returns Kostis PS. The clean up is incomplete. Somebody at OTP (Ingela? cc:) needs to run dialyzer with the option -Wunmatched_returns on the ssl code and take care of the remaining warnings. (Most are due to ignoring returns from file-handling functions.) From fredrik@REDACTED Fri Dec 14 10:00:31 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 14 Dec 2012 10:00:31 +0100 Subject: [erlang-patches] dist_util: A minor fix to prevent unwanted return In-Reply-To: <50CA02FA.1010709@cs.ntua.gr> References: <50CA02FA.1010709@cs.ntua.gr> Message-ID: <50CAEAAF.7010006@erlang.org> Hello Kostis, I have included this patch in master-pu BR Fredrik Gustafsson Erlang OTP Team On 12/13/2012 05:31 PM, Kostis Sagonas wrote: > Prevent an exported function from returning a tuple by mistake. > Please include. > > git fetch git://github.com/kostis/otp.git dist_util-minor-fix > > Kostis > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From aronisstav@REDACTED Fri Dec 14 10:11:25 2012 From: aronisstav@REDACTED (Stavros Aronis) Date: Fri, 14 Dec 2012 10:11:25 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: References: Message-ID: This patch enables Dialyzer to detect cases where a function has a specification for a return type containing some list with elements different than those Dialyzer's own algorithm can infer e.g. a function specified to return [atom()] when actually [[atom()]] is returned. Previously Dialyzer remained silent under normal operation, seeing that these two types have the empty list as a common element, so the spec was not 'completely irrelevant'. Using this patch one can find discrepancies in the specs of stdlib's sys.erl and erl_scan.erl. Kostis and I are in contact with the OTP team for the best way fix those as well. git fetch git://github.com/aronisstav/otp.git dialyzer-list-spec Regards, Stavros --- The new warnings are: sys.erl:303: Invalid type specification for function sys:handle_debug/4. The success typing is ([{_,_}],_,_,_) -> [{_,_}] erl_scan.erl:204: Invalid type specification for function erl_scan:token_info/2. The success typing is (_,'category' | 'column' | 'length' | 'line' | 'location' | 'symbol' | 'text' | maybe_improper_list('category' | 'column' | 'length' | 'line' | 'location' | 'symbol' | 'text','category' | 'column' | 'length' | 'line' | 'location' | 'symbol' | 'text' | [])) -> 'undefined' | maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} erl_scan.erl:242: Invalid type specification for function erl_scan:attributes_info/2. The success typing is (_,'column' | 'length' | 'line' | 'location' | 'text' | maybe_improper_list('column' | 'length' | 'line' | 'location' | 'text','column' | 'length' | 'line' | 'location' | 'text' | [])) -> 'undefined' | maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Fri Dec 14 10:23:24 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 14 Dec 2012 10:23:24 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CA0355.2040204@cs.ntua.gr> References: <50CA0355.2040204@cs.ntua.gr> Message-ID: <50CAF00C.7040908@erlang.org> Hello Kostis, I have included this patch in master-pu BR Fredrik Gustafsson Erlang OTP Team On 12/13/2012 05:33 PM, Kostis Sagonas wrote: > Corrects some specs which use type variables erroneously. > Please include: > > git fetch git://github.com/kostis/otp.git proplists-spec-cleanup > > Kostis > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From fredrik@REDACTED Fri Dec 14 10:40:15 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 14 Dec 2012 10:40:15 +0100 Subject: [erlang-patches] ssl: Clean up of specs and types In-Reply-To: <50CA04A5.4000605@cs.ntua.gr> References: <50CA04A5.4000605@cs.ntua.gr> Message-ID: <50CAF3FF.3070107@erlang.org> Hello Kostis, I have included this patch in master-pu BR Fredrik Gustafsson Erlang OTP Team On 12/13/2012 05:39 PM, Kostis Sagonas wrote: > git fetch git://github.com/kostis/otp.git ssl-fix-most-unmatched_returns From fredrik@REDACTED Fri Dec 14 12:29:49 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 14 Dec 2012 12:29:49 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: References: Message-ID: <50CB0DAD.4090408@erlang.org> Hello Stavros, I have included your patch in the master-pu branch. BR Fredrik Gustafsson Erlang OTP Team On 12/14/2012 10:11 AM, Stavros Aronis wrote: > git fetch git://github.com/aronisstav/otp.git > dialyzer-list-spec -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Fri Dec 14 14:59:00 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 14 Dec 2012 14:59:00 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CA0355.2040204@cs.ntua.gr> References: <50CA0355.2040204@cs.ntua.gr> Message-ID: <50CB30A4.5050301@erlang.org> Hello again, It fails to build, Error in proplists:expand/-: unknown annotation List Please correct and give me notice and I will fetch again. BR Fredrik Gustafsson Erlang OTP Team On 12/13/2012 05:33 PM, Kostis Sagonas wrote: > Corrects some specs which use type variables erroneously. > Please include: > > git fetch git://github.com/kostis/otp.git proplists-spec-cleanup > > Kostis > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From kostis@REDACTED Fri Dec 14 15:21:00 2012 From: kostis@REDACTED (Kostis Sagonas) Date: Fri, 14 Dec 2012 15:21:00 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CB30A4.5050301@erlang.org> References: <50CA0355.2040204@cs.ntua.gr> <50CB30A4.5050301@erlang.org> Message-ID: <50CB35CC.5000109@cs.ntua.gr> On 12/14/2012 02:59 PM, Fredrik wrote: > Hello again, > It fails to build, > > Error in proplists:expand/-: unknown annotation List > > > > Please correct and give me notice and I will fetch again. Hi Fredrik, It builds for me. What command are you using? Also, as you can see in the commit message, https://github.com/kostis/otp/commit/e8bbdbcb15731c2963144880cb20120d45350a01#L0L500 the lines with 'List' have been removed and they have been substituted with other names (ListIn and ListOut). So, I am not sure I understand the error you are getting. Kostis > BR Fredrik Gustafsson > Erlang OTP Team > On 12/13/2012 05:33 PM, Kostis Sagonas wrote: >> Corrects some specs which use type variables erroneously. >> Please include: >> >> git fetch git://github.com/kostis/otp.git proplists-spec-cleanup >> >> Kostis >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches From fdmanana@REDACTED Fri Dec 14 15:46:27 2012 From: fdmanana@REDACTED (Filipe David Manana) Date: Fri, 14 Dec 2012 14:46:27 +0000 Subject: [erlang-patches] Updates to file:allocate/2 (currently in master-pu) Message-ID: Hello, I added 2 commits on top of the existing ones for the file:allocate/2 patch, currently in master-pu branch. They can be found in the following branch: git fetch git://github.com/fdmanana/otp.git file_allocate These commits are the most recent: https://github.com/fdmanana/otp/commits/file_allocate Can you pick them, or shall I create a new branch with all of them squashed into a single commit? Thank you -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men." From fredrik@REDACTED Fri Dec 14 15:50:54 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 14 Dec 2012 15:50:54 +0100 Subject: [erlang-patches] Updates to file:allocate/2 (currently in master-pu) In-Reply-To: References: Message-ID: <50CB3CCE.2010407@erlang.org> Hello Filipe, Create a new branch and mail me back the fetch command and links, and I will fetch and put them into master-pu. BR Fredrik Gustafsson Erlang OTP Team On 12/14/2012 03:46 PM, Filipe David Manana wrote: > Hello, > > I added 2 commits on top of the existing ones for the file:allocate/2 > patch, currently in master-pu branch. > > They can be found in the following branch: > > git fetch git://github.com/fdmanana/otp.git file_allocate > > > These commits are the most recent: > > https://github.com/fdmanana/otp/commits/file_allocate > > Can you pick them, or shall I create a new branch with all of them > squashed into a single commit? > > Thank you > > From fredrik@REDACTED Fri Dec 14 16:28:27 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 14 Dec 2012 16:28:27 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CB35CC.5000109@cs.ntua.gr> References: <50CA0355.2040204@cs.ntua.gr> <50CB30A4.5050301@erlang.org> <50CB35CC.5000109@cs.ntua.gr> Message-ID: <50CB459B.6090504@erlang.org> First of all, it is `make release_docs` that fails, i.e the documentation building. Did you try to build the documentation? BR Fredrik Gustafsson Erlang OTP Team On 12/14/2012 03:21 PM, Kostis Sagonas wrote: > On 12/14/2012 02:59 PM, Fredrik wrote: >> Hello again, >> It fails to build, >> >> Error in proplists:expand/-: unknown annotation List >> >> >> >> Please correct and give me notice and I will fetch again. > > Hi Fredrik, > > It builds for me. What command are you using? > > Also, as you can see in the commit message, > > https://github.com/kostis/otp/commit/e8bbdbcb15731c2963144880cb20120d45350a01#L0L500 > > > the lines with 'List' have been removed and they have been substituted > with other names (ListIn and ListOut). So, I am not sure I understand > the error you are getting. > > Kostis > >> BR Fredrik Gustafsson >> Erlang OTP Team >> On 12/13/2012 05:33 PM, Kostis Sagonas wrote: >>> Corrects some specs which use type variables erroneously. >>> Please include: >>> >>> git fetch git://github.com/kostis/otp.git proplists-spec-cleanup >>> >>> Kostis >>> _______________________________________________ >>> erlang-patches mailing list >>> erlang-patches@REDACTED >>> http://erlang.org/mailman/listinfo/erlang-patches From fdmanana@REDACTED Fri Dec 14 16:41:22 2012 From: fdmanana@REDACTED (Filipe David Manana) Date: Fri, 14 Dec 2012 15:41:22 +0000 Subject: [erlang-patches] Updates to file:allocate/2 (currently in master-pu) In-Reply-To: <50CB3CCE.2010407@erlang.org> References: <50CB3CCE.2010407@erlang.org> Message-ID: On Fri, Dec 14, 2012 at 2:50 PM, Fredrik wrote: > Hello Filipe, > Create a new branch and mail me back the fetch command and links, and I will > fetch and put them into master-pu. Fredrik, I squashed all the commits into a new branch: git fetch git://github.com/fdmanana/otp.git file_allocate_squashed https://github.com/fdmanana/otp/compare/master...file_allocate_squashed.patch https://github.com/fdmanana/otp/compare/master...file_allocate_squashed Thank you > > BR Fredrik Gustafsson > Erlang OTP Team > > On 12/14/2012 03:46 PM, Filipe David Manana wrote: >> >> Hello, >> >> I added 2 commits on top of the existing ones for the file:allocate/2 >> patch, currently in master-pu branch. >> >> They can be found in the following branch: >> >> git fetch git://github.com/fdmanana/otp.git file_allocate >> >> >> These commits are the most recent: >> >> https://github.com/fdmanana/otp/commits/file_allocate >> >> Can you pick them, or shall I create a new branch with all of them >> squashed into a single commit? >> >> Thank you >> >> > -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men." From kostis@REDACTED Fri Dec 14 22:10:41 2012 From: kostis@REDACTED (Kostis Sagonas) Date: Fri, 14 Dec 2012 22:10:41 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CB459B.6090504@erlang.org> References: <50CA0355.2040204@cs.ntua.gr> <50CB30A4.5050301@erlang.org> <50CB35CC.5000109@cs.ntua.gr> <50CB459B.6090504@erlang.org> Message-ID: <50CB95D1.4070705@cs.ntua.gr> On 12/14/2012 04:28 PM, Fredrik wrote: > First of all, it is `make release_docs` that fails, i.e the > documentation building. > Did you try to build the documentation? No, I had not done so before this mail. But now I have and I can verify the failure you are getting. The problem is that I cannot fix it. I issued a 'make release_docs' command and it seems that this does not re=generate the .xml files (stdlib/doc/src/proplists.xml in particular) so whatever documentation I change in the src/proplists.erl file, the change does not get reflected in the .xml file. In fact, it seems that these files are part of github and actually pretty old (proplists.xml is more than two years old !?!?). Apparently, the information in them refers to names of variables in specs of the .erl file. This does not feel right... How does one re-create the .xml files? Because 'make release_docs' does not seem to have any effect on them... Kostis From jeremy@REDACTED Sun Dec 16 06:57:59 2012 From: jeremy@REDACTED (Jeremy Ong) Date: Sat, 15 Dec 2012 21:57:59 -0800 Subject: [erlang-patches] Minor additions to the lists stdlib module Message-ID: git fetch git://github.com/jeremyong/otp.git lists_module_additions https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions.patch I have added a few convenience functions for operating on lists in the stdlib. These functions are ifoldl, ifoldr, imap, ifilter, and ipartition (the i stands for "index). Often times, the index of an element is important when transforming a list (for example, if I want to perform an operation on an odd-indexed elements or tag each element of a list with the index formatted in some way). These functions are very similar to the usual ones but the lambdas passed to them take an additional argument which is the index of each element as it gets passed to the lambda. I have tried to follow all directions outlined in the github wiki and appreciate any and all feedback. Cheers, Jeremy -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Mon Dec 17 09:55:08 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 09:55:08 +0100 Subject: [erlang-patches] Updates to file:allocate/2 (currently in master-pu) In-Reply-To: References: <50CB3CCE.2010407@erlang.org> Message-ID: <50CEDDEC.5070301@erlang.org> Hello Filipe! The patch is now in the 'master-pu' branch. BR Fredrik Gustafsson Erlang OTP Team On 12/14/2012 04:41 PM, Filipe David Manana wrote: > On Fri, Dec 14, 2012 at 2:50 PM, Fredrik wrote: >> Hello Filipe, >> Create a new branch and mail me back the fetch command and links, and I will >> fetch and put them into master-pu. > Fredrik, > > I squashed all the commits into a new branch: > > git fetch git://github.com/fdmanana/otp.git file_allocate_squashed > > https://github.com/fdmanana/otp/compare/master...file_allocate_squashed.patch > https://github.com/fdmanana/otp/compare/master...file_allocate_squashed > > Thank you > > >> BR Fredrik Gustafsson >> Erlang OTP Team >> >> On 12/14/2012 03:46 PM, Filipe David Manana wrote: >>> Hello, >>> >>> I added 2 commits on top of the existing ones for the file:allocate/2 >>> patch, currently in master-pu branch. >>> >>> They can be found in the following branch: >>> >>> git fetch git://github.com/fdmanana/otp.git file_allocate >>> >>> >>> These commits are the most recent: >>> >>> https://github.com/fdmanana/otp/commits/file_allocate >>> >>> Can you pick them, or shall I create a new branch with all of them >>> squashed into a single commit? >>> >>> Thank you >>> >>> > > From fredrik@REDACTED Mon Dec 17 10:03:57 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 10:03:57 +0100 Subject: [erlang-patches] Fix memory leak when stopping file driver In-Reply-To: References: Message-ID: <50CEDFFD.1010103@erlang.org> Hello Filipe! Your patch is now in the 'master-pu' branch. BR Fredrik Gustafsson Erlang OTP Team On 12/13/2012 06:00 AM, Filipe David Manana wrote: > https://github.com/fdmanana/otp/compare/master...fix_file_driver_memory_leak.patch > https://github.com/fdmanana/otp/compare/master...fix_file_driver_memory_leak > > git fetch git://github.com/fdmanana/otp.git fix_file_driver_memory_leak > > From fredrik@REDACTED Mon Dec 17 10:22:44 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 10:22:44 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: References: Message-ID: <50CEE464.60707@erlang.org> Hello Stavros! This fails: 'small_SUITE : empty_list_infimum' with reason: dialyzer:format_warning failed on line 295 Reason: function_clause On all platforms.. Please fix this, and I will re-fetch. BR Fredrik Gustafsson Erlang OTP Team On 12/14/2012 10:11 AM, Stavros Aronis wrote: > This patch enables Dialyzer to detect cases where a function has a > specification for a return type containing some list with elements > different than those Dialyzer's own algorithm can infer e.g. a > function specified to return [atom()] when actually [[atom()]] is > returned. > > Previously Dialyzer remained silent under normal operation, seeing > that these two types have the empty list as a common element, so the > spec was not 'completely irrelevant'. > > Using this patch one can find discrepancies in the specs of > stdlib's sys.erl and erl_scan.erl. Kostis and I are in contact with > the OTP team for the best way fix those as well. > > git fetch git://github.com/aronisstav/otp.git > dialyzer-list-spec > > Regards, > > Stavros > > --- > > The new warnings are: > > sys.erl:303: Invalid type specification for function > sys:handle_debug/4. The success typing is ([{_,_}],_,_,_) -> [{_,_}] > erl_scan.erl:204: Invalid type specification for function > erl_scan:token_info/2. The success typing is (_,'category' | 'column' > | 'length' | 'line' | 'location' | 'symbol' | 'text' | > maybe_improper_list('category' | 'column' | 'length' | 'line' | > 'location' | 'symbol' | 'text','category' | 'column' | 'length' | > 'line' | 'location' | 'symbol' | 'text' | [])) -> 'undefined' | > maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} > erl_scan.erl:242: Invalid type specification for function > erl_scan:attributes_info/2. The success typing is (_,'column' | > 'length' | 'line' | 'location' | 'text' | maybe_improper_list('column' > | 'length' | 'line' | 'location' | 'text','column' | 'length' | 'line' > | 'location' | 'text' | [])) -> 'undefined' | > maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} > > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Mon Dec 17 10:26:37 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 10:26:37 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CB95D1.4070705@cs.ntua.gr> References: <50CA0355.2040204@cs.ntua.gr> <50CB30A4.5050301@erlang.org> <50CB35CC.5000109@cs.ntua.gr> <50CB459B.6090504@erlang.org> <50CB95D1.4070705@cs.ntua.gr> Message-ID: <50CEE54D.2030604@erlang.org> Hello Kostis! These files are updated manually. BR Fredrik Gustafsson Erlang OTP Team On 12/14/2012 10:10 PM, Kostis Sagonas wrote: > On 12/14/2012 04:28 PM, Fredrik wrote: >> First of all, it is `make release_docs` that fails, i.e the >> documentation building. >> Did you try to build the documentation? > > No, I had not done so before this mail. But now I have and I can > verify the failure you are getting. > > The problem is that I cannot fix it. > > I issued a 'make release_docs' command and it seems that this does not > re=generate the .xml files (stdlib/doc/src/proplists.xml in > particular) so whatever documentation I change in the > src/proplists.erl file, the change does not get reflected in the .xml > file. > > In fact, it seems that these files are part of github and actually > pretty old (proplists.xml is more than two years old !?!?). > Apparently, the information in them refers to names of variables in > specs of the .erl file. This does not feel right... > > How does one re-create the .xml files? Because 'make release_docs' > does not seem to have any effect on them... > > Kostis From fredrik@REDACTED Mon Dec 17 10:46:51 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 10:46:51 +0100 Subject: [erlang-patches] Minor additions to the lists stdlib module In-Reply-To: References: Message-ID: <50CEEA0B.9080203@erlang.org> Hello Jeremy! I have included your patch in the 'master-pu' branch BR Fredrik Gustafsson Erlang OTP Team On 12/16/2012 06:57 AM, Jeremy Ong wrote: > git fetch git://github.com/jeremyong/otp.git > lists_module_additions > > https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions > > https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions.patch > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aronisstav@REDACTED Mon Dec 17 11:09:46 2012 From: aronisstav@REDACTED (Stavros Aronis) Date: Mon, 17 Dec 2012 11:09:46 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: <50CEE464.60707@erlang.org> References: <50CEE464.60707@erlang.org> Message-ID: Hi Fredrik, Running the tests on my branch (which is rebased on maint) does not yield any errors. Running the tests on master-pu, I get a different error. By manually running the test I can see that the error that you report comes from what I would guess is the new extension that reports column numbers along file lines. Has this patch graduated on master? What is the suggested course of action? Regards, Stavros On Mon, Dec 17, 2012 at 10:22 AM, Fredrik wrote: > Hello Stavros! > This fails: > 'small_SUITE : empty_list_infimum' > with reason: > dialyzer:format_warning failed on line 295 Reason: function_clause > On all platforms.. > Please fix this, and I will re-fetch. > > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/14/2012 10:11 AM, Stavros Aronis wrote: > > This patch enables Dialyzer to detect cases where a function has a > specification for a return type containing some list with elements > different than those Dialyzer's own algorithm can infer e.g. a function > specified to return [atom()] when actually [[atom()]] is returned. > > Previously Dialyzer remained silent under normal operation, seeing that > these two types have the empty list as a common element, so the spec was > not 'completely irrelevant'. > > Using this patch one can find discrepancies in the specs of > stdlib's sys.erl and erl_scan.erl. Kostis and I are in contact with the OTP > team for the best way fix those as well. > > git fetch git://github.com/aronisstav/otp.git dialyzer-list-spec > > Regards, > > Stavros > > --- > > The new warnings are: > > sys.erl:303: Invalid type specification for function sys:handle_debug/4. > The success typing is ([{_,_}],_,_,_) -> [{_,_}] > erl_scan.erl:204: Invalid type specification for function > erl_scan:token_info/2. The success typing is (_,'category' | 'column' | > 'length' | 'line' | 'location' | 'symbol' | 'text' | > maybe_improper_list('category' | 'column' | 'length' | 'line' | 'location' > | 'symbol' | 'text','category' | 'column' | 'length' | 'line' | 'location' > | 'symbol' | 'text' | [])) -> 'undefined' | > maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} > erl_scan.erl:242: Invalid type specification for function > erl_scan:attributes_info/2. The success typing is (_,'column' | 'length' | > 'line' | 'location' | 'text' | maybe_improper_list('column' | 'length' | > 'line' | 'location' | 'text','column' | 'length' | 'line' | 'location' | > 'text' | [])) -> 'undefined' | maybe_improper_list({_,_},'undefined' | [] | > {_,_}) | {_,_} > > > > > _______________________________________________ > erlang-patches mailing listerlang-patches@REDACTED://erlang.org/mailman/listinfo/erlang-patches > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From kostis@REDACTED Mon Dec 17 11:20:12 2012 From: kostis@REDACTED (Kostis Sagonas) Date: Mon, 17 Dec 2012 11:20:12 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CEE54D.2030604@erlang.org> References: <50CA0355.2040204@cs.ntua.gr> <50CB30A4.5050301@erlang.org> <50CB35CC.5000109@cs.ntua.gr> <50CB459B.6090504@erlang.org> <50CB95D1.4070705@cs.ntua.gr> <50CEE54D.2030604@erlang.org> Message-ID: <50CEF1DC.3050703@cs.ntua.gr> On 12/17/2012 10:26 AM, Fredrik wrote: > Hello Kostis! > These files are updated manually. This seems to me to be very wrong. I would have guessed that there would be by now some automatic way of creating these files from the edoc comments in the source file instead of cutting and pasting these comments by hand... Anyway, I think I've updated the branch appropriately now. Please refetch: git fetch git://github.com/kostis/otp.git proplists-spec-cleanup Kostis > BR Fredrik Gustafsson > Erlang OTP Team > On 12/14/2012 10:10 PM, Kostis Sagonas wrote: >> On 12/14/2012 04:28 PM, Fredrik wrote: >>> First of all, it is `make release_docs` that fails, i.e the >>> documentation building. >>> Did you try to build the documentation? >> >> No, I had not done so before this mail. But now I have and I can >> verify the failure you are getting. >> >> The problem is that I cannot fix it. >> >> I issued a 'make release_docs' command and it seems that this does not >> re=generate the .xml files (stdlib/doc/src/proplists.xml in >> particular) so whatever documentation I change in the >> src/proplists.erl file, the change does not get reflected in the .xml >> file. >> >> In fact, it seems that these files are part of github and actually >> pretty old (proplists.xml is more than two years old !?!?). >> Apparently, the information in them refers to names of variables in >> specs of the .erl file. This does not feel right... >> >> How does one re-create the .xml files? Because 'make release_docs' >> does not seem to have any effect on them... >> >> Kostis From aronisstav@REDACTED Mon Dec 17 11:21:01 2012 From: aronisstav@REDACTED (Stavros Aronis) Date: Mon, 17 Dec 2012 11:21:01 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: References: <50CEE464.60707@erlang.org> Message-ID: Btw, the different error I get on master-pu comes from a very weird error on mnesia: On mnesia.erl, line 2739 there is a call to missing function mnesia:get_activity_id/0. This function was removed in commit 6f4c3d127e33d59ac87a3c3b600f7a7280c9674a, part of the patch that removes unused mnemosyne code. Regards, On Mon, Dec 17, 2012 at 11:09 AM, Stavros Aronis wrote: > Hi Fredrik, > > Running the tests on my branch (which is rebased on maint) does not yield > any errors. > > Running the tests on master-pu, I get a different error. > > By manually running the test I can see that the error that you report > comes from what I would guess is the new extension that reports column > numbers along file lines. > > Has this patch graduated on master? What is the suggested course of action? > > Regards, > > Stavros > > > On Mon, Dec 17, 2012 at 10:22 AM, Fredrik wrote: > >> Hello Stavros! >> This fails: >> 'small_SUITE : empty_list_infimum' >> with reason: >> dialyzer:format_warning failed on line 295 Reason: function_clause >> On all platforms.. >> Please fix this, and I will re-fetch. >> >> >> BR Fredrik Gustafsson >> Erlang OTP Team >> On 12/14/2012 10:11 AM, Stavros Aronis wrote: >> >> This patch enables Dialyzer to detect cases where a function has a >> specification for a return type containing some list with elements >> different than those Dialyzer's own algorithm can infer e.g. a function >> specified to return [atom()] when actually [[atom()]] is returned. >> >> Previously Dialyzer remained silent under normal operation, seeing that >> these two types have the empty list as a common element, so the spec was >> not 'completely irrelevant'. >> >> Using this patch one can find discrepancies in the specs of >> stdlib's sys.erl and erl_scan.erl. Kostis and I are in contact with the OTP >> team for the best way fix those as well. >> >> git fetch git://github.com/aronisstav/otp.git dialyzer-list-spec >> >> Regards, >> >> Stavros >> >> --- >> >> The new warnings are: >> >> sys.erl:303: Invalid type specification for function >> sys:handle_debug/4. The success typing is ([{_,_}],_,_,_) -> [{_,_}] >> erl_scan.erl:204: Invalid type specification for function >> erl_scan:token_info/2. The success typing is (_,'category' | 'column' | >> 'length' | 'line' | 'location' | 'symbol' | 'text' | >> maybe_improper_list('category' | 'column' | 'length' | 'line' | 'location' >> | 'symbol' | 'text','category' | 'column' | 'length' | 'line' | 'location' >> | 'symbol' | 'text' | [])) -> 'undefined' | >> maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} >> erl_scan.erl:242: Invalid type specification for function >> erl_scan:attributes_info/2. The success typing is (_,'column' | 'length' | >> 'line' | 'location' | 'text' | maybe_improper_list('column' | 'length' | >> 'line' | 'location' | 'text','column' | 'length' | 'line' | 'location' | >> 'text' | [])) -> 'undefined' | maybe_improper_list({_,_},'undefined' | [] | >> {_,_}) | {_,_} >> >> >> >> >> _______________________________________________ >> erlang-patches mailing listerlang-patches@REDACTED://erlang.org/mailman/listinfo/erlang-patches >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Mon Dec 17 11:40:13 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 11:40:13 +0100 Subject: [erlang-patches] proplists: Correct some specs In-Reply-To: <50CEF1DC.3050703@cs.ntua.gr> References: <50CA0355.2040204@cs.ntua.gr> <50CB30A4.5050301@erlang.org> <50CB35CC.5000109@cs.ntua.gr> <50CB459B.6090504@erlang.org> <50CB95D1.4070705@cs.ntua.gr> <50CEE54D.2030604@erlang.org> <50CEF1DC.3050703@cs.ntua.gr> Message-ID: <50CEF68D.6070007@erlang.org> Hello again, I have re-fetched and it is again in the 'master-pu' branch. Let's hope this will solve the problem! BR Fredrik Gustafsson Erlang OTP Team On 12/17/2012 11:20 AM, Kostis Sagonas wrote: > On 12/17/2012 10:26 AM, Fredrik wrote: >> Hello Kostis! >> These files are updated manually. > > This seems to me to be very wrong. I would have guessed that there > would be by now some automatic way of creating these files from the > edoc comments in the source file instead of cutting and pasting these > comments by hand... > > Anyway, I think I've updated the branch appropriately now. Please > refetch: > > git fetch git://github.com/kostis/otp.git proplists-spec-cleanup > > Kostis > > >> BR Fredrik Gustafsson >> Erlang OTP Team >> On 12/14/2012 10:10 PM, Kostis Sagonas wrote: >>> On 12/14/2012 04:28 PM, Fredrik wrote: >>>> First of all, it is `make release_docs` that fails, i.e the >>>> documentation building. >>>> Did you try to build the documentation? >>> >>> No, I had not done so before this mail. But now I have and I can >>> verify the failure you are getting. >>> >>> The problem is that I cannot fix it. >>> >>> I issued a 'make release_docs' command and it seems that this does not >>> re=generate the .xml files (stdlib/doc/src/proplists.xml in >>> particular) so whatever documentation I change in the >>> src/proplists.erl file, the change does not get reflected in the .xml >>> file. >>> >>> In fact, it seems that these files are part of github and actually >>> pretty old (proplists.xml is more than two years old !?!?). >>> Apparently, the information in them refers to names of variables in >>> specs of the .erl file. This does not feel right... >>> >>> How does one re-create the .xml files? Because 'make release_docs' >>> does not seem to have any effect on them... >>> >>> Kostis From fredrik@REDACTED Mon Dec 17 11:42:58 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 11:42:58 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: References: <50CEE464.60707@erlang.org> Message-ID: <50CEF732.5090707@erlang.org> Hello again, So what you are saying is that it is the patch that is reporting column numbers and the patch that is removing unused mnemosyne code? Neither of these patches has been graduated, they are in master-pu, the same as your patch. I will discuss with the responsible developers of the applications concerned here and get back to you. BR Fredrik Gustafsson Erlang OTP Team On 12/17/2012 11:21 AM, Stavros Aronis wrote: > Btw, > > the different error I get on master-pu comes from a very weird error > on mnesia: > > On mnesia.erl, line 2739 there is a call to missing function > mnesia:get_activity_id/0. > > This function was removed in commit > 6f4c3d127e33d59ac87a3c3b600f7a7280c9674a, part of the patch that > removes unused mnemosyne code. > > Regards, > > > On Mon, Dec 17, 2012 at 11:09 AM, Stavros Aronis > wrote: > > Hi Fredrik, > > Running the tests on my branch (which is rebased on maint) does > not yield any errors. > > Running the tests on master-pu, I get a different error. > > By manually running the test I can see that the error that you > report comes from what I would guess is the new extension that > reports column numbers along file lines. > > Has this patch graduated on master? What is the suggested course > of action? > > Regards, > > Stavros > > > On Mon, Dec 17, 2012 at 10:22 AM, Fredrik > wrote: > > Hello Stavros! > This fails: > 'small_SUITE : empty_list_infimum' > with reason: > dialyzer:format_warning failed on line 295 Reason: function_clause > On all platforms.. > Please fix this, and I will re-fetch. > > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/14/2012 10:11 AM, Stavros Aronis wrote: >> This patch enables Dialyzer to detect cases where a function >> has a specification for a return type containing some list >> with elements different than those Dialyzer's own algorithm >> can infer e.g. a function specified to return [atom()] when >> actually [[atom()]] is returned. >> >> Previously Dialyzer remained silent under normal operation, >> seeing that these two types have the empty list as a common >> element, so the spec was not 'completely irrelevant'. >> >> Using this patch one can find discrepancies in the specs of >> stdlib's sys.erl and erl_scan.erl. Kostis and I are in >> contact with the OTP team for the best way fix those as well. >> >> git fetch git://github.com/aronisstav/otp.git >> dialyzer-list-spec >> >> Regards, >> >> Stavros >> >> --- >> >> The new warnings are: >> >> sys.erl:303: Invalid type specification for function >> sys:handle_debug/4. The success typing is ([{_,_}],_,_,_) -> >> [{_,_}] >> erl_scan.erl:204: Invalid type specification for function >> erl_scan:token_info/2. The success typing is (_,'category' | >> 'column' | 'length' | 'line' | 'location' | 'symbol' | 'text' >> | maybe_improper_list('category' | 'column' | 'length' | >> 'line' | 'location' | 'symbol' | 'text','category' | 'column' >> | 'length' | 'line' | 'location' | 'symbol' | 'text' | [])) >> -> 'undefined' | maybe_improper_list({_,_},'undefined' | [] | >> {_,_}) | {_,_} >> erl_scan.erl:242: Invalid type specification for function >> erl_scan:attributes_info/2. The success typing is (_,'column' >> | 'length' | 'line' | 'location' | 'text' | >> maybe_improper_list('column' | 'length' | 'line' | 'location' >> | 'text','column' | 'length' | 'line' | 'location' | 'text' | >> [])) -> 'undefined' | maybe_improper_list({_,_},'undefined' | >> [] | {_,_}) | {_,_} >> >> >> >> >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aronisstav@REDACTED Mon Dec 17 11:49:01 2012 From: aronisstav@REDACTED (Stavros Aronis) Date: Mon, 17 Dec 2012 11:49:01 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: <50CEF732.5090707@erlang.org> References: <50CEE464.60707@erlang.org> <50CEF732.5090707@erlang.org> Message-ID: Hello! The error that you got ("dialyzer:format_warning failed on line 295 Reason: function_clause") comes from the unexpected structure of the file/line annotation due to the column number patch. Tyrying to run all the tests on master-pu however, I also got a different error ("small_SUITE:init_per_suite failed Reason: try_clause"), as trying to include mnesia in Dialyzer's PLT exposes the following error there: mnesia.erl:2739: Call to missing or unexported function mnesia:get_activity_id/0 The missing function was removed by the unused mnemosyne code patch. Hope this helps! Stavros On Mon, Dec 17, 2012 at 11:42 AM, Fredrik wrote: > Hello again, > So what you are saying is that it is the patch that is reporting column > numbers and the patch that is removing unused mnemosyne code? > Neither of these patches has been graduated, they are in master-pu, the > same as your patch. > I will discuss with the responsible developers of the applications > concerned here and get back to you. > > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/17/2012 11:21 AM, Stavros Aronis wrote: > > Btw, > > the different error I get on master-pu comes from a very weird error on > mnesia: > > On mnesia.erl, line 2739 there is a call to missing function > mnesia:get_activity_id/0. > > This function was removed in commit > 6f4c3d127e33d59ac87a3c3b600f7a7280c9674a, part of the patch that removes > unused mnemosyne code. > > Regards, > > > On Mon, Dec 17, 2012 at 11:09 AM, Stavros Aronis wrote: > >> Hi Fredrik, >> >> Running the tests on my branch (which is rebased on maint) does not >> yield any errors. >> >> Running the tests on master-pu, I get a different error. >> >> By manually running the test I can see that the error that you report >> comes from what I would guess is the new extension that reports column >> numbers along file lines. >> >> Has this patch graduated on master? What is the suggested course of >> action? >> >> Regards, >> >> Stavros >> >> >> On Mon, Dec 17, 2012 at 10:22 AM, Fredrik wrote: >> >>> Hello Stavros! >>> This fails: >>> 'small_SUITE : empty_list_infimum' >>> with reason: >>> dialyzer:format_warning failed on line 295 Reason: function_clause >>> On all platforms.. >>> Please fix this, and I will re-fetch. >>> >>> >>> BR Fredrik Gustafsson >>> Erlang OTP Team >>> On 12/14/2012 10:11 AM, Stavros Aronis wrote: >>> >>> This patch enables Dialyzer to detect cases where a function has a >>> specification for a return type containing some list with elements >>> different than those Dialyzer's own algorithm can infer e.g. a function >>> specified to return [atom()] when actually [[atom()]] is returned. >>> >>> Previously Dialyzer remained silent under normal operation, seeing >>> that these two types have the empty list as a common element, so the spec >>> was not 'completely irrelevant'. >>> >>> Using this patch one can find discrepancies in the specs of >>> stdlib's sys.erl and erl_scan.erl. Kostis and I are in contact with the OTP >>> team for the best way fix those as well. >>> >>> git fetch git://github.com/aronisstav/otp.git dialyzer-list-spec >>> >>> Regards, >>> >>> Stavros >>> >>> --- >>> >>> The new warnings are: >>> >>> sys.erl:303: Invalid type specification for function >>> sys:handle_debug/4. The success typing is ([{_,_}],_,_,_) -> [{_,_}] >>> erl_scan.erl:204: Invalid type specification for function >>> erl_scan:token_info/2. The success typing is (_,'category' | 'column' | >>> 'length' | 'line' | 'location' | 'symbol' | 'text' | >>> maybe_improper_list('category' | 'column' | 'length' | 'line' | 'location' >>> | 'symbol' | 'text','category' | 'column' | 'length' | 'line' | 'location' >>> | 'symbol' | 'text' | [])) -> 'undefined' | >>> maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} >>> erl_scan.erl:242: Invalid type specification for function >>> erl_scan:attributes_info/2. The success typing is (_,'column' | 'length' | >>> 'line' | 'location' | 'text' | maybe_improper_list('column' | 'length' | >>> 'line' | 'location' | 'text','column' | 'length' | 'line' | 'location' | >>> 'text' | [])) -> 'undefined' | maybe_improper_list({_,_},'undefined' | [] | >>> {_,_}) | {_,_} >>> >>> >>> >>> >>> _______________________________________________ >>> erlang-patches mailing listerlang-patches@REDACTED://erlang.org/mailman/listinfo/erlang-patches >>> >>> >>> >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Mon Dec 17 11:53:13 2012 From: fredrik@REDACTED (Fredrik) Date: Mon, 17 Dec 2012 11:53:13 +0100 Subject: [erlang-patches] dialyzer: Report specs defining 'incorrect' lists as return types In-Reply-To: References: <50CEE464.60707@erlang.org> <50CEF732.5090707@erlang.org> Message-ID: <50CEF999.90507@erlang.org> Thanks for the clarification Stavros! I've already been in contact with the one responsible for the "unused mnemosyne code" patch, I will try to sort out the compile column numbers later today. BR Fredrik Gustafsson Erlang OTP Team On 12/17/2012 11:49 AM, Stavros Aronis wrote: > Hello! > > The error that you got ("dialyzer:format_warning failed on line 295 > Reason: function_clause") comes from the unexpected structure of the > file/line annotation due to the column number patch. > > Tyrying to run all the tests on master-pu however, I also got a > different error ("small_SUITE:init_per_suite failed Reason: > try_clause"), as trying to include mnesia in Dialyzer's PLT exposes > the following error there: > mnesia.erl:2739: Call to missing or unexported function > mnesia:get_activity_id/0 > > The missing function was removed by the unused mnemosyne code patch. > > Hope this helps! > > Stavros > > > > > On Mon, Dec 17, 2012 at 11:42 AM, Fredrik > wrote: > > Hello again, > So what you are saying is that it is the patch that is reporting > column numbers and the patch that is removing unused mnemosyne code? > Neither of these patches has been graduated, they are in > master-pu, the same as your patch. > I will discuss with the responsible developers of the applications > concerned here and get back to you. > > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/17/2012 11:21 AM, Stavros Aronis wrote: >> Btw, >> >> the different error I get on master-pu comes from a very weird >> error on mnesia: >> >> On mnesia.erl, line 2739 there is a call to missing function >> mnesia:get_activity_id/0. >> >> This function was removed in commit >> 6f4c3d127e33d59ac87a3c3b600f7a7280c9674a, part of the patch that >> removes unused mnemosyne code. >> >> Regards, >> >> >> On Mon, Dec 17, 2012 at 11:09 AM, Stavros Aronis >> > wrote: >> >> Hi Fredrik, >> >> Running the tests on my branch (which is rebased on maint) >> does not yield any errors. >> >> Running the tests on master-pu, I get a different error. >> >> By manually running the test I can see that the error that >> you report comes from what I would guess is the new extension >> that reports column numbers along file lines. >> >> Has this patch graduated on master? What is the suggested >> course of action? >> >> Regards, >> >> Stavros >> >> >> On Mon, Dec 17, 2012 at 10:22 AM, Fredrik > > wrote: >> >> Hello Stavros! >> This fails: >> 'small_SUITE : empty_list_infimum' >> with reason: >> dialyzer:format_warning failed on line 295 Reason: >> function_clause >> On all platforms.. >> Please fix this, and I will re-fetch. >> >> >> BR Fredrik Gustafsson >> Erlang OTP Team >> On 12/14/2012 10:11 AM, Stavros Aronis wrote: >>> This patch enables Dialyzer to detect cases where a >>> function has a specification for a return type >>> containing some list with elements different than those >>> Dialyzer's own algorithm can infer e.g. a function >>> specified to return [atom()] when actually [[atom()]] is >>> returned. >>> >>> Previously Dialyzer remained silent under normal >>> operation, seeing that these two types have the empty >>> list as a common element, so the spec was not >>> 'completely irrelevant'. >>> >>> Using this patch one can find discrepancies in the specs >>> of stdlib's sys.erl and erl_scan.erl. Kostis and I are >>> in contact with the OTP team for the best way fix those >>> as well. >>> >>> git fetch git://github.com/aronisstav/otp.git >>> dialyzer-list-spec >>> >>> Regards, >>> >>> Stavros >>> >>> --- >>> >>> The new warnings are: >>> >>> sys.erl:303: Invalid type specification for function >>> sys:handle_debug/4. The success typing is >>> ([{_,_}],_,_,_) -> [{_,_}] >>> erl_scan.erl:204: Invalid type specification for >>> function erl_scan:token_info/2. The success typing is >>> (_,'category' | 'column' | 'length' | 'line' | >>> 'location' | 'symbol' | 'text' | >>> maybe_improper_list('category' | 'column' | 'length' | >>> 'line' | 'location' | 'symbol' | 'text','category' | >>> 'column' | 'length' | 'line' | 'location' | 'symbol' | >>> 'text' | [])) -> 'undefined' | >>> maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} >>> erl_scan.erl:242: Invalid type specification for >>> function erl_scan:attributes_info/2. The success typing >>> is (_,'column' | 'length' | 'line' | 'location' | 'text' >>> | maybe_improper_list('column' | 'length' | 'line' | >>> 'location' | 'text','column' | 'length' | 'line' | >>> 'location' | 'text' | [])) -> 'undefined' | >>> maybe_improper_list({_,_},'undefined' | [] | {_,_}) | {_,_} >>> >>> >>> >>> >>> _______________________________________________ >>> erlang-patches mailing list >>> erlang-patches@REDACTED >>> http://erlang.org/mailman/listinfo/erlang-patches >> >> >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From essen@REDACTED Mon Dec 17 19:47:48 2012 From: essen@REDACTED (=?ISO-8859-1?Q?Lo=EFc_Hoguin?=) Date: Mon, 17 Dec 2012 19:47:48 +0100 Subject: [erlang-patches] Reclaim the 'query' keyword In-Reply-To: <50B660BF.6060507@ninenines.eu> References: <50B660BF.6060507@ninenines.eu> Message-ID: <50CF68D4.90504@ninenines.eu> On 11/28/2012 08:06 PM, Lo?c Hoguin wrote: > git fetch git://github.com/essen/otp.git forget-mnemosyne > > https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne > > https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne.patch Please refetch. Amended the last commit with the proper fixes. Tests should pass and warning introduced has been removed. Issue came from this: % gg -i mnemosyne src/mnesia.erl:119: %% Mnemosyne exclusive src/mnesia.erl:2885:%% Mnemosyne exclusive Which says it's Mnemosyne exclusive but is clearly not as it's used by a few tests. I'll leave this for someone with better Mnesia knowledge to decide what to do. Thanks! -- Lo?c Hoguin Erlang Cowboy Nine Nines http://ninenines.eu From andrew@REDACTED Mon Dec 17 20:23:58 2012 From: andrew@REDACTED (Andrew Thompson) Date: Mon, 17 Dec 2012 14:23:58 -0500 Subject: [erlang-patches] Shell History to Erlang In-Reply-To: <4F38D7C1.3080502@erlang.org> References: <4F38D7C1.3080502@erlang.org> Message-ID: <20121217192357.GF28537@hijacked.us> On Mon, Feb 13, 2012 at 10:28:33AM +0100, Henrik Nord wrote: > This will have to wait for a technical board meeting. I will let you > know as soon as the meeting has been held. It's been 10 months, are there any updates on this? Andrew From fredrik@REDACTED Tue Dec 18 10:12:00 2012 From: fredrik@REDACTED (Fredrik) Date: Tue, 18 Dec 2012 10:12:00 +0100 Subject: [erlang-patches] Shell History to Erlang In-Reply-To: <20121217192357.GF28537@hijacked.us> References: <4F38D7C1.3080502@erlang.org> <20121217192357.GF28537@hijacked.us> Message-ID: <50D03360.3060908@erlang.org> Hello Andrew! What patch is this about? BR Fredrik Gustafsson Erlang OTP Team On 12/17/2012 08:23 PM, Andrew Thompson wrote: > On Mon, Feb 13, 2012 at 10:28:33AM +0100, Henrik Nord wrote: >> This will have to wait for a technical board meeting. I will let you >> know as soon as the meeting has been held. > It's been 10 months, are there any updates on this? > > Andrew > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From dch@REDACTED Tue Dec 18 12:14:20 2012 From: dch@REDACTED (Dave Cottlehuber) Date: Tue, 18 Dec 2012 12:14:20 +0100 Subject: [erlang-patches] escript does not parse supplied vm args on Windows In-Reply-To: References: Message-ID: Bumping, is there anything you'd like differently so this could go into R16 please? Gist has been updated according to the thread, https://gist.github.com/4189389ecd2bf1ca8163 I am not confident I have the whitespacing right, the escript.c style seems to vary a lot. We are very close to escript perfection on Windows! A+ Dave On 27 November 2012 14:40, Dave Cottlehuber wrote: > On Windows, the vmargs are not passed through from the 2nd or 3rd > line of the escript file if the shebang syntax is not the unix shell > style. Which it often isn't, as you'd expect. > > On unix, this produces the expected output of init-debug before requesting beer: > > ## ./icanhaz > > #!/usr/bin/env escript > %% -*- erlang -*- > %%! -init_debug -smp enable > main(_) -> io:format("I CAN HAZ BEER?~n", []). > > On Windows, only the BEER is requested: > > ## icanhaz.cmd > > @echo off & setlocal & path=%~dp0;%path%; & escript.exe > "%~dpn0.cmd" %* & goto :eof > %% -*- erlang -*- > %%! -init_debug -smp enable > main(_) -> io:format("I CAN HAZ BEER?~n", []). > > NB: the somewhat cryptic sequence above tells a windows .cmd script to > suppress printing the batch file commands as they are processed, so > this @ would be a very common approach on windows. The path juggling > inside allows you distribute an escript with a NIF-based DLL alongside > in the same directory and have it "just work" without altering the > system or shell path. > > Here's a small patch, accepting that the @ format is common on windows > https://gist.github.com/4189389ecd2bf1ca8163 > > diff --git i/erts/etc/common/escript.c w/erts/etc/common/escript.c > index 9e80ec6..dcb1c85 100644 > --- i/erts/etc/common/escript.c > +++ w/erts/etc/common/escript.c > @@ -264,7 +264,8 @@ append_shebang_args(char* scriptname) > static char linebuf[LINEBUFSZ]; > char* ptr = fgets(linebuf, LINEBUFSZ, fd); > > - if (ptr != NULL && linebuf[0] == '#' && linebuf[1] == '!') { > + /* Acceptable Shebang syntax is #/ for unix or @ for windows */ > + if (ptr != NULL && ((linebuf[0] == '#' && linebuf[1] == '!') || > linebuf[0] == '@')) { > /* Try to find args on second or third line */ > ptr = fgets(linebuf, LINEBUFSZ, fd); > if (ptr != NULL && linebuf[0] == '%' && linebuf[1] == '%' && > linebuf[2] == '!') { > > NBB: the whitespace in escript.c is inconsistent. The patch reflects this. > > NBBB: This yak was brought to you fully shaved whilst trying to > understand why `-detached` wasn't working in escript on Windows. > > A+ > Dave From fredrik@REDACTED Tue Dec 18 13:29:01 2012 From: fredrik@REDACTED (Fredrik) Date: Tue, 18 Dec 2012 13:29:01 +0100 Subject: [erlang-patches] Reclaim the 'query' keyword In-Reply-To: <50CF68D4.90504@ninenines.eu> References: <50B660BF.6060507@ninenines.eu> <50CF68D4.90504@ninenines.eu> Message-ID: <50D0618D.4000809@erlang.org> Hello, I have re-fetched and it is now in the 'master-pu' branch! BR Fredrik Gustafsson Erlang OTP Team On 12/17/2012 07:47 PM, Lo?c Hoguin wrote: > On 11/28/2012 08:06 PM, Lo?c Hoguin wrote: >> git fetch git://github.com/essen/otp.git forget-mnemosyne >> >> https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne >> >> https://github.com/essen/otp/compare/erlang:master...forget-mnemosyne.patch >> > > Please refetch. Amended the last commit with the proper fixes. Tests > should pass and warning introduced has been removed. > > Issue came from this: > % gg -i mnemosyne > src/mnesia.erl:119: %% Mnemosyne exclusive > src/mnesia.erl:2885:%% Mnemosyne exclusive > > Which says it's Mnemosyne exclusive but is clearly not as it's used by > a few tests. I'll leave this for someone with better Mnesia knowledge > to decide what to do. > > Thanks! > From mononcqc@REDACTED Tue Dec 18 14:15:19 2012 From: mononcqc@REDACTED (Fred Hebert) Date: Tue, 18 Dec 2012 08:15:19 -0500 Subject: [erlang-patches] Shell History to Erlang In-Reply-To: <50D03360.3060908@erlang.org> References: <4F38D7C1.3080502@erlang.org> <20121217192357.GF28537@hijacked.us> <50D03360.3060908@erlang.org> Message-ID: <20121218131517.GA57968@ferdmbp.local> Here's the original description back from February: http://erlang.org/pipermail/erlang-patches/2012-February/002645.html Regards, Fred. On 12/18, Fredrik wrote: > Hello Andrew! > What patch is this about? > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/17/2012 08:23 PM, Andrew Thompson wrote: > >On Mon, Feb 13, 2012 at 10:28:33AM +0100, Henrik Nord wrote: > >>This will have to wait for a technical board meeting. I will let you > >>know as soon as the meeting has been held. > >It's been 10 months, are there any updates on this? > > > >Andrew > >_______________________________________________ > >erlang-patches mailing list > >erlang-patches@REDACTED > >http://erlang.org/mailman/listinfo/erlang-patches > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From kostis@REDACTED Tue Dec 18 15:04:45 2012 From: kostis@REDACTED (Kostis Sagonas) Date: Tue, 18 Dec 2012 15:04:45 +0100 Subject: [erlang-patches] Some cleanups in kernel files Message-ID: <50D077FD.5060308@cs.ntua.gr> The code in some kernel modules has been cleaned up so that functions do not return terms of wrong type by accident (most notably by having a call to !/2 in a return position) and so that language constructs that reflect in a more accurate way the program's intention are used. Please include: git fetch git://github.com/kostis/otp.git kernel-cleanup Kostis From wallentin.dahlberg@REDACTED Tue Dec 18 15:36:53 2012 From: wallentin.dahlberg@REDACTED (=?ISO-8859-1?Q?Bj=F6rn=2DEgil_Dahlberg?=) Date: Tue, 18 Dec 2012 15:36:53 +0100 Subject: [erlang-patches] Support ANSI in the console In-Reply-To: <50ADED14.6030404@erlang.org> References: <50A4DE26.30402@erlang.org> <50ADEB64.6060601@erlang.org> <50ADED14.6030404@erlang.org> Message-ID: This seems nice. I use colors directly in the bash shell normally. Also via Erlang. Could be nice with colors in erlang shell also. Seems more modern =) Is: --- a/lib/stdlib/src/shell.erl 2011-11-22 08:57:01.000000000 -0500 +++ b/lib/stdlib/src/shell.erl 2011-12-10 14:25:58.000000000 -0500 @@ -674,6 +674,7 @@ exprs([E0|Es], Bs1, RT, Lf, Ef, Bs0, W) [io:requests([{put_chars, VS}, nl]) || W =:= cmd], %% Don't send the result back if it will be %% discarded anyway. + io:fwrite("\e[0m"), V = if W =:= pmt -> {W,V0}; intentionally omitted? Always clearing the shell might be the way to go =) // Bj?rn-Egil 2012/11/22 Henrik Nord > This mailing list + github is the only way atm. > > We are considering letting a view of our daily build result page show up > to the public via erlang.org > That would increase transparency and possible decrease the turnaround time > for patches as the authors themselves could check the test results of their > patches. > > > On 2012-11-22 10:11, Yurii Rashkovskii wrote: > > Is there any *reliable* way to track what's in pu/master-pu? > > > On Thu, Nov 22, 2012 at 1:07 AM, Henrik Nord wrote: > >> No its in there, it was just removed temporary from the push >> >> >> >> On 2012-11-21 19:01, Yurii Rashkovskii wrote: >> >> Forgive me if I am missing something, but did this patch somehow not make >> it to master-pu? >> >> >> https://github.com/erlang/otp/blob/master-pu/erts/emulator/drivers/unix/ttsl_drv.c#L915 >> >> (pu doesn't have it either >> https://github.com/erlang/otp/blob/pu/erts/emulator/drivers/unix/ttsl_drv.c#L915 >> ) >> >> Is it intentional or is it an omission? >> >> >> On Thu, Nov 15, 2012 at 4:20 AM, Henrik Nord wrote: >> >>> Thank you for your contribution, I have added the patch to 'master-pu' >>> >>> >>> >>> On 2012-11-14 14:49, Pedram Nimreezi wrote: >>> >>>> >>>> https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L901 >>>> >>>> https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L599 >>>> >>>> https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L609 >>>> >>> >>> -- >>> /Henrik Nord Erlang/OTP >>> >>> >>> _______________________________________________ >>> erlang-patches mailing list >>> erlang-patches@REDACTED >>> http://erlang.org/mailman/listinfo/erlang-patches >>> >> >> >> -- >> /Henrik Nord Erlang/OTP >> >> > > -- > /Henrik Nord Erlang/OTP > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From rich.neswold@REDACTED Tue Dec 18 16:13:57 2012 From: rich.neswold@REDACTED (Rich Neswold) Date: Tue, 18 Dec 2012 09:13:57 -0600 Subject: [erlang-patches] Shell History to Erlang In-Reply-To: <20121218131517.GA57968@ferdmbp.local> References: <4F38D7C1.3080502@erlang.org> <20121217192357.GF28537@hijacked.us> <50D03360.3060908@erlang.org> <20121218131517.GA57968@ferdmbp.local> Message-ID: On Tue, Dec 18, 2012 at 7:15 AM, Fred Hebert wrote: > Here's the original description back from February: > http://erlang.org/pipermail/erlang-patches/2012-February/002645.html We have a few active Erlang projects at Fermilab. Most people are taking to the language well, but one of the common complaints is how the shell has no history. We're hoping this patch makes it into the distribution and has official support! -- Rich From fredrik@REDACTED Tue Dec 18 16:18:49 2012 From: fredrik@REDACTED (Fredrik) Date: Tue, 18 Dec 2012 16:18:49 +0100 Subject: [erlang-patches] Shell History to Erlang In-Reply-To: <20121218131517.GA57968@ferdmbp.local> References: <4F38D7C1.3080502@erlang.org> <20121217192357.GF28537@hijacked.us> <50D03360.3060908@erlang.org> <20121218131517.GA57968@ferdmbp.local> Message-ID: <50D08959.90302@erlang.org> Could you please follow the instructions here: https://github.com/erlang/otp/wiki/submitting-patches And we will review your patch. BR Fredrik Gustafsson Erlang OTP Team On 12/18/2012 02:15 PM, Fred Hebert wrote: > Here's the original description back from February: > http://erlang.org/pipermail/erlang-patches/2012-February/002645.html > > Regards, > Fred. > > On 12/18, Fredrik wrote: >> Hello Andrew! >> What patch is this about? >> >> BR Fredrik Gustafsson >> Erlang OTP Team >> On 12/17/2012 08:23 PM, Andrew Thompson wrote: >>> On Mon, Feb 13, 2012 at 10:28:33AM +0100, Henrik Nord wrote: >>>> This will have to wait for a technical board meeting. I will let you >>>> know as soon as the meeting has been held. >>> It's been 10 months, are there any updates on this? >>> >>> Andrew >>> _______________________________________________ >>> erlang-patches mailing list >>> erlang-patches@REDACTED >>> http://erlang.org/mailman/listinfo/erlang-patches >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches -------------- next part -------------- An HTML attachment was scrubbed... URL: From mononcqc@REDACTED Tue Dec 18 16:31:27 2012 From: mononcqc@REDACTED (Fred Hebert) Date: Tue, 18 Dec 2012 10:31:27 -0500 Subject: [erlang-patches] Shell History to Erlang In-Reply-To: <50D08959.90302@erlang.org> References: <4F38D7C1.3080502@erlang.org> <20121217192357.GF28537@hijacked.us> <50D03360.3060908@erlang.org> <20121218131517.GA57968@ferdmbp.local> <50D08959.90302@erlang.org> Message-ID: <20121218153126.GB57968@ferdmbp.local> Does this mean it has a chance of making it there? The original thread I posted months ago asked if there were any chances for it to be included. If the OTP team is not interested in the solution in any way, it's no use losing my time formatting only to have it dismissed -- that's why I asked the question in the first place, and never got an answer. If there's a chances the OTP team is interested, I'll try and find the time to format things and send it as a proper patch. Regards, Fred. On 12/18, Fredrik wrote: > Could you please follow the instructions here: > https://github.com/erlang/otp/wiki/submitting-patches > And we will review your patch. > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/18/2012 02:15 PM, Fred Hebert wrote: > >Here's the original description back from February: > >http://erlang.org/pipermail/erlang-patches/2012-February/002645.html > > > >Regards, > >Fred. > > > >On 12/18, Fredrik wrote: > >>Hello Andrew! > >>What patch is this about? > >> > >>BR Fredrik Gustafsson > >>Erlang OTP Team > >>On 12/17/2012 08:23 PM, Andrew Thompson wrote: > >>>On Mon, Feb 13, 2012 at 10:28:33AM +0100, Henrik Nord wrote: > >>>>This will have to wait for a technical board meeting. I will let you > >>>>know as soon as the meeting has been held. > >>>It's been 10 months, are there any updates on this? > >>> > >>>Andrew > >>>_______________________________________________ > >>>erlang-patches mailing list > >>>erlang-patches@REDACTED > >>>http://erlang.org/mailman/listinfo/erlang-patches > >>_______________________________________________ > >>erlang-patches mailing list > >>erlang-patches@REDACTED > >>http://erlang.org/mailman/listinfo/erlang-patches > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From fredrik@REDACTED Tue Dec 18 17:07:20 2012 From: fredrik@REDACTED (Fredrik) Date: Tue, 18 Dec 2012 17:07:20 +0100 Subject: [erlang-patches] Shell History to Erlang In-Reply-To: <20121218153126.GB57968@ferdmbp.local> References: <4F38D7C1.3080502@erlang.org> <20121217192357.GF28537@hijacked.us> <50D03360.3060908@erlang.org> <20121218131517.GA57968@ferdmbp.local> <50D08959.90302@erlang.org> <20121218153126.GB57968@ferdmbp.local> Message-ID: <50D094B8.5090700@erlang.org> Since not anyone have had the time to look into it in detail, getting it like a patch would put it in the "tasks queue" for us to review it. In that way you would get a decision much faster. We think it would be a cool feature but it needs to be reviewed and have been run in all the tests before taking a decision. BR Fredrik Gustafsson Erlang OTP Team On 12/18/2012 04:31 PM, Fred Hebert wrote: > Does this mean it has a chance of making it there? The original thread I > posted months ago asked if there were any chances for it to be included. > If the OTP team is not interested in the solution in any way, it's no > use losing my time formatting only to have it dismissed -- that's why I > asked the question in the first place, and never got an answer. > > If there's a chances the OTP team is interested, I'll try and find the > time to format things and send it as a proper patch. > > Regards, > Fred. > > On 12/18, Fredrik wrote: >> Could you please follow the instructions here: >> https://github.com/erlang/otp/wiki/submitting-patches >> And we will review your patch. >> >> BR Fredrik Gustafsson >> Erlang OTP Team >> On 12/18/2012 02:15 PM, Fred Hebert wrote: >>> Here's the original description back from February: >>> http://erlang.org/pipermail/erlang-patches/2012-February/002645.html >>> >>> Regards, >>> Fred. >>> >>> On 12/18, Fredrik wrote: >>>> Hello Andrew! >>>> What patch is this about? >>>> >>>> BR Fredrik Gustafsson >>>> Erlang OTP Team >>>> On 12/17/2012 08:23 PM, Andrew Thompson wrote: >>>>> On Mon, Feb 13, 2012 at 10:28:33AM +0100, Henrik Nord wrote: >>>>>> This will have to wait for a technical board meeting. I will let you >>>>>> know as soon as the meeting has been held. >>>>> It's been 10 months, are there any updates on this? >>>>> >>>>> Andrew >>>>> _______________________________________________ >>>>> erlang-patches mailing list >>>>> erlang-patches@REDACTED >>>>> http://erlang.org/mailman/listinfo/erlang-patches >>>> _______________________________________________ >>>> erlang-patches mailing list >>>> erlang-patches@REDACTED >>>> http://erlang.org/mailman/listinfo/erlang-patches >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches From fredrik@REDACTED Tue Dec 18 17:34:38 2012 From: fredrik@REDACTED (Fredrik) Date: Tue, 18 Dec 2012 17:34:38 +0100 Subject: [erlang-patches] Some cleanups in kernel files In-Reply-To: <50D077FD.5060308@cs.ntua.gr> References: <50D077FD.5060308@cs.ntua.gr> Message-ID: <50D09B1E.2060902@erlang.org> Hello Kostis! The patch is now in the 'master-pu' branch. BR Fredrik Gustafsson Erlang OTP Team On 12/18/2012 03:04 PM, Kostis Sagonas wrote: > The code in some kernel modules has been cleaned up so that functions > do not return terms of wrong type by accident (most notably by having > a call to !/2 in a return position) and so that language constructs > that reflect in a more accurate way the program's intention are used. > > Please include: > > git fetch git://github.com/kostis/otp.git kernel-cleanup > > Kostis > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches From mc@REDACTED Tue Dec 18 18:20:36 2012 From: mc@REDACTED (Pedram Nimreezi) Date: Tue, 18 Dec 2012 12:20:36 -0500 Subject: [erlang-patches] Support ANSI in the console In-Reply-To: References: <50A4DE26.30402@erlang.org> <50ADEB64.6060601@erlang.org> <50ADED14.6030404@erlang.org> Message-ID: Yes that was intentionally omitted, as a small percentage of the time it affected the ( ) brace matching (in smaller terminals).. Also not properly resetting ANSI colors once a color is set is technically a user error. Would agree always resetting is the way to go, if it doesn't affect anything else. On Tue, Dec 18, 2012 at 9:36 AM, Bj?rn-Egil Dahlberg wrote: > This seems nice. > > I use colors directly in the bash shell normally. Also via Erlang. Could be > nice with colors in erlang shell also. Seems more modern =) > > Is: > --- a/lib/stdlib/src/shell.erl 2011-11-22 08:57:01.000000000 -0500 > +++ b/lib/stdlib/src/shell.erl 2011-12-10 14:25:58.000000000 -0500 > @@ -674,6 +674,7 @@ exprs([E0|Es], Bs1, RT, Lf, Ef, Bs0, W) > [io:requests([{put_chars, VS}, nl]) || W =:= cmd], > %% Don't send the result back if it will be > %% discarded anyway. > + io:fwrite("\e[0m"), > V = if > W =:= pmt -> > {W,V0}; > > intentionally omitted? > Always clearing the shell might be the way to go =) > > // Bj?rn-Egil > > 2012/11/22 Henrik Nord >> >> This mailing list + github is the only way atm. >> >> We are considering letting a view of our daily build result page show up >> to the public via erlang.org >> That would increase transparency and possible decrease the turnaround time >> for patches as the authors themselves could check the test results of their >> patches. >> >> >> On 2012-11-22 10:11, Yurii Rashkovskii wrote: >> >> Is there any *reliable* way to track what's in pu/master-pu? >> >> >> On Thu, Nov 22, 2012 at 1:07 AM, Henrik Nord wrote: >>> >>> No its in there, it was just removed temporary from the push >>> >>> >>> >>> On 2012-11-21 19:01, Yurii Rashkovskii wrote: >>> >>> Forgive me if I am missing something, but did this patch somehow not make >>> it to master-pu? >>> >>> >>> https://github.com/erlang/otp/blob/master-pu/erts/emulator/drivers/unix/ttsl_drv.c#L915 >>> >>> (pu doesn't have it either >>> https://github.com/erlang/otp/blob/pu/erts/emulator/drivers/unix/ttsl_drv.c#L915) >>> >>> Is it intentional or is it an omission? >>> >>> >>> On Thu, Nov 15, 2012 at 4:20 AM, Henrik Nord wrote: >>>> >>>> Thank you for your contribution, I have added the patch to 'master-pu' >>>> >>>> >>>> >>>> On 2012-11-14 14:49, Pedram Nimreezi wrote: >>>>> >>>>> >>>>> https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L901 >>>>> >>>>> https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L599 >>>>> >>>>> https://github.com/DeadZen/otp/blob/d3e3d51dbb21f0fdb125becacb80e34d0565fff7/erts/emulator/drivers/unix/ttsl_drv.c#L609 >>>> >>>> >>>> -- >>>> /Henrik Nord Erlang/OTP >>>> >>>> >>>> _______________________________________________ >>>> erlang-patches mailing list >>>> erlang-patches@REDACTED >>>> http://erlang.org/mailman/listinfo/erlang-patches >>> >>> >>> >>> -- >>> /Henrik Nord Erlang/OTP >> >> >> >> -- >> /Henrik Nord Erlang/OTP >> >> >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches >> > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > -- /* Sincerely -------------------------------------------------------------- Pedram Nimreezi - Chief Technology Officer */ // The hardest part of design ? is keeping features out. - Donald Norman From mloftis@REDACTED Tue Dec 18 22:35:07 2012 From: mloftis@REDACTED (Michael Loftis) Date: Tue, 18 Dec 2012 13:35:07 -0800 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto Message-ID: Add ripemd160 digest support to crypto. Includes a couple test cases. https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest.patch git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest This is based off of master-pu as of a few moments ago, my read of the requirements tells me that should be the correct spot since I'm adding a new feature to the crypto module. Not fully tested with the current erlang since jinterface has completely broken my build on all platforms -- even if it is disabled it still kills my build on most platforms because it's using sh with scripts that have bash semantics. Might have a chance to clean up that separate issue today and submit patches. -- "Genius might be described as a supreme capacity for getting its possessors into trouble of all kinds." -- Samuel Butler -------------- next part -------------- An HTML attachment was scrubbed... URL: From tuncer.ayaz@REDACTED Tue Dec 18 22:45:44 2012 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Tue, 18 Dec 2012 22:45:44 +0100 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: References: Message-ID: On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: > > Add ripemd160 digest support to crypto. Includes a couple test > cases. > > > git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest > > This is based off of master-pu as of a few moments ago, my read of > the requirements tells me that should be the correct spot since I'm > adding a new feature to the crypto module. A patch for 'master-pu' has to be based off 'master'. > Not fully tested with the current erlang since jinterface has > completely broken my build on all platforms -- even if it is > disabled it still kills my build on most platforms because it's > using sh with scripts that have bash semantics. Might have a chance > to clean up that separate issue today and submit patches. From mloftis@REDACTED Tue Dec 18 23:10:36 2012 From: mloftis@REDACTED (Michael Loftis) Date: Tue, 18 Dec 2012 14:10:36 -0800 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: References: Message-ID: Apologies, done... https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest On Tue, Dec 18, 2012 at 1:45 PM, Tuncer Ayaz wrote: > On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: > > > > Add ripemd160 digest support to crypto. Includes a couple test > > cases. > > > > > > git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest > > > > This is based off of master-pu as of a few moments ago, my read of > > the requirements tells me that should be the correct spot since I'm > > adding a new feature to the crypto module. > > A patch for 'master-pu' has to be based off 'master'. > > > Not fully tested with the current erlang since jinterface has > > completely broken my build on all platforms -- even if it is > > disabled it still kills my build on most platforms because it's > > using sh with scripts that have bash semantics. Might have a chance > > to clean up that separate issue today and submit patches. > -- "Genius might be described as a supreme capacity for getting its possessors into trouble of all kinds." -- Samuel Butler -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Wed Dec 19 10:01:32 2012 From: fredrik@REDACTED (Fredrik) Date: Wed, 19 Dec 2012 10:01:32 +0100 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: References: Message-ID: <50D1826C.6080305@erlang.org> Hello Michael! This patch is now in the 'master-pu' branch. BR Fredrik Gustafsson Erlang OTP Team On 12/18/2012 11:10 PM, Michael Loftis wrote: > Apologies, done... > > https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest > https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch > > git fetch git://github.com/mloftis/otp.git > crypto-add-ripemd160-digest > > > > > On Tue, Dec 18, 2012 at 1:45 PM, Tuncer Ayaz > wrote: > > On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: > > > > Add ripemd160 digest support to crypto. Includes a couple test > > cases. > > > > > > git fetch git://github.com/mloftis/otp.git > crypto-add-ripemd160-digest > > > > This is based off of master-pu as of a few moments ago, my read of > > the requirements tells me that should be the correct spot since I'm > > adding a new feature to the crypto module. > > A patch for 'master-pu' has to be based off 'master'. > > > Not fully tested with the current erlang since jinterface has > > completely broken my build on all platforms -- even if it is > > disabled it still kills my build on most platforms because it's > > using sh with scripts that have bash semantics. Might have a chance > > to clean up that separate issue today and submit patches. > > > > > -- > > "Genius might be described as a supreme capacity for getting its > possessors > into trouble of all kinds." > -- Samuel Butler > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Wed Dec 19 10:15:51 2012 From: fredrik@REDACTED (Fredrik) Date: Wed, 19 Dec 2012 10:15:51 +0100 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: References: Message-ID: <50D185C7.60805@erlang.org> Hello Michael, It does not build: crypto.c: In function 'ripemd160': crypto.c:621:28: error: 'RIPEMD160_LEN' undeclared (first use in this function) crypto.c:621:28: note: each undeclared identifier is reported only once for each function it appears in crypto.c: In function 'ripemd160_init': crypto.c:627:64: error: 'RIPEMD160_CTX_LEN' undeclared (first use in this function) crypto.c: In function 'ripemd160_update': crypto.c:636:22: error: 'RIPEMD160_CTX_LEN' undeclared (first use in this function) crypto.c: In function 'ripemd160_final': crypto.c:650:73: error: 'RIPEMD160_CTX_LEN' undeclared (first use in this function) crypto.c:654:47: error: 'RIPEMD160_LEN' undeclared (first use in this function) Please take a look at this and give me a notice. BR Fredrik Gustafsson Erlang OTP Team On 12/18/2012 11:10 PM, Michael Loftis wrote: > Apologies, done... > > https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest > https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch > > git fetch git://github.com/mloftis/otp.git > crypto-add-ripemd160-digest > > > > > On Tue, Dec 18, 2012 at 1:45 PM, Tuncer Ayaz > wrote: > > On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: > > > > Add ripemd160 digest support to crypto. Includes a couple test > > cases. > > > > > > git fetch git://github.com/mloftis/otp.git > crypto-add-ripemd160-digest > > > > This is based off of master-pu as of a few moments ago, my read of > > the requirements tells me that should be the correct spot since I'm > > adding a new feature to the crypto module. > > A patch for 'master-pu' has to be based off 'master'. > > > Not fully tested with the current erlang since jinterface has > > completely broken my build on all platforms -- even if it is > > disabled it still kills my build on most platforms because it's > > using sh with scripts that have bash semantics. Might have a chance > > to clean up that separate issue today and submit patches. > > > > > -- > > "Genius might be described as a supreme capacity for getting its > possessors > into trouble of all kinds." > -- Samuel Butler > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -------------- next part -------------- An HTML attachment was scrubbed... URL: From mloftis@REDACTED Wed Dec 19 19:05:08 2012 From: mloftis@REDACTED (Michael Loftis) Date: Wed, 19 Dec 2012 10:05:08 -0800 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: <50D185C7.60805@erlang.org> References: <50D185C7.60805@erlang.org> Message-ID: Entirely my fault, I missed two #define's when I moved the patch from the crypto module I forked back at R13 back into the R15 source. I only got R15 to compile today, R15 and my javac do not get along (but I don't use any of that anyway). I've updated the github repo, same branch. https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest.patch git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest On Wed, Dec 19, 2012 at 1:15 AM, Fredrik wrote: > Hello Michael, > It does not build: > crypto.c: In function ?ripemd160?: > crypto.c:621:28: error: ?RIPEMD160_LEN? undeclared (first use in this > function) > crypto.c:621:28: note: each undeclared identifier is reported only once > for each function it appears in > crypto.c: In function ?ripemd160_init?: > crypto.c:627:64: error: ?RIPEMD160_CTX_LEN? undeclared (first use in this > function) > crypto.c: In function ?ripemd160_update?: > crypto.c:636:22: error: ?RIPEMD160_CTX_LEN? undeclared (first use in this > function) > crypto.c: In function ?ripemd160_final?: > crypto.c:650:73: error: ?RIPEMD160_CTX_LEN? undeclared (first use in this > function) > crypto.c:654:47: error: ?RIPEMD160_LEN? undeclared (first use in this > function) > > Please take a look at this and give me a notice. > > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/18/2012 11:10 PM, Michael Loftis wrote: > > Apologies, done... > > > https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest > > https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch > > git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest > > > > > On Tue, Dec 18, 2012 at 1:45 PM, Tuncer Ayaz wrote: > >> On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: >> > >> > Add ripemd160 digest support to crypto. Includes a couple test >> > cases. >> > >> > >> > git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest >> > >> > This is based off of master-pu as of a few moments ago, my read of >> > the requirements tells me that should be the correct spot since I'm >> > adding a new feature to the crypto module. >> >> A patch for 'master-pu' has to be based off 'master'. >> >> > Not fully tested with the current erlang since jinterface has >> > completely broken my build on all platforms -- even if it is >> > disabled it still kills my build on most platforms because it's >> > using sh with scripts that have bash semantics. Might have a chance >> > to clean up that separate issue today and submit patches. >> > > > > -- > > "Genius might be described as a supreme capacity for getting its possessors > into trouble of all kinds." > -- Samuel Butler > > > > _______________________________________________ > erlang-patches mailing listerlang-patches@REDACTED://erlang.org/mailman/listinfo/erlang-patches > > > -- "Genius might be described as a supreme capacity for getting its possessors into trouble of all kinds." -- Samuel Butler -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Thu Dec 20 11:37:07 2012 From: fredrik@REDACTED (Fredrik) Date: Thu, 20 Dec 2012 11:37:07 +0100 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: References: <50D185C7.60805@erlang.org> Message-ID: <50D2EA53.8000208@erlang.org> Hello again Michael! I've refetched and it is now located in the 'master-pu' branch. BR Fredrik Gustafsson Erlang OTP Team On 12/19/2012 07:05 PM, Michael Loftis wrote: > Entirely my fault, I missed two #define's when I moved the patch from > the crypto module I forked back at R13 back into the R15 source. I > only got R15 to compile today, R15 and my javac do not get along (but > I don't use any of that anyway). > > I've updated the github repo, same branch. > > > https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest > https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest.patch > > git fetch git://github.com/mloftis/otp.git > crypto-add-ripemd160-digest > > > > On Wed, Dec 19, 2012 at 1:15 AM, Fredrik > wrote: > > Hello Michael, > It does not build: > crypto.c: In function ?ripemd160?: > crypto.c:621:28: error: ?RIPEMD160_LEN? undeclared (first use in > this function) > crypto.c:621:28: note: each undeclared identifier is reported only > once for each function it appears in > crypto.c: In function ?ripemd160_init?: > crypto.c:627:64: error: ?RIPEMD160_CTX_LEN? undeclared (first use > in this function) > crypto.c: In function ?ripemd160_update?: > crypto.c:636:22: error: ?RIPEMD160_CTX_LEN? undeclared (first use > in this function) > crypto.c: In function ?ripemd160_final?: > crypto.c:650:73: error: ?RIPEMD160_CTX_LEN? undeclared (first use > in this function) > crypto.c:654:47: error: ?RIPEMD160_LEN? undeclared (first use in > this function) > > Please take a look at this and give me a notice. > > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/18/2012 11:10 PM, Michael Loftis wrote: >> Apologies, done... >> >> https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest >> https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch >> >> git fetch git://github.com/mloftis/otp.git >> crypto-add-ripemd160-digest >> >> >> >> >> On Tue, Dec 18, 2012 at 1:45 PM, Tuncer Ayaz >> > wrote: >> >> On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: >> > >> > Add ripemd160 digest support to crypto. Includes a couple test >> > cases. >> > >> > >> > git fetch git://github.com/mloftis/otp.git >> crypto-add-ripemd160-digest >> > >> > This is based off of master-pu as of a few moments ago, my >> read of >> > the requirements tells me that should be the correct spot >> since I'm >> > adding a new feature to the crypto module. >> >> A patch for 'master-pu' has to be based off 'master'. >> >> > Not fully tested with the current erlang since jinterface has >> > completely broken my build on all platforms -- even if it is >> > disabled it still kills my build on most platforms because it's >> > using sh with scripts that have bash semantics. Might have >> a chance >> > to clean up that separate issue today and submit patches. >> >> >> >> >> -- >> >> "Genius might be described as a supreme capacity for getting its >> possessors >> into trouble of all kinds." >> -- Samuel Butler >> >> >> >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > > > > > -- > > "Genius might be described as a supreme capacity for getting its > possessors > into trouble of all kinds." > -- Samuel Butler > -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Thu Dec 20 15:02:11 2012 From: fredrik@REDACTED (Fredrik) Date: Thu, 20 Dec 2012 15:02:11 +0100 Subject: [erlang-patches] Some cleanups in kernel files In-Reply-To: <50D077FD.5060308@cs.ntua.gr> References: <50D077FD.5060308@cs.ntua.gr> Message-ID: <50D31A63.9000706@erlang.org> Hello Kostis, There has been raised some questions regarding this patch from the OTP team. In this commit: https://github.com/kostis/otp/commit/3a13b7a1e1bdd48b0293fc7366c3d133abf845bd You are returning 'ok' from a case clause which does not an affect on the returned value, {noreply, S}; We would like an explanation why this is so important. BR Fredrik Gustafsson Erlang OTP Team On 12/18/2012 03:04 PM, Kostis Sagonas wrote: > The code in some kernel modules has been cleaned up so that functions > do not return terms of wrong type by accident (most notably by having > a call to !/2 in a return position) and so that language constructs > that reflect in a more accurate way the program's intention are used. > > Please include: > > git fetch git://github.com/kostis/otp.git kernel-cleanup > > Kostis > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Fri Dec 21 11:51:56 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 21 Dec 2012 11:51:56 +0100 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: References: <50D185C7.60805@erlang.org> Message-ID: <50D43F4C.7070205@erlang.org> Hello Michael! The patch has been into review and the feedback: " New functions hash,hash_init,hash_update,hash_final has been added in master for R16. You should use them instead and not export your ripemd160 functions. Documentation is missing." Please fix this and I will fetch again. BR Fredrik Gustafsson Erlang OTP Team On 12/19/2012 07:05 PM, Michael Loftis wrote: > Entirely my fault, I missed two #define's when I moved the patch from > the crypto module I forked back at R13 back into the R15 source. I > only got R15 to compile today, R15 and my javac do not get along (but > I don't use any of that anyway). > > I've updated the github repo, same branch. > > > https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest > https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest.patch > > git fetch git://github.com/mloftis/otp.git > crypto-add-ripemd160-digest > > > > On Wed, Dec 19, 2012 at 1:15 AM, Fredrik > wrote: > > Hello Michael, > It does not build: > crypto.c: In function ?ripemd160?: > crypto.c:621:28: error: ?RIPEMD160_LEN? undeclared (first use in > this function) > crypto.c:621:28: note: each undeclared identifier is reported only > once for each function it appears in > crypto.c: In function ?ripemd160_init?: > crypto.c:627:64: error: ?RIPEMD160_CTX_LEN? undeclared (first use > in this function) > crypto.c: In function ?ripemd160_update?: > crypto.c:636:22: error: ?RIPEMD160_CTX_LEN? undeclared (first use > in this function) > crypto.c: In function ?ripemd160_final?: > crypto.c:650:73: error: ?RIPEMD160_CTX_LEN? undeclared (first use > in this function) > crypto.c:654:47: error: ?RIPEMD160_LEN? undeclared (first use in > this function) > > Please take a look at this and give me a notice. > > > BR Fredrik Gustafsson > Erlang OTP Team > On 12/18/2012 11:10 PM, Michael Loftis wrote: >> Apologies, done... >> >> https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest >> https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch >> >> git fetch git://github.com/mloftis/otp.git >> crypto-add-ripemd160-digest >> >> >> >> >> On Tue, Dec 18, 2012 at 1:45 PM, Tuncer Ayaz >> > wrote: >> >> On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: >> > >> > Add ripemd160 digest support to crypto. Includes a couple test >> > cases. >> > >> > >> > git fetch git://github.com/mloftis/otp.git >> crypto-add-ripemd160-digest >> > >> > This is based off of master-pu as of a few moments ago, my >> read of >> > the requirements tells me that should be the correct spot >> since I'm >> > adding a new feature to the crypto module. >> >> A patch for 'master-pu' has to be based off 'master'. >> >> > Not fully tested with the current erlang since jinterface has >> > completely broken my build on all platforms -- even if it is >> > disabled it still kills my build on most platforms because it's >> > using sh with scripts that have bash semantics. Might have >> a chance >> > to clean up that separate issue today and submit patches. >> >> >> >> >> -- >> >> "Genius might be described as a supreme capacity for getting its >> possessors >> into trouble of all kinds." >> -- Samuel Butler >> >> >> >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > > > > > -- > > "Genius might be described as a supreme capacity for getting its > possessors > into trouble of all kinds." > -- Samuel Butler > -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik@REDACTED Fri Dec 21 13:26:29 2012 From: fredrik@REDACTED (Fredrik) Date: Fri, 21 Dec 2012 13:26:29 +0100 Subject: [erlang-patches] Minor additions to the lists stdlib module In-Reply-To: References: Message-ID: <50D45575.1020607@erlang.org> Your patch has been into review and the feedback was: Hi We have decided to not include this patch, the lists module is full :-) and we are now rather restrictive in what we add to it. The convenience functions you added are already available with, array:foldl(Fun, [], array:from_list(List)) with some more functionality such as foldr, map and so on. Also the array module probably is a better datastructure to use if you need to access by index. Nice patch and sorry for the lost effort. BR Fredrik Gustafsson Erlang OTP Team On 12/16/2012 06:57 AM, Jeremy Ong wrote: > git fetch git://github.com/jeremyong/otp.git > lists_module_additions > > https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions > > https://github.com/jeremyong/otp/compare/erlang:master...jeremyong:lists_module_additions.patch > > I have added a few convenience functions for operating on lists in the > stdlib. > > These functions are ifoldl, ifoldr, imap, ifilter, and ipartition (the > i stands for "index). > > Often times, the index of an element is important when transforming a > list (for example, if I want to perform an operation on an odd-indexed > elements or tag each element of a list with the index formatted in > some way). These functions are very similar to the usual ones but the > lambdas passed to them take an additional argument which is the index > of each element as it gets passed to the lambda. > > I have tried to follow all directions outlined in the github wiki and > appreciate any and all feedback. > > Cheers, > Jeremy > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -------------- next part -------------- An HTML attachment was scrubbed... URL: From mloftis@REDACTED Fri Dec 21 19:38:06 2012 From: mloftis@REDACTED (Michael Loftis) Date: Fri, 21 Dec 2012 10:38:06 -0800 Subject: [erlang-patches] Add RIPEMD160 digest support to crypto In-Reply-To: <50D43F4C.7070205@erlang.org> References: <50D185C7.60805@erlang.org> <50D43F4C.7070205@erlang.org> Message-ID: I added the ripemd160 atom to the documentation, removed the exports, and added the bits to the hash and hash_init family....There's a info/0 function that returns ?FUNC_LIST -- and I'm actually not clear on it's use/behavior, but it appears that it is intended to indicate exported crypto functions, so I've omitted the now non-exported functions from that define. Hopefully this is right, as this appears to be the first "example" of a hash only function. On Fri, Dec 21, 2012 at 2:51 AM, Fredrik wrote: > Hello Michael! > The patch has been into review and the feedback: > " > > New functions hash,hash_init,hash_update,hash_final has been added in > master for R16. You should use them instead and not export your ripemd160 > functions. > > Documentation is missing." > Please fix this and I will fetch again. > > > BR Fredrik Gustafsson > Erlang OTP Team > > On 12/19/2012 07:05 PM, Michael Loftis wrote: > > Entirely my fault, I missed two #define's when I moved the patch from the > crypto module I forked back at R13 back into the R15 source. I only got > R15 to compile today, R15 and my javac do not get along (but I don't use > any of that anyway). > > I've updated the github repo, same branch. > > > > https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest > > https://github.com/mloftis/otp/compare/master-pu...crypto-add-ripemd160-digest.patch > > git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest > > > > On Wed, Dec 19, 2012 at 1:15 AM, Fredrik wrote: > >> Hello Michael, >> It does not build: >> crypto.c: In function ?ripemd160?: >> crypto.c:621:28: error: ?RIPEMD160_LEN? undeclared (first use in this >> function) >> crypto.c:621:28: note: each undeclared identifier is reported only once >> for each function it appears in >> crypto.c: In function ?ripemd160_init?: >> crypto.c:627:64: error: ?RIPEMD160_CTX_LEN? undeclared (first use in this >> function) >> crypto.c: In function ?ripemd160_update?: >> crypto.c:636:22: error: ?RIPEMD160_CTX_LEN? undeclared (first use in this >> function) >> crypto.c: In function ?ripemd160_final?: >> crypto.c:650:73: error: ?RIPEMD160_CTX_LEN? undeclared (first use in this >> function) >> crypto.c:654:47: error: ?RIPEMD160_LEN? undeclared (first use in this >> function) >> >> Please take a look at this and give me a notice. >> >> >> BR Fredrik Gustafsson >> Erlang OTP Team >> On 12/18/2012 11:10 PM, Michael Loftis wrote: >> >> Apologies, done... >> >> >> https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest >> >> https://github.com/mloftis/otp/compare/master...crypto-add-ripemd160-digest.patch >> >> git fetch git://github.com/mloftis/otp.git crypto-add-ripemd160-digest >> >> >> >> >> On Tue, Dec 18, 2012 at 1:45 PM, Tuncer Ayaz wrote: >> >>> On Tue, Dec 18, 2012 at 10:35 PM, Michael Loftis wrote: >>> > >>> > Add ripemd160 digest support to crypto. Includes a couple test >>> > cases. >>> > >>> > >>> > git fetch git://github.com/mloftis/otp.gitcrypto-add-ripemd160-digest >>> > >>> > This is based off of master-pu as of a few moments ago, my read of >>> > the requirements tells me that should be the correct spot since I'm >>> > adding a new feature to the crypto module. >>> >>> A patch for 'master-pu' has to be based off 'master'. >>> >>> > Not fully tested with the current erlang since jinterface has >>> > completely broken my build on all platforms -- even if it is >>> > disabled it still kills my build on most platforms because it's >>> > using sh with scripts that have bash semantics. Might have a chance >>> > to clean up that separate issue today and submit patches. >>> >> >> >> >> -- >> >> "Genius might be described as a supreme capacity for getting its >> possessors >> into trouble of all kinds." >> -- Samuel Butler >> >> >> >> _______________________________________________ >> erlang-patches mailing listerlang-patches@REDACTED://erlang.org/mailman/listinfo/erlang-patches >> >> >> > > > -- > > "Genius might be described as a supreme capacity for getting its possessors > into trouble of all kinds." > -- Samuel Butler > > > -- "Genius might be described as a supreme capacity for getting its possessors into trouble of all kinds." -- Samuel Butler -------------- next part -------------- An HTML attachment was scrubbed... URL: From mononcqc@REDACTED Sat Dec 22 23:41:29 2012 From: mononcqc@REDACTED (Fred Hebert) Date: Sat, 22 Dec 2012 17:41:29 -0500 Subject: [erlang-patches] Shell history search Message-ID: <20121222224128.GA941@ferdmbp.local> Hi, the following patch adds functionality to group.erl and edlin.erl in order to allow the user to search history. Search mode can be entered by pressing ctrl-r. Enter terms and press ctrl-r again to search backwards, or ctrl-s to then search forward (if you terminal doesn't eat up that one). Press enter to execute the line, or use tab, arrow keys, or other control sequences (^D, ^K, etc.) to exit search mode while remaining on the last found line. The search mode is a simpler version of the one available in bash or zsh shells. This adds a few modes to the shell (search, on top of none and meta) in group.erl for history search, and a few more in edlin.erl to change the meaning of control sequences while searching. This patch has been tested on OSX and some linux variants and worked fine. I tested it on Windows, and neither do werl.exe, or erl.exe (under PowerShell or cmd.exe) capture the ^R and ^S sequences -- it will not work there, but will not break any existing functionality. As far as I'm aware, this is more likely a driver issue than an issue with the patch (^G is not captured in cmd.exe, ctrl+C works in none of the above, for example). git fetch git://github.com/ferd/otp.git shell_history_search Compare at: https://github.com/ferd/otp/compare/erlang:master...ferd:shell_history_search https://github.com/ferd/otp/compare/erlang:master...ferd:shell_history_search.patch Regards, Fred. From mc@REDACTED Wed Dec 26 16:35:27 2012 From: mc@REDACTED (Pedram Nimreezi) Date: Wed, 26 Dec 2012 10:35:27 -0500 Subject: [erlang-patches] Selectively receive system messages in gen_server and gen_fsm Message-ID: The gen_server and gen_fsm modules do not selectively receive system messages. This commit addresses that and allows for them to be consistent with gen_event, as well as possibly taking advantage of the recent improvements to selective receive. https://github.com/DeadZen/otp/compare/maint...system-selective-receive https://github.com/DeadZen/otp/compare/maint...system-selective-receive.patch git fetch git://github.com/DeadZen/otp.git system-selective-receive Supplemental Questions... 1. I believe, but I am not sure if the selective receive call optimization triggers... seems like it should. 2. I see that gen_event does do a selective receive, and I believe this is more correct.. is that true? https://github.com/DeadZen/otp/blob/maint/lib/stdlib/src/gen_event.erl#L231 <- does https://github.com/DeadZen/otp/blob/maint/lib/stdlib/src/gen_fsm.erl#L424 <- does not https://github.com/DeadZen/otp/blob/maint/lib/stdlib/src/gen_server.erl#L374 <- does not 3. Is gen_event a more recent erlang behaviour than gen_server and gen_fsm? -- /* Sincerely -------------------------------------------------------------- Pedram Nimreezi - Chief Technology Officer */ // The hardest part of design ? is keeping features out. - Donald Norman From fdmanana@REDACTED Thu Dec 27 14:07:12 2012 From: fdmanana@REDACTED (Filipe David Manana) Date: Thu, 27 Dec 2012 13:07:12 +0000 Subject: [erlang-patches] Fix efile_drv crash when using async thread pool Message-ID: https://github.com/fdmanana/otp/compare/master...fix_efile_drv_crash.patch https://github.com/fdmanana/otp/compare/master...fix_efile_drv_crash git ?fetch ?git://github.com/fdmanana/otp.git ?fix_efile_drv_crash -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men."