From kostis@REDACTED Sun May 1 12:51:55 2011 From: kostis@REDACTED (Kostis Sagonas) Date: Sun, 01 May 2011 13:51:55 +0300 Subject: [erlang-patches] Fix in type info of list_to_bitstring/1 Message-ID: <4DBD3B4B.3010902@cs.ntua.gr> I've not seen this ending up in erlang-patches yet, so I repost it.T The hard coded type information about erlang:list_to_bitstring/1 in erl_bif_types was erroneous. The following patch fixes this. Please include in 'pu' and soon to 'dev'. git fetch git://github.com/kostis/otp.git list_to_bitstring Kostis From kostis@REDACTED Mon May 2 09:21:42 2011 From: kostis@REDACTED (Kostis Sagonas) Date: Mon, 02 May 2011 10:21:42 +0300 Subject: [erlang-patches] [erlang-bugs] Dialyzer v2.2.0 crash In-Reply-To: <4DBD72E3.1030307@cs.ntua.gr> References: <4DBD72E3.1030307@cs.ntua.gr> Message-ID: <4DBE5B86.4020403@cs.ntua.gr> Kostis Sagonas wrote: > Peer Stritzinger wrote: >> When running dialyzer like: >> >> ... >> >> I get the following error: >> ... SNIP > > Thanks for your bug report! It's indeed an error in the processing of > binary types generated by typer which are then fed back to dialyzer. I > already have a patch ready that fixes this and will hopefully appear in > OTP's dev branch pretty soon. Since I had already a branch open which was fixing some other issue in erl_types.erl, I've decided to use that branch for including those fixes too. I know it's not the proper way of doing things, but it's extremely cumbersome to maintain different versions of erl_types... The changes that fix these are here: git fetch git://github.com/kostis/otp.git list_to_bitstring The last commit fixes the issue reported by Peer. The previous commits refer to erlang:list_to_bitstring/1. Kostis From henrik@REDACTED Mon May 2 11:34:40 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 2 May 2011 11:34:40 +0200 Subject: [erlang-patches] [erlang-bugs] Dialyzer v2.2.0 crash In-Reply-To: <4DBE5B86.4020403@cs.ntua.gr> References: <4DBD72E3.1030307@cs.ntua.gr> <4DBE5B86.4020403@cs.ntua.gr> Message-ID: <4DBE7AB0.1080307@erlang.org> On 05/02/2011 09:21 AM, Kostis Sagonas wrote: > Kostis Sagonas wrote: >> Peer Stritzinger wrote: >>> When running dialyzer like: >>> >>> ... >>> >>> I get the following error: >>> ... SNIP >> >> Thanks for your bug report! It's indeed an error in the processing >> of binary types generated by typer which are then fed back to >> dialyzer. I already have a patch ready that fixes this and will >> hopefully appear in OTP's dev branch pretty soon. > > Since I had already a branch open which was fixing some other issue in > erl_types.erl, I've decided to use that branch for including those > fixes too. I know it's not the proper way of doing things, but it's > extremely cumbersome to maintain different versions of erl_types... > > The changes that fix these are here: > > git fetch git://github.com/kostis/otp.git list_to_bitstring > > The last commit fixes the issue reported by Peer. > The previous commits refer to erlang:list_to_bitstring/1. > > Kostis > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi I have included this branch into 'pu' If nothing breaks I aim for a swift graduation to 'dev' Thank you for the contribution -- /Henrik Nord Erlang/OTP From henrik@REDACTED Mon May 2 12:17:12 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 2 May 2011 12:17:12 +0200 Subject: [erlang-patches] True streaming of AES CTR In-Reply-To: References: Message-ID: <4DBE84A8.8070501@erlang.org> On 04/29/2011 07:14 PM, Travis Jensen wrote: > I've added a pull request to github for a change to the crypto module > that allows true streaming of AES CTR mode. I'm afraid I didn't get > things quite right on the formatting of the pull request (I'm more > familiar with Mercurial than Git), but here it is, anyway: > https://github.com/erlang/otp/pull/12 > > Basically, this change makes AES CTR behave similarly to the RC4 > implementation. > > An example usage looks like: > > State = crypto:aes_ctr_state_init(Key, IV), > { Cipher, State2 } = crypto:aes_ctr_encrypt_with_state(State, Data), > { Cipher2, State3 } = crypto:aes_ctr_encrypt_with_state(State2, Data), > > I've used the existing AES CTR tests to implement tests for it as > well. If I need to reformat the patch, I can certainly do that, but > it really pretty minor. > > tj > -- > *Travis Jensen* > * > *Read the Software Maven @ http://softwaremaven.innerbrane.com/ > Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen > Read my Twitter mumblings @ http://twitter.com/SoftwareMaven > Send me email @ travis.jensen@REDACTED > > /*What kind of guy calls himself the Software Maven???*/ > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Please don't use pull requests as that is not the correct channel to get the patch into Erlang/OTP Have a look at the patch guide. https://github.com/erlang/otp/wiki/Submitting-patches https://github.com/erlang/otp/wiki/Writing-good-commit-messages https://github.com/erlang/otp/wiki/FAQ%3A-What-kind-of-patches-will-be-approved%3F Also please make sure you only have relevant commits in your branch https://github.com/erlang/otp/wiki/Refining-patches-using-git Thank you for the contribution! -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From tuncer.ayaz@REDACTED Mon May 2 12:51:36 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Mon, 2 May 2011 12:51:36 +0200 Subject: [erlang-patches] inet_drv: remove unused tcp request id Message-ID: git fetch git://github.com/tuncer/otp.git inet_drv-unused-req-id From henrik@REDACTED Mon May 2 14:41:12 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 2 May 2011 14:41:12 +0200 Subject: [erlang-patches] inet_drv: remove unused tcp request id In-Reply-To: References: Message-ID: <4DBEA668.9060106@erlang.org> On 05/02/2011 12:51 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git inet_drv-unused-req-id > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi Tuncer It would be nice if you can gather your changes in one branch and have separate commits for the changes instead of alot of small branches. Thanks -- /Henrik Nord Erlang/OTP From henrik@REDACTED Mon May 2 14:54:11 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 2 May 2011 14:54:11 +0200 Subject: [erlang-patches] cover: fix file descriptor leak In-Reply-To: References: Message-ID: <4DBEA973.8050707@erlang.org> On 04/29/2011 08:07 AM, shunichi shinohara wrote: > The patch below fixes file descriptor leak of cover module. > > git fetch https://github.com/shino/otp.git shino/fix-cover-fd-leak > > Explanation: > > Data import of cover module is called with a file path and > open a fd internally. The fd should be closed in cover module, > but it does not. > As an additional information, in data export it closes a fd properly. > > This patch does not include test code because > - I can't find the way to execute test suites, and > - I don't know how to find fd list in beam process. > > Steps to reproduce: > > I tested the patch on Mac OS X 10.6.7, 64bit. > > 1. Run the escript below, and find the process id (OS pid). > ============ > #!/usr/bin/env escript > -export([main/1]). > > main([]) -> > file:write_file("sample.erl",<<"-module(sample).\n">>), > {ok, sample} = cover:compile("sample.erl"), > ok = cover:export("sample.coverdata", sample), > ok = cover:import("sample.coverdata"), > io:format("~s~n", [os:cmd("lsof -p " ++ os:getpid())]). > ============ > > 2. Confirm cover's data file is NOT listed in output. > > Before apply this patch, script outputs the line like: > beam.smp 17008 shino 11r REG 14,5 89 567192 /path/to/sample.coverdata > > After this patch is applied, lsof does not report "sample.coverdata". > > Regards, > Shunichi Shinohara (shino.shun@REDACTED) > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi I have now included this branch in 'pu' and I will let it cook for a while. Information on how to invoke the tests can be found on the github wiki: https://github.com/erlang/otp/wiki/Running-tests If you have additional questions do not hesitate to ask Thank you for the contribution! -- /Henrik Nord Erlang/OTP From tuncer.ayaz@REDACTED Mon May 2 15:12:59 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Mon, 2 May 2011 15:12:59 +0200 Subject: [erlang-patches] inet_drv: remove unused tcp request id In-Reply-To: <4DBEA668.9060106@erlang.org> References: <4DBEA668.9060106@erlang.org> Message-ID: On Mon, May 2, 2011 at 2:41 PM, Henrik Nord wrote: > On 05/02/2011 12:51 PM, Tuncer Ayaz wrote: >> >> git fetch git://github.com/tuncer/otp.git inet_drv-unused-req-id > > Hi Tuncer > > It would be nice if you can gather your changes in one branch and have > separate commits for the changes instead of alot of small branches. Sure. git fetch git://github.com/tuncer/otp.git inet_drv-cleanup From henrik@REDACTED Mon May 2 16:29:25 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 2 May 2011 16:29:25 +0200 Subject: [erlang-patches] eunit: fix race conditions In-Reply-To: References: Message-ID: <4DBEBFC5.2000209@erlang.org> On 04/18/2011 11:06 AM, Klas Johansson wrote: > Hi, > > When playing around with eunit's surefire XML reports I > noticed that the files are sometimes not generated and > I decided to have a look: > > Wait until all eunit listeners terminate > > Ensure that all eunit listeners (like > eunit_surefire) get the chance to finish their work > before terminating. Prior to this fix, the > eunit_surefire XML was sometimes not generated. > > While addressing that problem I also noticed the > following: > > Don't let eunit_surefire report back to eunit when stopping > > When eunit is terminating, a stop message is sent > to all listeners and eunit then waits for *one* > result message but previously both eunit_tty and > eunit_surefire sent a response on error. Don't > send a result message from eunit_surefire; let > eunit_tty take care of all result reporting, both > positive and negative to avoid race conditions and > inconsistencies. > > Tested manually by running eunit with surefire report > generation over and over again (with a timer:sleep/1 > inserted to make sure that XML file generation takes > time to complete). > > > Code here: > > git fetch git://github.com/klajo/otp.git eunit-race-cond > > > > Cheers, > Klas > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi Thank you for the contribution! you branch is now cooking in 'pu' -- /Henrik Nord Erlang/OTP From henrik@REDACTED Mon May 2 17:48:51 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 2 May 2011 17:48:51 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-05-02) Message-ID: <201105021548.p42FmnkP027974@smaug.otp.ericsson.se> ------------------------------------------------------------ [Graduated] * km/pool_connect-to-running-nodes (stdlib) (2010-09-02) 1 commit + Change pool module to attempt to attach to nodes that are already running (a9f4cbc) * ks/prim_file-fixes (erts) (2011-04-27) 3 commits + add prim_file.beam (e56d1c1) + Driver names should be strings, not atoms (0f03b1e) + Cleanup and cosmetic changes (bfc2254) * ms/erl_interface-compile-error (erl_interface) (2011-04-08) 1 commit + erl_interface: fix compile error (daad8e6) * ms/file-fix-hang-reading-compressed-files (erts, kernel) (2011-04-07) 1 commit + file: fix hang reading compressed files (b9e8506) * ms/unsigned-integer-overflow-in-error (erts) (2011-04-06) 1 commit + Unsigned integer may overflow in error message (3257bb0) * sv/enif_is_exception (erts) (2011-02-22) 1 commit + add support for checking if an ERL_NIF_TERM is an exception (b02f03c) * ta/common_test-ignore-ct_slave-xml (otp) (2011-04-27) 1 commit + Ignore lib/common_test/doc/src/ct_slave.xml (44465b1) * ta/driver_entry-typo (erts) (2011-04-26) 1 commit + driver_entry: Remove gratuitous paren and fix typo (4380605) ------------------------------------------------------------ [New topics] * kj/eunit-race-cond (eunit) (2011-04-17) 2 commits - Don't let eunit_surefire report back to eunit when stopping (bd38a12) - Wait until all eunit listeners terminate (0e7c557) * ks/list_to_bitstring (hipe) (2011-05-01) 4 commits - Fix handling of <<_:N,_:_*M>> type expressions (9a256f1) - Fix the argument of erlang:list_to_bitstring/1 (1abe7a3) - Move function to its proper place (ba73458) - Remove unneeded function 'sequence/2' (b9903ed) * ss/fix-cover-fd-leak (tools) (2011-04-29) 1 commit - Fix file descriptor leak (0568a0e) * ta/inet_drv-cleanup (erts) (2011-05-02) 2 commits - inet_drv: remove unused tcp request id (1a0389b) - inet_drv: remove gratuitous assignment (92b693e) ------------------------------------------------------------ [Stalled] * bw/efile_exists (erts) (2010-10-07) 1 commit - prim_file:exists/{1,2} which is lightweight file existence check (7203932) Action expected from: Topic author * fm/posix-fallocate (erts, kernel) (2011-04-15) 4 commits - Added missing surrounding if statement (5ec9fab) - Fixes to file:allocate/2 and respective tests (d0fb479) - Fix build on Solaris (9b8aecf) - Added file:allocate/2 (7554dbb) Action expected from: Topic author * jf/run_erl-disable-flow-control (erts) (2010-03-05) 1 commit - Teach run_erl RUN_ERL_DISABLE_FLOWCNTRL for disabling flow control (d0775cd) Action expected from: Topic author * jn/gen_stream (stdlib) (2011-04-15) 2 commits - Update gen_stream tests to conform with common_test standard (9f50d34) - Add gen_stream behaviour (3065e10) Action expected from: OTP-Team * lt/et-fix (et) (2011-03-30) 1 commit - Force contents window size to display correctly on Windows. (9836fb2) Action expected from: Topic author * sa/callback-attr (compiler, inets, kernel, otp, stdlib) (2010-06-08) 6 commits - Add callback specs into 'application' module in kernel (a180fb1) - Add callback specs to tftp module following internet documentation (d0e32d8) - Add callback specs to inets_service module following possibly deprecated comments (d90e984) - Add '-callback' attributes in stdlib's behaviours (acf3d67) - Update primary bootstrap (30c1e91) - Add '-callback' attribute to language syntax (6ee955e) Action expected from: OTP-Team * ta/typer-quote-atoms (hipe, typer) (2011-03-20) 1 commit - Quote atoms if necessary in types (254e21e) Action expected from: Hipe-team reviewer * uw/mnesia-majority (mnesia) (2011-01-30) 8 commits - Add documentation text about majority checking (f5b8427) - add mnesia_majority_test suite (9c2f765) - where_to_wlock optimization + change_table_majority/2 (a535b6c) - bug in mnesia_tm:needs_majority/2 (eb81e20) - optimize sticky_lock maj. check (5b304d4) - check majority for sticky locks (ae9e1fa) - Write locks now check majority when needed. (6f02d2e) - Add {majority, boolean()} per-table option. (c3241c0) Action expected from: OTP-Applications team * vb/shell (erts, kernel, stdlib) (2011-01-21) 6 commits - Add expandfmt_fun option for io:setopts (f139eab) - Correct JCL's help indentation (95672fa) - Handle JCL's "r" command error when no pool started (ba4b196) - Fix tab expansion in remote shell (e2077cb) - edlin_expand: fix matches formatting (838b84a) - Take into account arity len when calculating field's width (ff28c52) Action expected from: OTP-reviewer * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits . Implement namespace axis (27d791f) . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) . Fix processing-instruction(name?) (f05e78b) . Fix path filters (610df56) . Support more top-level primary expressions (770d6d9) . Accumulate comments in element nodes (e5b6b3a) . Add `default_attrs` option (18584c5) . Allow whole documents to be returned (aef3dea) . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) . Track parents in `#xmlPI` nodes (5095331) . Set `vsn` field in `#xmlDecl` record (d712331) . Fix namespace-conformance constraints (e062270) Action expected from: R15 rel ------------------------------------------------------------ [Cooking] * bd/mod_esi_timeout_fix (inets) (2011-03-17) 1 commit - Fix timeout message generated by mod_esi (eea0a7b) * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits - Avoid crash by skipping compilation_SUITE:on_load/1 (0d913e0) - Inline less aggressively for native-code compilation (0215ac6) - Crudely fix return type for the lists:key{search,find,member}/3 (4f48864) - seq_trace_SUITE: Don't native-compile (3799b17) - Disable native code if on_load is used (f35872c) - andor_SUITE: Don't native-compile (a8ab68c) This branch contains temporary workarounds to avoid failing test cases and is never intended to graduate. * bsmr/fix-makefile-in-for-xref-mod-app-escript (otp) (2010-12-10) 1 commit - Fix for Makefile.in invoking xref_mod_app.escript (10d4235) * ks/snmp-specs (snmp) (2011-04-03) 1 commit - Add specs for functions that do not return (7354ffb) * mh/inhibit-newline-inside-typespec (tools) (2011-04-14) 1 commit - Inhibit electric newline after "->" when inside a type spec (c0c600a) * ms/beam-fix-format-specifiers-in-erl_exit-msg (erts) (2011-04-06) 1 commit - Fix format specifiers in erl_exit messages (a8bacf3) * pr/mnesia_frag_hash (mnesia) (2011-04-27) 2 commits - add mnesia_frag_hash test (1d6762d) - Reduce calls to phash in key_to_frag_number (67a20c0) * rj/fix-httpd-format (inets) (2011-03-17) 1 commit - Fix log messages formating in httpd (cbe8b2e) * sa/dialyzer-tests (dialyzer) (2011-03-21) 22 commits - Update dialyzer.spec (6f2b127) - Add race/ets_insert_public (fee1a1e) - Add opaque/ewgi,ewgi2 (7cd0b26) - Add opaque/schuett_bug (9c7d84b) - Add small/param_types_crash (aaf9ec2) - Add small/file_open_encoding (a106909) - Add small/false_false (4cd05bf) - Add small/ets_update_counter (3f25077) - Add small/bin_compr (8b3b609) - Add small/tuple_set_crash (dc91d02) - Add small/refine_failing (bb03af3) - Add small/not_bogus_warning (c3c4253) ... * ta/dragonfly-test_server-config (test_server) (2011-04-22) 1 commit - Add DragonflyBSD support to test_server (0a97fea) * ta/sendfile (erts, kernel) (2011-01-13) 1 commit - Implement file:sendfile (6c70e81) * ta/unicode-non-chars (stdlib) (2011-04-05) 1 commit - unicode: document 16#FFFE and 16#FFFF (non chars) (5043e8f) * tn/inet_drv-fix (erts) (2011-04-08) 1 commit - Use libdlpi to get physical address (e360563) * dc/improved_find_redist (erts) (2011-03-18) 1 commit . support new SDKs in find_redist.sh and fallback to $ERL_TOP as last resort (f4f35aa) ------------------------------------------------------------ [Dropped] * ta/inet_drv-gratuitous-assign (erts) (2011-04-30) 1 commit . inet_drv: remove gratuitous assignment (6d2477c) From jonas.falkevik@REDACTED Mon May 2 22:28:50 2011 From: jonas.falkevik@REDACTED (Jonas Falkevik) Date: Mon, 2 May 2011 22:28:50 +0200 Subject: [erlang-patches] Disable flow control for beam started via run_erl In-Reply-To: <4DA5A707.2050101@erlang.org> References: <4DA5A707.2050101@erlang.org> Message-ID: <425A8771-7CB7-495A-9326-21D56E4B3167@mobilearts.com> On Apr 13, 2011, at 15:37 , Henrik Nord wrote: > Hi > > This branch has been long overdue for a review sense it was submitted over a year ago > > Here are the things that we would like to see done before it is included in 'dev' > > * RUN_ERL_DISABLE_FLOWCNTRL needs to be documented. > * In the error messages, "terminals" should be changed to "terminal's". > > Thank you for your patience and contribution! > > -- > /Henrik Nord Erlang/OTP > Changes done according to your suggestions. I made a new branch since I have been playing around with the old one trying to keep it up to date. git fetch git://github.com/falkevik/otp.git opt_disable_flow_ctrl_run_erl_pty Thanks, Jonas From travis.jensen@REDACTED Mon May 2 22:58:55 2011 From: travis.jensen@REDACTED (Travis Jensen) Date: Mon, 2 May 2011 14:58:55 -0600 Subject: [erlang-patches] Streaming AES CTR and HMAC functions Message-ID: git fetch git://github.com/SoftwareMaven/otp.git streaming_crypto_functions Add true streaming AES (CTR) encryption and streaming HMAC operations The current crypto module implementations require all of the data being encrypted or authenticated to be in memory at one time. When trying to encrypt or authenticate a large file (on order of GBs), this is problematic. The implementation of AES CTR uses the same underlying implementation as aes_ctr_[en|de]crypt, but hands the state back to the client after every operation. The HMAC implementation differs from the previous implementations of sha_mac and md5_mac. The old implementations did not utilize the OpenSSL HMAC implementation. In order to ensure that I didn't implement something incorrectly, I chose to use the OpenSSL HMAC implementation directly, since it handles streaming as well. This has the added side benefit of allowing other hash functions to be used as desired (for instances, I added support for ripemd160 hashing). While I haven't done this, it seems like the existing md5_mac and sha_mac functions could either be depricated or redefined in terms of the new hmac_ functions. -- *Travis Jensen* *** *Read the Software Maven @ http://softwaremaven.innerbrane.com/ Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen Read my Twitter mumblings @ http://twitter.com/SoftwareMaven Send me email @ travis.jensen@REDACTED **What kind of guy calls himself the Software Maven???** -------------- next part -------------- An HTML attachment was scrubbed... URL: From henrik@REDACTED Tue May 3 11:16:23 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 3 May 2011 11:16:23 +0200 Subject: [erlang-patches] Disable flow control for beam started via run_erl In-Reply-To: <425A8771-7CB7-495A-9326-21D56E4B3167@mobilearts.com> References: <4DA5A707.2050101@erlang.org> <425A8771-7CB7-495A-9326-21D56E4B3167@mobilearts.com> Message-ID: <4DBFC7E7.7030201@erlang.org> On 05/02/2011 10:28 PM, Jonas Falkevik wrote: > On Apr 13, 2011, at 15:37 , Henrik Nord wrote: > >> Hi >> >> This branch has been long overdue for a review sense it was submitted over a year ago >> >> Here are the things that we would like to see done before it is included in 'dev' >> >> * RUN_ERL_DISABLE_FLOWCNTRL needs to be documented. >> * In the error messages, "terminals" should be changed to "terminal's". >> >> Thank you for your patience and contribution! >> >> -- >> /Henrik Nord Erlang/OTP >> > > Changes done according to your suggestions. > I made a new branch since I have been playing around with the old one trying to keep it up to date. > > git fetch git://github.com/falkevik/otp.git opt_disable_flow_ctrl_run_erl_pty > > Thanks, > Jonas > I have refetched your branch Thank you for the contribution! -- /Henrik Nord Erlang/OTP From henrik@REDACTED Tue May 3 14:48:12 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 3 May 2011 14:48:12 +0200 Subject: [erlang-patches] Streaming AES CTR and HMAC functions In-Reply-To: References: Message-ID: <4DBFF98C.9050509@erlang.org> On 05/02/2011 10:58 PM, Travis Jensen wrote: > git fetch git://github.com/SoftwareMaven/otp.git > streaming_crypto_functions > > Add true streaming AES (CTR) encryption and streaming HMAC operations > > The current crypto module implementations require all of the data > being encrypted or authenticated to be in memory at one time. When > trying to encrypt or authenticate a large file (on order of GBs), > this is problematic. > > The implementation of AES CTR uses the same underlying implementation > as aes_ctr_[en|de]crypt, but hands the state back to the client > after every operation. > > The HMAC implementation differs from the previous implementations of > sha_mac and md5_mac. The old implementations did not utilize the > OpenSSL HMAC implementation. In order to ensure that I didn't > implement something incorrectly, I chose to use the OpenSSL HMAC > implementation directly, since it handles streaming as well. This > has the added side benefit of allowing other hash functions to be > used as desired (for instances, I added support for ripemd160 > hashing). > > While I haven't done this, it seems like the existing md5_mac and > sha_mac functions could either be depricated or redefined in terms > of the new hmac_ functions. > > > -- > *Travis Jensen* > * > *Read the Software Maven @ http://softwaremaven.innerbrane.com/ > Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen > Read my Twitter mumblings @ http://twitter.com/SoftwareMaven > Send me email @ travis.jensen@REDACTED > > /*What kind of guy calls himself the Software Maven???*/ > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi I have included your branch into 'pu' and will let it cook for a while. Thank you for the contribution! -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From henrik@REDACTED Tue May 3 15:17:08 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 3 May 2011 15:17:08 +0200 Subject: [erlang-patches] Patch to xmerl_scan to fix character-reference normalization in attribute values In-Reply-To: References: Message-ID: <4DC00054.7020306@erlang.org> On 04/28/2011 11:24 PM, Tom Moertel wrote: > The following short patch fixes a bug in xmerl that causes character > references in attribute values to be normalized incorrectly: > > git fetch https://github.com/tmoertel/otp.git xmerl_attr_charref_fix > > Explanation: > > Section 3.3.3 of the XML Recommendation gives the rules for > attribute-value normalization. One of those rules requires > that character references not be re-normalized after being > replaced with the referenced characters: > > For a character reference, append the referenced > character to the normalized value. > > And, in particular: > > Note that if the unnormalized attribute value contains > a character reference to a white space character other > than space (#x20), the normalized value contains the > referenced character itself (#xD, #xA or #x9). > > Source: http://www.w3.org/TR/xml/#AVNormalize > > In xmerl_scan, however, character references in attributes are > normalized again after replacement. For example, the > character reference " " in the following XML document gets > normalized (incorrectly) into a space when parsed: > > 2> xmerl_scan:string(""). > {... [{xmlAttribute,x,[],[],[],[],1,[]," ",false}] ...} > > This short patch restores the correct behavior: > > 2> xmerl_scan:string(""). > {... [{xmlAttribute,x,[],[],[],[],1,[],"\n",false}] ...} > > NOTE: This change does not include tests because I could not > find a test suite for xmerl. > > > > Cheers, > Tom > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Your branch is included in 'opu' If nothing major breaks you it will be merged into 'dev' shortly Thank you for the contribution! -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From henrik@REDACTED Wed May 4 11:35:56 2011 From: henrik@REDACTED (Henrik Nord) Date: Wed, 4 May 2011 11:35:56 +0200 Subject: [erlang-patches] Dialyzer tests update In-Reply-To: References: Message-ID: <4DC11DFC.9090901@erlang.org> On 04/21/2011 11:46 AM, Stavros Aronis wrote: > This branch contains a restructure of Dialyzer's test suites, a fix > for the options1/compiler broken test and some more tests that have > been added to the suites. > > git fetch git://github.com/aronisstav/otp.git > dialyzer-tests > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hello Stavros. Thees tests are now passing, after failing on all platforms prior to: ks/list_to_bitstring: http://github.com/erlang/otp/commit/9b046ad3ab6fb2c77b3ce8708e8751da189e1089 inclusion into 'pu' r9c_SUITE:asn1 race_SUITE:mnesia_diff_atoms_race2 race_SUITE:mnesia_dirty_read_two_write_one race_SUITE:mnesia_dirty_read_write_double2 race_SUITE:mnesia_dirty_read_write_double4 race_SUITE:mnesia_dirty_read_write_one small_SUITE:my_sofs This test is still failing on all 'pu' platforms small_SUITE:cerl_hipeify === location [{small_SUITE,cerl_hipeify,147 }, {small_SUITE,dialyze,75 }, {small_SUITE,cerl_hipeify,145 }] === reason = {test_case_failed, {differ, [{old,3, "cerl_hipeify.erl:370: Guard test fun((none()) -> none()) =:= F::{_,_,_} | {_,_,_,_} | {_,_,_,_,_} | {_,_,_,_,_,_} | {_,_,_,_,_,_,_} can never succeed\n"}, {old,4, "cerl_hipeify.erl:641: Function env__new_function_name/2 will never be called\n"}]}} Let me know if I can assist with more info, and/or specific logs -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From shino.shun@REDACTED Wed May 4 17:03:59 2011 From: shino.shun@REDACTED (shunichi shinohara) Date: Thu, 5 May 2011 00:03:59 +0900 Subject: [erlang-patches] cover: fix file descriptor leak In-Reply-To: <4DBEA973.8050707@erlang.org> References: <4DBEA973.8050707@erlang.org> Message-ID: Thanks for information to run tests. By following the wiki, I can execute test suites of tools app. Thanks, shino On Mon, May 2, 2011 at 9:54 PM, Henrik Nord wrote: > On 04/29/2011 08:07 AM, shunichi shinohara wrote: >> >> The patch below fixes file descriptor leak of cover module. >> >> ? git fetch https://github.com/shino/otp.git shino/fix-cover-fd-leak >> >> Explanation: >> >> Data import of cover module is called with a file path and >> open a fd internally. The fd should be closed in cover module, >> but it does not. >> As an additional information, in data export it closes a fd properly. >> >> This patch does not include test code because >> ? - I can't find the way to execute test suites, and >> ? - I don't know how to find fd list in beam process. >> >> Steps to reproduce: >> >> I tested the patch on Mac OS X 10.6.7, 64bit. >> >> 1. Run the escript below, and find the process id (OS pid). >> ============ >> #!/usr/bin/env escript >> -export([main/1]). >> >> main([]) -> >> ? ? file:write_file("sample.erl",<<"-module(sample).\n">>), >> ? ? {ok, sample} = cover:compile("sample.erl"), >> ? ? ok = cover:export("sample.coverdata", sample), >> ? ? ok = cover:import("sample.coverdata"), >> ? ? io:format("~s~n", [os:cmd("lsof -p " ++ os:getpid())]). >> ============ >> >> 2. Confirm cover's data file is NOT listed in output. >> >> ? ?Before apply this patch, script outputs the line like: >> ? ?beam.smp 17008 shino 11r REG 14,5 89 567192 /path/to/sample.coverdata >> >> ? ?After this patch is applied, lsof does not report "sample.coverdata". >> >> Regards, >> Shunichi Shinohara (shino.shun@REDACTED) >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > > Hi > > I have now included this branch in 'pu' and I will let it cook for a while. > > Information on how to invoke the tests can be found on the github wiki: > https://github.com/erlang/otp/wiki/Running-tests > If you have additional questions do not hesitate to ask > Thank you for the contribution! > > -- > /Henrik Nord Erlang/OTP > > From tuncer.ayaz@REDACTED Thu May 5 00:27:12 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Thu, 5 May 2011 00:27:12 +0200 Subject: [erlang-patches] sendfile() In-Reply-To: References: Message-ID: git fetch git://github.com/tuncer/otp.git sendfile Please refetch. Refactored to use driver_select(). From henrik@REDACTED Thu May 5 10:34:00 2011 From: henrik@REDACTED (Henrik Nord) Date: Thu, 5 May 2011 10:34:00 +0200 Subject: [erlang-patches] sendfile() In-Reply-To: References: Message-ID: <4DC260F8.9080505@erlang.org> On 05/05/2011 12:27 AM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git sendfile > > Please refetch. Refactored to use driver_select(). > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Refetched! -- /Henrik Nord Erlang/OTP From nick@REDACTED Thu May 5 16:13:10 2011 From: nick@REDACTED (Niclas Eklund) Date: Thu, 5 May 2011 16:13:10 +0200 Subject: [erlang-patches] SSH-2.0.6 is available Message-ID: Hello! A memory leak has been sealed in the SSH application. If you use it you should upgrade as soon as possible (at the latest when R14B03 is released within a few weeks). You can find it via Github: https://github.com/erlang/otp/commit/b39153c1db8e311e6fb759f7c778b10340902890 Note, it depends on some new functions in Crypto. Hence, you must add this as well: https://github.com/erlang/otp/commit/f228601de45c5b53241b103af6616453c50885a5 Since it's impossible how many uses this application, it would be nice if you could reply to this mail (to me only) what you use it for. A general description is good enough. TIA! Best Regards, Niclas @ Erlang/OTP From shino.shun@REDACTED Fri May 6 04:57:36 2011 From: shino.shun@REDACTED (shunichi shinohara) Date: Fri, 6 May 2011 11:57:36 +0900 Subject: [erlang-patches] cover: fix file descriptor leak In-Reply-To: <4DBEA973.8050707@erlang.org> References: <4DBEA973.8050707@erlang.org> Message-ID: Hi I added assertion to detect file descriptor leak in the test case. git fetch https://github.com/shino/otp.git shino/fix-cover-fd-leak It not elegant, but works :-) HTH -- shino On Mon, May 2, 2011 at 9:54 PM, Henrik Nord wrote: > On 04/29/2011 08:07 AM, shunichi shinohara wrote: >> >> The patch below fixes file descriptor leak of cover module. >> >> ? git fetch https://github.com/shino/otp.git shino/fix-cover-fd-leak >> >> Explanation: >> >> Data import of cover module is called with a file path and >> open a fd internally. The fd should be closed in cover module, >> but it does not. >> As an additional information, in data export it closes a fd properly. >> >> This patch does not include test code because >> ? - I can't find the way to execute test suites, and >> ? - I don't know how to find fd list in beam process. >> >> Steps to reproduce: >> >> I tested the patch on Mac OS X 10.6.7, 64bit. >> >> 1. Run the escript below, and find the process id (OS pid). >> ============ >> #!/usr/bin/env escript >> -export([main/1]). >> >> main([]) -> >> ? ? file:write_file("sample.erl",<<"-module(sample).\n">>), >> ? ? {ok, sample} = cover:compile("sample.erl"), >> ? ? ok = cover:export("sample.coverdata", sample), >> ? ? ok = cover:import("sample.coverdata"), >> ? ? io:format("~s~n", [os:cmd("lsof -p " ++ os:getpid())]). >> ============ >> >> 2. Confirm cover's data file is NOT listed in output. >> >> ? ?Before apply this patch, script outputs the line like: >> ? ?beam.smp 17008 shino 11r REG 14,5 89 567192 /path/to/sample.coverdata >> >> ? ?After this patch is applied, lsof does not report "sample.coverdata". >> >> Regards, >> Shunichi Shinohara (shino.shun@REDACTED) >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > > Hi > > I have now included this branch in 'pu' and I will let it cook for a while. > > Information on how to invoke the tests can be found on the github wiki: > https://github.com/erlang/otp/wiki/Running-tests > If you have additional questions do not hesitate to ask > Thank you for the contribution! > > -- > /Henrik Nord Erlang/OTP > > From henrik@REDACTED Fri May 6 09:25:45 2011 From: henrik@REDACTED (Henrik Nord) Date: Fri, 6 May 2011 09:25:45 +0200 Subject: [erlang-patches] cover: fix file descriptor leak In-Reply-To: References: <4DBEA973.8050707@erlang.org> Message-ID: <4DC3A279.7010604@erlang.org> On 05/06/2011 04:57 AM, shunichi shinohara wrote: > Hi > > I added assertion to detect file descriptor leak in the test case. > > git fetch https://github.com/shino/otp.git shino/fix-cover-fd-leak > > It not elegant, but works :-) > HTH > > -- > shino > > On Mon, May 2, 2011 at 9:54 PM, Henrik Nord wrote: >> On 04/29/2011 08:07 AM, shunichi shinohara wrote: >>> The patch below fixes file descriptor leak of cover module. >>> >>> git fetch https://github.com/shino/otp.git shino/fix-cover-fd-leak >>> >>> Explanation: >>> >>> Data import of cover module is called with a file path and >>> open a fd internally. The fd should be closed in cover module, >>> but it does not. >>> As an additional information, in data export it closes a fd properly. >>> >>> This patch does not include test code because >>> - I can't find the way to execute test suites, and >>> - I don't know how to find fd list in beam process. >>> >>> Steps to reproduce: >>> >>> I tested the patch on Mac OS X 10.6.7, 64bit. >>> >>> 1. Run the escript below, and find the process id (OS pid). >>> ============ >>> #!/usr/bin/env escript >>> -export([main/1]). >>> >>> main([]) -> >>> file:write_file("sample.erl",<<"-module(sample).\n">>), >>> {ok, sample} = cover:compile("sample.erl"), >>> ok = cover:export("sample.coverdata", sample), >>> ok = cover:import("sample.coverdata"), >>> io:format("~s~n", [os:cmd("lsof -p " ++ os:getpid())]). >>> ============ >>> >>> 2. Confirm cover's data file is NOT listed in output. >>> >>> Before apply this patch, script outputs the line like: >>> beam.smp 17008 shino 11r REG 14,5 89 567192 /path/to/sample.coverdata >>> >>> After this patch is applied, lsof does not report "sample.coverdata". >>> >>> Regards, >>> Shunichi Shinohara (shino.shun@REDACTED) >>> _______________________________________________ >>> erlang-patches mailing list >>> erlang-patches@REDACTED >>> http://erlang.org/mailman/listinfo/erlang-patches >> Hi >> >> I have now included this branch in 'pu' and I will let it cook for a while. >> >> Information on how to invoke the tests can be found on the github wiki: >> https://github.com/erlang/otp/wiki/Running-tests >> If you have additional questions do not hesitate to ask >> Thank you for the contribution! >> >> -- >> /Henrik Nord Erlang/OTP >> >> Refetched ! -- /Henrik Nord Erlang/OTP From henrik@REDACTED Fri May 6 11:22:48 2011 From: henrik@REDACTED (Henrik Nord) Date: Fri, 6 May 2011 11:22:48 +0200 Subject: [erlang-patches] Patch to fix compilation on OpenIndiana In-Reply-To: <27585996-CAF4-472A-9175-A865AD5D4A54@gmail.com> References: <25F118BB-CDA2-4A11-8613-240692C99D41@gmail.com> <4DA5A3FF.6090500@erlang.org> <31720CA3-B0FE-4109-A0B5-5CFD10854E89@gmail.com> <4DA5AD58.1010003@erlang.org> <961F813B-65BF-491F-9349-582A849804B6@gmail.com> <4DB988E0.8020200@erlang.org> <4ACEE2A8-03BB-4D09-A5D3-DF02DAF2F128@gmail.com> <4DC2C56B.9060801@erlang.org> <27585996-CAF4-472A-9175-A865AD5D4A54@gmail.com> Message-ID: <4DC3BDE8.6050401@erlang.org> Hi Trond! Here is a more detailed review of the patch On 05/06/2011 11:10 AM, Raimo Niskanen wrote: We want the functionality, but we have just deprecated (at least disrecommended) inet:getiflist/0 and inet:ifget/2. This functionality should go into inet:getifaddrs/0, but there it will be harder to fit it in. We might accept this patch (despite improving a deprecated interface) to keep as a coding example for later improving inet:getifaddrs/0 (but would of course prefer to get it right from the start) if the test inet_SUITE:getif/1, function do_getif/1 that checks if os:type/0 returns {unix,sunos} and if so does not check for a hardware address covers this operating system. The test has to be narrowed so it checks for hardware address when the patch is supposed to work. I guess os:version() can tell if this is openindiana... -- /Henrik Nord Erlang/OTP From henrik@REDACTED Fri May 6 17:43:24 2011 From: henrik@REDACTED (Henrik Nord) Date: Fri, 6 May 2011 17:43:24 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-05-06) Message-ID: <201105061543.p46FhMPC024272@smaug.otp.ericsson.se> Hello Patches! The next release of Erlang/OTP draws near and so does the patch code-stop for R14B03 Code-stop for the 'pu' branch is Wednesday 11th of May! Thank you for all your contributions this release Number of patches last 3 months: Mar: 39, Apr: 28, May: 7 And currently in 'Pu' Total of: 16 unique authors Total of: 20 number of patches ------------------------------------------------------------ [Graduated] * jf/run_erl-disable-flow-control (erts) (2011-05-02) 1 commit + Teach run_erl RUN_ERL_DISABLE_FLOWCNTRL for disabling flow control (1307af3) * kj/eunit-race-cond (eunit) (2011-04-17) 2 commits + Don't let eunit_surefire report back to eunit when stopping (bd38a12) + Wait until all eunit listeners terminate (0e7c557) * mh/inhibit-newline-inside-typespec (tools) (2011-04-14) 1 commit + Inhibit electric newline after "->" when inside a type spec (c0c600a) * ms/beam-fix-format-specifiers-in-erl_exit-msg (erts) (2011-04-06) 1 commit + Fix format specifiers in erl_exit messages (a8bacf3) * ta/inet_drv-cleanup (erts) (2011-05-02) 2 commits + inet_drv: remove unused tcp request id (1a0389b) + inet_drv: remove gratuitous assignment (92b693e) * ta/unicode-non-chars (stdlib) (2011-04-05) 1 commit + unicode: document 16#FFFE and 16#FFFF (non chars) (5043e8f) ------------------------------------------------------------ [New topics] * tm/xmerl_attr_charref_fix (xmerl) (2011-04-28) 1 commit - Prevent xmerl from over-normalizing character references in attributes (a011451) * tj/streaming_crypto_functions (crypto) (2011-05-02) 1 commit - Add true streaming AES (CTR) encryption and streaming HMAC operations (c24493f) ------------------------------------------------------------ [Stalled] * bw/efile_exists (erts) (2010-10-07) 1 commit - prim_file:exists/{1,2} which is lightweight file existence check (7203932) Action expected from: Topic author * fm/posix-fallocate (erts, kernel) (2011-04-15) 4 commits - Added missing surrounding if statement (5ec9fab) - Fixes to file:allocate/2 and respective tests (d0fb479) - Fix build on Solaris (9b8aecf) - Added file:allocate/2 (7554dbb) Action expected from: Topic author * jn/gen_stream (stdlib) (2011-04-15) 2 commits - Update gen_stream tests to conform with common_test standard (9f50d34) - Add gen_stream behaviour (3065e10) Action expected from: OTP-Team * lt/et-fix (et) (2011-03-30) 1 commit - Force contents window size to display correctly on Windows. (9836fb2) Action expected from: Topic author * sa/callback-attr (compiler, inets, kernel, otp, stdlib) (2010-06-08) 6 commits - Add callback specs into 'application' module in kernel (a180fb1) - Add callback specs to tftp module following internet documentation (d0e32d8) - Add callback specs to inets_service module following possibly deprecated comments (d90e984) - Add '-callback' attributes in stdlib's behaviours (acf3d67) - Update primary bootstrap (30c1e91) - Add '-callback' attribute to language syntax (6ee955e) Action expected from: OTP-Team * ta/typer-quote-atoms (hipe, typer) (2011-03-20) 1 commit - Quote atoms if necessary in types (254e21e) Action expected from: Hipe-team reviewer * uw/mnesia-majority (mnesia) (2011-01-30) 8 commits - Add documentation text about majority checking (f5b8427) - add mnesia_majority_test suite (9c2f765) - where_to_wlock optimization + change_table_majority/2 (a535b6c) - bug in mnesia_tm:needs_majority/2 (eb81e20) - optimize sticky_lock maj. check (5b304d4) - check majority for sticky locks (ae9e1fa) - Write locks now check majority when needed. (6f02d2e) - Add {majority, boolean()} per-table option. (c3241c0) Action expected from: OTP-Applications team * vb/shell (erts, kernel, stdlib) (2011-01-21) 6 commits - Add expandfmt_fun option for io:setopts (f139eab) - Correct JCL's help indentation (95672fa) - Handle JCL's "r" command error when no pool started (ba4b196) - Fix tab expansion in remote shell (e2077cb) - edlin_expand: fix matches formatting (838b84a) - Take into account arity len when calculating field's width (ff28c52) Action expected from: OTP-reviewer * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits . Implement namespace axis (27d791f) . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) . Fix processing-instruction(name?) (f05e78b) . Fix path filters (610df56) . Support more top-level primary expressions (770d6d9) . Accumulate comments in element nodes (e5b6b3a) . Add `default_attrs` option (18584c5) . Allow whole documents to be returned (aef3dea) . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) . Track parents in `#xmlPI` nodes (5095331) . Set `vsn` field in `#xmlDecl` record (d712331) . Fix namespace-conformance constraints (e062270) Action expected from: R15 rel ------------------------------------------------------------ [Cooking] * bd/mod_esi_timeout_fix (inets) (2011-03-17) 1 commit - Fix timeout message generated by mod_esi (eea0a7b) * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits - Avoid crash by skipping compilation_SUITE:on_load/1 (0d913e0) - Inline less aggressively for native-code compilation (0215ac6) - Crudely fix return type for the lists:key{search,find,member}/3 (4f48864) - seq_trace_SUITE: Don't native-compile (3799b17) - Disable native code if on_load is used (f35872c) - andor_SUITE: Don't native-compile (a8ab68c) This branch contains temporary workarounds to avoid failing test cases and is never intended to graduate. * bsmr/fix-makefile-in-for-xref-mod-app-escript (otp) (2010-12-10) 1 commit - Fix for Makefile.in invoking xref_mod_app.escript (10d4235) * ks/list_to_bitstring (hipe) (2011-05-01) 4 commits - Fix handling of <<_:N,_:_*M>> type expressions (9a256f1) - Fix the argument of erlang:list_to_bitstring/1 (1abe7a3) - Move function to its proper place (ba73458) - Remove unneeded function 'sequence/2' (b9903ed) * ks/snmp-specs (snmp) (2011-04-03) 1 commit - Add specs for functions that do not return (7354ffb) * pr/mnesia_frag_hash (mnesia) (2011-04-27) 2 commits - add mnesia_frag_hash test (1d6762d) - Reduce calls to phash in key_to_frag_number (67a20c0) * rj/fix-httpd-format (inets) (2011-03-17) 1 commit - Fix log messages formating in httpd (cbe8b2e) * sa/dialyzer-tests (dialyzer) (2011-03-21) 22 commits - Update dialyzer.spec (39e62c0) - Add race/ets_insert_public (afd9dd5) - Add opaque/ewgi,ewgi2 (5e76fd5) - Add opaque/schuett_bug (7a43c9f) - Add small/param_types_crash (b93b8ea) - Add small/file_open_encoding (eaead79) - Add small/false_false (1f1e045) - Add small/ets_update_counter (4db4b78) - Add small/bin_compr (120aa71) - Add small/tuple_set_crash (c69947d) - Add small/refine_failing (7afd920) - Add small/not_bogus_warning (500567d) ... * ss/fix-cover-fd-leak (tools) (2011-05-06) 2 commits - Add a check logic to prevent file descriptor leak (7c1b371) - Fix file descriptor leak (0568a0e) * ta/dragonfly-test_server-config (test_server) (2011-04-22) 1 commit - Add DragonflyBSD support to test_server (0a97fea) * ta/sendfile (erts, kernel) (2011-05-02) 2 commits - sendfile: use driver_select() (c420aef) - Implement file:sendfile (5518c44) * tn/inet_drv-fix (erts) (2011-04-08) 1 commit - Use libdlpi to get physical address (e360563) * dc/improved_find_redist (erts) (2011-03-18) 1 commit . support new SDKs in find_redist.sh and fallback to $ERL_TOP as last resort (f4f35aa) ------------------------------------------------------------ [Dropped] From max.lapshin@REDACTED Fri May 6 18:06:51 2011 From: max.lapshin@REDACTED (Max Lapshin) Date: Fri, 6 May 2011 20:06:51 +0400 Subject: [erlang-patches] What's cooking in erlang/otp (2011-05-06) In-Reply-To: <201105061543.p46FhMPC024272@smaug.otp.ericsson.se> References: <201105061543.p46FhMPC024272@smaug.otp.ericsson.se> Message-ID: > * sa/callback-attr (compiler, inets, kernel, otp, stdlib) (2010-06-08) 6 commits > ?- Add callback specs into 'application' module in kernel (a180fb1) > ?- Add callback specs to tftp module following internet documentation (d0e32d8) > ?- Add callback specs to inets_service module following possibly deprecated comments (d90e984) > ?- Add '-callback' attributes in stdlib's behaviours (acf3d67) > ?- Update primary bootstrap (30c1e91) > ?- Add '-callback' attribute to language syntax (6ee955e) > > Action expected from: OTP-Team > I've missed: what does it mean? From travis.jensen@REDACTED Tue May 10 16:51:14 2011 From: travis.jensen@REDACTED (Travis Jensen) Date: Tue, 10 May 2011 08:51:14 -0600 Subject: [erlang-patches] Fwd: True streaming of AES CTR In-Reply-To: References: <4DC2C762.4040004@erlang.org> <4DC3B17A.8060909@erlang.org> Message-ID: I haven't heard back from Henrik on this, so am resending to the list. tj ---------- Forwarded message ---------- From: Travis Jensen Date: Fri, May 6, 2011 at 12:58 PM Subject: Re: [erlang-patches] True streaming of AES CTR To: Henrik Nord I'm not sure what's happening here. The code is there, I promise. :) I just did the following, and everything checked out correctly: git clone https://github.com/erlang/otp.git . git fetch https://github.com/SoftwareMaven/otp.git streaming_crypto_functions git checkout pu git merge 487ed88cdff77e55273b4c62a60c0203f90bd7b0 That said, I made a new branch and re-committed the files to the new branch. It should be happily found at: git fetch https://github.com/SoftwareMaven/otp.git streaming_crypto_funcs The commit point on that one is 299a2ee97fa5ee82eaeeb150cc88c95110258ba9. I realize you are into the weekend now, but I'll make sure I'm on top of anything I can be over said weekend. I'll also plan on staying up late on my Sunday (your Monday morning) to cover anything at that point. Sorry for being such a...git. ;) tj On Fri, May 6, 2011 at 2:29 AM, Henrik Nord wrote: > On 05/06/2011 01:57 AM, Travis Jensen wrote: > > >> These tests have started to fail after this branch was included in 'pu' >> >> crypto_SUITE:hmac_update >> crypto_SUITE:rc4_stream_test >> crypto_SUITE:rc4_test >> crypto_SUITE:smp >> >> The deadline for R14B03 approaches so I will need fixes early next week if >> you want this to be included. >> Thanks! >> >> Ps >> Let me know if you require more info >> >> -- >> /Henrik Nord Erlang/OTP >> >> > Hi, Henrik, > > I've made an update to my branch that addresses the first 3 (problem as > the all() list not referencing the correct functions). > > git fetch git://github.com/SoftwareMaven/otp.git > streaming_crypto_functions > > The rc4_ failures were a result of emacs substituting special characters > behind my back; I did not modify any code there (I tell you so you know what > I'm changing and what you have to worry about those changes impacting), so > it is reverted to what existed previous to my commit. > > The smp test was failing because it references the rc4_ tests. I've added > my new tests to the smp test as well so they will be tested in multiple > processes. > > I'm having a heck of a time getting unit tests running. I am running them > manually using: > > lists:map(fun(T) -> > io:format("~p~n", [T]), > apply(crypto_SUITE, T, [[]]) > end, > crypto_SUITE:all()). > > so there is a chance I may be missing something, however, all of the > these did run and there were no errors. > > I will continue working on getting the unit tests running officially. If > there are other issues, this is my current #1 priority at work. :) > > Thanks. > > tj > -- > *Travis Jensen* > * > *Read the Software Maven @ http://softwaremaven.innerbrane.com/ > Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen > Read my Twitter mumblings @ http://twitter.com/SoftwareMaven > Send me email @ travis.jensen@REDACTED > > **What kind of guy calls himself the Software Maven???** > > Oo > I rechecked you branch, and it looks like you have made something strange > with it. > > * Add true streaming AES (CTR) encryption and streaming HMAC operations > Is now gone? > > and there are a strange "Merge git://github.com/erlang/otp into > streaming_crypto_functions" there instread, followed by the 2 commits to > scrypto_SUIT.erl > Resolve unittest failures for streaming encryption > Add streaming AES CTR and HMAC functions to smp test > > > -- > /Henrik Nord Erlang/OTP > > -- *Travis Jensen* *** *Read the Software Maven @ http://softwaremaven.innerbrane.com/ Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen Read my Twitter mumblings @ http://twitter.com/SoftwareMaven Send me email @ travis.jensen@REDACTED **What kind of guy calls himself the Software Maven???** -- *Travis Jensen* *** *Read the Software Maven @ http://softwaremaven.innerbrane.com/ Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen Read my Twitter mumblings @ http://twitter.com/SoftwareMaven Send me email @ travis.jensen@REDACTED **What kind of guy calls himself the Software Maven???** -------------- next part -------------- An HTML attachment was scrubbed... URL: From henrik@REDACTED Tue May 10 17:07:48 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 10 May 2011 17:07:48 +0200 Subject: [erlang-patches] Fwd: True streaming of AES CTR In-Reply-To: References: <4DC2C762.4040004@erlang.org> <4DC3B17A.8060909@erlang.org> Message-ID: <4DC954C4.7010904@erlang.org> On 05/10/2011 04:51 PM, Travis Jensen wrote: > I haven't heard back from Henrik on this, so am resending to the list. > > tj > > ---------- Forwarded message ---------- > From: *Travis Jensen* > > Date: Fri, May 6, 2011 at 12:58 PM > Subject: Re: [erlang-patches] True streaming of AES CTR > To: Henrik Nord > > > > I'm not sure what's happening here. The code is there, I promise. :) > I just did the following, and everything checked out correctly: > > git clone https://github.com/erlang/otp.git . > git fetch > https://github.com/SoftwareMaven/otp.git streaming_crypto_functions > git checkout pu > git merge 487ed88cdff77e55273b4c62a60c0203f90bd7b0 > > That said, I made a new branch and re-committed the files to the new > branch. It should be happily found at: > > git fetch https://github.com/SoftwareMaven/otp.git streaming_crypto_funcs > > The commit point on that one is 299a2ee97fa5ee82eaeeb150cc88c95110258ba9. > > I realize you are into the weekend now, but I'll make sure I'm on top > of anything I can be over said weekend. I'll also plan on staying up > late on my Sunday (your Monday morning) to cover anything at that point. > > Sorry for being such a...git. ;) > > tj > > On Fri, May 6, 2011 at 2:29 AM, Henrik Nord > wrote: > > On 05/06/2011 01:57 AM, Travis Jensen wrote: >> >> >> These tests have started to fail after this branch was >> included in 'pu' >> >> crypto_SUITE:hmac_update >> crypto_SUITE:rc4_stream_test >> crypto_SUITE:rc4_test >> crypto_SUITE:smp >> >> The deadline for R14B03 approaches so I will need fixes early >> next week if you want this to be included. >> Thanks! >> >> Ps >> Let me know if you require more info >> >> -- >> /Henrik Nord Erlang/OTP >> >> >> Hi, Henrik, >> >> I've made an update to my branch that addresses the first 3 >> (problem as the all() list not referencing the correct functions). >> >> git fetch git://github.com/SoftwareMaven/otp.git >> streaming_crypto_functions >> >> The rc4_ failures were a result of emacs substituting special >> characters behind my back; I did not modify any code there (I >> tell you so you know what I'm changing and what you have to worry >> about those changes impacting), so it is reverted to what existed >> previous to my commit. >> >> The smp test was failing because it references the rc4_ tests. >> I've added my new tests to the smp test as well so they will be >> tested in multiple processes. >> >> I'm having a heck of a time getting unit tests running. I am >> running them manually using: >> >> lists:map(fun(T) -> >> io:format("~p~n", [T]), >> apply(crypto_SUITE, T, [[]]) >> end, >> crypto_SUITE:all()). >> >> so there is a chance I may be missing something, however, all of >> the these did run and there were no errors. >> >> I will continue working on getting the unit tests running >> officially. If there are other issues, this is my current #1 >> priority at work. :) >> >> Thanks. >> >> tj >> -- >> *Travis Jensen* >> * >> *Read the Software Maven @ http://softwaremaven.innerbrane.com/ >> Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen >> Read my Twitter mumblings @ http://twitter.com/SoftwareMaven >> Send me email @ travis.jensen@REDACTED >> >> >> /*What kind of guy calls himself the Software Maven???*/ >> > Oo > I rechecked you branch, and it looks like you have made something > strange with it. > > * Add true streaming AES (CTR) encryption and streaming HMAC > operations > Is now gone? > > and there are a strange "Merge git://github.com/erlang/otp > into streaming_crypto_functions" > there instread, followed by the 2 commits to scrypto_SUIT.erl > Resolve unittest failures for streaming encryption > Add streaming AES CTR and HMAC functions to smp test > > > -- > /Henrik Nord Erlang/OTP > > > > > -- > *Travis Jensen* > * > *Read the Software Maven @ http://softwaremaven.innerbrane.com/ > Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen > Read my Twitter mumblings @ http://twitter.com/SoftwareMaven > Send me email @ travis.jensen@REDACTED > > /*What kind of guy calls himself the Software Maven???*/ > > > > > -- > *Travis Jensen* > * > *Read the Software Maven @ http://softwaremaven.innerbrane.com/ > Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen > Read my Twitter mumblings @ http://twitter.com/SoftwareMaven > Send me email @ travis.jensen@REDACTED > > /*What kind of guy calls himself the Software Maven???*/ > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi Strange, I thought i sent you a reply Anyways, I refetched the branch and it is currently cooking in 'pu'. Sofar it looks good, but its only one of the builds that have finished from yesterday, If it looks well in the morning I will get someone to take a closer look at it. Thank you for the contribution! -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From tuncer.ayaz@REDACTED Tue May 10 20:00:54 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Tue, 10 May 2011 20:00:54 +0200 Subject: [erlang-patches] erts: use a union to avoid strict aliasing issues Message-ID: git fetch git://github.com/tuncer/otp.git nif-strict-aliasing From tuncer.ayaz@REDACTED Wed May 11 16:45:28 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Wed, 11 May 2011 16:45:28 +0200 Subject: [erlang-patches] git ignore lib/xmerl/test/xmerl_test.erl Message-ID: git fetch git://github.com/tuncer/otp.git gitignore-xmerl_test From henrik@REDACTED Wed May 11 17:41:19 2011 From: henrik@REDACTED (Henrik Nord) Date: Wed, 11 May 2011 17:41:19 +0200 Subject: [erlang-patches] erts: use a union to avoid strict aliasing issues In-Reply-To: References: Message-ID: <4DCAAE1F.6030208@erlang.org> On 05/10/2011 08:00 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git nif-strict-aliasing > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi This is now cooking in 'pu' ill let you know -- /Henrik Nord Erlang/OTP From henrik@REDACTED Wed May 11 17:41:42 2011 From: henrik@REDACTED (Henrik Nord) Date: Wed, 11 May 2011 17:41:42 +0200 Subject: [erlang-patches] git ignore lib/xmerl/test/xmerl_test.erl In-Reply-To: References: Message-ID: <4DCAAE36.5080201@erlang.org> On 05/11/2011 04:45 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git gitignore-xmerl_test > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches also in 'pu' from now Thanks Tuncer -- /Henrik Nord Erlang/OTP From aronisstav@REDACTED Fri May 13 16:40:20 2011 From: aronisstav@REDACTED (Stavros Aronis) Date: Fri, 13 May 2011 17:40:20 +0300 Subject: [erlang-patches] Dialyzer non-terminating recursive functions warnings fix Message-ID: This patch fixes a small issue where non-terminating recursive functions (e.g. server loops) were internally characterized as "failing" by Dialyzer. This lead to some unnecessary warnings that have been eliminated. git fetch git://github.com/aronisstav/otp.git dialyzer-server-loop-fix From vances@REDACTED Sun May 15 03:49:22 2011 From: vances@REDACTED (Vance Shipley) Date: Sun, 15 May 2011 07:19:22 +0530 Subject: [erlang-patches] ASN.1 Long Definite Length Message-ID: <20110515014920.GN43920@aluminum-2.local> The asn1_erl_driver driver does not perform adequate bounds checking in the case where the length value of a TLV is a Long Definite Length. The following demonstrates the problem: Eshell V5.8.3 (abort with ^G) 1> asn1rt_ber_bin_v2:decode(<<252,255,255,255,255,255,255,255>>, driver). Segmentation fault The attached patch adds a test to determine if the calculated length has overflowed the size of the variable used to store it. With the patch applied: Eshell V5.8.3 (abort with ^G) 1> asn1rt_ber_bin_v2:decode(<<252,255,255,255,255,255,255,255>>, driver). ** exception exit: {error,{asn1,{"bad length field after byte:",5, <<"\374\377\377\377\377\377\377\377">>}}} in function asn1rt_ber_bin_v2:handle_error/2 I will submit a full patch with a test suite if you'd like me to. -- -Vance From vances@REDACTED Sun May 15 03:53:01 2011 From: vances@REDACTED (Vance Shipley) Date: Sun, 15 May 2011 07:23:01 +0530 Subject: [erlang-patches] ASN.1 Long Definite Length In-Reply-To: <20110515014920.GN43920@aluminum-2.local> References: <20110515014920.GN43920@aluminum-2.local> Message-ID: <20110515015259.GA25903@aluminum-2.local> ... attached now. On Sun, May 15, 2011 at 07:19:20AM +0530, Vance Shipley wrote: } The attached patch adds a test to determine if the calculated length } has overflowed the size of the variable used to store it. -- -Vance -------------- next part -------------- --- lib/asn1/c_src/asn1_erl_driver.c.orig 2011-05-14 13:15:25.000000000 +0530 +++ lib/asn1/c_src/asn1_erl_driver.c 2011-05-14 22:23:11.000000000 +0530 @@ -1300,6 +1300,8 @@ printf("decode_value1:ii=%d.\r\n",*ib_index); #endif len = (len << 8) + in_buf[*ib_index]; + if (len < 0) + return ASN1_LEN_ERROR; } if (len > (in_buf_len - (*ib_index + 1))) return ASN1_LEN_ERROR; From vances@REDACTED Mon May 16 05:59:33 2011 From: vances@REDACTED (Vance Shipley) Date: Mon, 16 May 2011 09:29:33 +0530 Subject: [erlang-patches] ASN.1 Long Definite Length In-Reply-To: <20110515014920.GN43920@aluminum-2.local> References: <20110515014920.GN43920@aluminum-2.local> Message-ID: <20110516035925.GA743@aluminum.local> While looking into this problem I believe I have spotted another small bug. The while loop will result in memory beyond the end of the input buffer being read. The attached patch to the existing file corrects this. On Sun, May 15, 2011 at 07:19:20AM +0530, Vance Shipley wrote: } The asn1_erl_driver driver does not perform adequate bounds } checking in the case where the length value of a TLV is a } Long Definite Length. -- -Vance -------------- next part -------------- --- lib/asn1/c_src/asn1_erl_driver.c +++ lib/asn1/c_src/asn1_erl_driver.c @@ -1294,7 +1294,7 @@ printf("decode_value,lenoflen:%d\r\n",lenoflen); #endif len = 0; - while (lenoflen-- && (*ib_index <= in_buf_len)) { + while (lenoflen-- && (*ib_index < in_buf_len)) { (*ib_index)++; #ifdef ASN1_DEBUG printf("decode_value1:ii=%d.\r\n",*ib_index); From henrik@REDACTED Mon May 16 09:35:25 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 16 May 2011 09:35:25 +0200 Subject: [erlang-patches] Dialyzer non-terminating recursive functions warnings fix In-Reply-To: References: Message-ID: <4DD0D3BD.3000109@erlang.org> On 05/13/2011 04:40 PM, Stavros Aronis wrote: > This patch fixes a small issue where non-terminating recursive > functions (e.g. server loops) were internally characterized as > "failing" by Dialyzer. This lead to some unnecessary warnings that > have been eliminated. > > git fetch git://github.com/aronisstav/otp.git dialyzer-server-loop-fix > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi Stavros Your branch is now cooking in 'pu' -- /Henrik Nord Erlang/OTP From henrik@REDACTED Mon May 16 17:13:49 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 16 May 2011 17:13:49 +0200 Subject: [erlang-patches] ASN.1 Long Definite Length In-Reply-To: <20110515014920.GN43920@aluminum-2.local> References: <20110515014920.GN43920@aluminum-2.local> Message-ID: <4DD13F2D.1040506@erlang.org> On 05/15/2011 03:49 AM, Vance Shipley wrote: > The asn1_erl_driver driver does not perform adequate bounds > checking in the case where the length value of a TLV is a > Long Definite Length. The following demonstrates the problem: > > Eshell V5.8.3 (abort with ^G) > 1> asn1rt_ber_bin_v2:decode(<<252,255,255,255,255,255,255,255>>, driver). > Segmentation fault > > The attached patch adds a test to determine if the calculated length > has overflowed the size of the variable used to store it. With the > patch applied: > > Eshell V5.8.3 (abort with ^G) > 1> asn1rt_ber_bin_v2:decode(<<252,255,255,255,255,255,255,255>>, driver). > ** exception exit: {error,{asn1,{"bad length field after byte:",5, > <<"\374\377\377\377\377\377\377\377">>}}} > in function asn1rt_ber_bin_v2:handle_error/2 > > I will submit a full patch with a test suite if you'd like me to. > Hello A full patch, with test suite and proper commit msg is preferred more info is found on https://github.com/erlang/otp/wiki I will include these mail-patches in 'pu' now, and let you know if something breaks. Thank you for the contribution! -- /Henrik Nord Erlang/OTP From fdmanana@REDACTED Tue May 17 12:01:14 2011 From: fdmanana@REDACTED (Filipe David Manana) Date: Tue, 17 May 2011 11:01:14 +0100 Subject: [erlang-patches] [PATCH] - improve zlib doc and type specs Message-ID: git fetch git://github.com/fdmanana/otp.git zlib_doc -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From fdmanana@REDACTED Tue May 17 12:53:36 2011 From: fdmanana@REDACTED (Filipe David Manana) Date: Tue, 17 May 2011 11:53:36 +0100 Subject: [erlang-patches] [PATCH] add a erlang:external_size/2 BIF Message-ID: git fetch git://github.com/fdmanana/otp.git external_size_2 Btw, why isn't the existing BIF erlang:external_size/1 documented anywhere? I see it used in some OTP modules like dets.erl for e.g. I find this a very useful function, as it's certainly more efficient then doing a "byte_size(term_to_binary(Term))" call. -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From henrik@REDACTED Tue May 17 15:44:36 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 17 May 2011 15:44:36 +0200 Subject: [erlang-patches] [PATCH] add a erlang:external_size/2 BIF In-Reply-To: References: Message-ID: <4DD27BC4.5090003@erlang.org> On 05/17/2011 12:53 PM, Filipe David Manana wrote: > git fetch git://github.com/fdmanana/otp.git external_size_2 > > Btw, why isn't the existing BIF erlang:external_size/1 documented anywhere? > I see it used in some OTP modules like dets.erl for e.g. I find this a > very useful function, as it's certainly more efficient then doing a > "byte_size(term_to_binary(Term))" call. I will include this in 'pu' and the other branch you sent when I have rebuilt the preloaded and bootstrap files. regarding missing documentation, its one of these 3 cases 1. it is not supposed to be used by other ppl. 2. it is not supported on all supported platforms. 3. someone has been lazy and or forgot to add documentation. In case 3, feel free to add documentation, and if case 1 and 2 does not apply, we will accept the patch with the documentation fix. If case 1 or 2 apply we will reject your patch. I do not know the specific case for this function, but I will try to find out. -- /Henrik Nord Erlang/OTP From henrik@REDACTED Wed May 18 11:56:50 2011 From: henrik@REDACTED (Henrik Nord) Date: Wed, 18 May 2011 11:56:50 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-05-17) Message-ID: <201105180956.p4I9ummk002378@smaug.otp.ericsson.se> ------------------------------------------------------------ [Graduated] * bd/mod_esi_binary (inets) (2011-02-23) 1 commit + Modify mod_esi:deliver/2 to accept binary data (73f261d) * bd/mod_esi_timeout_fix (inets) (2011-03-17) 1 commit + Fix timeout message generated by mod_esi (eea0a7b) * bsmr/fix-makefile-in-for-xref-mod-app-escript () (2010-12-10) 0 commits * dc/improved_find_redist (erts) (2011-03-18) 1 commit + support new SDKs in find_redist.sh and fallback to $ERL_TOP as last resort (b76ad06) * fm/httpc-upload-body-streaming () (2011-03-04) 0 commits * gs/mod_security-property-docs () (2011-03-14) 0 commits * ks/list_to_bitstring (hipe) (2011-05-01) 4 commits + Fix handling of <<_:N,_:_*M>> type expressions (9a256f1) + Fix the argument of erlang:list_to_bitstring/1 (1abe7a3) + Move function to its proper place (ba73458) + Remove unneeded function 'sequence/2' (b9903ed) * ks/snmp-specs (snmp) (2011-04-03) 1 commit + Add specs for functions that do not return (7354ffb) * lt/et-fix (et) (2011-04-26) 1 commit + Windows fixes, content_viewer window size was wrong and removed focus stealing (d3d2a66) * ms/inets-prevent_xss_in_error_pages/bmkmerge (inets) (2011-02-21) 1 commit + inets: prevent XSS in error pages (4827d5d) * rj/fix-httpd-format (inets) (2011-03-17) 1 commit + Fix log messages formating in httpd (cbe8b2e) * sa/dialyzer-tests (dialyzer) (2011-03-21) 22 commits + Update dialyzer.spec (39e62c0) + Add race/ets_insert_public (afd9dd5) + Add opaque/ewgi,ewgi2 (5e76fd5) + Add opaque/schuett_bug (7a43c9f) + Add small/param_types_crash (b93b8ea) + Add small/file_open_encoding (eaead79) + Add small/false_false (1f1e045) + Add small/ets_update_counter (4db4b78) + Add small/bin_compr (120aa71) + Add small/tuple_set_crash (c69947d) + Add small/refine_failing (7afd920) + Add small/not_bogus_warning (500567d) ... * ss/fix-cover-fd-leak (tools) (2011-05-06) 2 commits + Add a check logic to prevent file descriptor leak (7c1b371) + Fix file descriptor leak (0568a0e) * ta/gitignore-xmerl_test (otp) (2011-05-11) 1 commit + git ignore lib/xmerl/test/xmerl_test.erl (3c0fb92) * ta/re-doc (stdlib) (2011-05-16) 1 commit + re: remove gratuitous "it " in manpage (657cf4b) * tm/xmerl_attr_charref_fix (xmerl) (2011-04-28) 1 commit + Prevent xmerl from over-normalizing character references in attributes (a011451) * uw/mnesia-majority (mnesia) (2011-05-13) 9 commits + dialyzer warning on mnesia_tm (8d7963d) + Add documentation text about majority checking (497f4b2) + add mnesia_majority_test suite (4eacd6d) + where_to_wlock optimization + change_table_majority/2 (5423559) + bug in mnesia_tm:needs_majority/2 (ca1412a) + optimize sticky_lock maj. check (b10094b) + check majority for sticky locks (5309d52) + Write locks now check majority when needed. (38eef7a) + Add {majority, boolean()} per-table option. (6d446fc) ------------------------------------------------------------ [New topics] * fm/external_size_2 (erts, hipe) (2011-05-16) 1 commit - Added erlang:external_size/2 BIF (7eb8098) * sa/dialyzer-server-loop-fix (dialyzer) (2011-05-03) 1 commit - Fix server loop detection (3a7af1c) * ta/nif-strict-aliasing (erts) (2011-05-10) 2 commits - erts: use a union to avoid strict aliasing issues (751a5c3) - erts: adapt matrix_nif to R14 erl_nif API changes (d965eb8) * ta/nif-variadic-funs (erts) (2011-05-13) 1 commit - erts: convert variadic nif funs into inline funs (19a9f1c) * vs/asn1_long-definite-lenght (asn1) (2011-05-16) 2 commits - fix while loop reading beyond input buffers memory (c07026e) - add size check to determine if the calculated length has overflowed the size of the variable used to store it (6ac219a) ------------------------------------------------------------ [Stalled] * bw/efile_exists (erts) (2010-10-07) 1 commit - prim_file:exists/{1,2} which is lightweight file existence check (7203932) Action expected from: Topic author * fm/posix-fallocate (erts, kernel) (2011-04-15) 4 commits - Added missing surrounding if statement (5ec9fab) - Fixes to file:allocate/2 and respective tests (d0fb479) - Fix build on Solaris (9b8aecf) - Added file:allocate/2 (7554dbb) Action expected from: Topic author * jn/gen_stream (stdlib) (2011-04-15) 2 commits - Update gen_stream tests to conform with common_test standard (9f50d34) - Add gen_stream behaviour (3065e10) Action expected from: OTP-Team * sa/callback-attr (compiler, inets, kernel, otp, stdlib) (2010-06-08) 8 commits - Add callback specs into 'application' module in kernel (c8dfabf) - Add callback specs to tftp module following internet documentation (3f633a0) - Add callback specs to inets_service module following possibly deprecated comments (4fc26b6) - Add '-callback' attributes in stdlib's behaviours (688f3a4) - Update primary bootstrap (be87065) - Update the documentation with information on the callback attribute (ad7eb2c) - Automatically generate 'behaviour_info' function from '-callback' attributes (67fc274) - Add '-callback' attribute to language syntax (b0ecd29) Action expected from: OTP-Team * ta/typer-quote-atoms (hipe, typer) (2011-03-20) 1 commit - Quote atoms if necessary in types (254e21e) Action expected from: Hipe-team reviewer * vb/shell (erts, kernel, stdlib) (2011-01-21) 6 commits - Add expandfmt_fun option for io:setopts (f139eab) - Correct JCL's help indentation (95672fa) - Handle JCL's "r" command error when no pool started (ba4b196) - Fix tab expansion in remote shell (e2077cb) - edlin_expand: fix matches formatting (838b84a) - Take into account arity len when calculating field's width (ff28c52) Action expected from: Topic author * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits . Implement namespace axis (27d791f) . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) . Fix processing-instruction(name?) (f05e78b) . Fix path filters (610df56) . Support more top-level primary expressions (770d6d9) . Accumulate comments in element nodes (e5b6b3a) . Add `default_attrs` option (18584c5) . Allow whole documents to be returned (aef3dea) . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) . Track parents in `#xmlPI` nodes (5095331) . Set `vsn` field in `#xmlDecl` record (d712331) . Fix namespace-conformance constraints (e062270) Action expected from: R15 rel * pd/ttb_upgrade (observer) (2011-04-05) 30 commits . additional tests for ttb module (ee2dabc) . new tests for ttb module (6f8ec53) . updated documentation (d39fa78) . updated OTP tests (dc1af0f) . (BUGFIX) Error with ip tracing to wrap sets (5082fc8) . Add onviso_server and cli as an exemplary ttb usage (d5a68df) . Include logfile name in fetch directory name (45f3302) . missing files addes (3e759dd) . dbg-type tracing (ece6a3b) . Optional handler specification allowed in stop/1 - Allowed optional handler specification in trace/2 (97be5ad) . Flush file trace port buffers with given frequency (9d4b083) . Autoresume tracing (7101720) ... Action expected from: Topic author ------------------------------------------------------------ [Cooking] * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits - Avoid crash by skipping compilation_SUITE:on_load/1 (0d913e0) - Inline less aggressively for native-code compilation (0215ac6) - Crudely fix return type for the lists:key{search,find,member}/3 (4f48864) - seq_trace_SUITE: Don't native-compile (3799b17) - Disable native code if on_load is used (f35872c) - andor_SUITE: Don't native-compile (a8ab68c) This branch contains temporary workarounds to avoid failing test cases and is never intended to graduate. * pr/mnesia_frag_hash (mnesia) (2011-04-27) 2 commits - add mnesia_frag_hash test (1d6762d) - Reduce calls to phash in key_to_frag_number (67a20c0) * ta/dragonfly-test_server-config (test_server) (2011-04-22) 1 commit - Add DragonflyBSD support to test_server (0a97fea) * ta/sendfile (erts, kernel) (2011-01-13) 1 commit - Implement file:sendfile (cc93068) * tj/streaming_crypto_functions (crypto) (2011-05-06) 1 commit - Add true streaming AES (CTR) encryption and streaming HMAC operations (46c20ea) * tn/inet_drv-fix (erts) (2011-04-08) 1 commit - Use libdlpi to get physical address (e360563) ------------------------------------------------------------ [Dropped] From kenneth.lundin@REDACTED Wed May 18 18:33:27 2011 From: kenneth.lundin@REDACTED (Kenneth Lundin) Date: Wed, 18 May 2011 18:33:27 +0200 Subject: [erlang-patches] ASN.1 Long Definite Length In-Reply-To: <4DD13F2D.1040506@erlang.org> References: <20110515014920.GN43920@aluminum-2.local> <4DD13F2D.1040506@erlang.org> Message-ID: Hi Vance, Thanks for finding the bugs (which I think only have impact if the indata in incorrect) But of course it is not good if incorrect input can cause a crash of the Erlang VM. I will correct it in a slightly different way. /Regards Kenneth On Mon, May 16, 2011 at 5:13 PM, Henrik Nord wrote: > On 05/15/2011 03:49 AM, Vance Shipley wrote: >> >> The asn1_erl_driver driver does not perform adequate bounds >> checking in the case where the length value of a TLV is a >> Long Definite Length. ?The following demonstrates the problem: >> >> ? ? ?Eshell V5.8.3 ?(abort with ^G) >> ? ? ?1> ?asn1rt_ber_bin_v2:decode(<<252,255,255,255,255,255,255,255>>, >> driver). >> ? ? ?Segmentation fault >> >> The attached patch adds a test to determine if the calculated length >> has overflowed the size of the variable used to store it. ?With the >> patch applied: >> >> ? ? ?Eshell V5.8.3 ?(abort with ^G) >> ? ? ?1> ?asn1rt_ber_bin_v2:decode(<<252,255,255,255,255,255,255,255>>, >> driver). >> ? ? ?** exception exit: {error,{asn1,{"bad length field after byte:",5, >> >> <<"\374\377\377\377\377\377\377\377">>}}} >> ? ? ? ? ? in function ?asn1rt_ber_bin_v2:handle_error/2 >> >> I will submit a full patch with a test suite if you'd like me to. >> > Hello > A full patch, with test suite and proper commit msg is preferred > more info is found on https://github.com/erlang/otp/wiki > > > I will include these mail-patches in 'pu' now, and let you know if something > breaks. > > Thank you for the contribution! > > -- > /Henrik Nord Erlang/OTP > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > From pguyot@REDACTED Sat May 21 09:12:06 2011 From: pguyot@REDACTED (Paul Guyot) Date: Sat, 21 May 2011 09:12:06 +0200 Subject: [erlang-patches] Patch for hibernate/HiPE bug Message-ID: <9729102E-188E-4C80-B574-E1675ED8810C@kallisys.net> Hello, This commit : https://github.com/erlang/otp/commit/b7ecdcd1ae9e11b8f75e11b82d94da32837932bc introduced a new flag (F_HIBERNATE_SCHED) that is set when hibernating and cleared when hibernated process is scheduled out. However, this flag was not cleared when the hibernated process is scheduled out in hipe_mode_switch. As a result, a process that would hibernate, wake up and then trap by a BIF would be stuck. The following commit fixes this bug and includes a non-regression test. https://github.com/pguyot/otp/commit/614c92088cb947a8849ab4681458b233d2151f40 git fetch git://github.com/pguyot/otp.git fix-hibernate-scheduling-with-hipe Regards, Paul -- Semiocast http://semiocast.com/ +33.183627948 - 20 rue Lacaze, 75014 Paris From kostis@REDACTED Sat May 21 09:25:26 2011 From: kostis@REDACTED (Kostis Sagonas) Date: Sat, 21 May 2011 10:25:26 +0300 Subject: [erlang-patches] Patch for hibernate/HiPE bug In-Reply-To: <9729102E-188E-4C80-B574-E1675ED8810C@kallisys.net> References: <9729102E-188E-4C80-B574-E1675ED8810C@kallisys.net> Message-ID: <4DD768E6.1050003@cs.ntua.gr> Paul Guyot wrote: > Hello, > > This commit : > https://github.com/erlang/otp/commit/b7ecdcd1ae9e11b8f75e11b82d94da32837932bc > introduced a new flag (F_HIBERNATE_SCHED) that is set when hibernating and cleared when hibernated process is scheduled out. > However, this flag was not cleared when the hibernated process is scheduled out in hipe_mode_switch. As a result, a process that would hibernate, wake up and then trap by a BIF would be stuck. > > The following commit fixes this bug and includes a non-regression test. > https://github.com/pguyot/otp/commit/614c92088cb947a8849ab4681458b233d2151f40 > git fetch git://github.com/pguyot/otp.git fix-hibernate-scheduling-with-hipe Merci Paul, I hope it's not too late to include this in the upcoming R14B03. It would be nice to do so. Kostis From pguyot@REDACTED Sat May 21 10:19:50 2011 From: pguyot@REDACTED (Paul Guyot) Date: Sat, 21 May 2011 10:19:50 +0200 Subject: [erlang-patches] Fix bug in FreeBSD topology detection code Message-ID: <2440BB77-F821-47D9-97FE-F698AE561A82@kallisys.net> Hello, There is a bug in the FreeBSD topology detection code. The parser wouldn't consider the proper cache level and as a result, Intel Bi Xeons would appear has having 2n cores instead of 2 CPUs with n cores each. The fix is available here: https://github.com/pguyot/otp/commit/a13caa7beeec4c54f3879da694231b81b3a7a36d git fetch git://github.com/pguyot/otp.git fix-freebsd-dualcore-detection Regards, Paul -- Semiocast http://semiocast.com/ +33.183627948 - 20 rue Lacaze, 75014 Paris From tuncer.ayaz@REDACTED Sat May 21 16:22:27 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sat, 21 May 2011 16:22:27 +0200 Subject: [erlang-patches] Fix error in erlang-indent-find-preceding-exp Message-ID: git fetch git://github.com/tuncer/otp.git erlang-indent-find-preceding-exp From henrik@REDACTED Mon May 23 12:13:06 2011 From: henrik@REDACTED (Henrik Nord) Date: Mon, 23 May 2011 12:13:06 +0200 Subject: [erlang-patches] Patch for hibernate/HiPE bug In-Reply-To: <4DD768E6.1050003@cs.ntua.gr> References: <9729102E-188E-4C80-B574-E1675ED8810C@kallisys.net> <4DD768E6.1050003@cs.ntua.gr> Message-ID: <4DDA3332.10606@erlang.org> On 05/21/2011 09:25 AM, Kostis Sagonas wrote: > Paul Guyot wrote: >> Hello, >> >> This commit : >> https://github.com/erlang/otp/commit/b7ecdcd1ae9e11b8f75e11b82d94da32837932bc >> >> introduced a new flag (F_HIBERNATE_SCHED) that is set when >> hibernating and cleared when hibernated process is scheduled out. >> However, this flag was not cleared when the hibernated process is >> scheduled out in hipe_mode_switch. As a result, a process that would >> hibernate, wake up and then trap by a BIF would be stuck. >> >> The following commit fixes this bug and includes a non-regression test. >> https://github.com/pguyot/otp/commit/614c92088cb947a8849ab4681458b233d2151f40 >> >> git fetch git://github.com/pguyot/otp.git >> fix-hibernate-scheduling-with-hipe > > Merci Paul, > > I hope it's not too late to include this in the upcoming R14B03. > It would be nice to do so. > > Kostis > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi This is now cooking in 'pu' but it will not make it to the R14B03 release. I will try to get it through the testing and into 'dev' as soon as possible after the release. -- /Henrik Nord Erlang/OTP From tuncer.ayaz@REDACTED Mon May 23 12:45:12 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Mon, 23 May 2011 12:45:12 +0200 Subject: [erlang-patches] Fix error in erlang-indent-find-preceding-exp In-Reply-To: References: Message-ID: On Sat, May 21, 2011 at 4:22 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git erlang-indent-find-preceding-exp Patch not needed as the error was caused by something else. From rzezeski@REDACTED Mon May 23 17:00:45 2011 From: rzezeski@REDACTED (Ryan Zezeski) Date: Mon, 23 May 2011 11:00:45 -0400 Subject: [erlang-patches] Add a proplist() type Message-ID: I found it odd the there is no canonical proplist() type defined so this is my attempt at adding one. git fetch git://github.com/rzezeski/otp.git add_proplist_type -Ryan -------------- next part -------------- An HTML attachment was scrubbed... URL: From kostis@REDACTED Mon May 23 17:11:44 2011 From: kostis@REDACTED (Kostis Sagonas) Date: Mon, 23 May 2011 18:11:44 +0300 Subject: [erlang-patches] Add a proplist() type In-Reply-To: References: Message-ID: <4DDA7930.9010306@cs.ntua.gr> Ryan Zezeski wrote: > I found it odd the there is no canonical proplist() type defined so this > is my attempt at adding one. > > git fetch git://github.com/rzezeski/otp.git > add_proplist_type Ryan, Your attempt is not OK. For it to be, the proplist() type should be exported from the proplists module; i.e. added in the export_type declaration of that module. So, if your patch is to be accepted and included in OTP, minimally this needs to be fixed. I thought that since property() is an exported type from the proplists module, there is no need to define proplist() since its definition would be simple. But I think I was wrong: Your patch definitely shows that the current situation with various different "definitions" of proplist() is not optimal... Thanks for noticing this. Kostis From rzezeski@REDACTED Mon May 23 17:33:30 2011 From: rzezeski@REDACTED (Ryan Zezeski) Date: Mon, 23 May 2011 11:33:30 -0400 Subject: [erlang-patches] Add a proplist() type In-Reply-To: <4DDA7930.9010306@cs.ntua.gr> References: <4DDA7930.9010306@cs.ntua.gr> Message-ID: Kostis, Crap, I missed the export_type. Interesting I was able to run Dialyzer on stdlib with no problems (related to this change). Anyways, I'll fix this and resubmit. -Ryan On Mon, May 23, 2011 at 11:11 AM, Kostis Sagonas wrote: > Ryan Zezeski wrote: > >> I found it odd the there is no canonical proplist() type defined so this >> is my attempt at adding one. >> >> git fetch git://github.com/rzezeski/otp.git < >> http://github.com/rzezeski/otp.git> add_proplist_type >> > > Ryan, > > Your attempt is not OK. > > For it to be, the proplist() type should be exported from the proplists > module; i.e. added in the export_type declaration of that module. So, if > your patch is to be accepted and included in OTP, minimally this needs to be > fixed. > > I thought that since property() is an exported type from the proplists > module, there is no need to define proplist() since its definition would be > simple. But I think I was wrong: Your patch definitely shows that the > current situation with various different "definitions" of proplist() is not > optimal... > > Thanks for noticing this. > > Kostis > -------------- next part -------------- An HTML attachment was scrubbed... URL: From carlsson.richard@REDACTED Mon May 23 17:36:53 2011 From: carlsson.richard@REDACTED (Richard Carlsson) Date: Mon, 23 May 2011 17:36:53 +0200 Subject: [erlang-patches] Add a proplist() type In-Reply-To: References: Message-ID: <4DDA7F15.5090607@gmail.com> On 2011-05-23 17:00, Ryan Zezeski wrote: > I found it odd the there is no canonical proplist() type defined so this > is my attempt at adding one. > > git fetch git://github.com/rzezeski/otp.git > add_proplist_type Good idea. It fixes a few overspecified local definitions which state that a proplist has the type [{atom(),term()}] while the proplists module define it to be [property()] where property() = atom() | tuple(). (If some of those local definitions really mean that only {atom(), term()} are allowed, and they don't actually use the proplists module, they should preferably change the name of their local type instead.) A couple of examples should make it clear: to the proplists module, all of these elements are valid properties: foo % interpreted as equal to {foo, true} {bar, 42} {<<"baz">>, 1234} % the key can be any term, not just an atom {foo, 1, 2, 3} % the tuple may have more than two elements {foo} % even a tuple with only a key is allowed In fact, the functions in the proplists module generally allow other terms to be present in the list, so they actually accept [any()] as input, but elements that are not of the property() type are ignored. Specifying that they require [property()] instead might concievably make some existing code be considered as broken by Dialyzer, but it could be worth it in order to get better checking in normal cases. I'll leave this decision to Kostis and the OTP team. /Richard From rzezeski@REDACTED Mon May 23 21:37:46 2011 From: rzezeski@REDACTED (Ryan Zezeski) Date: Mon, 23 May 2011 15:37:46 -0400 Subject: [erlang-patches] Add a proplist() type In-Reply-To: <4DDA7F15.5090607@gmail.com> References: <4DDA7F15.5090607@gmail.com> Message-ID: I went ahead and amended my commit and forced the push. So if you refetch it should include the export declaration now. Richard, I think specifying it as [property()] makes more sense because [any()] is just a list, and at that point why are you using a proplist? Said another way, if the type was [any()] then I don't really see much of a benefit of typing it at all. -Ryan On Mon, May 23, 2011 at 11:36 AM, Richard Carlsson < carlsson.richard@REDACTED> wrote: > On 2011-05-23 17:00, Ryan Zezeski wrote: > >> I found it odd the there is no canonical proplist() type defined so this >> is my attempt at adding one. >> >> git fetch git://github.com/rzezeski/otp.git >> add_proplist_type >> > > Good idea. It fixes a few overspecified local definitions which state that > a proplist has the type [{atom(),term()}] while the proplists module define > it to be [property()] where property() = atom() | tuple(). > > (If some of those local definitions really mean that only {atom(), term()} > are allowed, and they don't actually use the proplists module, they should > preferably change the name of their local type instead.) > > A couple of examples should make it clear: to the proplists module, all of > these elements are valid properties: > > foo % interpreted as equal to {foo, true} > {bar, 42} > {<<"baz">>, 1234} % the key can be any term, not just an atom > {foo, 1, 2, 3} % the tuple may have more than two elements > {foo} % even a tuple with only a key is allowed > > In fact, the functions in the proplists module generally allow other terms > to be present in the list, so they actually accept [any()] as input, but > elements that are not of the property() type are ignored. > Specifying that they require [property()] instead might concievably make > some existing code be considered as broken by Dialyzer, but it could be > worth it in order to get better checking in normal cases. I'll leave this > decision to Kostis and the OTP team. > > /Richard > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > -------------- next part -------------- An HTML attachment was scrubbed... URL: From henrik@REDACTED Tue May 24 09:17:20 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 24 May 2011 09:17:20 +0200 Subject: [erlang-patches] Add a proplist() type In-Reply-To: References: <4DDA7F15.5090607@gmail.com> Message-ID: <4DDB5B80.5060901@erlang.org> On 05/23/2011 09:37 PM, Ryan Zezeski wrote: > I went ahead and amended my commit and forced the push. So if you > refetch it should include the export declaration now. > > Richard, I think specifying it as [property()] makes more sense > because [any()] is just a list, and at that point why are you using a > proplist? Said another way, if the type was [any()] then I don't > really see much of a benefit of typing it at all. > > -Ryan > > On Mon, May 23, 2011 at 11:36 AM, Richard Carlsson > > wrote: > > On 2011-05-23 17:00, Ryan Zezeski wrote: > > I found it odd the there is no canonical proplist() type > defined so this > is my attempt at adding one. > > git fetch git://github.com/rzezeski/otp.git > > add_proplist_type > > > Good idea. It fixes a few overspecified local definitions which > state that a proplist has the type [{atom(),term()}] while the > proplists module define it to be [property()] where property() = > atom() | tuple(). > > (If some of those local definitions really mean that only {atom(), > term()} are allowed, and they don't actually use the proplists > module, they should preferably change the name of their local type > instead.) > > A couple of examples should make it clear: to the proplists > module, all of these elements are valid properties: > > foo % interpreted as equal to {foo, true} > {bar, 42} > {<<"baz">>, 1234} % the key can be any term, not just an atom > {foo, 1, 2, 3} % the tuple may have more than two elements > {foo} % even a tuple with only a key is allowed > > In fact, the functions in the proplists module generally allow > other terms to be present in the list, so they actually accept > [any()] as input, but elements that are not of the property() type > are ignored. > Specifying that they require [property()] instead might > concievably make some existing code be considered as broken by > Dialyzer, but it could be worth it in order to get better checking > in normal cases. I'll leave this decision to Kostis and the OTP team. > > /Richard > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Hi I have now fetched your patch, and will cook it in 'pu' for a while, Thank you for the contribution! -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From carlsson.richard@REDACTED Tue May 24 10:38:30 2011 From: carlsson.richard@REDACTED (Richard Carlsson) Date: Tue, 24 May 2011 10:38:30 +0200 Subject: [erlang-patches] Add a proplist() type In-Reply-To: References: <4DDA7F15.5090607@gmail.com> Message-ID: <4DDB6E86.10401@gmail.com> On 05/23/2011 09:37 PM, Ryan Zezeski wrote: > Richard, I think specifying it as [property()] makes more sense because > [any()] is just a list, and at that point why are you using a proplist? The main use of the proplists module is to allow humans to specify a list of options to a function, in a readable way. The idea, when I wrote it, was that if a program wants to allow other things in its option list - for example, a naked integer might make sense in some cases - it should still be able to use the proplists module for most of its normal options, so the proplists functions should not crash on unexpected elements. As long as this is allowed, Dialyzer should not complain about arbitrary lists as input. On the other hand, if you constrain the input type to [property()], it's fairly simple to work around the Dialyzer warning by doing an initial pass over the list and convert the naked values to valid properties, e.g., mapping integers to {some_tag, N}, before you pass the list to the proplists module. > Said another way, if the type was [any()] then I don't really see much > of a benefit of typing it at all. Knowing that it must be a (proper) list is obviously better than not knowing anything at all. /Richard From michael.santos@REDACTED Tue May 24 14:02:25 2011 From: michael.santos@REDACTED (Michael Santos) Date: Tue, 24 May 2011 08:02:25 -0400 Subject: [erlang-patches] [PATCH] inet: error if fd does not match socket domain Message-ID: <20110524120225.GA2945@ecn.lan> If an IPv4 fd is opened as an IPv6 socket, unexpected behaviour can occur. For example, if an IPv4 UDP socket is opened and passed into Erlang as an IPv6 socket, the first 3 bytes (corresponding to 1 byte representing the protocol family, 2 bytes set to the port) are stripped from the payload. The cause of the UDP payload truncation happens in inet_drv.c:packet_inet_input when a call to inet_get_address fails silently because the family is set to PF_INET6 but the buffer len is the size of an IPv4 struct sockaddr_in. Prevent this behaviour by checking that the protocol family of the file descriptor matches the family of the requested Erlang socket. {ok, S1} = gen_udp:open(0, [binary, inet]), {ok, FD} = inet:getfd(S1), {ok, Port} = inet:port(S1), {ok, S} = gen_udp:open(Port, [binary, {fd, FD}, inet6]), {ok, C} = gen_udp:open(0, [binary]), Msg = <<1,2,3,4,5>>, gen_udp:send(C, "127.0.0.1", Port, Msg), receive {udp, S, _, _, Msg} -> ok; {udp, S, _, _, NewMsg} -> {error, Msg, NewMsg} end. This test results in: {error,<<1,2,3,4,5>>,<<4,5>>} Thanks to Andrew Tunnell-Jones for finding the bug and the test case! --- erts/emulator/drivers/common/inet_drv.c | 4 +++- lib/kernel/test/gen_udp_SUITE.erl | 1 + 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/erts/emulator/drivers/common/inet_drv.c b/erts/emulator/drivers/common/inet_drv.c index 40c4a0d..ebc4469 100644 --- a/erts/emulator/drivers/common/inet_drv.c +++ b/erts/emulator/drivers/common/inet_drv.c @@ -3709,6 +3709,8 @@ static int inet_ctl_fdopen(inet_descriptor* desc, int domain, int type, /* check that it is a socket and that the socket is bound */ if (IS_SOCKET_ERROR(sock_name(s, (struct sockaddr*) &name, &sz))) return ctl_error(sock_errno(), rbuf, rsize); + if (name.sa.sa_family != domain) + return ctl_error(EINVAL, rbuf, rsize); desc->s = s; if ((desc->event = sock_create_event(desc)) == INVALID_EVENT) return ctl_error(sock_errno(), rbuf, rsize); @@ -9739,7 +9741,7 @@ static int packet_inet_ctl(ErlDrvData e, unsigned int cmd, char* buf, int len, if (desc->active || (len != 8)) return ctl_error(EINVAL, rbuf, rsize); timeout = get_int32(buf); - /* The 2nd arg, Length(4), is ignored for both UDP ans SCTP protocols, + /* The 2nd arg, Length(4), is ignored for both UDP and SCTP protocols, since they are msg-oriented. */ if (enq_async(desc, tbuf, PACKET_REQ_RECV) < 0) diff --git a/lib/kernel/test/gen_udp_SUITE.erl b/lib/kernel/test/gen_udp_SUITE.erl index d8a5519..b734d7f 100644 --- a/lib/kernel/test/gen_udp_SUITE.erl +++ b/lib/kernel/test/gen_udp_SUITE.erl @@ -400,6 +400,7 @@ open_fd(Config) when is_list(Config) -> {ok,S1} = gen_udp:open(0), {ok,P2} = inet:port(S1), {ok,FD} = prim_inet:getfd(S1), + {error,einval} = gen_udp:open(P2, [inet6, {fd,FD}]), {ok,S2} = gen_udp:open(P2, [{fd,FD}]), {ok,S3} = gen_udp:open(0), {ok,P3} = inet:port(S3), -- 1.7.0.4 From henrik@REDACTED Tue May 24 14:20:36 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 24 May 2011 14:20:36 +0200 Subject: [erlang-patches] [PATCH] inet: error if fd does not match socket domain In-Reply-To: <20110524120225.GA2945@ecn.lan> References: <20110524120225.GA2945@ecn.lan> Message-ID: <4DDBA294.3000101@erlang.org> On 05/24/2011 02:02 PM, Michael Santos wrote: > If an IPv4 fd is opened as an IPv6 socket, unexpected behaviour can > occur. For example, if an IPv4 UDP socket is opened and passed into > Erlang as an IPv6 socket, the first 3 bytes (corresponding to 1 byte > representing the protocol family, 2 bytes set to the port) are stripped > from the payload. The cause of the UDP payload truncation happens in > inet_drv.c:packet_inet_input when a call to inet_get_address fails > silently because the family is set to PF_INET6 but the buffer len is > the size of an IPv4 struct sockaddr_in. > > Prevent this behaviour by checking that the protocol family of the file > descriptor matches the family of the requested Erlang socket. > > {ok, S1} = gen_udp:open(0, [binary, inet]), > {ok, FD} = inet:getfd(S1), > {ok, Port} = inet:port(S1), > {ok, S} = gen_udp:open(Port, [binary, {fd, FD}, inet6]), > {ok, C} = gen_udp:open(0, [binary]), > Msg =<<1,2,3,4,5>>, > gen_udp:send(C, "127.0.0.1", Port, Msg), > receive > {udp, S, _, _, Msg} -> ok; > {udp, S, _, _, NewMsg} -> {error, Msg, NewMsg} > end. > > This test results in: {error,<<1,2,3,4,5>>,<<4,5>>} > > Thanks to Andrew Tunnell-Jones for finding the bug and the test case! > --- > erts/emulator/drivers/common/inet_drv.c | 4 +++- > lib/kernel/test/gen_udp_SUITE.erl | 1 + > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/erts/emulator/drivers/common/inet_drv.c b/erts/emulator/drivers/common/inet_drv.c > index 40c4a0d..ebc4469 100644 > --- a/erts/emulator/drivers/common/inet_drv.c > +++ b/erts/emulator/drivers/common/inet_drv.c > @@ -3709,6 +3709,8 @@ static int inet_ctl_fdopen(inet_descriptor* desc, int domain, int type, > /* check that it is a socket and that the socket is bound */ > if (IS_SOCKET_ERROR(sock_name(s, (struct sockaddr*)&name,&sz))) > return ctl_error(sock_errno(), rbuf, rsize); > + if (name.sa.sa_family != domain) > + return ctl_error(EINVAL, rbuf, rsize); > desc->s = s; > if ((desc->event = sock_create_event(desc)) == INVALID_EVENT) > return ctl_error(sock_errno(), rbuf, rsize); > @@ -9739,7 +9741,7 @@ static int packet_inet_ctl(ErlDrvData e, unsigned int cmd, char* buf, int len, > if (desc->active || (len != 8)) > return ctl_error(EINVAL, rbuf, rsize); > timeout = get_int32(buf); > - /* The 2nd arg, Length(4), is ignored for both UDP ans SCTP protocols, > + /* The 2nd arg, Length(4), is ignored for both UDP and SCTP protocols, > since they are msg-oriented. */ > > if (enq_async(desc, tbuf, PACKET_REQ_RECV)< 0) > diff --git a/lib/kernel/test/gen_udp_SUITE.erl b/lib/kernel/test/gen_udp_SUITE.erl > index d8a5519..b734d7f 100644 > --- a/lib/kernel/test/gen_udp_SUITE.erl > +++ b/lib/kernel/test/gen_udp_SUITE.erl > @@ -400,6 +400,7 @@ open_fd(Config) when is_list(Config) -> > {ok,S1} = gen_udp:open(0), > {ok,P2} = inet:port(S1), > {ok,FD} = prim_inet:getfd(S1), > + {error,einval} = gen_udp:open(P2, [inet6, {fd,FD}]), > {ok,S2} = gen_udp:open(P2, [{fd,FD}]), > {ok,S3} = gen_udp:open(0), > {ok,P3} = inet:port(S3), Hi I have merged this into 'pu' as "ms/inet-socket-domain-error" thank you for the contribution! -- /Henrik Nord Erlang/OTP From henrik@REDACTED Tue May 24 14:29:33 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 24 May 2011 14:29:33 +0200 Subject: [erlang-patches] Fix bug in FreeBSD topology detection code In-Reply-To: <2440BB77-F821-47D9-97FE-F698AE561A82@kallisys.net> References: <2440BB77-F821-47D9-97FE-F698AE561A82@kallisys.net> Message-ID: <4DDBA4AD.6050000@erlang.org> On 05/21/2011 10:19 AM, Paul Guyot wrote: > Hello, > > There is a bug in the FreeBSD topology detection code. The parser wouldn't consider the proper cache level and as a result, Intel Bi Xeons would appear has having 2n cores instead of 2 CPUs with n cores each. > > The fix is available here: > https://github.com/pguyot/otp/commit/a13caa7beeec4c54f3879da694231b81b3a7a36d > git fetch git://github.com/pguyot/otp.git fix-freebsd-dualcore-detection > > Regards, > > Paul Hi I have included this in 'pu' and will let it cook for a while. Thank you for the contribution! -- /Henrik Nord Erlang/OTP From henrik@REDACTED Tue May 24 14:31:13 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 24 May 2011 14:31:13 +0200 Subject: [erlang-patches] [PATCH] - improve zlib doc and type specs In-Reply-To: References: Message-ID: <4DDBA511.1000002@erlang.org> On 05/17/2011 12:01 PM, Filipe David Manana wrote: > git fetch git://github.com/fdmanana/otp.git zlib_doc > Hi This is also merged into 'pu' Thank you! -- /Henrik Nord Erlang/OTP From rzezeski@REDACTED Tue May 24 15:40:58 2011 From: rzezeski@REDACTED (Ryan Zezeski) Date: Tue, 24 May 2011 09:40:58 -0400 Subject: [erlang-patches] Add a proplist() type In-Reply-To: <4DDB6E86.10401@gmail.com> References: <4DDA7F15.5090607@gmail.com> <4DDB6E86.10401@gmail.com> Message-ID: On Tue, May 24, 2011 at 4:38 AM, Richard Carlsson < carlsson.richard@REDACTED> wrote: > On 05/23/2011 09:37 PM, Ryan Zezeski wrote: > >> Richard, I think specifying it as [property()] makes more sense because >> [any()] is just a list, and at that point why are you using a proplist? >> > > The main use of the proplists module is to allow humans to specify a list > of options to a function, in a readable way. The idea, when I wrote it, was > that if a program wants to allow other things in its option list - for > example, a naked integer might make sense in some cases - it should still be > able to use the proplists module for most of its normal options, so the > proplists functions should not crash on unexpected elements. As long as this > is allowed, Dialyzer should not complain about arbitrary lists as input. > > On the other hand, if you constrain the input type to [property()], it's > fairly simple to work around the Dialyzer warning by doing an initial pass > over the list and convert the naked values to valid properties, e.g., > mapping integers to {some_tag, N}, before you pass the list to the proplists > module. > > > Said another way, if the type was [any()] then I don't really see much >> of a benefit of typing it at all. >> > > Knowing that it must be a (proper) list is obviously better than not > knowing anything at all. > > /Richard > Richard, yes, having an alias is better than nothing at all. I spoke too quickly there. I guess everywhere I've seen proplists used it's as a map. If it's type is really just an alias for 'list()' then a function that returns 'proplist()' could return a string and that seems counterintuitive to me. My main use of proplists was actually as a slightly more succinct option to lists:keyfind, so take that as you may. I could use the dict module (and I have plenty of times before) but it's pretty print form is horrible/impossible to read. Regardless, I think adding a proplist() type is a good step and we seem to all agree there. If you want to change the type to be an alias of list() then that's fine, it would actually be more correct given what proplists documentation says. But, personally, I'd prefer it to be more restrictive. -Ryan -------------- next part -------------- An HTML attachment was scrubbed... URL: From cristian@REDACTED Tue May 24 19:46:56 2011 From: cristian@REDACTED (Cristian Greco) Date: Tue, 24 May 2011 19:46:56 +0200 Subject: [erlang-patches] Fix use of a logical operator instead of the bitwise one Message-ID: <20110524194656.74fd131e@regolo> Hi, the following commit should fix an incorrect use of the logical operator && with a constant operand, instead of the bitwise &. https://github.com/cristiangreco/otp/commit/53d1d7424fc435ad5846fb1d6483b7cb1b19fa3e git fetch git@REDACTED:cristiangreco/otp.git cg/fix-constant-logical-operand Thanks, -- Cristian Greco GPG key ID: 0xCF4D32E4 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From henrik@REDACTED Thu May 26 11:10:02 2011 From: henrik@REDACTED (Henrik Nord) Date: Thu, 26 May 2011 11:10:02 +0200 Subject: [erlang-patches] Fix use of a logical operator instead of the bitwise one In-Reply-To: <20110524194656.74fd131e@regolo> References: <20110524194656.74fd131e@regolo> Message-ID: <4DDE18EA.9090503@erlang.org> On 05/24/2011 07:46 PM, Cristian Greco wrote: > Hi, > > the following commit should fix an incorrect use of the logical > operator&& with a constant operand, instead of the bitwise&. > > https://github.com/cristiangreco/otp/commit/53d1d7424fc435ad5846fb1d6483b7cb1b19fa3e > > git fetch git@REDACTED:cristiangreco/otp.git cg/fix-constant-logical-operand > > Thanks, > -- > Cristian Greco > GPG key ID: 0xCF4D32E4 > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Your branch is cooking in 'pu' Thank you for the contribution! -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From klas.johansson@REDACTED Thu May 26 18:22:42 2011 From: klas.johansson@REDACTED (Klas Johansson) Date: Thu, 26 May 2011 18:22:42 +0200 Subject: [erlang-patches] eunit: generate separate surefire XMLs for each test suite Message-ID: Hi, Yet another eunit fix: Generate separate surefire XMLs for each test suite Previously the test cases of all test suites (=modules) were put in one and the same surefire report XML thereby breaking the principle of least astonishment and making post analysis harder. Assume the following layout: src/x.erl src/y.erl test/x_tests.erl test/y_tests.erl The results for both x_tests and y_tests were written to only one report grouped under either module x or y (seemingly randomly). Now two reports, one for module x and one for y are generated. This has now been running for a couple of weeks in our system and seems to do the trick. Code here: git fetch git://github.com/klajo/otp.git eunit-surefire-fixes Cheers, Klas From aronisstav@REDACTED Sat May 28 11:17:33 2011 From: aronisstav@REDACTED (Stavros Aronis) Date: Sat, 28 May 2011 12:17:33 +0300 Subject: [erlang-patches] Discrepancy in prim_file Message-ID: Details in the commit message: git fetch git://github.com/aronisstav/otp.git prim-file-fix I've tested this patch by running: - the test suite kernel/prim_file_SUITE - the experimental version of Dialyzer that discovered the discrepancy (nearly all of the warnings in http://dialyzer.softlab.ntua.gr/intersection/disco and all the warnings in http://dialyzer.softlab.ntua.gr/intersection/otp-erts stem from this discrepancy. Other applications affected include OTP kernel and ssl, hibari, scalaris and yaws.) From tuncer.ayaz@REDACTED Sat May 28 15:22:19 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sat, 28 May 2011 15:22:19 +0200 Subject: [erlang-patches] leex and yecc: add warnings_as_errors option Message-ID: git fetch git://github.com/tuncer/otp.git warnings_as_errors From henrik@REDACTED Tue May 31 11:39:21 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 31 May 2011 11:39:21 +0200 Subject: [erlang-patches] leex and yecc: add warnings_as_errors option In-Reply-To: References: Message-ID: <4DE4B749.7090201@erlang.org> On 05/28/2011 03:22 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git warnings_as_errors > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Thank you This is now cooking in 'pu' -- /Henrik Nord Erlang/OTP From henrik@REDACTED Tue May 31 11:40:32 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 31 May 2011 11:40:32 +0200 Subject: [erlang-patches] Discrepancy in prim_file In-Reply-To: References: Message-ID: <4DE4B790.1020308@erlang.org> On 05/28/2011 11:17 AM, Stavros Aronis wrote: > Details in the commit message: > > git fetch git://github.com/aronisstav/otp.git prim-file-fix > > I've tested this patch by running: > - the test suite kernel/prim_file_SUITE > - the experimental version of Dialyzer that discovered the discrepancy > (nearly all of the warnings in > http://dialyzer.softlab.ntua.gr/intersection/disco and all the > warnings in http://dialyzer.softlab.ntua.gr/intersection/otp-erts stem > from this discrepancy. Other applications affected include OTP kernel > and ssl, hibari, scalaris and yaws.) > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Thank you Stavros I have included this in 'pu', and will let it cook for a few days. -- /Henrik Nord Erlang/OTP From henrik@REDACTED Tue May 31 16:30:39 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 31 May 2011 16:30:39 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-05-31) Message-ID: <201105311430.p4VEUbfg011829@smaug.otp.ericsson.se> ------------------------------------------------------------ [Graduated] * ta/dragonfly-test_server-config (test_server) (2011-04-22) 1 commit + Add DragonflyBSD support to test_server (9d8d432) * tj/streaming_crypto_functions () (2011-05-06) 0 commits ------------------------------------------------------------ [New topics] * cg/fix-constant-logical-operand (erts) (2011-05-24) 1 commit - Fix use of logical operator && with constant operand instead of bitwise &. (53d1d74) * fm/zlib_doc (erts, kernel) (2011-05-31) 1 commit - Fix doc and spec tags for a few zlib erlang module functions (156827a) * hs/odbc-sql_wlongvarchar_support (odbc) (2011-05-04) 1 commit - Add support for SQL_WLONGVARCHAR (0445b6e) * kj/eunit-surefire-fixes (eunit) (2011-05-11) 1 commit - Generate separate surefire XMLs for each test suite (61621e6) * ms/inet-socket-domain-error (erts, kernel) (2011-05-24) 1 commit - inet: error if fd does not match socket domain (169080d) * pg/fix-freebsd-dualcore-detection (erts) (2011-05-21) 1 commit - Fix bug in FreeBSD topology detection code (a13caa7) * pg/fix-hibernate-scheduling-with-hipe (erts) (2011-05-21) 1 commit - Fix bug related to hibernate and HiPE (clear F_HIBERNATE_SCHED flag) (614c920) * rz/add_proplist_type (common_test, dialyzer, edoc, stdlib, test_server) (2011-05-22) 1 commit - Add a proplist() type (7d8a1f8) * sa/prim-file-fix (erts) (2011-05-27) 1 commit - Replace atom in DRV macro in prim_file with string (1f47084) * ta/warnings_as_errors (parsetools) (2011-05-28) 3 commits - yecc: add warnings_as_errors option (043ad1a) - leex: add warnings_as_errors option (fb7c707) - leex: fix typo in leex_SUITE (efc5ce3) ------------------------------------------------------------ [Stalled] * bw/efile_exists (erts) (2010-10-07) 1 commit - prim_file:exists/{1,2} which is lightweight file existence check (7203932) Action expected from: Topic author * fm/posix-fallocate (erts, kernel) (2011-04-15) 4 commits - Added missing surrounding if statement (5ec9fab) - Fixes to file:allocate/2 and respective tests (d0fb479) - Fix build on Solaris (9b8aecf) - Added file:allocate/2 (7554dbb) Action expected from: Topic author * jn/gen_stream (stdlib) (2011-04-15) 2 commits - Update gen_stream tests to conform with common_test standard (9f50d34) - Add gen_stream behaviour (3065e10) Action expected from: OTP-Team * sa/callback-attr (compiler, inets, kernel, orber, otp, stdlib) (2010-06-08) 8 commits - Add callback specs into 'application' module in kernel (4bca766) - Add callback specs to tftp module following internet documentation (bba649c) - Add callback specs to inets_service module following possibly deprecated comments (e41a958) - Add '-callback' attributes in stdlib's behaviours (d8d94c4) - Update primary bootstrap (199525a) - Update the documentation with information on the callback attribute (311a25f) - Automatically generate 'behaviour_info' function from '-callback' attributes (7c44f16) - Add '-callback' attribute to language syntax (e8336ff) Action expected from: OTP-Team * ta/typer-quote-atoms (hipe, typer) (2011-03-20) 1 commit - Quote atoms if necessary in types (254e21e) Action expected from: Hipe-team reviewer * vb/shell (erts, kernel, stdlib) (2011-01-21) 6 commits - Add expandfmt_fun option for io:setopts (f139eab) - Correct JCL's help indentation (95672fa) - Handle JCL's "r" command error when no pool started (ba4b196) - Fix tab expansion in remote shell (e2077cb) - edlin_expand: fix matches formatting (838b84a) - Take into account arity len when calculating field's width (ff28c52) Action expected from: Topic author * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits . Implement namespace axis (27d791f) . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) . Fix processing-instruction(name?) (f05e78b) . Fix path filters (610df56) . Support more top-level primary expressions (770d6d9) . Accumulate comments in element nodes (e5b6b3a) . Add `default_attrs` option (18584c5) . Allow whole documents to be returned (aef3dea) . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) . Track parents in `#xmlPI` nodes (5095331) . Set `vsn` field in `#xmlDecl` record (d712331) . Fix namespace-conformance constraints (e062270) Action expected from: Topic author * pd/ttb_upgrade (observer) (2011-04-05) 30 commits . additional tests for ttb module (ee2dabc) . new tests for ttb module (6f8ec53) . updated documentation (d39fa78) . updated OTP tests (dc1af0f) . (BUGFIX) Error with ip tracing to wrap sets (5082fc8) . Add onviso_server and cli as an exemplary ttb usage (d5a68df) . Include logfile name in fetch directory name (45f3302) . missing files addes (3e759dd) . dbg-type tracing (ece6a3b) . Optional handler specification allowed in stop/1 - Allowed optional handler specification in trace/2 (97be5ad) . Flush file trace port buffers with given frequency (9d4b083) . Autoresume tracing (7101720) Action expected from: Topic author ------------------------------------------------------------ [Cooking] * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits - Avoid crash by skipping compilation_SUITE:on_load/1 (0d913e0) - Inline less aggressively for native-code compilation (0215ac6) - Crudely fix return type for the lists:key{search,find,member}/3 (4f48864) - seq_trace_SUITE: Don't native-compile (3799b17) - Disable native code if on_load is used (f35872c) - andor_SUITE: Don't native-compile (a8ab68c) This branch contains temporary workarounds to avoid failing test cases and is never intended to graduate. * fm/external_size_2 (erts, hipe) (2011-05-16) 1 commit - Added erlang:external_size/2 BIF (2f4277a) * pr/mnesia_frag_hash (mnesia) (2011-04-27) 2 commits - add mnesia_frag_hash test (1d6762d) - Reduce calls to phash in key_to_frag_number (67a20c0) * sa/dialyzer-server-loop-fix (dialyzer) (2011-05-03) 1 commit - Fix server loop detection (3a7af1c) * ta/nif-strict-aliasing (erts) (2011-05-10) 2 commits - erts: use a union to avoid strict aliasing issues (8717b93) - erts: adapt matrix_nif to R14 erl_nif API changes (97fb95f) * ta/nif-variadic-funs (erts) (2011-05-13) 1 commit - erts: convert variadic nif funs into inline funs (9a1f9b6) * ta/sendfile (erts, kernel) (2011-01-13) 1 commit - Implement file:sendfile (6ae9c14) * tn/inet_drv-fix (erts) (2011-04-08) 1 commit - Use libdlpi to get physical address (e360563) ------------------------------------------------------------ [Dropped] * vs/asn1_long-definite-lenght (asn1) (2011-05-16) 2 commits . fix while loop reading beyond input buffers memory (c07026e) . add size check to determine if the calculated length has overflowed the size of the variable used to store it (6ac219a) Will be corrected it in a slightly different way by OTP-reviewer From henrik@REDACTED Tue May 31 15:37:50 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 31 May 2011 15:37:50 +0200 Subject: [erlang-patches] eunit: generate separate surefire XMLs for each test suite In-Reply-To: References: Message-ID: <4DE4EF2E.1010900@erlang.org> On 05/26/2011 06:22 PM, Klas Johansson wrote: > Hi, > > Yet another eunit fix: > > Generate separate surefire XMLs for each test suite > > Previously the test cases of all test suites (=modules) were put in > one and the same surefire report XML thereby breaking the principle of > least astonishment and making post analysis harder. Assume the > following layout: > > src/x.erl > src/y.erl > test/x_tests.erl > test/y_tests.erl > > The results for both x_tests and y_tests were written to only one > report grouped under either module x or y (seemingly randomly). > > Now two reports, one for module x and one for y are generated. > > This has now been running for a couple of weeks in our system and > seems to do the trick. > > Code here: > > git fetch git://github.com/klajo/otp.git eunit-surefire-fixes > > > > Cheers, > Klas > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Thank you Klas I have included this in 'pu' and it will cook for a while. -- /Henrik Nord Erlang/OTP From nox@REDACTED Tue May 31 17:13:52 2011 From: nox@REDACTED (Anthony Ramine) Date: Tue, 31 May 2011 17:13:52 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-05-31) In-Reply-To: <201105311430.p4VEUbfg011829@smaug.otp.ericsson.se> References: <201105311430.p4VEUbfg011829@smaug.otp.ericsson.se> Message-ID: <939E0C64-EBEE-4CB7-AA49-5C855CE28CA2@dev-extend.eu> Le 31 mai 2011 ? 16:30, Henrik Nord a ?crit : > * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits > . Implement namespace axis (27d791f) > . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) > . Fix processing-instruction(name?) (f05e78b) > . Fix path filters (610df56) > . Support more top-level primary expressions (770d6d9) > . Accumulate comments in element nodes (e5b6b3a) > . Add `default_attrs` option (18584c5) > . Allow whole documents to be returned (aef3dea) > . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) > . Track parents in `#xmlPI` nodes (5095331) > . Set `vsn` field in `#xmlDecl` record (d712331) > . Fix namespace-conformance constraints (e062270) > > Action expected from: Topic author Hi, This is not expected for R15 release anymore? May I know why? Regards, -- Anthony Ramine Dev:Extend http://dev-extend.eu From henrik@REDACTED Tue May 31 17:39:34 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 31 May 2011 17:39:34 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-05-31) In-Reply-To: <939E0C64-EBEE-4CB7-AA49-5C855CE28CA2@dev-extend.eu> References: <201105311430.p4VEUbfg011829@smaug.otp.ericsson.se> <939E0C64-EBEE-4CB7-AA49-5C855CE28CA2@dev-extend.eu> Message-ID: <4DE50BB6.1070109@erlang.org> On 05/31/2011 05:13 PM, Anthony Ramine wrote: > Le 31 mai 2011 ? 16:30, Henrik Nord a ?crit : > >> * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits >> . Implement namespace axis (27d791f) >> . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) >> . Fix processing-instruction(name?) (f05e78b) >> . Fix path filters (610df56) >> . Support more top-level primary expressions (770d6d9) >> . Accumulate comments in element nodes (e5b6b3a) >> . Add `default_attrs` option (18584c5) >> . Allow whole documents to be returned (aef3dea) >> . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) >> . Track parents in `#xmlPI` nodes (5095331) >> . Set `vsn` field in `#xmlDecl` record (d712331) >> . Fix namespace-conformance constraints (e062270) >> >> Action expected from: Topic author > Hi, > > This is not expected for R15 release anymore? May I know why? > > Regards, > > -- > Anthony Ramine > Dev:Extend > http://dev-extend.eu > > > > It is, I must have made a copy-paste error. Sorry about that -- /Henrik Nord Erlang/OTP