From holger@REDACTED Wed Jun 1 00:56:19 2011 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 1 Jun 2011 00:56:19 +0200 Subject: [erlang-patches] Fix typos in the epmd docs Message-ID: <20110531225619.GA27319005@CIS.FU-Berlin.DE> This replaces "implicitely" with "implicitly" in the epmd documentation: git fetch git://github.com/weiss/otp.git fix-doc-typos Holger From tuncer.ayaz@REDACTED Thu Jun 2 01:43:01 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Thu, 2 Jun 2011 01:43:01 +0200 Subject: [erlang-patches] Do not write beam file if Werr and warnings /= [] Message-ID: git fetch git://github.com/tuncer/otp.git compile-werr-beam-file From michael.santos@REDACTED Fri Jun 3 16:33:50 2011 From: michael.santos@REDACTED (Michael Santos) Date: Fri, 3 Jun 2011 10:33:50 -0400 Subject: [erlang-patches] [PATCH 1/2] epmd: support IPv6 node registration Message-ID: <20110603143350.GA1746@ecn.lan> Allow IPv6 nodes to register with and query epmd. epmd now listens on an IPv6 socket by default (if IPv6 support is available). Reported-By: Boris M?hmer --- erts/epmd/src/epmd_int.h | 2 +- erts/epmd/src/epmd_srv.c | 66 +++++++++++++++++++++++------------- lib/kernel/src/erl_epmd.erl | 18 +++++++--- lib/kernel/src/inet6_tcp_dist.erl | 2 +- 4 files changed, 56 insertions(+), 32 deletions(-) diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h index 2a0de4d..850607b 100644 --- a/erts/epmd/src/epmd_int.h +++ b/erts/epmd/src/epmd_int.h @@ -165,7 +165,7 @@ /* ************************************************************************ */ /* Macros that let us use IPv6 */ -#if defined(HAVE_IN6) && defined(AF_INET6) && defined(EPMD6) +#if defined(HAVE_IN6) && defined(AF_INET6) #define EPMD_SOCKADDR_IN sockaddr_in6 #define EPMD_IN_ADDR in6_addr diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c index 4d9b454..ea7caf2 100644 --- a/erts/epmd/src/epmd_srv.c +++ b/erts/epmd/src/epmd_srv.c @@ -69,6 +69,7 @@ static time_t current_time(EpmdVars*); static Connection *conn_init(EpmdVars*); static int conn_open(EpmdVars*,int); +static int conn_local_access_check(int fd); static int conn_close_fd(EpmdVars*,int); static void node_init(EpmdVars*); @@ -122,7 +123,7 @@ void run(EpmdVars *g) epmd_cleanup_exit(g,1); } else if (ret == 0) -#elif !defined(EPMD6) +#else if ((addr.EPMD_S_ADDR = inet_addr(token)) == INADDR_NONE) #endif { @@ -808,15 +809,6 @@ static int conn_open(EpmdVars *g,int fd) for (i = 0; i < g->max_conn; i++) { if (g->conn[i].open == EPMD_FALSE) { - struct sockaddr_in si; - struct sockaddr_in di; -#ifdef HAVE_SOCKLEN_T - socklen_t st; -#else - int st; -#endif - st = sizeof(si); - g->active_conn++; s = &g->conn[i]; @@ -827,20 +819,7 @@ static int conn_open(EpmdVars *g,int fd) s->open = EPMD_TRUE; s->keep = EPMD_FALSE; - /* Determine if connection is from localhost */ - if (getpeername(s->fd,(struct sockaddr*) &si,&st) || - st < sizeof(si)) { - /* Failure to get peername is regarded as non local host */ - s->local_peer = EPMD_FALSE; - } else { - /* Only 127.x.x.x and connections from the host's IP address - allowed, no false positives */ - s->local_peer = - (((((unsigned) ntohl(si.sin_addr.s_addr)) & 0xFF000000U) == - 0x7F000000U) || - (getsockname(s->fd,(struct sockaddr*) &di,&st) ? - EPMD_FALSE : si.sin_addr.s_addr == di.sin_addr.s_addr)); - } + s->local_peer = conn_local_access_check(s->fd); dbg_tty_printf(g,2,(s->local_peer) ? "Local peer connected" : "Non-local peer connected"); @@ -866,6 +845,45 @@ static int conn_open(EpmdVars *g,int fd) return EPMD_FALSE; } +static int conn_local_access_check(int fd) +{ + struct EPMD_SOCKADDR_IN si; + struct EPMD_SOCKADDR_IN di; +#ifdef HAVE_SOCKLEN_T + socklen_t st; +#else + int st; +#endif + st = sizeof(si); + + /* Determine if connection is from localhost */ + if (getpeername(fd,(struct sockaddr*) &si,&st) || + st < sizeof(si)) { + /* Failure to get peername is regarded as non local host */ + return EPMD_FALSE; + } + + /* Only 127.x.x.x and connections from the host's IP address + allowed, no false positives */ +#if defined(HAVE_IN6) && defined(AF_INET6) + if (IN6_IS_ADDR_LOOPBACK(&si.sin6_addr)) + return EPMD_TRUE; +#else + if ((((unsigned) ntohl(si.sin_addr.s_addr)) & 0xFF000000U) == + 0x7F000000U) + return EPMD_TRUE; +#endif + + if (getsockname(fd,(struct sockaddr*) &di,&st)) + return EPMD_FALSE; + +#if defined(HAVE_IN6) && defined(AF_INET6) + return IN6_ARE_ADDR_EQUAL(&si.sin6_addr, &di.sin6_addr); +#else + return si.sin_addr.s_addr == di.sin_addr.s_addr; +#endif +} + static int conn_close_fd(EpmdVars *g,int fd) { int i; diff --git a/lib/kernel/src/erl_epmd.erl b/lib/kernel/src/erl_epmd.erl index 91af49f..e9d1caa 100644 --- a/lib/kernel/src/erl_epmd.erl +++ b/lib/kernel/src/erl_epmd.erl @@ -31,7 +31,7 @@ %% External exports -export([start/0, start_link/0, stop/0, port_please/2, port_please/3, names/0, names/1, - register_node/2, open/0, open/1, open/2]). + register_node/2, register_node/3, open/0, open/1, open/2]). %% gen_server callbacks -export([init/1, handle_call/3, handle_cast/2, handle_info/2, @@ -106,7 +106,9 @@ names1(HostName) -> register_node(Name, PortNo) -> - gen_server:call(erl_epmd, {register, Name, PortNo}, infinity). + register_node(Name, PortNo, inet). +register_node(Name, PortNo, Family) -> + gen_server:call(erl_epmd, {register, Name, PortNo, Family}, infinity). %%%---------------------------------------------------------------------- %%% Callback functions from gen_server @@ -124,10 +126,10 @@ init(_) -> -spec handle_call(calls(), term(), state()) -> {'reply', term(), state()} | {'stop', 'shutdown', 'ok', state()}. -handle_call({register, Name, PortNo}, _From, State) -> +handle_call({register, Name, PortNo, Family}, _From, State) -> case State#state.socket of P when P < 0 -> - case do_register_node(Name, PortNo) of + case do_register_node(Name, PortNo, Family) of {alive, Socket, Creation} -> S = State#state{socket = Socket, port_no = PortNo, @@ -210,8 +212,12 @@ open({A,B,C,D,E,F,G,H}=EpmdAddr, Timeout) when ?ip6(A,B,C,D,E,F,G,H) -> close(Socket) -> gen_tcp:close(Socket). -do_register_node(NodeName, TcpPort) -> - case open() of +do_register_node(NodeName, TcpPort, Family) -> + Register = case Family of + inet -> open({127,0,0,1}); + inet6 -> open({0,0,0,0,0,0,0,1}) + end, + case Register of {ok, Socket} -> Name = to_string(NodeName), Extra = "", diff --git a/lib/kernel/src/inet6_tcp_dist.erl b/lib/kernel/src/inet6_tcp_dist.erl index b9c4fa6..0b5fb44 100644 --- a/lib/kernel/src/inet6_tcp_dist.erl +++ b/lib/kernel/src/inet6_tcp_dist.erl @@ -71,7 +71,7 @@ listen(Name) -> {ok, Socket} -> TcpAddress = get_tcp_address(Socket), {_,Port} = TcpAddress#net_address.address, - {ok, Creation} = erl_epmd:register_node(Name, Port), + {ok, Creation} = erl_epmd:register_node(Name, Port, inet6), {ok, {Socket, TcpAddress, Creation}}; Error -> Error -- 1.7.0.4 From michael.santos@REDACTED Fri Jun 3 16:34:15 2011 From: michael.santos@REDACTED (Michael Santos) Date: Fri, 3 Jun 2011 10:34:15 -0400 Subject: [erlang-patches] [PATCH 2/2] epmd: fix compiler warnings Message-ID: <20110603143415.GA1760@ecn.lan> Suppress compiler warnings about ignored return values. --- erts/epmd/src/epmd.c | 6 +++++- erts/epmd/src/epmd_cli.c | 5 ++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/erts/epmd/src/epmd.c b/erts/epmd/src/epmd.c index 08576d9..2267f9b 100644 --- a/erts/epmd/src/epmd.c +++ b/erts/epmd/src/epmd.c @@ -324,7 +324,11 @@ static void run_daemon(EpmdVars *g) } /* move cwd to root to make sure we are not on a mounted filesystem */ - chdir("/"); + if (chdir("/") < 0) + { + dbg_perror(g,"epmd: chdir() failed"); + epmd_cleanup_exit(g,1); + } umask(0); diff --git a/erts/epmd/src/epmd_cli.c b/erts/epmd/src/epmd_cli.c index ac55ba6..2377c0d 100644 --- a/erts/epmd/src/epmd_cli.c +++ b/erts/epmd/src/epmd_cli.c @@ -104,7 +104,10 @@ void epmd_call(EpmdVars *g,int what) fd = conn_to_epmd(g); put_int16(1,buf); buf[2] = what; - write(fd,buf,3); + if (write(fd, buf, 3) != 3) { + printf("epmd: Can't write to epmd\n"); + epmd_cleanup_exit(g,1); + } if (read(fd,(char *)&i,4) != 4) { if (!g->silent) printf("epmd: no response from local epmd\n"); -- 1.7.0.4 From michael.santos@REDACTED Fri Jun 3 16:49:25 2011 From: michael.santos@REDACTED (Michael Santos) Date: Fri, 3 Jun 2011 10:49:25 -0400 Subject: [erlang-patches] [PATCH 1/2] epmd: support IPv6 node registration Message-ID: <20110603144925.GA1822@ecn.lan> Allow IPv6 nodes to register with and query epmd. epmd now listens on an IPv6 socket by default (if IPv6 support is available). Reported-By: Boris M?hmer --- erts/epmd/src/epmd_int.h | 2 +- erts/epmd/src/epmd_srv.c | 66 +++++++++++++++++++++++------------- lib/kernel/src/erl_epmd.erl | 18 +++++++--- lib/kernel/src/inet6_tcp_dist.erl | 2 +- 4 files changed, 56 insertions(+), 32 deletions(-) diff --git a/erts/epmd/src/epmd_int.h b/erts/epmd/src/epmd_int.h index 2a0de4d..850607b 100644 --- a/erts/epmd/src/epmd_int.h +++ b/erts/epmd/src/epmd_int.h @@ -165,7 +165,7 @@ /* ************************************************************************ */ /* Macros that let us use IPv6 */ -#if defined(HAVE_IN6) && defined(AF_INET6) && defined(EPMD6) +#if defined(HAVE_IN6) && defined(AF_INET6) #define EPMD_SOCKADDR_IN sockaddr_in6 #define EPMD_IN_ADDR in6_addr diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c index 4d9b454..ea7caf2 100644 --- a/erts/epmd/src/epmd_srv.c +++ b/erts/epmd/src/epmd_srv.c @@ -69,6 +69,7 @@ static time_t current_time(EpmdVars*); static Connection *conn_init(EpmdVars*); static int conn_open(EpmdVars*,int); +static int conn_local_access_check(int fd); static int conn_close_fd(EpmdVars*,int); static void node_init(EpmdVars*); @@ -122,7 +123,7 @@ void run(EpmdVars *g) epmd_cleanup_exit(g,1); } else if (ret == 0) -#elif !defined(EPMD6) +#else if ((addr.EPMD_S_ADDR = inet_addr(token)) == INADDR_NONE) #endif { @@ -808,15 +809,6 @@ static int conn_open(EpmdVars *g,int fd) for (i = 0; i < g->max_conn; i++) { if (g->conn[i].open == EPMD_FALSE) { - struct sockaddr_in si; - struct sockaddr_in di; -#ifdef HAVE_SOCKLEN_T - socklen_t st; -#else - int st; -#endif - st = sizeof(si); - g->active_conn++; s = &g->conn[i]; @@ -827,20 +819,7 @@ static int conn_open(EpmdVars *g,int fd) s->open = EPMD_TRUE; s->keep = EPMD_FALSE; - /* Determine if connection is from localhost */ - if (getpeername(s->fd,(struct sockaddr*) &si,&st) || - st < sizeof(si)) { - /* Failure to get peername is regarded as non local host */ - s->local_peer = EPMD_FALSE; - } else { - /* Only 127.x.x.x and connections from the host's IP address - allowed, no false positives */ - s->local_peer = - (((((unsigned) ntohl(si.sin_addr.s_addr)) & 0xFF000000U) == - 0x7F000000U) || - (getsockname(s->fd,(struct sockaddr*) &di,&st) ? - EPMD_FALSE : si.sin_addr.s_addr == di.sin_addr.s_addr)); - } + s->local_peer = conn_local_access_check(s->fd); dbg_tty_printf(g,2,(s->local_peer) ? "Local peer connected" : "Non-local peer connected"); @@ -866,6 +845,45 @@ static int conn_open(EpmdVars *g,int fd) return EPMD_FALSE; } +static int conn_local_access_check(int fd) +{ + struct EPMD_SOCKADDR_IN si; + struct EPMD_SOCKADDR_IN di; +#ifdef HAVE_SOCKLEN_T + socklen_t st; +#else + int st; +#endif + st = sizeof(si); + + /* Determine if connection is from localhost */ + if (getpeername(fd,(struct sockaddr*) &si,&st) || + st < sizeof(si)) { + /* Failure to get peername is regarded as non local host */ + return EPMD_FALSE; + } + + /* Only 127.x.x.x and connections from the host's IP address + allowed, no false positives */ +#if defined(HAVE_IN6) && defined(AF_INET6) + if (IN6_IS_ADDR_LOOPBACK(&si.sin6_addr)) + return EPMD_TRUE; +#else + if ((((unsigned) ntohl(si.sin_addr.s_addr)) & 0xFF000000U) == + 0x7F000000U) + return EPMD_TRUE; +#endif + + if (getsockname(fd,(struct sockaddr*) &di,&st)) + return EPMD_FALSE; + +#if defined(HAVE_IN6) && defined(AF_INET6) + return IN6_ARE_ADDR_EQUAL(&si.sin6_addr, &di.sin6_addr); +#else + return si.sin_addr.s_addr == di.sin_addr.s_addr; +#endif +} + static int conn_close_fd(EpmdVars *g,int fd) { int i; diff --git a/lib/kernel/src/erl_epmd.erl b/lib/kernel/src/erl_epmd.erl index 91af49f..e9d1caa 100644 --- a/lib/kernel/src/erl_epmd.erl +++ b/lib/kernel/src/erl_epmd.erl @@ -31,7 +31,7 @@ %% External exports -export([start/0, start_link/0, stop/0, port_please/2, port_please/3, names/0, names/1, - register_node/2, open/0, open/1, open/2]). + register_node/2, register_node/3, open/0, open/1, open/2]). %% gen_server callbacks -export([init/1, handle_call/3, handle_cast/2, handle_info/2, @@ -106,7 +106,9 @@ names1(HostName) -> register_node(Name, PortNo) -> - gen_server:call(erl_epmd, {register, Name, PortNo}, infinity). + register_node(Name, PortNo, inet). +register_node(Name, PortNo, Family) -> + gen_server:call(erl_epmd, {register, Name, PortNo, Family}, infinity). %%%---------------------------------------------------------------------- %%% Callback functions from gen_server @@ -124,10 +126,10 @@ init(_) -> -spec handle_call(calls(), term(), state()) -> {'reply', term(), state()} | {'stop', 'shutdown', 'ok', state()}. -handle_call({register, Name, PortNo}, _From, State) -> +handle_call({register, Name, PortNo, Family}, _From, State) -> case State#state.socket of P when P < 0 -> - case do_register_node(Name, PortNo) of + case do_register_node(Name, PortNo, Family) of {alive, Socket, Creation} -> S = State#state{socket = Socket, port_no = PortNo, @@ -210,8 +212,12 @@ open({A,B,C,D,E,F,G,H}=EpmdAddr, Timeout) when ?ip6(A,B,C,D,E,F,G,H) -> close(Socket) -> gen_tcp:close(Socket). -do_register_node(NodeName, TcpPort) -> - case open() of +do_register_node(NodeName, TcpPort, Family) -> + Localhost = case Family of + inet -> {127,0,0,1}; + inet6 -> {0,0,0,0,0,0,0,1} + end, + case open(Localhost) of {ok, Socket} -> Name = to_string(NodeName), Extra = "", diff --git a/lib/kernel/src/inet6_tcp_dist.erl b/lib/kernel/src/inet6_tcp_dist.erl index b9c4fa6..0b5fb44 100644 --- a/lib/kernel/src/inet6_tcp_dist.erl +++ b/lib/kernel/src/inet6_tcp_dist.erl @@ -71,7 +71,7 @@ listen(Name) -> {ok, Socket} -> TcpAddress = get_tcp_address(Socket), {_,Port} = TcpAddress#net_address.address, - {ok, Creation} = erl_epmd:register_node(Name, Port), + {ok, Creation} = erl_epmd:register_node(Name, Port, inet6), {ok, {Socket, TcpAddress, Creation}}; Error -> Error -- 1.7.0.4 From michael.santos@REDACTED Fri Jun 3 16:50:34 2011 From: michael.santos@REDACTED (Michael Santos) Date: Fri, 3 Jun 2011 10:50:34 -0400 Subject: [erlang-patches] [PATCH 1/2] epmd: support IPv6 node registration In-Reply-To: <20110603144925.GA1822@ecn.lan> References: <20110603144925.GA1822@ecn.lan> Message-ID: <20110603145034.GA1812@ecn.lan> Please use the second version of this patch. Sorry, of course I didn't notice a change I'd wanted to make until after I sent it the first time. On Fri, Jun 03, 2011 at 10:49:25AM -0400, Michael Santos wrote: > Allow IPv6 nodes to register with and query epmd. epmd now listens on > an IPv6 socket by default (if IPv6 support is available). > > Reported-By: Boris M?hmer From michael.santos@REDACTED Fri Jun 3 16:58:57 2011 From: michael.santos@REDACTED (Michael Santos) Date: Fri, 3 Jun 2011 10:58:57 -0400 Subject: [erlang-patches] [PATCH] ei: integer overflow in string/atom encoding Message-ID: <20110603145857.GA1924@ecn.lan> ei_encode_atom() and ei_encode_string() use strlen() to get the length of the buffer. As strlen() returns an unsigned long long and both ei functions take a signed integer, the length fields may overflow. Note: the index may still overflow. Check the results of strlen can be held in a signed integer. --- lib/erl_interface/src/encode/encode_atom.c | 4 ++++ lib/erl_interface/src/encode/encode_string.c | 6 +++++- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/lib/erl_interface/src/encode/encode_atom.c b/lib/erl_interface/src/encode/encode_atom.c index 69f2d14..0efa204 100644 --- a/lib/erl_interface/src/encode/encode_atom.c +++ b/lib/erl_interface/src/encode/encode_atom.c @@ -17,12 +17,16 @@ * %CopyrightEnd% */ #include +#include #include "eidef.h" #include "eiext.h" #include "putget.h" int ei_encode_atom(char *buf, int *index, const char *p) { + size_t len = strlen(p); + + if (len >= INT_MAX) return -1; return ei_encode_atom_len(buf, index, p, strlen(p)); } diff --git a/lib/erl_interface/src/encode/encode_string.c b/lib/erl_interface/src/encode/encode_string.c index 1d342cb..593bbf2 100644 --- a/lib/erl_interface/src/encode/encode_string.c +++ b/lib/erl_interface/src/encode/encode_string.c @@ -17,6 +17,7 @@ * %CopyrightEnd% */ #include +#include #include "eidef.h" #include "eiext.h" #include "putget.h" @@ -24,7 +25,10 @@ int ei_encode_string(char *buf, int *index, const char *p) { - return ei_encode_string_len(buf, index, p, strlen(p)); + size_t len = strlen(p); + + if (len >= INT_MAX) return -1; + return ei_encode_string_len(buf, index, p, len); } int ei_encode_string_len(char *buf, int *index, const char *p, int len) -- 1.7.0.4 From mikpe@REDACTED Fri Jun 3 18:21:10 2011 From: mikpe@REDACTED (Mikael Pettersson) Date: Fri, 3 Jun 2011 18:21:10 +0200 Subject: [erlang-patches] [PATCH] ei: integer overflow in string/atom encoding In-Reply-To: <20110603145857.GA1924@ecn.lan> References: <20110603145857.GA1924@ecn.lan> Message-ID: <19945.2550.221956.792604@pilspetsen.it.uu.se> Michael Santos writes: > ei_encode_atom() and ei_encode_string() use strlen() to get the length > of the buffer. As strlen() returns an unsigned long long and both ei size_t is unsigned but may or may not be long long > functions take a signed integer, the length fields may overflow. Indeed. > > Note: the index may still overflow. > > Check the results of strlen can be held in a signed integer. The change feels like a kludge. IMO ei_encode_{atom,string}_len() should be fixed to take size_t lengths rather than signed int lengths. Is there any reason why that wouldn't work? /Mikael p.s. Thank you for inlining the patch and providing a rationale, most git users on this list don't do that which makes peer review difficult. > --- > lib/erl_interface/src/encode/encode_atom.c | 4 ++++ > lib/erl_interface/src/encode/encode_string.c | 6 +++++- > 2 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/lib/erl_interface/src/encode/encode_atom.c b/lib/erl_interface/src/encode/encode_atom.c > index 69f2d14..0efa204 100644 > --- a/lib/erl_interface/src/encode/encode_atom.c > +++ b/lib/erl_interface/src/encode/encode_atom.c > @@ -17,12 +17,16 @@ > * %CopyrightEnd% > */ > #include > +#include > #include "eidef.h" > #include "eiext.h" > #include "putget.h" > > int ei_encode_atom(char *buf, int *index, const char *p) > { > + size_t len = strlen(p); > + > + if (len >= INT_MAX) return -1; > return ei_encode_atom_len(buf, index, p, strlen(p)); > } > > diff --git a/lib/erl_interface/src/encode/encode_string.c b/lib/erl_interface/src/encode/encode_string.c > index 1d342cb..593bbf2 100644 > --- a/lib/erl_interface/src/encode/encode_string.c > +++ b/lib/erl_interface/src/encode/encode_string.c > @@ -17,6 +17,7 @@ > * %CopyrightEnd% > */ > #include > +#include > #include "eidef.h" > #include "eiext.h" > #include "putget.h" > @@ -24,7 +25,10 @@ > > int ei_encode_string(char *buf, int *index, const char *p) > { > - return ei_encode_string_len(buf, index, p, strlen(p)); > + size_t len = strlen(p); > + > + if (len >= INT_MAX) return -1; > + return ei_encode_string_len(buf, index, p, len); > } > > int ei_encode_string_len(char *buf, int *index, const char *p, int len) > -- > 1.7.0.4 > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches > From michael.santos@REDACTED Fri Jun 3 19:03:25 2011 From: michael.santos@REDACTED (Michael Santos) Date: Fri, 3 Jun 2011 13:03:25 -0400 Subject: [erlang-patches] [PATCH] ei: integer overflow in string/atom encoding In-Reply-To: <19945.2550.221956.792604@pilspetsen.it.uu.se> References: <20110603145857.GA1924@ecn.lan> <19945.2550.221956.792604@pilspetsen.it.uu.se> Message-ID: <20110603170325.GB1939@ecn.lan> On Fri, Jun 03, 2011 at 06:21:10PM +0200, Mikael Pettersson wrote: > Michael Santos writes: > > ei_encode_atom() and ei_encode_string() use strlen() to get the length > > of the buffer. As strlen() returns an unsigned long long and both ei > > size_t is unsigned but may or may not be long long > > > functions take a signed integer, the length fields may overflow. > > Indeed. > > > > > Note: the index may still overflow. > > > > Check the results of strlen can be held in a signed integer. > > The change feels like a kludge. IMO ei_encode_{atom,string}_len() should be > fixed to take size_t lengths rather than signed int lengths. Is there any > reason why that wouldn't work? I agree with the kludge comment. There may still be a need for a check though since the list length is held in 4 bytes in the external term format. It would be great to move from signed to unsigned ints but that would involve an interface change. If that's ok, I'd be happy to make the changes and update the docs (looks like a few changes in other places as well, like odbcserver.c). > /Mikael > > p.s. Thank you for inlining the patch and providing a rationale, most git > users on this list don't do that which makes peer review difficult. > > > --- > > lib/erl_interface/src/encode/encode_atom.c | 4 ++++ > > lib/erl_interface/src/encode/encode_string.c | 6 +++++- > > 2 files changed, 9 insertions(+), 1 deletions(-) > > > > diff --git a/lib/erl_interface/src/encode/encode_atom.c b/lib/erl_interface/src/encode/encode_atom.c > > index 69f2d14..0efa204 100644 > > --- a/lib/erl_interface/src/encode/encode_atom.c > > +++ b/lib/erl_interface/src/encode/encode_atom.c > > @@ -17,12 +17,16 @@ > > * %CopyrightEnd% > > */ > > #include > > +#include > > #include "eidef.h" > > #include "eiext.h" > > #include "putget.h" > > > > int ei_encode_atom(char *buf, int *index, const char *p) > > { > > + size_t len = strlen(p); > > + > > + if (len >= INT_MAX) return -1; > > return ei_encode_atom_len(buf, index, p, strlen(p)); > > } > > > > diff --git a/lib/erl_interface/src/encode/encode_string.c b/lib/erl_interface/src/encode/encode_string.c > > index 1d342cb..593bbf2 100644 > > --- a/lib/erl_interface/src/encode/encode_string.c > > +++ b/lib/erl_interface/src/encode/encode_string.c > > @@ -17,6 +17,7 @@ > > * %CopyrightEnd% > > */ > > #include > > +#include > > #include "eidef.h" > > #include "eiext.h" > > #include "putget.h" > > @@ -24,7 +25,10 @@ > > > > int ei_encode_string(char *buf, int *index, const char *p) > > { > > - return ei_encode_string_len(buf, index, p, strlen(p)); > > + size_t len = strlen(p); > > + > > + if (len >= INT_MAX) return -1; > > + return ei_encode_string_len(buf, index, p, len); > > } > > > > int ei_encode_string_len(char *buf, int *index, const char *p, int len) > > -- > > 1.7.0.4 > > > > _______________________________________________ > > erlang-patches mailing list > > erlang-patches@REDACTED > > http://erlang.org/mailman/listinfo/erlang-patches > > From fdmanana@REDACTED Sun Jun 5 19:41:07 2011 From: fdmanana@REDACTED (Filipe David Manana) Date: Sun, 5 Jun 2011 18:41:07 +0100 Subject: [erlang-patches] [PATCH] - add NIF functions for arithmetic and bitwise operations on numbers (including large numbers) Message-ID: git fetch git://github.com/fdmanana/otp.git nif_number_operations -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From holger@REDACTED Sun Jun 5 23:16:40 2011 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Sun, 5 Jun 2011 23:16:40 +0200 Subject: [erlang-patches] Call chmod without the "-f" flag (again) Message-ID: <20110605211640.GA27032277@CIS.FU-Berlin.DE> Commit 7ed11a88 removed the non-standard "-f" flag from chmod calls in Makefiles. Meanwhile, new "chmod -f" calls have been added, so this commit removes the "-f" flag from those new calls: git fetch git://github.com/weiss/otp.git update-chmod-without-f Holger From spawn.think@REDACTED Mon Jun 6 10:44:56 2011 From: spawn.think@REDACTED (Ahmed Omar) Date: Mon, 6 Jun 2011 10:44:56 +0200 Subject: [erlang-patches] Fixes messages handling in percept_db Message-ID: Fixes some issues with messages in percept_db commit 3e8fe28afaf2d78d33dc Added demonitor to avoid keeping DOWN message in the queue. Also fixed a wrong spec in do_start/0. commit 5ba7bf2acdf59cf36dd6: Fixes message handling in select requests. percept_db used to send results in an untagged messages, and use a non selective receive to extract them. When percept is used from the shell process, this can confuse other messages with the actual result. Added a tag to the message to be {result, Result}. git fetch git://github.com/spawnthink/otp.git fix_percept_msgs -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think -------------- next part -------------- An HTML attachment was scrubbed... URL: From michael.santos@REDACTED Mon Jun 6 16:54:38 2011 From: michael.santos@REDACTED (Michael Santos) Date: Mon, 6 Jun 2011 10:54:38 -0400 Subject: [erlang-patches] [PATCH] ei: integer overflow in string/atom encoding In-Reply-To: <20110603145857.GA1924@ecn.lan> References: <20110603145857.GA1924@ecn.lan> Message-ID: <20110606145438.GA2407@ecn.lan> On Fri, Jun 03, 2011 at 10:58:57AM -0400, Michael Santos wrote: > + size_t len = strlen(p); > + > + if (len >= INT_MAX) return -1; > return ei_encode_atom_len(buf, index, p, strlen(p)); Redundant strlen is redundant. I'll amend the patch. From michael.santos@REDACTED Mon Jun 6 16:55:19 2011 From: michael.santos@REDACTED (Michael Santos) Date: Mon, 6 Jun 2011 10:55:19 -0400 Subject: [erlang-patches] [PATCH] ei: integer overflow in string/atom encoding Message-ID: <20110606145519.GA2485@ecn.lan> ei_encode_atom() and ei_encode_string() use strlen() to get the length of the buffer. As strlen() returns an unsigned long long and both ei functions take a signed integer, the length fields may overflow. Check the results of strlen can be held in a signed integer. --- lib/erl_interface/src/encode/encode_atom.c | 6 +++++- lib/erl_interface/src/encode/encode_string.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/erl_interface/src/encode/encode_atom.c b/lib/erl_interface/src/encode/encode_atom.c index 69f2d14..b1a4479 100644 --- a/lib/erl_interface/src/encode/encode_atom.c +++ b/lib/erl_interface/src/encode/encode_atom.c @@ -17,13 +17,17 @@ * %CopyrightEnd% */ #include +#include #include "eidef.h" #include "eiext.h" #include "putget.h" int ei_encode_atom(char *buf, int *index, const char *p) { - return ei_encode_atom_len(buf, index, p, strlen(p)); + size_t len = strlen(p); + + if (len >= INT_MAX) return -1; + return ei_encode_atom_len(buf, index, p, len); } int ei_encode_atom_len(char *buf, int *index, const char *p, int len) diff --git a/lib/erl_interface/src/encode/encode_string.c b/lib/erl_interface/src/encode/encode_string.c index 1d342cb..593bbf2 100644 --- a/lib/erl_interface/src/encode/encode_string.c +++ b/lib/erl_interface/src/encode/encode_string.c @@ -17,6 +17,7 @@ * %CopyrightEnd% */ #include +#include #include "eidef.h" #include "eiext.h" #include "putget.h" @@ -24,7 +25,10 @@ int ei_encode_string(char *buf, int *index, const char *p) { - return ei_encode_string_len(buf, index, p, strlen(p)); + size_t len = strlen(p); + + if (len >= INT_MAX) return -1; + return ei_encode_string_len(buf, index, p, len); } int ei_encode_string_len(char *buf, int *index, const char *p, int len) -- 1.7.0.4 From holger@REDACTED Tue Jun 7 12:51:42 2011 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Tue, 7 Jun 2011 12:51:42 +0200 Subject: [erlang-patches] Detect the available CPUs on IRIX Message-ID: <20110607105142.GA28396954@CIS.FU-Berlin.DE> Add support for querying the number of configured and online CPUs on systems running IRIX: git fetch git://github.com/weiss/otp.git detect-cpus-on-irix Holger From tom@REDACTED Tue Jun 7 18:11:01 2011 From: tom@REDACTED (Tom Moertel) Date: Tue, 7 Jun 2011 12:11:01 -0400 Subject: [erlang-patches] What is the preferred method of submitting patches to the list? [was Re: [PATCH] ei: integer overflow in string/atom encoding] Message-ID: On Fri, Jun 3, 2011 at 12:21 PM, Mikael Pettersson wrote: > p.s. Thank you for inlining the patch and providing a rationale, most git > users on this list don't do that which makes peer review difficult. > > If inline patches are preferred, perhaps the following recommendations should be revised to say so more clearly: https://github.com/erlang/otp/wiki/submitting-patches Right now, the recommendations on that page begin with the strong suggestion that the Right Thing is to email a reference to the Git branch that represents the proposed patches: The recommended way of sending patches is described on this page. Basically, > you push your changes to a git repository and send us an email with a > reference to your public git repository and branch.... If you send us a > patch in other ways than described on this page, it will mean more work for > us and we cannot guarantee anything. It is up to the maintainer for that > part of OTP to decide whether (s)he will pick up the patch. It is only much later in the document, in the "Sending the patch" section, that readers learn that inline patches are acceptable at all, but even then it's only via a parenthetical comment: (We also accept *inline* patches compatible with format generated by git > format-patch, but please make sure that your email client has not garbled > the message.) What *is* the preferred method of submitting patches to the list? Inline? Git fetch command? Some combination of the two? Cheers, Tom -------------- next part -------------- An HTML attachment was scrubbed... URL: From tom@REDACTED Tue Jun 7 18:11:42 2011 From: tom@REDACTED (Tom Moertel) Date: Tue, 7 Jun 2011 12:11:42 -0400 Subject: [erlang-patches] What is the preferred method of submitting patches to the list? [was Re: [PATCH] ei: integer overflow in string/atom encoding] In-Reply-To: References: Message-ID: On Fri, Jun 3, 2011 at 12:21 PM, Mikael Pettersson wrote: > p.s. Thank you for inlining the patch and providing a rationale, most git > users on this list don't do that which makes peer review difficult. > > If inline patches are preferred, perhaps the following recommendations should be revised to say so more clearly: https://github.com/erlang/otp/wiki/submitting-patches Right now, the recommendations on that page begin with the strong suggestion that the Right Thing is to email a reference to the Git branch that represents the proposed patches: The recommended way of sending patches is described on this page. Basically, > you push your changes to a git repository and send us an email with a > reference to your public git repository and branch.... If you send us a > patch in other ways than described on this page, it will mean more work for > us and we cannot guarantee anything. It is up to the maintainer for that > part of OTP to decide whether (s)he will pick up the patch. It is only much later in the document, in the "Sending the patch" section, that readers learn that inline patches are acceptable at all, but even then it's only via a parenthetical comment: (We also accept *inline* patches compatible with format generated by git > format-patch, but please make sure that your email client has not garbled > the message.) What *is* the preferred method of submitting patches to the list? Inline? Git fetch command? Some combination of the two? Cheers, Tom -------------- next part -------------- An HTML attachment was scrubbed... URL: From raimo+erlang-patches@REDACTED Tue Jun 7 18:21:59 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:21:59 +0200 Subject: [erlang-patches] Do not write beam file if Werr and warnings /= [] In-Reply-To: References: Message-ID: <20110607162159.GA14106@erix.ericsson.se> On Thu, Jun 02, 2011 at 01:43:01AM +0200, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git compile-werr-beam-file Thank you. I have included your patch into 'pu'. -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Tue Jun 7 18:24:06 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:24:06 +0200 Subject: [erlang-patches] [PATCH 1/2] epmd: support IPv6 node registration In-Reply-To: <20110603144925.GA1822@ecn.lan> References: <20110603144925.GA1822@ecn.lan> Message-ID: <20110607162406.GB14106@erix.ericsson.se> On Fri, Jun 03, 2011 at 10:49:25AM -0400, Michael Santos wrote: > Allow IPv6 nodes to register with and query epmd. epmd now listens on > an IPv6 socket by default (if IPv6 support is available). > > Reported-By: Boris M?hmer Thank you. I have included your patch into 'pu'. -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Tue Jun 7 18:24:30 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:24:30 +0200 Subject: [erlang-patches] [PATCH 2/2] epmd: fix compiler warnings In-Reply-To: <20110603143415.GA1760@ecn.lan> References: <20110603143415.GA1760@ecn.lan> Message-ID: <20110607162430.GC14106@erix.ericsson.se> On Fri, Jun 03, 2011 at 10:34:15AM -0400, Michael Santos wrote: > Suppress compiler warnings about ignored return values. Thank you. I have included your patch into 'pu'. -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Tue Jun 7 18:29:14 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:29:14 +0200 Subject: [erlang-patches] Call chmod without the "-f" flag (again) In-Reply-To: <20110605211640.GA27032277@CIS.FU-Berlin.DE> References: <20110605211640.GA27032277@CIS.FU-Berlin.DE> Message-ID: <20110607162914.GD14106@erix.ericsson.se> On Sun, Jun 05, 2011 at 11:16:40PM +0200, Holger Wei? wrote: > Commit 7ed11a88 removed the non-standard "-f" flag from chmod calls in > Makefiles. Meanwhile, new "chmod -f" calls have been added, so this > commit removes the "-f" flag from those new calls: > > git fetch git://github.com/weiss/otp.git update-chmod-without-f Thank you. I have included your patch into 'pu'. -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Tue Jun 7 18:31:23 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:31:23 +0200 Subject: [erlang-patches] Fixes messages handling in percept_db In-Reply-To: References: Message-ID: <20110607163123.GE14106@erix.ericsson.se> On Mon, Jun 06, 2011 at 10:44:56AM +0200, Ahmed Omar wrote: > Fixes some issues with messages in percept_db > > commit 3e8fe28afaf2d78d33dc > > Added demonitor to avoid keeping DOWN message in the queue. Also fixed > a wrong spec in do_start/0. > > > commit 5ba7bf2acdf59cf36dd6: > > > Fixes message handling in select requests. > > percept_db used to send results in an untagged messages, and use a non > selective receive to extract them. When percept is used from the shell > process, this can confuse other messages with the actual result. Added > a tag to the message to be {result, Result}. > > > > git fetch git://github.com/spawnthink/otp.git fix_percept_msgs Thank you. I have included your patch into 'pu', after rewording the commit message. Please see: http://github.com/erlang/otp/wiki/Writing-good-commit-messages * Imperative form * Line break the message * No trailing dot on the summary line -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Tue Jun 7 18:32:04 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:32:04 +0200 Subject: [erlang-patches] [PATCH] ei: integer overflow in string/atom encoding In-Reply-To: <20110606145519.GA2485@ecn.lan> References: <20110606145519.GA2485@ecn.lan> Message-ID: <20110607163204.GF14106@erix.ericsson.se> On Mon, Jun 06, 2011 at 10:55:19AM -0400, Michael Santos wrote: > ei_encode_atom() and ei_encode_string() use strlen() to get the length > of the buffer. As strlen() returns an unsigned long long and both ei > functions take a signed integer, the length fields may overflow. > > Check the results of strlen can be held in a signed integer. Thank you. I have included your patch into 'pu'. -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Tue Jun 7 18:32:18 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:32:18 +0200 Subject: [erlang-patches] Detect the available CPUs on IRIX In-Reply-To: <20110607105142.GA28396954@CIS.FU-Berlin.DE> References: <20110607105142.GA28396954@CIS.FU-Berlin.DE> Message-ID: <20110607163218.GG14106@erix.ericsson.se> On Tue, Jun 07, 2011 at 12:51:42PM +0200, Holger Wei? wrote: > Add support for querying the number of configured and online CPUs on > systems running IRIX: > > git fetch git://github.com/weiss/otp.git detect-cpus-on-irix Thank you. I have included your patch into 'pu', -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From spawn.think@REDACTED Tue Jun 7 18:37:15 2011 From: spawn.think@REDACTED (Ahmed Omar) Date: Tue, 7 Jun 2011 18:37:15 +0200 Subject: [erlang-patches] Fixes messages handling in percept_db In-Reply-To: <20110607163123.GE14106@erix.ericsson.se> References: <20110607163123.GE14106@erix.ericsson.se> Message-ID: Thanks Raimo. Will consider that in the future On Tue, Jun 7, 2011 at 6:31 PM, Raimo Niskanen < raimo+erlang-patches@REDACTED> wrote: > On Mon, Jun 06, 2011 at 10:44:56AM +0200, Ahmed Omar wrote: > > Fixes some issues with messages in percept_db > > > > commit 3e8fe28afaf2d78d33dc > > > > Added demonitor to avoid keeping DOWN message in the queue. Also fixed > > a wrong spec in do_start/0. > > > > > > commit 5ba7bf2acdf59cf36dd6: > > > > > > Fixes message handling in select requests. > > > > percept_db used to send results in an untagged messages, and use a non > > selective receive to extract them. When percept is used from the shell > > process, this can confuse other messages with the actual result. Added > > a tag to the message to be {result, Result}. > > > > > > > > git fetch git://github.com/spawnthink/otp.git fix_percept_msgs > > Thank you. I have included your patch into 'pu', > after rewording the commit message. Please see: > http://github.com/erlang/otp/wiki/Writing-good-commit-messages > > * Imperative form > * Line break the message > * No trailing dot on the summary line > > > -- > > / Raimo Niskanen, Erlang/OTP, Ericsson AB > -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think -------------- next part -------------- An HTML attachment was scrubbed... URL: From egil@REDACTED Tue Jun 7 18:41:33 2011 From: egil@REDACTED (=?ISO-8859-1?Q?Bj=F6rn-Egil_Dahlberg?=) Date: Tue, 7 Jun 2011 18:41:33 +0200 Subject: [erlang-patches] [PATCH] ei: integer overflow in string/atom encoding In-Reply-To: <20110603170325.GB1939@ecn.lan> References: <20110603145857.GA1924@ecn.lan> <19945.2550.221956.792604@pilspetsen.it.uu.se> <20110603170325.GB1939@ecn.lan> Message-ID: <4DEE54BD.7000601@erix.ericsson.se> On 2011-06-03 19:03, Michael Santos wrote: > It would be great to move from signed to unsigned ints but that would > involve an interface change. If that's ok, I'd be happy to make the > changes and update the docs (looks like a few changes in other places > as well, like odbcserver.c). Stuck between a rock and a hard place. I like correct behaviour and I do not like API-changes. However, if a change should be made it should be made to R15A. I also think correctness should trump any other considerations. // Bj?rn-Egil Erlang/OTP From raimo+erlang-patches@REDACTED Tue Jun 7 18:41:59 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Tue, 7 Jun 2011 18:41:59 +0200 Subject: [erlang-patches] What is the preferred method of submitting patches to the list? [was Re: [PATCH] ei: integer overflow in string/atom encoding] In-Reply-To: References: Message-ID: <20110607164159.GH14106@erix.ericsson.se> On Tue, Jun 07, 2011 at 12:11:01PM -0400, Tom Moertel wrote: > On Fri, Jun 3, 2011 at 12:21 PM, Mikael Pettersson wrote: > > > p.s. Thank you for inlining the patch and providing a rationale, most git > > users on this list don't do that which makes peer review difficult. > > > > > > If inline patches are preferred, perhaps the following recommendations > should be revised to say so more clearly: That Mikael likes inline patches is not our official policy. He is in this context a peer himself, although a dear one. We find patches in the form of Git branch references less error prone. Also, one can rather easily navigate to the contributor's github repository and view the commits, not as easy as having the patch in the mail, though. Maybe we should wish for contributors to besides the git fetch command supply a http link to the branch for easier online viewing... Those who do inline patches correct are welcome to do so, but recommending that as the preferred method would render us lots of corrupt patches due to malicious mail clients and whatnot. / Raimo Niskanen, Erlang/OTP, Ericsson AB > > https://github.com/erlang/otp/wiki/submitting-patches > > > Right now, the recommendations on that page begin with the strong suggestion > that the Right Thing is to email a reference to the Git branch that > represents the proposed patches: > > The recommended way of sending patches is described on this page. Basically, > > you push your changes to a git repository and send us an email with a > > reference to your public git repository and branch.... If you send us a > > patch in other ways than described on this page, it will mean more work for > > us and we cannot guarantee anything. It is up to the maintainer for that > > part of OTP to decide whether (s)he will pick up the patch. > > > It is only much later in the document, in the "Sending the patch" section, > that readers learn that inline patches are acceptable at all, but even then > it's only via a parenthetical comment: > > (We also accept *inline* patches compatible with format generated by git > > format-patch, but please make sure that your email client has not garbled > > the message.) > > > > What *is* the preferred method of submitting patches to the list? Inline? > Git fetch command? Some combination of the two? > > Cheers, > Tom > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From egil@REDACTED Tue Jun 7 19:05:10 2011 From: egil@REDACTED (=?ISO-8859-1?Q?Bj=F6rn-Egil_Dahlberg?=) Date: Tue, 7 Jun 2011 19:05:10 +0200 Subject: [erlang-patches] What is the preferred method of submitting patches to the list? [was Re: [PATCH] ei: integer overflow in string/atom encoding] In-Reply-To: <20110607164159.GH14106@erix.ericsson.se> References: <20110607164159.GH14106@erix.ericsson.se> Message-ID: <4DEE5A46.3000809@erix.ericsson.se> On 2011-06-07 18:41, Raimo Niskanen wrote: > On Tue, Jun 07, 2011 at 12:11:01PM -0400, Tom Moertel wrote: >> On Fri, Jun 3, 2011 at 12:21 PM, Mikael Pettersson wrote: >> >>> p.s. Thank you for inlining the patch and providing a rationale, most git >>> users on this list don't do that which makes peer review difficult. >>> >>> >> >> If inline patches are preferred, perhaps the following recommendations >> should be revised to say so more clearly: > > That Mikael likes inline patches is not our official policy. > He is in this context a peer himself, although a dear one. > > We find patches in the form of Git branch references less error prone. > Also, one can rather easily navigate to the contributor's github repository > and view the commits, not as easy as having the patch in the mail, though. > > Maybe we should wish for contributors to besides the git fetch command > supply a http link to the branch for easier online viewing... +1, I would like that. > Those who do inline patches correct are welcome to do so, but > recommending that as the preferred method would render us lots > of corrupt patches due to malicious mail clients and whatnot. I think Mikaels point is well taken. For small patches it is much easier to review a patch via mail then on github and discussions on various issues could easily be done in the mail. Patch notifications should always carry a 'git fetch' entry at the top of the mail. Regards, Bj?rn-Egil Erlang/OTP From tuncer.ayaz@REDACTED Tue Jun 7 19:30:20 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Tue, 7 Jun 2011 19:30:20 +0200 Subject: [erlang-patches] Move fdatasync autoconf checks to proper place Message-ID: git fetch git://github.com/tuncer/otp.git configure_fdatasync https://github.com/tuncer/otp/compare/dev...configure_fdatasync.patch https://github.com/tuncer/otp/compare/dev...configure_fdatasync From joe@REDACTED Tue Jun 7 23:33:25 2011 From: joe@REDACTED (Joe Williams) Date: Tue, 7 Jun 2011 14:33:25 -0700 Subject: [erlang-patches] release_handler_1 improvements Message-ID: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> git fetch git://github.com/joewilliams/otp.git release_handler -------------- next part -------------- An HTML attachment was scrubbed... URL: From raimo+erlang-patches@REDACTED Wed Jun 8 10:56:41 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Wed, 8 Jun 2011 10:56:41 +0200 Subject: [erlang-patches] What is the preferred method of submitting patches to the list? [was Re: [PATCH] ei: integer overflow in string/atom encoding] In-Reply-To: <4DEE5A46.3000809@erix.ericsson.se> References: <20110607164159.GH14106@erix.ericsson.se> <4DEE5A46.3000809@erix.ericsson.se> Message-ID: <20110608085641.GA7170@erix.ericsson.se> On Tue, Jun 07, 2011 at 07:05:10PM +0200, Bj?rn-Egil Dahlberg wrote: > On 2011-06-07 18:41, Raimo Niskanen wrote: : : > > > >Maybe we should wish for contributors to besides the git fetch command > >supply a http link to the branch for easier online viewing... > > +1, I would like that. > > >Those who do inline patches correct are welcome to do so, but > >recommending that as the preferred method would render us lots > >of corrupt patches due to malicious mail clients and whatnot. > > I think Mikaels point is well taken. For small patches it is much easier > to review a patch via mail then on github and discussions on various > issues could easily be done in the mail. > > Patch notifications should always carry a 'git fetch' entry at the top > of the mail. Except for correct inline patches, of course... -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Wed Jun 8 18:10:04 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Wed, 8 Jun 2011 18:10:04 +0200 Subject: [erlang-patches] Move fdatasync autoconf checks to proper place In-Reply-To: References: Message-ID: <20110608161004.GB7170@erix.ericsson.se> On Tue, Jun 07, 2011 at 07:30:20PM +0200, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git configure_fdatasync Thank you. Your patch is included in 'pu'. > > https://github.com/tuncer/otp/compare/dev...configure_fdatasync.patch > https://github.com/tuncer/otp/compare/dev...configure_fdatasync Those were nice ones! What I can not find on Github is something like: dev..configure_fdatasync: * Move fdatasync autoconf checks to proper place http://github.com/tuncer/otp/commit/d18dbf72d504aedcbf4e820ff3626af9d7d39909 * Next commit summary http://github.com/next-commit-content : > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From fdmanana@REDACTED Wed Jun 8 20:23:01 2011 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 8 Jun 2011 19:23:01 +0100 Subject: [erlang-patches] [PATCH] - add NIF function enif_is_number Message-ID: git fetch git://github.com/fdmanana/otp.git enif_is_number Web diff: https://github.com/fdmanana/otp/compare/enif_is_number This is a subset of a patch sent earlier to add NIF functions to operate on big numbers. regards -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From joe@REDACTED Thu Jun 9 00:41:37 2011 From: joe@REDACTED (Joe Williams) Date: Wed, 8 Jun 2011 15:41:37 -0700 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> Message-ID: Any thoughts/feedback on this patch? I realize it doesn't follow the guidelines (https://github.com/erlang/otp/wiki/Submitting-patches) exactly and will clean it up soon. -- Name: Joseph A. Williams Email: joe@REDACTED Blog: http://www.joeandmotorboat.com/ Twitter: http://twitter.com/williamsjoe On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) release_handler > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From raimo+erlang-patches@REDACTED Thu Jun 9 09:11:43 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Thu, 9 Jun 2011 09:11:43 +0200 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> Message-ID: <20110609071143.GB16577@erix.ericsson.se> On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote: > Any thoughts/feedback on this patch? I realize it doesn't follow the guidelines (https://github.com/erlang/otp/wiki/Submitting-patches) exactly and will clean it up soon. Anything in particular? I just got caught up in tideous merge work yesterday and missed to include your patch in 'pu', I was about to take it now. But if you have a cleanup I can wait for it... > > > -- > Name: Joseph A. Williams > Email: joe@REDACTED > Blog: http://www.joeandmotorboat.com/ > Twitter: http://twitter.com/williamsjoe > > > On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) release_handler > > > > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Thu Jun 9 14:14:38 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Thu, 9 Jun 2011 14:14:38 +0200 Subject: [erlang-patches] [PATCH] - add NIF function enif_is_number In-Reply-To: References: Message-ID: <20110609121438.GC16577@erix.ericsson.se> On Wed, Jun 08, 2011 at 07:23:01PM +0100, Filipe David Manana wrote: > git fetch git://github.com/fdmanana/otp.git enif_is_number > > Web diff: https://github.com/fdmanana/otp/compare/enif_is_number > > This is a subset of a patch sent earlier to add NIF functions to > operate on big numbers. Thank you. I will include this patch in 'pu'. > > regards > > -- > Filipe David Manana, > fdmanana@REDACTED, fdmanana@REDACTED > > "Reasonable men adapt themselves to the world. > ?Unreasonable men adapt the world to themselves. > ?That's why all progress depends on unreasonable men." > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From joe@REDACTED Thu Jun 9 16:44:37 2011 From: joe@REDACTED (Joe Williams) Date: Thu, 9 Jun 2011 07:44:37 -0700 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: <20110609071143.GB16577@erix.ericsson.se> References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> <20110609071143.GB16577@erix.ericsson.se> Message-ID: Nothing specific, just wondered if anyone had any thoughts on how I dealt with a couple of corner cases in installing releases. I'll fix things up and get back shortly. -- Name: Joseph A. Williams Email: joe@REDACTED Blog: http://www.joeandmotorboat.com/ Twitter: http://twitter.com/williamsjoe On Thursday, June 9, 2011 at 12:11 AM, Raimo Niskanen wrote: > On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote: > > Any thoughts/feedback on this patch? I realize it doesn't follow the guidelines (https://github.com/erlang/otp/wiki/Submitting-patches) exactly and will clean it up soon. > > Anything in particular? I just got caught up in tideous merge work > yesterday and missed to include your patch in 'pu', I was about > to take it now. > > But if you have a cleanup I can wait for it... > > > > > > > -- > > Name: Joseph A. Williams > > Email: joe@REDACTED (mailto:joe@REDACTED) > > Blog: http://www.joeandmotorboat.com/ > > Twitter: http://twitter.com/williamsjoe > > > > > > On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: > > > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) release_handler > > > _______________________________________________ > > erlang-patches mailing list > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) > > http://erlang.org/mailman/listinfo/erlang-patches > > > -- > > / Raimo Niskanen, Erlang/OTP, Ericsson AB -------------- next part -------------- An HTML attachment was scrubbed... URL: From joe@REDACTED Thu Jun 9 17:20:51 2011 From: joe@REDACTED (Joe Williams) Date: Thu, 9 Jun 2011 08:20:51 -0700 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> <20110609071143.GB16577@erix.ericsson.se> Message-ID: <59BD610D63824C4AABB5673C3688A9FF@joetify.com> Please fetch: git fetch git://github.com/joewilliams/otp.git release_handler_1 This is a different branch with a better commit message and no white space changes. -- Name: Joseph A. Williams Email: joe@REDACTED Blog: http://www.joeandmotorboat.com/ Twitter: http://twitter.com/williamsjoe On Thursday, June 9, 2011 at 7:44 AM, Joe Williams wrote: > Nothing specific, just wondered if anyone had any thoughts on how I dealt with a couple of corner cases in installing releases. > > I'll fix things up and get back shortly. > > -- > Name: Joseph A. Williams > Email: joe@REDACTED (mailto:joe@REDACTED) > Blog: http://www.joeandmotorboat.com/ > Twitter: http://twitter.com/williamsjoe > > > On Thursday, June 9, 2011 at 12:11 AM, Raimo Niskanen wrote: > > > On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote: > > > Any thoughts/feedback on this patch? I realize it doesn't follow the guidelines (https://github.com/erlang/otp/wiki/Submitting-patches) exactly and will clean it up soon. > > > > Anything in particular? I just got caught up in tideous merge work > > yesterday and missed to include your patch in 'pu', I was about > > to take it now. > > > > But if you have a cleanup I can wait for it... > > > > > > > > > > > -- > > > Name: Joseph A. Williams > > > Email: joe@REDACTED (mailto:joe@REDACTED) > > > Blog: http://www.joeandmotorboat.com/ > > > Twitter: http://twitter.com/williamsjoe > > > > > > > > > On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: > > > > > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) (http://github.com/joewilliams/otp.git) release_handler > > > > > _______________________________________________ > > > erlang-patches mailing list > > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) > > > http://erlang.org/mailman/listinfo/erlang-patches > > > > > > -- > > > > / Raimo Niskanen, Erlang/OTP, Ericsson AB > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) > http://erlang.org/mailman/listinfo/erlang-patches -------------- next part -------------- An HTML attachment was scrubbed... URL: From raimo+erlang-patches@REDACTED Fri Jun 10 15:20:46 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Fri, 10 Jun 2011 15:20:46 +0200 Subject: [erlang-patches] Patch to fix compilation on OpenIndiana In-Reply-To: <4DC3BDE8.6050401@erlang.org> References: <4DA5A3FF.6090500@erlang.org> <31720CA3-B0FE-4109-A0B5-5CFD10854E89@gmail.com> <4DA5AD58.1010003@erlang.org> <961F813B-65BF-491F-9349-582A849804B6@gmail.com> <4DB988E0.8020200@erlang.org> <4ACEE2A8-03BB-4D09-A5D3-DF02DAF2F128@gmail.com> <4DC2C56B.9060801@erlang.org> <27585996-CAF4-472A-9175-A865AD5D4A54@gmail.com> <4DC3BDE8.6050401@erlang.org> Message-ID: <20110610132046.GC7170@erix.ericsson.se> Hi - an update. We can not use the patch as it is today since it causes a build error on Solaris 10; uname -a: SunOS fenris 5.10 Generic_142909-17 sun4u sparc SUNW,Sun-Fire-V245 Seems to be a library yet to find by configure... Make log ending: 00350: gcc -o /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/bin/sparc-sun-solaris2.10/beam.smp \ 00351: -m64 obj/sparc-sun-solaris2.10/opt/smp/erl_main.o \ obj/sparc-sun-solaris2.10/opt/smp/preload.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_pbifs.o \ obj/sparc-sun-solaris2.10/opt/smp/benchmark.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_alloc.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_mtrace.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_alloc_util.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_goodfit_alloc.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bestfit_alloc.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_afit_alloc.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_instrument.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_init.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_atom_table.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_table.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_ddll.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_guard.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_info.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_op.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_os.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_lists.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_trace.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_wrap.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_trace.o \ obj/sparc-sun-solaris2.10/opt/smp/copy.o \ obj/sparc-sun-solaris2.10/opt/smp/utils.o \ obj/sparc-sun-solaris2.10/opt/smp/bif.o \ obj/sparc-sun-solaris2.10/opt/smp/io.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_printf_term.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_debug.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_md5.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_message.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_process.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_process_dict.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_process_lock.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_port_task.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_arith.o \ obj/sparc-sun-solaris2.10/opt/smp/time.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_time_sup.o \ obj/sparc-sun-solaris2.10/opt/smp/external.o \ obj/sparc-sun-solaris2.10/opt/smp/dist.o \ obj/sparc-sun-solaris2.10/opt/smp/binary.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_db.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_db_util.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_db_hash.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_db_tree.o \ obj/sparc-sun-solaris2.10/opt/smp/fix_alloc.o \ obj/sparc-sun-solaris2.10/opt/smp/big.o \ obj/sparc-sun-solaris2.10/opt/smp/hash.o \ obj/sparc-sun-solaris2.10/opt/smp/index.o \ obj/sparc-sun-solaris2.10/opt/smp/atom.o \ obj/sparc-sun-solaris2.10/opt/smp/module.o \ obj/sparc-sun-solaris2.10/opt/smp/export.o \ obj/sparc-sun-solaris2.10/opt/smp/register.o \ obj/sparc-sun-solaris2.10/opt/smp/break.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_async.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_lock_check.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_gc.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_lock_count.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_nmgc.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_posix_str.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bits.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_math.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_fun.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_port.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_term.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_node_tables.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_monitors.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_process_dump.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_timer.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_cpu_topology.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_drv_thread.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_chksum.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_re.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_unicode.o \ obj/sparc-sun-solaris2.10/opt/smp/packet_parser.o \ obj/sparc-sun-solaris2.10/opt/smp/safe_hash.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_zlib.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_nif.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_bif_binary.o \ obj/sparc-sun-solaris2.10/opt/smp/beam_emu.o \ obj/sparc-sun-solaris2.10/opt/smp/beam_opcodes.o \ obj/sparc-sun-solaris2.10/opt/smp/beam_load.o \ obj/sparc-sun-solaris2.10/opt/smp/beam_bif_load.o \ obj/sparc-sun-solaris2.10/opt/smp/beam_debug.o \ obj/sparc-sun-solaris2.10/opt/smp/beam_bp.o \ obj/sparc-sun-solaris2.10/opt/smp/beam_catches.o \ obj/sparc-sun-solaris2.10/opt/smp/sys.o \ obj/sparc-sun-solaris2.10/opt/smp/driver_tab.o \ obj/sparc-sun-solaris2.10/opt/smp/unix_efile.o \ obj/sparc-sun-solaris2.10/opt/smp/gzio.o \ obj/sparc-sun-solaris2.10/opt/smp/elib_memmove.o \ obj/sparc-sun-solaris2.10/opt/smp/sys_float.o \ obj/sparc-sun-solaris2.10/opt/smp/sys_time.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_poll.kp.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_check_io.kp.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_poll.nkp.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_check_io.nkp.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_mseg.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_unix_sys_ddll.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_mtrace_sys_wrap.o \ obj/sparc-sun-solaris2.10/opt/smp/erl_sys_common_misc.o \ obj/sparc-sun-solaris2.10/opt/smp/efile_drv.o \ obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o \ obj/sparc-sun-solaris2.10/opt/smp/zlib_drv.o \ obj/sparc-sun-solaris2.10/opt/smp/ram_file_drv.o \ obj/sparc-sun-solaris2.10/opt/smp/ttsl_drv.o \ -ldl -lm -lsocket -lnsl -lcurses -L../lib/internal/sparc-sun-solaris2.10 -lkstat \ /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator/zlib/obj/sparc-sun-solaris2.10/opt/libz.a \ /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator/pcre/obj/sparc-sun-solaris2.10/opt/libepcre.a \ -lethread -lerts_internal_r -lpthread -lkstat -lrt 00352: Undefined first referenced 00353: symbol in file 00354: dlpi_info obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o 00355: dlpi_open obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o 00356: dlpi_get_physaddr obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o 00357: dlpi_close obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o 00358: ld: fatal: Symbol referencing errors. No output written to /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/bin/sparc-sun-solaris2.10/beam.smp 00359: collect2: ld returned 1 exit status 00360: gmake[3]: *** [/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/bin/sparc-sun-solaris2.10/beam.smp] Error 1 00361: gmake[3]: Leaving directory `/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator' 00362: gmake[2]: *** [opt] Error 2 00363: gmake[2]: Leaving directory `/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator' 00364: gmake[1]: *** [smp] Error 2 00365: gmake[1]: Leaving directory `/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts' 00366: gmake: *** [emulator] Error 2 On Fri, May 06, 2011 at 11:22:48AM +0200, Henrik Nord wrote: > Hi Trond! > Here is a more detailed review of the patch > > > On 05/06/2011 11:10 AM, Raimo Niskanen wrote: > > We want the functionality, but we have just deprecated (at least > disrecommended) inet:getiflist/0 and inet:ifget/2. This functionality > should go into inet:getifaddrs/0, but there it will be harder to fit it in. > > We might accept this patch (despite improving a deprecated interface) > to keep as a coding example for later improving inet:getifaddrs/0 > (but would of course prefer to get it right from the start) if > the test inet_SUITE:getif/1, function do_getif/1 that checks if > os:type/0 returns {unix,sunos} and if so does not check for a hardware > address covers this operating system. The test has to be narrowed so it > checks for hardware address when the patch is supposed to work. > I guess os:version() can tell if this is openindiana... > > -- > /Henrik Nord Erlang/OTP > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From raimo+erlang-patches@REDACTED Fri Jun 10 17:51:25 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Fri, 10 Jun 2011 17:51:25 +0200 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: <59BD610D63824C4AABB5673C3688A9FF@joetify.com> References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> <20110609071143.GB16577@erix.ericsson.se> <59BD610D63824C4AABB5673C3688A9FF@joetify.com> Message-ID: <20110610155125.GD7170@erix.ericsson.se> On Thu, Jun 09, 2011 at 08:20:51AM -0700, Joe Williams wrote: > Please fetch: > > git fetch git://github.com/joewilliams/otp.git release_handler_1 > > This is a different branch with a better commit message and no white space changes. Excellent. I will include your patch in 'pu' after rewording the summary line to imperative form. > > > > -- > Name: Joseph A. Williams > Email: joe@REDACTED > Blog: http://www.joeandmotorboat.com/ > Twitter: http://twitter.com/williamsjoe > > > On Thursday, June 9, 2011 at 7:44 AM, Joe Williams wrote: > > > Nothing specific, just wondered if anyone had any thoughts on how I dealt with a couple of corner cases in installing releases. > > > > I'll fix things up and get back shortly. > > > > -- > > Name: Joseph A. Williams > > Email: joe@REDACTED (mailto:joe@REDACTED) > > Blog: http://www.joeandmotorboat.com/ > > Twitter: http://twitter.com/williamsjoe > > > > > > On Thursday, June 9, 2011 at 12:11 AM, Raimo Niskanen wrote: > > > > > On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote: > > > > Any thoughts/feedback on this patch? I realize it doesn't follow the guidelines (https://github.com/erlang/otp/wiki/Submitting-patches) exactly and will clean it up soon. > > > > > > Anything in particular? I just got caught up in tideous merge work > > > yesterday and missed to include your patch in 'pu', I was about > > > to take it now. > > > > > > But if you have a cleanup I can wait for it... > > > > > > > > > > > > > > > -- > > > > Name: Joseph A. Williams > > > > Email: joe@REDACTED (mailto:joe@REDACTED) > > > > Blog: http://www.joeandmotorboat.com/ > > > > Twitter: http://twitter.com/williamsjoe > > > > > > > > > > > > On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: > > > > > > > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) (http://github.com/joewilliams/otp.git) release_handler > > > > > > > _______________________________________________ > > > > erlang-patches mailing list > > > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) > > > > http://erlang.org/mailman/listinfo/erlang-patches > > > > > > > > > -- > > > > > > / Raimo Niskanen, Erlang/OTP, Ericsson AB > > > > _______________________________________________ > > erlang-patches mailing list > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) > > http://erlang.org/mailman/listinfo/erlang-patches > -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From joe@REDACTED Fri Jun 10 17:52:58 2011 From: joe@REDACTED (Joe Williams) Date: Fri, 10 Jun 2011 08:52:58 -0700 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: <20110610155125.GD7170@erix.ericsson.se> References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> <20110609071143.GB16577@erix.ericsson.se> <59BD610D63824C4AABB5673C3688A9FF@joetify.com> <20110610155125.GD7170@erix.ericsson.se> Message-ID: <5599EA2E920D462E9CA899BD7DF1B3E6@joetify.com> Great, thanks! -- Name: Joseph A. Williams Email: joe@REDACTED Blog: http://www.joeandmotorboat.com/ Twitter: http://twitter.com/williamsjoe On Friday, June 10, 2011 at 8:51 AM, Raimo Niskanen wrote: > On Thu, Jun 09, 2011 at 08:20:51AM -0700, Joe Williams wrote: > > Please fetch: > > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) release_handler_1 > > > > This is a different branch with a better commit message and no white space changes. > > Excellent. I will include your patch in 'pu' after rewording the > summary line to imperative form. > > > > > > > > > -- > > Name: Joseph A. Williams > > Email: joe@REDACTED (mailto:joe@REDACTED) > > Blog: http://www.joeandmotorboat.com/ > > Twitter: http://twitter.com/williamsjoe > > > > > > On Thursday, June 9, 2011 at 7:44 AM, Joe Williams wrote: > > > > > Nothing specific, just wondered if anyone had any thoughts on how I dealt with a couple of corner cases in installing releases. > > > > > > I'll fix things up and get back shortly. > > > > > > -- > > > Name: Joseph A. Williams > > > Email: joe@REDACTED (mailto:joe@REDACTED) > > > Blog: http://www.joeandmotorboat.com/ > > > Twitter: http://twitter.com/williamsjoe > > > > > > > > > On Thursday, June 9, 2011 at 12:11 AM, Raimo Niskanen wrote: > > > > > > > On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote: > > > > > Any thoughts/feedback on this patch? I realize it doesn't follow the guidelines (https://github.com/erlang/otp/wiki/Submitting-patches) exactly and will clean it up soon. > > > > > > > > Anything in particular? I just got caught up in tideous merge work > > > > yesterday and missed to include your patch in 'pu', I was about > > > > to take it now. > > > > > > > > But if you have a cleanup I can wait for it... > > > > > > > > > > > > > > > > > > > -- > > > > > Name: Joseph A. Williams > > > > > Email: joe@REDACTED (mailto:joe@REDACTED) > > > > > Blog: http://www.joeandmotorboat.com/ > > > > > Twitter: http://twitter.com/williamsjoe > > > > > > > > > > > > > > > On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: > > > > > > > > > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) (http://github.com/joewilliams/otp.git) release_handler > > > > > > > > > _______________________________________________ > > > > > erlang-patches mailing list > > > > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) > > > > > http://erlang.org/mailman/listinfo/erlang-patches > > > > > > > > > > > > -- > > > > > > > > / Raimo Niskanen, Erlang/OTP, Ericsson AB > > > > > > _______________________________________________ > > > erlang-patches mailing list > > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) > > > http://erlang.org/mailman/listinfo/erlang-patches > > -- > > / Raimo Niskanen, Erlang/OTP, Ericsson AB -------------- next part -------------- An HTML attachment was scrubbed... URL: From raimo+erlang-patches@REDACTED Fri Jun 10 18:02:40 2011 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Fri, 10 Jun 2011 18:02:40 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-06-10) In-Reply-To: <201105311430.p4VEUbfg011829@smaug.otp.ericsson.se> References: <201105311430.p4VEUbfg011829@smaug.otp.ericsson.se> Message-ID: <20110610160240.GE7170@erix.ericsson.se> I'm sorry but this weaks "What's cooking" will be different/delayed. I had to step in for the regular guy and have not quite got the hang of it yet... I have graduated ta/warnings_as_errors and sa/prim-file-fix. New topics are: ta/compile-werr-beam-file ms/epmd-IPv6-node-reg ms/epmd-fix-compiler-warnings hw/update-chmod-without-f ao/fix-percept-msgs ms/ei-int-overflow-in-string-atom-enc hw/detect-cpus-on-irix ta/configure-fdatasync fm/enif_is_number ta/docs-fixes jw/release_handler_1 And tn/inet_drv-fix is stalled because build fails on Solaris 10. I will produce a better report eventually... On Tue, May 31, 2011 at 04:30:39PM +0200, Henrik Nord wrote: > ------------------------------------------------------------ > [Graduated] > > * ta/dragonfly-test_server-config (test_server) (2011-04-22) 1 commit > + Add DragonflyBSD support to test_server (9d8d432) > > * tj/streaming_crypto_functions () (2011-05-06) 0 commits > > ------------------------------------------------------------ > [New topics] > > * cg/fix-constant-logical-operand (erts) (2011-05-24) 1 commit > - Fix use of logical operator && with constant operand instead of bitwise &. (53d1d74) > > * fm/zlib_doc (erts, kernel) (2011-05-31) 1 commit > - Fix doc and spec tags for a few zlib erlang module functions (156827a) > > * hs/odbc-sql_wlongvarchar_support (odbc) (2011-05-04) 1 commit > - Add support for SQL_WLONGVARCHAR (0445b6e) > > * kj/eunit-surefire-fixes (eunit) (2011-05-11) 1 commit > - Generate separate surefire XMLs for each test suite (61621e6) > > * ms/inet-socket-domain-error (erts, kernel) (2011-05-24) 1 commit > - inet: error if fd does not match socket domain (169080d) > > * pg/fix-freebsd-dualcore-detection (erts) (2011-05-21) 1 commit > - Fix bug in FreeBSD topology detection code (a13caa7) > > * pg/fix-hibernate-scheduling-with-hipe (erts) (2011-05-21) 1 commit > - Fix bug related to hibernate and HiPE (clear F_HIBERNATE_SCHED flag) (614c920) > > * rz/add_proplist_type (common_test, dialyzer, edoc, stdlib, test_server) (2011-05-22) 1 commit > - Add a proplist() type (7d8a1f8) > > * sa/prim-file-fix (erts) (2011-05-27) 1 commit > - Replace atom in DRV macro in prim_file with string (1f47084) > > * ta/warnings_as_errors (parsetools) (2011-05-28) 3 commits > - yecc: add warnings_as_errors option (043ad1a) > - leex: add warnings_as_errors option (fb7c707) > - leex: fix typo in leex_SUITE (efc5ce3) > > ------------------------------------------------------------ > [Stalled] > > * bw/efile_exists (erts) (2010-10-07) 1 commit > - prim_file:exists/{1,2} which is lightweight file existence check (7203932) > > Action expected from: Topic author > > * fm/posix-fallocate (erts, kernel) (2011-04-15) 4 commits > - Added missing surrounding if statement (5ec9fab) > - Fixes to file:allocate/2 and respective tests (d0fb479) > - Fix build on Solaris (9b8aecf) > - Added file:allocate/2 (7554dbb) > > Action expected from: Topic author > > * jn/gen_stream (stdlib) (2011-04-15) 2 commits > - Update gen_stream tests to conform with common_test standard (9f50d34) > - Add gen_stream behaviour (3065e10) > > Action expected from: OTP-Team > > * sa/callback-attr (compiler, inets, kernel, orber, otp, stdlib) (2010-06-08) 8 commits > - Add callback specs into 'application' module in kernel (4bca766) > - Add callback specs to tftp module following internet documentation (bba649c) > - Add callback specs to inets_service module following possibly deprecated comments (e41a958) > - Add '-callback' attributes in stdlib's behaviours (d8d94c4) > - Update primary bootstrap (199525a) > - Update the documentation with information on the callback attribute (311a25f) > - Automatically generate 'behaviour_info' function from '-callback' attributes (7c44f16) > - Add '-callback' attribute to language syntax (e8336ff) > > Action expected from: OTP-Team > > * ta/typer-quote-atoms (hipe, typer) (2011-03-20) 1 commit > - Quote atoms if necessary in types (254e21e) > > Action expected from: Hipe-team reviewer > > * vb/shell (erts, kernel, stdlib) (2011-01-21) 6 commits > - Add expandfmt_fun option for io:setopts (f139eab) > - Correct JCL's help indentation (95672fa) > - Handle JCL's "r" command error when no pool started (ba4b196) > - Fix tab expansion in remote shell (e2077cb) > - edlin_expand: fix matches formatting (838b84a) > - Take into account arity len when calculating field's width (ff28c52) > > Action expected from: Topic author > > * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits > . Implement namespace axis (27d791f) > . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) > . Fix processing-instruction(name?) (f05e78b) > . Fix path filters (610df56) > . Support more top-level primary expressions (770d6d9) > . Accumulate comments in element nodes (e5b6b3a) > . Add `default_attrs` option (18584c5) > . Allow whole documents to be returned (aef3dea) > . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) > . Track parents in `#xmlPI` nodes (5095331) > . Set `vsn` field in `#xmlDecl` record (d712331) > . Fix namespace-conformance constraints (e062270) > > Action expected from: Topic author > > * pd/ttb_upgrade (observer) (2011-04-05) 30 commits > . additional tests for ttb module (ee2dabc) > . new tests for ttb module (6f8ec53) > . updated documentation (d39fa78) > . updated OTP tests (dc1af0f) > . (BUGFIX) Error with ip tracing to wrap sets (5082fc8) > . Add onviso_server and cli as an exemplary ttb usage (d5a68df) > . Include logfile name in fetch directory name (45f3302) > . missing files addes (3e759dd) > . dbg-type tracing (ece6a3b) > . Optional handler specification allowed in stop/1 - Allowed optional handler specification in trace/2 (97be5ad) > . Flush file trace port buffers with given frequency (9d4b083) > . Autoresume tracing (7101720) > > > Action expected from: Topic author > ------------------------------------------------------------ > [Cooking] > > * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits > - Avoid crash by skipping compilation_SUITE:on_load/1 (0d913e0) > - Inline less aggressively for native-code compilation (0215ac6) > - Crudely fix return type for the lists:key{search,find,member}/3 (4f48864) > - seq_trace_SUITE: Don't native-compile (3799b17) > - Disable native code if on_load is used (f35872c) > - andor_SUITE: Don't native-compile (a8ab68c) > > This branch contains temporary workarounds to avoid failing test > cases and is never intended to graduate. > > * fm/external_size_2 (erts, hipe) (2011-05-16) 1 commit > - Added erlang:external_size/2 BIF (2f4277a) > > * pr/mnesia_frag_hash (mnesia) (2011-04-27) 2 commits > - add mnesia_frag_hash test (1d6762d) > - Reduce calls to phash in key_to_frag_number (67a20c0) > > * sa/dialyzer-server-loop-fix (dialyzer) (2011-05-03) 1 commit > - Fix server loop detection (3a7af1c) > > * ta/nif-strict-aliasing (erts) (2011-05-10) 2 commits > - erts: use a union to avoid strict aliasing issues (8717b93) > - erts: adapt matrix_nif to R14 erl_nif API changes (97fb95f) > > * ta/nif-variadic-funs (erts) (2011-05-13) 1 commit > - erts: convert variadic nif funs into inline funs (9a1f9b6) > > * ta/sendfile (erts, kernel) (2011-01-13) 1 commit > - Implement file:sendfile (6ae9c14) > > * tn/inet_drv-fix (erts) (2011-04-08) 1 commit > - Use libdlpi to get physical address (e360563) > > ------------------------------------------------------------ > [Dropped] > > > * vs/asn1_long-definite-lenght (asn1) (2011-05-16) 2 commits > . fix while loop reading beyond input buffers memory (c07026e) > . add size check to determine if the calculated length has overflowed the size of the variable used to store it (6ac219a) > > Will be corrected it in a slightly different way by OTP-reviewer > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches -- / Raimo Niskanen, Erlang/OTP, Ericsson AB From tuncer.ayaz@REDACTED Sun Jun 12 21:34:34 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sun, 12 Jun 2011 21:34:34 +0200 Subject: [erlang-patches] parsetools: test that warnings_as_errors doesn't write file Message-ID: git fetch git://github.com/tuncer/otp.git warnings_as_errors https://github.com/tuncer/otp/compare/warnings_as_errors https://github.com/tuncer/otp/compare/warnings_as_errors.patch From trond.norbye@REDACTED Tue Jun 14 14:48:04 2011 From: trond.norbye@REDACTED (Trond Norbye) Date: Tue, 14 Jun 2011 14:48:04 +0200 Subject: [erlang-patches] Patch to fix compilation on OpenIndiana In-Reply-To: <20110610132046.GC7170@erix.ericsson.se> References: <4DA5A3FF.6090500@erlang.org> <31720CA3-B0FE-4109-A0B5-5CFD10854E89@gmail.com> <4DA5AD58.1010003@erlang.org> <961F813B-65BF-491F-9349-582A849804B6@gmail.com> <4DB988E0.8020200@erlang.org> <4ACEE2A8-03BB-4D09-A5D3-DF02DAF2F128@gmail.com> <4DC2C56B.9060801@erlang.org> <27585996-CAF4-472A-9175-A865AD5D4A54@gmail.com> <4DC3BDE8.6050401@erlang.org> <20110610132046.GC7170@erix.ericsson.se> Message-ID: <59F8D040-5532-49D5-A0AC-792D2E8EF6FB@gmail.com> On 10. juni 2011, at 15.20, Raimo Niskanen wrote: > Hi - an update. > > We can not use the patch as it is today since it causes > a build error on Solaris 10; uname -a: > SunOS fenris 5.10 Generic_142909-17 sun4u sparc SUNW,Sun-Fire-V245 > > Seems to be a library yet to find by configure... > According to the manual page for dlpi_open, you should build your program using dlpi with the following command line: cc [ flag ... ] file ... -ldlpi [ library ... ] During configure I'm trying to detect dlpi_open in libdlpi, so we're instructing configure to compile the following program: char dlpi_open (); int main () { return dlpi_open (); } When I try to build this with the Solaris Studio compiler with "cc a.c -ldlpi" everything work as expected, but when I try to run the same with gcc I'm getting: trond@REDACTED:2004> /opt/gcc/bin/gcc a.c -ldlpi ld: warning: file libdladm.so.1: required by /usr/lib/libdlpi.so, not found Undefined first referenced symbol in file dladm_close /usr/lib/libdlpi.so dladm_dev2linkid /usr/lib/libdlpi.so dladm_phys_info /usr/lib/libdlpi.so dladm_walk /usr/lib/libdlpi.so dladm_open /usr/lib/libdlpi.so dladm_parselink /usr/lib/libdlpi.so ld: fatal: symbol referencing errors. No output written to a.out collect2: ld returned 1 exit status If you look at the output from configure you'll see this with: checking for libdlpi.h... yes [ ... cut ...] checking for dlpi_open in -ldlpi... no If you look at /usr/lib/libdlpi.so with "dump -Lv", you'll see that it needs: trond@REDACTED:2010> dump -Lv /usr/lib/libdlpi.so.1 /usr/lib/libdlpi.so.1: **** DYNAMIC SECTION INFORMATION **** .dynamic: [INDEX] Tag Value [1] NEEDED libc.so.1 [2] POSFLAG_1 LAZYLOAD [3] NEEDED libinetutil.so.1 [4] POSFLAG_1 LAZYLOAD [5] NEEDED libdladm.so.1 From looking at the arguments gcc and cc sends to the linker (both use the one in /usr/ccs/bin), gcc don't add /lib. On my System I see that they try to set up the following search paths for the linker: gcc: -Y P,/usr/ccs/lib:/usr/lib cc: -Y P,/opt/solstudio12.2/prod/lib:/usr/ccs/lib:/lib:/usr/lib To me it looks like gcc ignores the run path on the system when it tries to unroll all of the nested dependencies (but I have not checked the source code for gcc or Solaris studio to see how they determine the path or if it is hardcoded ;)). Most of the libraries on the system is installed in both /usr/lib and /lib, but libdladm.so.1 is only installed in /lib. That _shouldn't_ be a problem, because /lib is part of the default runtime path (you may verify this by running crle: Default configuration file (/var/ld/ld.config) not found Platform: 32-bit LSB 80386 Default Library Path (ELF): /lib:/usr/lib (system default) Trusted Directories (ELF): /lib/secure:/usr/lib/secure (system default) ) I would _guess_ that libdladm.so is just a "helper library" for the operating system, because _none_ of the functions it exports are documented... To work around the problem you need to tell gcc (with friends) to search for libraries in /lib as well.. The easiest way is probably to set LD_LIBRARY_PATH=/lib, or create a symbolic link to /lib/libdladm.so.1 from /usr/lib (or perhaps use -L/lib in LDFLAGS?) Trond > Make log ending: > 00350: gcc -o /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/bin/sparc-sun-solaris2.10/beam.smp \ > 00351: -m64 obj/sparc-sun-solaris2.10/opt/smp/erl_main.o \ > obj/sparc-sun-solaris2.10/opt/smp/preload.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_pbifs.o \ > obj/sparc-sun-solaris2.10/opt/smp/benchmark.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_alloc.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_mtrace.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_alloc_util.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_goodfit_alloc.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bestfit_alloc.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_afit_alloc.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_instrument.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_init.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_atom_table.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_table.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_ddll.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_guard.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_info.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_op.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_os.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_lists.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_trace.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_wrap.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_trace.o \ > obj/sparc-sun-solaris2.10/opt/smp/copy.o \ > obj/sparc-sun-solaris2.10/opt/smp/utils.o \ > obj/sparc-sun-solaris2.10/opt/smp/bif.o \ > obj/sparc-sun-solaris2.10/opt/smp/io.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_printf_term.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_debug.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_md5.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_message.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_process.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_process_dict.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_process_lock.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_port_task.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_arith.o \ > obj/sparc-sun-solaris2.10/opt/smp/time.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_time_sup.o \ > obj/sparc-sun-solaris2.10/opt/smp/external.o \ > obj/sparc-sun-solaris2.10/opt/smp/dist.o \ > obj/sparc-sun-solaris2.10/opt/smp/binary.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_db.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_db_util.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_db_hash.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_db_tree.o \ > obj/sparc-sun-solaris2.10/opt/smp/fix_alloc.o \ > obj/sparc-sun-solaris2.10/opt/smp/big.o \ > obj/sparc-sun-solaris2.10/opt/smp/hash.o \ > obj/sparc-sun-solaris2.10/opt/smp/index.o \ > obj/sparc-sun-solaris2.10/opt/smp/atom.o \ > obj/sparc-sun-solaris2.10/opt/smp/module.o \ > obj/sparc-sun-solaris2.10/opt/smp/export.o \ > obj/sparc-sun-solaris2.10/opt/smp/register.o \ > obj/sparc-sun-solaris2.10/opt/smp/break.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_async.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_lock_check.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_gc.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_lock_count.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_nmgc.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_posix_str.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bits.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_math.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_fun.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_port.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_term.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_node_tables.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_monitors.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_process_dump.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_timer.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_cpu_topology.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_drv_thread.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_chksum.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_re.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_unicode.o \ > obj/sparc-sun-solaris2.10/opt/smp/packet_parser.o \ > obj/sparc-sun-solaris2.10/opt/smp/safe_hash.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_zlib.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_nif.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_bif_binary.o \ > obj/sparc-sun-solaris2.10/opt/smp/beam_emu.o \ > obj/sparc-sun-solaris2.10/opt/smp/beam_opcodes.o \ > obj/sparc-sun-solaris2.10/opt/smp/beam_load.o \ > obj/sparc-sun-solaris2.10/opt/smp/beam_bif_load.o \ > obj/sparc-sun-solaris2.10/opt/smp/beam_debug.o \ > obj/sparc-sun-solaris2.10/opt/smp/beam_bp.o \ > obj/sparc-sun-solaris2.10/opt/smp/beam_catches.o \ > obj/sparc-sun-solaris2.10/opt/smp/sys.o \ > obj/sparc-sun-solaris2.10/opt/smp/driver_tab.o \ > obj/sparc-sun-solaris2.10/opt/smp/unix_efile.o \ > obj/sparc-sun-solaris2.10/opt/smp/gzio.o \ > obj/sparc-sun-solaris2.10/opt/smp/elib_memmove.o \ > obj/sparc-sun-solaris2.10/opt/smp/sys_float.o \ > obj/sparc-sun-solaris2.10/opt/smp/sys_time.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_poll.kp.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_check_io.kp.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_poll.nkp.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_check_io.nkp.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_mseg.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_unix_sys_ddll.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_mtrace_sys_wrap.o \ > obj/sparc-sun-solaris2.10/opt/smp/erl_sys_common_misc.o \ > obj/sparc-sun-solaris2.10/opt/smp/efile_drv.o \ > obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o \ > obj/sparc-sun-solaris2.10/opt/smp/zlib_drv.o \ > obj/sparc-sun-solaris2.10/opt/smp/ram_file_drv.o \ > obj/sparc-sun-solaris2.10/opt/smp/ttsl_drv.o \ > -ldl -lm -lsocket -lnsl -lcurses -L../lib/internal/sparc-sun-solaris2.10 -lkstat \ > /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator/zlib/obj/sparc-sun-solaris2.10/opt/libz.a \ > /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator/pcre/obj/sparc-sun-solaris2.10/opt/libepcre.a \ > -lethread -lerts_internal_r -lpthread -lkstat -lrt > 00352: Undefined first referenced > 00353: symbol in file > 00354: dlpi_info obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o > 00355: dlpi_open obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o > 00356: dlpi_get_physaddr obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o > 00357: dlpi_close obj/sparc-sun-solaris2.10/opt/smp/inet_drv.o > 00358: ld: fatal: Symbol referencing errors. No output written to /ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/bin/sparc-sun-solaris2.10/beam.smp > 00359: collect2: ld returned 1 exit status > 00360: gmake[3]: *** [/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/bin/sparc-sun-solaris2.10/beam.smp] Error 1 > 00361: gmake[3]: Leaving directory `/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator' > 00362: gmake[2]: *** [opt] Error 2 > 00363: gmake[2]: Leaving directory `/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts/emulator' > 00364: gmake[1]: *** [smp] Error 2 > 00365: gmake[1]: Leaving directory `/ldisk/daily_build/r14b04_opu_o.2011-06-09_20/otp_src_R14B04/erts' > 00366: gmake: *** [emulator] Error 2 > > > > On Fri, May 06, 2011 at 11:22:48AM +0200, Henrik Nord wrote: >> Hi Trond! >> Here is a more detailed review of the patch >> >> >> On 05/06/2011 11:10 AM, Raimo Niskanen wrote: >> >> We want the functionality, but we have just deprecated (at least >> disrecommended) inet:getiflist/0 and inet:ifget/2. This functionality >> should go into inet:getifaddrs/0, but there it will be harder to fit it in. >> >> We might accept this patch (despite improving a deprecated interface) >> to keep as a coding example for later improving inet:getifaddrs/0 >> (but would of course prefer to get it right from the start) if >> the test inet_SUITE:getif/1, function do_getif/1 that checks if >> os:type/0 returns {unix,sunos} and if so does not check for a hardware >> address covers this operating system. The test has to be narrowed so it >> checks for hardware address when the patch is supposed to work. >> I guess os:version() can tell if this is openindiana... >> >> -- >> /Henrik Nord Erlang/OTP >> >> _______________________________________________ >> erlang-patches mailing list >> erlang-patches@REDACTED >> http://erlang.org/mailman/listinfo/erlang-patches > > -- > > / Raimo Niskanen, Erlang/OTP, Ericsson AB From carlsson.richard@REDACTED Tue Jun 14 16:18:28 2011 From: carlsson.richard@REDACTED (Richard Carlsson) Date: Tue, 14 Jun 2011 16:18:28 +0200 Subject: [erlang-patches] fix include path behaviour in epp Message-ID: <4DF76DB4.5060004@gmail.com> I thought include files were working, after I submitted a patch back in the R11 days, but it turns out I'm an idiot and I had only fixed the most important special case involving include_lib. The following patch makes the Erlang preprocessor behave as is expected of a C-style preprocessor, which is to always look for include files relative to the parent file first, also when includes are nested: git fetch git://github.com/richcarl/otp.git epp-include-path-fix For example, suppose src/foo.erl contains -include("stuff/foo.hrl"), and the preprocessor manages to open src/stuff/foo.hrl (even though this subdirectory is not in the include path passed to the compiler). This works today, because the directory of the source file ("src" in this case) is always passed to the preprocessor. However, suppose src/stuff/foo.hrl contains -include("bar.hrl") and src/stuff/bar.hrl exists. Without this patch, the preprocessor does not know to look for bar.hrl in the directory of foo.hrl, even though that is the first place it _ought_ to look (at least in C programming tradition), so the user has to make sure to explicitly pass "src/stuff" as part of the include path. In some build systems, this can be a royal pain. The patch fixes this, and should arguably not break any build that is not already broken by definition. (It also means that the compiler no longer needs to pass the directory of the main source file as part of the include path, since that is now handled automatically, but that is not part of this patch.) /Richard From henrik@REDACTED Tue Jun 14 17:00:36 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 14 Jun 2011 17:00:36 +0200 Subject: [erlang-patches] fix include path behaviour in epp In-Reply-To: <4DF76DB4.5060004@gmail.com> References: <4DF76DB4.5060004@gmail.com> Message-ID: <4DF77794.3020308@erlang.org> On 06/14/2011 04:18 PM, Richard Carlsson wrote: > I thought include files were working, after I submitted a patch back > in the R11 days, but it turns out I'm an idiot and I had only fixed > the most important special case involving include_lib. > > The following patch makes the Erlang preprocessor behave as is > expected of a C-style preprocessor, which is to always look for > include files relative to the parent file first, also when includes > are nested: > > git fetch git://github.com/richcarl/otp.git epp-include-path-fix > > For example, suppose src/foo.erl contains -include("stuff/foo.hrl"), > and the preprocessor manages to open src/stuff/foo.hrl (even though > this subdirectory is not in the include path passed to the compiler). > This works today, because the directory of the source file ("src" in > this case) is always passed to the preprocessor. > > However, suppose src/stuff/foo.hrl contains -include("bar.hrl") and > src/stuff/bar.hrl exists. Without this patch, the preprocessor does > not know to look for bar.hrl in the directory of foo.hrl, even though > that is the first place it _ought_ to look (at least in C programming > tradition), so the user has to make sure to explicitly pass > "src/stuff" as part of the include path. In some build systems, this > can be a royal pain. The patch fixes this, and should arguably not > break any build that is not already broken by definition. > > (It also means that the compiler no longer needs to pass the directory > of the main source file as part of the include path, since that is now > handled automatically, but that is not part of this patch.) > > /Richard > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Thank you. I have included your patch into 'pu', after rewording the commit message. Please see: http://github.com/erlang/otp/wiki/Writing-good-commit-messages * Imperative form * Line break the message * No trailing dot on the summary line -- /Henrik Nord Erlang/OTP From joe@REDACTED Tue Jun 14 21:26:04 2011 From: joe@REDACTED (Joe Williams) Date: Tue, 14 Jun 2011 12:26:04 -0700 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: <5599EA2E920D462E9CA899BD7DF1B3E6@joetify.com> References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> <20110609071143.GB16577@erix.ericsson.se> <59BD610D63824C4AABB5673C3688A9FF@joetify.com> <20110610155125.GD7170@erix.ericsson.se> <5599EA2E920D462E9CA899BD7DF1B3E6@joetify.com> Message-ID: <6ED9E10797924705B8D252A4593F22E3@joetify.com> Updated this branch, please refetch. git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) release_handler_1 -- Name: Joseph A. Williams Email: joe@REDACTED Blog: http://www.joeandmotorboat.com/ Twitter: http://twitter.com/williamsjoe On Friday, June 10, 2011 at 8:52 AM, Joe Williams wrote: > Great, thanks! > > > -- > Name: Joseph A. Williams > Email: joe@REDACTED (mailto:joe@REDACTED) > Blog: http://www.joeandmotorboat.com/ > Twitter: http://twitter.com/williamsjoe > > > On Friday, June 10, 2011 at 8:51 AM, Raimo Niskanen wrote: > > > On Thu, Jun 09, 2011 at 08:20:51AM -0700, Joe Williams wrote: > > > Please fetch: > > > > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) release_handler_1 > > > > > > This is a different branch with a better commit message and no white space changes. > > > > Excellent. I will include your patch in 'pu' after rewording the > > summary line to imperative form. > > > > > > > > > > > > > > -- > > > Name: Joseph A. Williams > > > Email: joe@REDACTED (mailto:joe@REDACTED) > > > Blog: http://www.joeandmotorboat.com/ > > > Twitter: http://twitter.com/williamsjoe > > > > > > > > > On Thursday, June 9, 2011 at 7:44 AM, Joe Williams wrote: > > > > > > > Nothing specific, just wondered if anyone had any thoughts on how I dealt with a couple of corner cases in installing releases. > > > > > > > > I'll fix things up and get back shortly. > > > > > > > > -- > > > > Name: Joseph A. Williams > > > > Email: joe@REDACTED (mailto:joe@REDACTED) (mailto:joe@REDACTED) > > > > Blog: http://www.joeandmotorboat.com/ > > > > Twitter: http://twitter.com/williamsjoe > > > > > > > > > > > > On Thursday, June 9, 2011 at 12:11 AM, Raimo Niskanen wrote: > > > > > > > > > On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote: > > > > > > Any thoughts/feedback on this patch? I realize it doesn't follow the guidelines (https://github.com/erlang/otp/wiki/Submitting-patches) exactly and will clean it up soon. > > > > > > > > > > Anything in particular? I just got caught up in tideous merge work > > > > > yesterday and missed to include your patch in 'pu', I was about > > > > > to take it now. > > > > > > > > > > But if you have a cleanup I can wait for it... > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Name: Joseph A. Williams > > > > > > Email: joe@REDACTED (mailto:joe@REDACTED) (mailto:joe@REDACTED) > > > > > > Blog: http://www.joeandmotorboat.com/ > > > > > > Twitter: http://twitter.com/williamsjoe > > > > > > > > > > > > > > > > > > On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: > > > > > > > > > > > > > git fetch git://github.com/joewilliams/otp.git (http://github.com/joewilliams/otp.git) (http://github.com/joewilliams/otp.git) (http://github.com/joewilliams/otp.git) release_handler > > > > > > > > > > > _______________________________________________ > > > > > > erlang-patches mailing list > > > > > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) (mailto:erlang-patches@REDACTED) > > > > > > http://erlang.org/mailman/listinfo/erlang-patches > > > > > > > > > > > > > > > -- > > > > > > > > > > / Raimo Niskanen, Erlang/OTP, Ericsson AB > > > > > > > > _______________________________________________ > > > > erlang-patches mailing list > > > > erlang-patches@REDACTED (mailto:erlang-patches@REDACTED) (mailto:erlang-patches@REDACTED) > > > > http://erlang.org/mailman/listinfo/erlang-patches > > > > -- > > > > / Raimo Niskanen, Erlang/OTP, Ericsson AB > -------------- next part -------------- An HTML attachment was scrubbed... URL: From henrik@REDACTED Wed Jun 15 09:57:15 2011 From: henrik@REDACTED (Henrik Nord) Date: Wed, 15 Jun 2011 09:57:15 +0200 Subject: [erlang-patches] release_handler_1 improvements In-Reply-To: <6ED9E10797924705B8D252A4593F22E3@joetify.com> References: <1C74E579B911446FBEFB7DF9D3DDD11A@joetify.com> <20110609071143.GB16577@erix.ericsson.se> <59BD610D63824C4AABB5673C3688A9FF@joetify.com> <20110610155125.GD7170@erix.ericsson.se> <5599EA2E920D462E9CA899BD7DF1B3E6@joetify.com> <6ED9E10797924705B8D252A4593F22E3@joetify.com> Message-ID: <4DF865DB.4050209@erlang.org> On 06/14/2011 09:26 PM, Joe Williams wrote: > Updated this branch, please refetch. > > git fetch git://github.com/joewilliams/otp.git > release_handler_1 > > > -- > Name: Joseph A. Williams > Email: joe@REDACTED > Blog: http://www.joeandmotorboat.com/ > Twitter: http://twitter.com/williamsjoe > > On Friday, June 10, 2011 at 8:52 AM, Joe Williams wrote: > >> Great, thanks! >> >> >> -- >> Name: Joseph A. Williams >> Email: joe@REDACTED >> Blog: http://www.joeandmotorboat.com/ >> Twitter: http://twitter.com/williamsjoe >> >> On Friday, June 10, 2011 at 8:51 AM, Raimo Niskanen wrote: >> >>> On Thu, Jun 09, 2011 at 08:20:51AM -0700, Joe Williams wrote: >>>> Please fetch: >>>> >>>> git fetch git://github.com/joewilliams/otp.git >>>> release_handler_1 >>>> >>>> This is a different branch with a better commit message and no >>>> white space changes. >>> >>> Excellent. I will include your patch in 'pu' after rewording the >>> summary line to imperative form. >>> >>>> >>>> >>>> >>>> -- >>>> Name: Joseph A. Williams >>>> Email: joe@REDACTED >>>> Blog: http://www.joeandmotorboat.com/ >>>> Twitter: http://twitter.com/williamsjoe >>>> >>>> >>>> On Thursday, June 9, 2011 at 7:44 AM, Joe Williams wrote: >>>> >>>>> Nothing specific, just wondered if anyone had any thoughts on how >>>>> I dealt with a couple of corner cases in installing releases. >>>>> >>>>> I'll fix things up and get back shortly. >>>>> >>>>> -- >>>>> Name: Joseph A. Williams >>>>> Email: joe@REDACTED >>>>> (mailto:joe@REDACTED) >>>>> Blog: http://www.joeandmotorboat.com/ >>>>> Twitter: http://twitter.com/williamsjoe >>>>> >>>>> >>>>> On Thursday, June 9, 2011 at 12:11 AM, Raimo Niskanen wrote: >>>>> >>>>>> On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote: >>>>>>> Any thoughts/feedback on this patch? I realize it doesn't follow >>>>>>> the guidelines >>>>>>> (https://github.com/erlang/otp/wiki/Submitting-patches) exactly >>>>>>> and will clean it up soon. >>>>>> >>>>>> Anything in particular? I just got caught up in tideous merge work >>>>>> yesterday and missed to include your patch in 'pu', I was about >>>>>> to take it now. >>>>>> >>>>>> But if you have a cleanup I can wait for it... >>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Name: Joseph A. Williams >>>>>>> Email: joe@REDACTED >>>>>>> (mailto:joe@REDACTED) >>>>>>> Blog: http://www.joeandmotorboat.com/ >>>>>>> Twitter: http://twitter.com/williamsjoe >>>>>>> >>>>>>> >>>>>>> On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote: >>>>>>> >>>>>>>> git fetch git://github.com/joewilliams/otp.git >>>>>>>> >>>>>>>> (http://github.com/joewilliams/otp.git) >>>>>>>> (http://github.com/joewilliams/otp.git) release_handler >>>>>> >>>>>>> _______________________________________________ >>>>>>> erlang-patches mailing list >>>>>>> erlang-patches@REDACTED >>>>>>> (mailto:erlang-patches@REDACTED) >>>>>>> http://erlang.org/mailman/listinfo/erlang-patches >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> / Raimo Niskanen, Erlang/OTP, Ericsson AB >>>>> >>>>> _______________________________________________ >>>>> erlang-patches mailing list >>>>> erlang-patches@REDACTED >>>>> (mailto:erlang-patches@REDACTED) >>>>> http://erlang.org/mailman/listinfo/erlang-patches >>> >>> -- >>> >>> / Raimo Niskanen, Erlang/OTP, Ericsson AB >> > > > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches Refetched! -- /Henrik Nord Erlang/OTP -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthias@REDACTED Sun Jun 19 00:56:18 2011 From: matthias@REDACTED (Matthias Lang) Date: Sun, 19 Jun 2011 00:56:18 +0200 Subject: [erlang-patches] two trivial documentation patches (gen_fsm and Install.md) Message-ID: <20110618225618.GA17721@corelatus.se> Hi, Happened to notice these today. gen_fsm.xml has some spurious > characters in the gen_info docs Install.md misspells 'mentioned'. Matt --- otp_src_R14B03/INSTALL.md.orig 2011-06-18 23:58:18.343855657 +0200 +++ otp_src_R14B03/INSTALL.md 2011-06-19 00:03:29.452575661 +0200 @@ -27,7 +27,7 @@ Binary releases for Windows can be found at . -Before reading the above mensioned documents you are in any case advised to +Before reading the above mentioned documents you are in any case advised to read this document first, since it covers building Erlang/OTP in general as well as other important information. 3/lib/stdlib/doc/src/gen_fsm.xml --- otp_src_R14B03/lib/stdlib/doc/src/gen_fsm.xml.orig 2011-06-18 +23:54:58.829593975 +0200 +++ otp_src_R14B03/lib/stdlib/doc/src/gen_fsm.xml 2011-06-18 +23:55:36.785263210 +0200 @@ -639,9 +639,9 @@ StateName = atom() StateData = term() Result = {next_state,NextStateName,NewStateData} -  > | {next_state,NextStateName,NewStateData,Timeout} -  > | {next_state,NextStateName,NewStateData,hibernate} -  > | {stop,Reason,NewStateData} +   | {next_state,NextStateName,NewStateData,Timeout} +   | {next_state,NextStateName,NewStateData,hibernate} +   | {stop,Reason,NewStateData}  NextStateName = atom()  NewStateData = term()  Timeout = int()>0 | infinity From fdmanana@REDACTED Sun Jun 19 22:22:54 2011 From: fdmanana@REDACTED (Filipe David Manana) Date: Sun, 19 Jun 2011 21:22:54 +0100 Subject: [erlang-patches] [PATCH] - fix send function Packet type in gen_tcp and gen_udp Message-ID: git fetch git://github.com/fdmanana/otp.git gen_tcp_udp_doc_packet_type https://github.com/fdmanana/otp/compare/gen_tcp_udp_doc_packet_type -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From henrik@REDACTED Tue Jun 21 11:23:43 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 21 Jun 2011 11:23:43 +0200 Subject: [erlang-patches] [PATCH] - fix send function Packet type in gen_tcp and gen_udp In-Reply-To: References: Message-ID: <4E00631F.4030806@erlang.org> On 06/19/2011 10:22 PM, Filipe David Manana wrote: > git fetch git://github.com/fdmanana/otp.git gen_tcp_udp_doc_packet_type I have included your patch into 'pu' -- /Henrik Nord Erlang/OTP From fdmanana@REDACTED Tue Jun 21 13:21:47 2011 From: fdmanana@REDACTED (Filipe David Manana) Date: Tue, 21 Jun 2011 12:21:47 +0100 Subject: [erlang-patches] [PATCH] - minor fix in documentation for enif_inspect_iolist_as_binary Message-ID: git fetch git://github.com/fdmanana/otp.git erl_nif_doc_fix -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From henrik@REDACTED Tue Jun 21 16:28:10 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 21 Jun 2011 16:28:10 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-06-21) Message-ID: <201106211428.p5LES8QC025632@smaug.otp.ericsson.se> During the month of July there will only be afew updates to 'pu' due to vacations. So do not be alarmed if your patches will be left unattended for a few weeks, we will be back in full force in August, and we aim to get as much as possible into the R14B04 release. As the last cooking email was done in a slightly different way, there may be some redundancy and or inconsistency in this one. Feel free to let me know if something is missing. ------------------------------------------------------------ [Graduated] * ml/docfix () (2011-06-20) 0 commits * ta/warnings_as_errors (parsetools) (2011-05-28) 3 commits + yecc: add warnings_as_errors option (69a2b05) + leex: add warnings_as_errors option (8f9203c) + leex: fix typo in leex_SUITE (762125d) * sa/prim-file-fix (erts) (2011-05-27) 1 commit . Replace atom in DRV macro in prim_file with string (3ca5c01) ------------------------------------------------------------ [New topics] * ao/fix-percept-msgs (percept) (2011-06-06) 2 commits - Fix message handling in select requests (b8da49b) - Add demonitor to avoid keeping DOWN message in the queue, fix one wrong spec in do_start/0 (db6918d) * fm/enif_is_number (erts) (2011-06-08) 1 commit - Add NIF function enif_is_number (8db78b0) * fm/gen_tcp_udp_doc_packet_type (kernel) (2011-06-19) 1 commit - Fix type of Packet arg of gen_tcp:send/2 and gen_udp:send/4 (042f8da) * hw/detect-cpus-on-irix (erts) (2011-06-07) 1 commit - Detect the available CPUs on IRIX (e68fde9) * hw/update-chmod-without-f (dialyzer, diameter, sasl, snmp, ssh, xmerl) (2011-06-05) 1 commit - Again: Call chmod without the "-f" flag (d0fb46f) * jw/release_handler_1 (sasl) (2011-06-14) 3 commits - catch suspended supervisors (b03c6e1) - catch the errors specifically rather than attempting to pattern match (02d40e2) - General improvements to get_supervised_procs (d02e9d5) * ms/ei-int-overflow-in-string-atom-enc (erl_interface) (2011-06-06) 1 commit - ei: integer overflow in string/atom encoding (9cf9cde) * ms/epmd-IPv6-node-reg (erts, kernel) (2011-06-03) 1 commit - epmd: support IPv6 node registration (5523b21) * ms/epmd-fix-compiler-warnings (erts) (2011-06-03) 1 commit - epmd: fix compiler warnings (b5ff56d) * rc/epp-include-path-fix (stdlib) (2011-06-14) 1 commit - Make Erlang preprocessor check dir of current file first (b5d2469) * ta/configure-fdatasync (erts) (2011-06-13) 2 commits - Document fdatasync -lrt requirement (SunOS <= 5.10) (8f0f462) - Move fdatasync autoconf checks to proper place (8b579a2) * ta/docs-fixes (erts) (2011-05-31) 1 commit - Fix trivial typos in erlang.xml (943c396) * ta/werr_extend_tests (parsetools) (2011-06-12) 1 commit - parsetools: test if warnings_as_errors writes file (dd89b75) ------------------------------------------------------------ [Stalled] * bw/efile_exists (erts) (2010-10-07) 1 commit - prim_file:exists/{1,2} which is lightweight file existence check (7203932) Action expected from: Topic author * fm/posix-fallocate (erts, kernel) (2011-04-15) 4 commits - Added missing surrounding if statement (5ec9fab) - Fixes to file:allocate/2 and respective tests (d0fb479) - Fix build on Solaris (9b8aecf) - Added file:allocate/2 (7554dbb) Action expected from: Topic author * jn/gen_stream (stdlib) (2011-04-15) 2 commits - Update gen_stream tests to conform with common_test standard (9f50d34) - Add gen_stream behaviour (3065e10) Action expected from: OTP-Team * sa/callback-attr (compiler, inets, kernel, orber, otp, stdlib) (2010-06-08) 8 commits - Add callback specs into 'application' module in kernel (4bca766) - Add callback specs to tftp module following internet documentation (bba649c) - Add callback specs to inets_service module following possibly deprecated comments (e41a958) - Add '-callback' attributes in stdlib's behaviours (d8d94c4) - Update primary bootstrap (199525a) - Update the documentation with information on the callback attribute (311a25f) - Automatically generate 'behaviour_info' function from '-callback' attributes (7c44f16) - Add '-callback' attribute to language syntax (e8336ff) Action expected from: OTP-Team * ta/typer-quote-atoms (hipe, typer) (2011-03-20) 1 commit - Quote atoms if necessary in types (254e21e) Action expected from: Hipe-team reviewer * vb/shell (erts, kernel, stdlib) (2011-01-21) 6 commits - Add expandfmt_fun option for io:setopts (f139eab) - Correct JCL's help indentation (95672fa) - Handle JCL's "r" command error when no pool started (ba4b196) - Fix tab expansion in remote shell (e2077cb) - edlin_expand: fix matches formatting (838b84a) - Take into account arity len when calculating field's width (ff28c52) Action expected from: Topic author * nox/xmerl-namespace-axis (xmerl) (2010-12-07) 12 commits . Implement namespace axis (27d791f) . Add `#xmlPI` support to xmerl_xpath:write_node/1 (75e67f5) . Fix processing-instruction(name?) (f05e78b) . Fix path filters (610df56) . Support more top-level primary expressions (770d6d9) . Accumulate comments in element nodes (e5b6b3a) . Add `default_attrs` option (18584c5) . Allow whole documents to be returned (aef3dea) . Track parents and namespace in `#xmlAttribute` nodes (dc9b220) . Track parents in `#xmlPI` nodes (5095331) . Set `vsn` field in `#xmlDecl` record (d712331) . Fix namespace-conformance constraints (e062270) Action expected from: Topic author * pd/ttb_upgrade (observer) (2011-04-05) 30 commits . additional tests for ttb module (ee2dabc) . new tests for ttb module (6f8ec53) . updated documentation (d39fa78) . updated OTP tests (dc1af0f) . (BUGFIX) Error with ip tracing to wrap sets (5082fc8) . Add onviso_server and cli as an exemplary ttb usage (d5a68df) . Include logfile name in fetch directory name (45f3302) . missing files addes (3e759dd) . dbg-type tracing (ece6a3b) . Optional handler specification allowed in stop/1 - Allowed optional handler specification in trace/2 (97be5ad) . Flush file trace port buffers with given frequency (9d4b083) . Autoresume tracing (7101720) Action expected from: Topic author * ta/compile-werr-beam-file (compiler) (2011-06-01) 1 commit . Do not write beam file if Werr and warnings /= [] (850d4c9) Action expected from: OTP-team ------------------------------------------------------------ [Cooking] * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits - Avoid crash by skipping compilation_SUITE:on_load/1 (a8ea623) - Inline less aggressively for native-code compilation (1346686) - Crudely fix return type for the lists:key{search,find,member}/3 (c03a748) - seq_trace_SUITE: Don't native-compile (b8c17a9) - Disable native code if on_load is used (974ee4e) - andor_SUITE: Don't native-compile (86e4df8) This branch contains temporary workarounds to avoid failing test cases and is never intended to graduate. * cg/fix-constant-logical-operand (erts) (2011-05-24) 1 commit - Fix use of logical operator && with constant operand instead of bitwise &. (53d1d74) * fm/external_size_2 (erts, hipe) (2011-05-16) 1 commit - Added erlang:external_size/2 BIF (2f4277a) * hs/odbc-sql_wlongvarchar_support (odbc) (2011-05-04) 1 commit - Add support for SQL_WLONGVARCHAR (0445b6e) * kj/eunit-surefire-fixes (eunit) (2011-05-11) 1 commit - Generate separate surefire XMLs for each test suite (61621e6) * ms/inet-socket-domain-error (erts, kernel) (2011-05-24) 1 commit - inet: error if fd does not match socket domain (169080d) * pg/fix-freebsd-dualcore-detection (erts) (2011-05-21) 1 commit - Fix bug in FreeBSD topology detection code (a13caa7) * pg/fix-hibernate-scheduling-with-hipe (erts) (2011-05-21) 1 commit - Fix bug related to hibernate and HiPE (clear F_HIBERNATE_SCHED flag) (614c920) * pr/mnesia_frag_hash (mnesia) (2011-04-27) 2 commits - add mnesia_frag_hash test (1d6762d) - Reduce calls to phash in key_to_frag_number (67a20c0) * rz/add_proplist_type (common_test, dialyzer, edoc, stdlib, test_server) (2011-05-22) 1 commit - Add a proplist() type (7d8a1f8) * sa/dialyzer-server-loop-fix (dialyzer) (2011-05-03) 1 commit - Fix server loop detection (3a7af1c) * ta/nif-strict-aliasing (erts) (2011-05-10) 2 commits - erts: use a union to avoid strict aliasing issues (8717b93) - erts: adapt matrix_nif to R14 erl_nif API changes (97fb95f) * ta/nif-variadic-funs (erts) (2011-05-13) 1 commit - erts: convert variadic nif funs into inline funs (9a1f9b6) * ta/sendfile (erts, kernel) (2011-06-07) 2 commits - Move sendfile autoconf checks to proper place (ff4f837) - Implement file:sendfile (6ae9c14) * tn/inet_drv-fix (erts) (2011-04-08) 1 commit - Use libdlpi to get physical address (e360563) * fm/zlib_doc (erts, kernel) (2011-05-31) 1 commit . Fix doc and spec tags for a few zlib erlang module functions (8eddbb9) Action expected from: Topic author, rebase * hw/fix-doc-typos (erts) (2011-06-01) 1 commit . Fix typos in the epmd documentation (1750b67) * ml/two-trivial-documentation-fixes (erts) (2011-06-21) 1 commit . Fix trivial documentation errors ------------------------------------------------------------ [Dropped] From henrik@REDACTED Tue Jun 21 17:12:01 2011 From: henrik@REDACTED (Henrik Nord) Date: Tue, 21 Jun 2011 17:12:01 +0200 Subject: [erlang-patches] Add a proplist() type In-Reply-To: References: <4DDA7F15.5090607@gmail.com> Message-ID: <4E00B4C1.9050402@erlang.org> Hi Can you update the commit msg on your commit according to the rules on the wiki? https://github.com/erlang/otp/wiki/Writing-good-commit-messages Summarize clearly in one line what the commit is about Describe the problem the commit solves or the use case for a new feature. Justify why you chose the particular solution. Add a proplist() type Recently I was adding specs to an API and found that there is no canonical proplist() type defined. -- /Henrik Nord Erlang/OTP From tomas.abrahamsson@REDACTED Thu Jun 23 16:53:57 2011 From: tomas.abrahamsson@REDACTED (Tomas Abrahamsson) Date: Thu, 23 Jun 2011 16:53:57 +0200 Subject: [erlang-patches] What's cooking in erlang/otp (2011-06-21) In-Reply-To: <201106211428.p5LES8QC025632@smaug.otp.ericsson.se> References: <201106211428.p5LES8QC025632@smaug.otp.ericsson.se> Message-ID: > [Stalled] > ... > * ta/typer-quote-atoms (hipe, typer) (2011-03-20) 1 commit > ?- Quote atoms if necessary in types (254e21e) > > Action expected from: Hipe-team reviewer Hi, is there any chance of any review for this patch? Here's a link to the patch itself: http://article.gmane.org/gmane.comp.lang.erlang.patches/1996/ The patch fixes quoting of atoms (if needed) when printed by TypEr. It was discovered on R14B02, but the same issue exists with R14B03. (see the link above for a closer description of the issue) BRs Tomas From tuncer.ayaz@REDACTED Thu Jun 23 20:02:15 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Thu, 23 Jun 2011 20:02:15 +0200 Subject: [erlang-patches] snmpc: add warnings_as_errors option Message-ID: git fetch git://github.com/tuncer/otp.git snmpc-werr https://github.com/tuncer/otp/compare/snmpc-werr https://github.com/tuncer/otp/compare/snmpc-werr.patch From tuncer.ayaz@REDACTED Sat Jun 25 17:00:39 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sat, 25 Jun 2011 17:00:39 +0200 Subject: [erlang-patches] asn1ct: add warnings_as_errors option Message-ID: git fetch git://github.com/tuncer/otp.git asn1ct-werr https://github.com/tuncer/otp/compare/asn1ct-werr https://github.com/tuncer/otp/compare/asn1ct-werr.patch From tuncer.ayaz@REDACTED Tue Jun 28 22:33:42 2011 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Tue, 28 Jun 2011 22:33:42 +0200 Subject: [erlang-patches] wx: Fix obsolete guard warning (list/1) Message-ID: git fetch git://github.com/tuncer/otp.git wx-obsolete-guard https://github.com/tuncer/otp/compare/wx-obsolete-guard https://github.com/tuncer/otp/compare/wx-obsolete-guard.patch From henrik@REDACTED Thu Jun 30 10:47:26 2011 From: henrik@REDACTED (Henrik Nord) Date: Thu, 30 Jun 2011 10:47:26 +0200 Subject: [erlang-patches] snmpc: add warnings_as_errors option In-Reply-To: References: Message-ID: <4E0C381E.7090303@erlang.org> On 06/23/2011 08:02 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git snmpc-werr > > https://github.com/tuncer/otp/compare/snmpc-werr > https://github.com/tuncer/otp/compare/snmpc-werr.patch > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches I have included you patch into 'pu' -- /Henrik Nord Erlang/OTP From henrik@REDACTED Thu Jun 30 10:47:46 2011 From: henrik@REDACTED (Henrik Nord) Date: Thu, 30 Jun 2011 10:47:46 +0200 Subject: [erlang-patches] asn1ct: add warnings_as_errors option In-Reply-To: References: Message-ID: <4E0C3832.3070801@erlang.org> On 06/25/2011 05:00 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git asn1ct-werr > > https://github.com/tuncer/otp/compare/asn1ct-werr > https://github.com/tuncer/otp/compare/asn1ct-werr.patch > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches I have included this patch into 'pu' -- /Henrik Nord Erlang/OTP From henrik@REDACTED Thu Jun 30 10:48:05 2011 From: henrik@REDACTED (Henrik Nord) Date: Thu, 30 Jun 2011 10:48:05 +0200 Subject: [erlang-patches] wx: Fix obsolete guard warning (list/1) In-Reply-To: References: Message-ID: <4E0C3845.7040107@erlang.org> On 06/28/2011 10:33 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git wx-obsolete-guard > > https://github.com/tuncer/otp/compare/wx-obsolete-guard > https://github.com/tuncer/otp/compare/wx-obsolete-guard.patch > _______________________________________________ > erlang-patches mailing list > erlang-patches@REDACTED > http://erlang.org/mailman/listinfo/erlang-patches This is now cooking in 'pu' -- /Henrik Nord Erlang/OTP