From tuncer.ayaz@REDACTED Mon Nov 1 01:38:32 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Mon, 1 Nov 2010 01:38:32 +0100 Subject: [erlang-patches] sendfile() In-Reply-To: References: Message-ID: 2010/10/20 Tuncer Ayaz : > 2010/10/20 Bj?rn Gustavsson : >> Refetched. Please refetch. Now also with Windows support using TransmitFile(). From fritchie@REDACTED Mon Nov 1 18:24:55 2010 From: fritchie@REDACTED (Scott Lystig Fritchie) Date: Mon, 01 Nov 2010 12:24:55 -0500 Subject: Patch for configurable ERTS_DE_BUSY_LIMIT In-Reply-To: Message of "Fri, 29 Oct 2010 16:31:27 +0200." <4CCADABF.6070201@erlang.org> Message-ID: <7740.1288632295@snookles.snookles.com> Rickard Green wrote: rg> If so (and no unexpected problems show up in our daily builds), the rg> resulting commit will be merged into dev some time next week. Rickard, the changes look fine, thanks for making them. Plus, it taught me that I didn't need an entry in "atom.names", what a deal. -Scott From billiob@REDACTED Mon Nov 1 22:40:38 2010 From: billiob@REDACTED (Boris 'billiob' Faure) Date: Mon, 1 Nov 2010 22:40:38 +0100 Subject: small fixes on mnesia documentation Message-ID: I've fixed a few issues I encountered while reading the mnesia documentation: some typos and issues with tab character '\011'. You can find those fixes at: git fetch git://github.com/billiob/otp.git mnesia_doc_fixes Best Regards, -- Boris 'billiob' Faure From spawn.think@REDACTED Thu Nov 4 22:38:22 2010 From: spawn.think@REDACTED (Ahmed Omar) Date: Thu, 4 Nov 2010 22:38:22 +0100 Subject: Patch to fix dialyzer expan_files bug Message-ID: git fetch git://github.com/spawnthink/otp.git dialyzer_expand_files_bug Please note that the functionality of expanding the files list is implemented in two different places in dialyzer application. Once in dialyzer_cl and another in dialyzer_analysis_callgraph. dialyzer_cl already pass the files list to dialyzer_analysis_callgraph Which means dialyzer will iterate twice on the list of files in that case. I suggest moving the implementation into once place as an improvement. I can work on that if you agree. -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think From kostis@REDACTED Sat Nov 6 15:59:51 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Sat, 06 Nov 2010 16:59:51 +0200 Subject: dialyzer: Fix pretty rare crashes and an infinite loop Message-ID: <4CD56D67.2000402@cs.ntua.gr> git fetch git://github.com/kostis/otp.git erl_types-fixes Kostis From kostis@REDACTED Sat Nov 6 18:02:15 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Sat, 06 Nov 2010 19:02:15 +0200 Subject: erts/preloaded: Fix erroneous specs Message-ID: <4CD58A17.9060707@cs.ntua.gr> git fetch git://github.com/kostis/otp.git init-spec-fixes Kostis From kostis@REDACTED Sun Nov 7 18:33:22 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Sun, 07 Nov 2010 19:33:22 +0200 Subject: dialyzer: Speed up analysis of nested list comprehensions Message-ID: <4CD6E2E2.606@cs.ntua.gr> git fetch git://github.com/kostis/otp.git dialyzer-fixes Kostis From kostis@REDACTED Tue Nov 9 13:01:15 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Tue, 09 Nov 2010 14:01:15 +0200 Subject: [erlang-patches] Patch to fix dialyzer expan_files bug In-Reply-To: References: Message-ID: <4CD9380B.2080506@cs.ntua.gr> Ahmed Omar wrote: > git fetch git://github.com/spawnthink/otp.git dialyzer_expand_files_bug Thanks for your mail and your patch! I've slightly rewrote the change and incorporated to an existing patch concerning dialyzer, which has not yet been added to 'pu' git fetch git://github.com/kostis/otp.git dialyzer-fixes I suggest to the OTP maintainers to use that version instead. Kostis From kostis@REDACTED Tue Nov 9 14:45:59 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Tue, 09 Nov 2010 15:45:59 +0200 Subject: hipe: Various fixes in types and specs Message-ID: <4CD95097.2050903@cs.ntua.gr> git fetch git://github.com/kostis/otp.git hipe-patches Kostis From bgustavsson@REDACTED Tue Nov 9 14:33:34 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 14:33:34 +0100 Subject: [erlang-patches] [PATCH] Fix two typos in Dialyzer documentation In-Reply-To: <1288380102-10632-1-git-send-email-tuncer.ayaz@gmail.com> References: <1288380102-10632-1-git-send-email-tuncer.ayaz@gmail.com> Message-ID: On Fri, Oct 29, 2010 at 9:21 PM, Tuncer Ayaz wrote: > --- > lib/dialyzer/doc/src/dialyzer.xml | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks! Will include directly in 'dev'. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Tue Nov 9 14:44:08 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 14:44:08 +0100 Subject: [erlang-patches] sendfile() In-Reply-To: References: Message-ID: 2010/11/1 Tuncer Ayaz : > 2010/10/20 Tuncer Ayaz : >> 2010/10/20 Bj?rn Gustavsson : >>> Refetched. > > Please refetch. Now also with Windows support using TransmitFile(). > Refetched. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Tue Nov 9 14:50:37 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 14:50:37 +0100 Subject: [erlang-patches] small fixes on mnesia documentation In-Reply-To: References: Message-ID: On Mon, Nov 1, 2010 at 10:40 PM, Boris 'billiob' Faure wrote: > I've fixed a few issues I encountered while reading the mnesia > documentation: some typos and issues with tab character '\011'. You > can find those fixes at: > git fetch git://github.com/billiob/otp.git mnesia_doc_fixes Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Tue Nov 9 14:54:30 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 14:54:30 +0100 Subject: [erlang-patches] dialyzer: Fix pretty rare crashes and an infinite loop In-Reply-To: <4CD56D67.2000402@cs.ntua.gr> References: <4CD56D67.2000402@cs.ntua.gr> Message-ID: 2010/11/6 Kostis Sagonas : > git fetch git://github.com/kostis/otp.git erl_types-fixes Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Tue Nov 9 14:57:44 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 14:57:44 +0100 Subject: [erlang-patches] erts/preloaded: Fix erroneous specs In-Reply-To: <4CD58A17.9060707@cs.ntua.gr> References: <4CD58A17.9060707@cs.ntua.gr> Message-ID: 2010/11/6 Kostis Sagonas : > git fetch git://github.com/kostis/otp.git init-spec-fixes Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Tue Nov 9 15:00:12 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 15:00:12 +0100 Subject: [erlang-patches] dialyzer: Speed up analysis of nested list comprehensions In-Reply-To: <4CD6E2E2.606@cs.ntua.gr> References: <4CD6E2E2.606@cs.ntua.gr> Message-ID: 2010/11/7 Kostis Sagonas : > git fetch git://github.com/kostis/otp.git dialyzer-fixes Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Tue Nov 9 15:03:05 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 15:03:05 +0100 Subject: [erlang-patches] hipe: Various fixes in types and specs In-Reply-To: <4CD95097.2050903@cs.ntua.gr> References: <4CD95097.2050903@cs.ntua.gr> Message-ID: 2010/11/9 Kostis Sagonas : > git fetch git://github.com/kostis/otp.git hipe-patches Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Tue Nov 9 15:09:45 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Tue, 9 Nov 2010 15:09:45 +0100 Subject: [erlang-patches] Supervisor transient workers restart strategy fix In-Reply-To: References: <638DB44D-BDED-428F-A376-BBA37A1ADEFA@erlang-solutions.com> Message-ID: 2010/10/29 Bj?rn Gustavsson : > On Fri, Oct 29, 2010 at 1:19 PM, Michal Ptaszek > wrote: >> Hi, >> >> we have found the following inconsistency in the supervisor.erl code: >> when supervisor's child restart strategy is set to transient and the child exits with reason shutdown, it is never restarted. >> >> The patches include fix for the issue and the test suite used for reproducing the error, and later, after patching, for verifying the correctness of the code. >> >> The patches are available here: >> git fetch git@REDACTED:paulgray/otp.git >> supervisor_transient_children_fix > > Thanks! Will include in pu. This change breaks mnesia (27 test cases fail). While it might be possible to update mnesia to cope with this change, we suspect that other applications could break as well. Therefore, the patch has been rejected and will be taken out of of pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From spawn.think@REDACTED Tue Nov 9 19:50:02 2010 From: spawn.think@REDACTED (Ahmed Omar) Date: Tue, 9 Nov 2010 19:50:02 +0100 Subject: [erlang-patches] Patch to fix dialyzer expan_files bug In-Reply-To: <4CD9380B.2080506@cs.ntua.gr> References: <4CD9380B.2080506@cs.ntua.gr> Message-ID: can't say no to a neater line of code :) On Tue, Nov 9, 2010 at 1:01 PM, Kostis Sagonas wrote: > Ahmed Omar wrote: > >> git fetch git://github.com/spawnthink/otp.git dialyzer_expand_files_bug >> > > Thanks for your mail and your patch! I've slightly rewrote the change and > incorporated to an existing patch concerning dialyzer, which has not yet > been added to 'pu' > > git fetch git://github.com/kostis/otp.git dialyzer-fixes > > I suggest to the OTP maintainers to use that version instead. > > Kostis > -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think From ulf.wiger@REDACTED Tue Nov 9 22:05:29 2010 From: ulf.wiger@REDACTED (Ulf Wiger) Date: Tue, 9 Nov 2010 14:05:29 -0700 Subject: [erlang-patches] Supervisor transient workers restart strategy fix In-Reply-To: References: <638DB44D-BDED-428F-A376-BBA37A1ADEFA@erlang-solutions.com> Message-ID: Hmm, interesting... :) The documentation for 'supervisor' says: "...a transient child process should be restarted only if it terminates abnormally, i.e. with another exit reason than normal." OTOH, the code has violated* this description at least since R6C-0. Perhaps the documentation should be changed then? But what is the principle implemented exactly? The way it currently works, a child that explicitly exits with reason shutdown (presumably signaling that it doesn't want to restart), it _will_ be restarted if the supervisor is configured for 'permanent' supervision of the child, but not if it's 'transient' supervision. I think this feels wrong and unnecessary, but respect the reluctance to break important code. Perhaps mnesia could be changed so as not to rely on this behaviour, and the supervisor module be corrected after that? So far, the documented principle in Erlang has been that there is exit(normal), and abnormal exits. The main use of the 'shutdown' convention has been (in my mind) to differentiate between a clean coordinated shutdown, and one where the client tried to do something (perhaps important) but failed. * Strictly speaking, it doesn't violate it, since it doesn't say "if and only if". BR, Ulf W On 9 Nov 2010, at 07:09, Bj?rn Gustavsson wrote: > 2010/10/29 Bj?rn Gustavsson : >> On Fri, Oct 29, 2010 at 1:19 PM, Michal Ptaszek >> wrote: >>> Hi, >>> >>> we have found the following inconsistency in the supervisor.erl code: >>> when supervisor's child restart strategy is set to transient and the child exits with reason shutdown, it is never restarted. >>> >>> The patches include fix for the issue and the test suite used for reproducing the error, and later, after patching, for verifying the correctness of the code. >>> >>> The patches are available here: >>> git fetch git@REDACTED:paulgray/otp.git >>> supervisor_transient_children_fix >> >> Thanks! Will include in pu. > > This change breaks mnesia (27 test cases fail). > > While it might be possible to update mnesia to > cope with this change, we suspect that other > applications could break as well. > > Therefore, the patch has been rejected and > will be taken out of of pu. > > -- > Bj?rn Gustavsson, Erlang/OTP, Ericsson AB > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Ulf Wiger, CTO, Erlang Solutions, Ltd. http://erlang-solutions.com From spawn.think@REDACTED Thu Nov 11 14:41:08 2010 From: spawn.think@REDACTED (Ahmed Omar) Date: Thu, 11 Nov 2010 14:41:08 +0100 Subject: mod_auth.xml typos Message-ID: git fetch git://github.com/spawnthink/otp.git mod_auth_doc_typos -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think From aronisstav@REDACTED Thu Nov 11 18:18:30 2010 From: aronisstav@REDACTED (Stavros Aronis) Date: Thu, 11 Nov 2010 19:18:30 +0200 Subject: [erlang-patches] Callback attribute for better definition of behaviour callbacks. Message-ID: I've been doing some work related to this patch and I found a small error. I have fixed it and rebased the whole branch on the current dev. Should I replace my github copy with the new one? If not, the new branch is here: git fetch git@REDACTED:aronisstav/otp.git callback-attr-new Thanks in advance! Stavros Aronis From tuncer.ayaz@REDACTED Thu Nov 11 19:21:01 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Thu, 11 Nov 2010 19:21:01 +0100 Subject: [erlang-patches] Callback attribute for better definition of behaviour callbacks. In-Reply-To: References: Message-ID: On Thu, Nov 11, 2010 at 6:18 PM, Stavros Aronis wrote: > I've been doing some work related to this patch and I found a small > error. I have fixed it and rebased the whole branch on the current > dev. Should I replace my github copy with the new one? Yes. See "Pushing an amended or rebased branch" at https://github.com/erlang/otp/wiki/Refining-patches-using-git > If not, the new branch is here: > > ?git fetch git@REDACTED:aronisstav/otp.git callback-attr-new From aronisstav@REDACTED Thu Nov 11 19:46:28 2010 From: aronisstav@REDACTED (Stavros Aronis) Date: Thu, 11 Nov 2010 20:46:28 +0200 Subject: [erlang-patches] Callback attribute for better definition of behaviour callbacks. Message-ID: Ok, it's done. Thanks for the reply! From kostis@REDACTED Mon Nov 15 14:50:05 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Mon, 15 Nov 2010 15:50:05 +0200 Subject: edoc: Fix dialyzer warnings Message-ID: <4CE13A8D.8080007@cs.ntua.gr> git fetch git://github.com/kostis/otp.git edoc-dialyzer-fixes Kostis From holger@REDACTED Mon Nov 15 16:27:05 2010 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Mon, 15 Nov 2010 16:27:05 +0100 Subject: Allow user to specify the IP address epmd binds to Message-ID: <20101115152705.GB6008624@CIS.FU-Berlin.DE> This adds an epmd option (and an environment variable) to specify the IP address(es) epmd should listen on: git fetch git://github.com/weiss/otp.git epmd-bind-to-address Holger From holger@REDACTED Tue Nov 16 12:47:07 2010 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Tue, 16 Nov 2010 12:47:07 +0100 Subject: Call chmod without the "-f" flag Message-ID: <20101116114707.GC6008624@CIS.FU-Berlin.DE> This fixes "make install" on (at least) IRIX: git fetch git://github.com/weiss/otp.git call-chmod-without-f Holger From michael.santos@REDACTED Tue Nov 16 14:19:11 2010 From: michael.santos@REDACTED (Michael Santos) Date: Tue, 16 Nov 2010 08:19:11 -0500 Subject: [erlang-patches] Allow user to specify the IP address epmd binds to In-Reply-To: <20101115152705.GB6008624@CIS.FU-Berlin.DE> References: <20101115152705.GB6008624@CIS.FU-Berlin.DE> Message-ID: <20101116131911.GB27248@ecn.lan> On Mon, Nov 15, 2010 at 04:27:05PM +0100, Holger Wei? wrote: > This adds an epmd option (and an environment variable) to specify the IP > address(es) epmd should listen on: > > git fetch git://github.com/weiss/otp.git epmd-bind-to-address + char *tmp = malloc(strlen(g->addresses) + 1); + char *token; + int loopback_ok = 0; + + strcpy(tmp,g->addresses); Might want to check if tmp is NULL here and exit if it is. From th.lachmann@REDACTED Tue Nov 16 23:31:08 2010 From: th.lachmann@REDACTED (Thomas Lachmann) Date: Tue, 16 Nov 2010 23:31:08 +0100 Subject: Fix binary:matches/2,3 when called on empty binary Message-ID: <20101116233108.67e4b013@optd.heidelberg.local> Hello, binary:matches doesn't always work as documented, as a consequence binary:replace might misbehave, too. Example: Current behaviour: 1> binary:matches(<<>>, <<"1">>). nomatch 2> binary:replace(<<>>, <<"1">>, <<"2">>, [global]). ** exception error: bad argument in function binary:replace/4 New behaviour: 1> binary:matches(<<>>, <<"1">>). [] 2> binary:replace(<<>>, <<"1">>, <<"2">>, [global]). <<>> Contents of the branch: - Changing a test which assumed binary:matches should return nomatch - Add above example of re:replace/4 as test - Fix source to behave as documented git fetch git://github.com/thlachmann/otp.git binary_matches_fix Regards, Thomas From holger@REDACTED Wed Nov 17 10:11:21 2010 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 17 Nov 2010 10:11:21 +0100 Subject: [erlang-patches] Allow user to specify the IP address epmd binds to In-Reply-To: <20101116131911.GB27248@ecn.lan> References: <20101115152705.GB6008624@CIS.FU-Berlin.DE> <20101116131911.GB27248@ecn.lan> Message-ID: <20101117091121.GD6008624@CIS.FU-Berlin.DE> * Michael Santos [2010-11-16 08:19]: > On Mon, Nov 15, 2010 at 04:27:05PM +0100, Holger Wei? wrote: > > This adds an epmd option (and an environment variable) to specify the IP > > address(es) epmd should listen on: > > > > git fetch git://github.com/weiss/otp.git epmd-bind-to-address > > + char *tmp = malloc(strlen(g->addresses) + 1); > + char *token; > + int loopback_ok = 0; > + > + strcpy(tmp,g->addresses); > > Might want to check if tmp is NULL here and exit if it is. Indeed, I've amended that into the commit. (The reason I didn't do that in the first place is that it's not done in epmd.c either, and my idea was to provide a separate commit which changes all malloc/realloc calls to use simple wrappers which abort on error. However, that's not as completely trivial as I initially thought.) Thanks, Holger From holger@REDACTED Wed Nov 17 11:01:45 2010 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 17 Nov 2010 11:01:45 +0100 Subject: Fix typo in the epmd documentation Message-ID: <20101117100145.GA6595387@CIS.FU-Berlin.DE> This fixes a minor typo (which shows up twice) in the epmd manual: git fetch git://github.com/weiss/otp.git fix-epmd-doc-typo Holger From holger@REDACTED Wed Nov 17 16:45:37 2010 From: holger@REDACTED (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 17 Nov 2010 16:45:37 +0100 Subject: Fix epmd's dbg_perror() output Message-ID: <20101117154537.GE6008624@CIS.FU-Berlin.DE> When epmd prints an error message via dbg_perror(), the dbg_gen_printf() function is supposed to append the error message which corresponds to the current errno value. The following commit fixes the problem that errno has been reset to zero (by erts_snprintf()) before it is used: git fetch git://github.com/weiss/otp.git fix-epmd-perror The problem can easily be reproduced by executing e.g. epmd -port 42 as an unprivileged user. Without the patch, this will spit out something along the lines of: epmd: Wed Nov 17 16:44:22 2010: failed to bind socket: Success Holger From bgustavsson@REDACTED Thu Nov 18 14:24:55 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 14:24:55 +0100 Subject: [erlang-patches] mod_auth.xml typos In-Reply-To: References: Message-ID: On Thu, Nov 11, 2010 at 2:41 PM, Ahmed Omar wrote: > git fetch git://github.com/spawnthink/otp.git mod_auth_doc_typos Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Thu Nov 18 14:40:34 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 14:40:34 +0100 Subject: [erlang-patches] Callback attribute for better definition of behaviour callbacks. In-Reply-To: References: Message-ID: On Thu, Nov 11, 2010 at 7:46 PM, Stavros Aronis wrote: > Ok, it's done. > > Thanks for the reply! Thanks! I will update your branch in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Thu Nov 18 14:47:56 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 14:47:56 +0100 Subject: [erlang-patches] edoc: Fix dialyzer warnings In-Reply-To: <4CE13A8D.8080007@cs.ntua.gr> References: <4CE13A8D.8080007@cs.ntua.gr> Message-ID: 2010/11/15 Kostis Sagonas : > git fetch git://github.com/kostis/otp.git edoc-dialyzer-fixes Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Thu Nov 18 14:54:05 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 14:54:05 +0100 Subject: [erlang-patches] Call chmod without the "-f" flag In-Reply-To: <20101116114707.GC6008624@CIS.FU-Berlin.DE> References: <20101116114707.GC6008624@CIS.FU-Berlin.DE> Message-ID: 2010/11/16 Holger Wei? : > This fixes "make install" on (at least) IRIX: > > git fetch git://github.com/weiss/otp.git call-chmod-without-f Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Thu Nov 18 15:31:14 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 15:31:14 +0100 Subject: [erlang-patches] Fix binary:matches/2,3 when called on empty binary In-Reply-To: <20101116233108.67e4b013@optd.heidelberg.local> References: <20101116233108.67e4b013@optd.heidelberg.local> Message-ID: On Tue, Nov 16, 2010 at 11:31 PM, Thomas Lachmann wrote: > > Hello, > binary:matches doesn't always work as documented, as a consequence > binary:replace might misbehave, too. Thanks! Reading only your commit messages (ignoring the information in your email), I can't understand why this patch is useful and what problem it fixes. Also, it seems it would be better to combine the three commits to one. Here is our guidelines for writing good commit messages: https://github.com/erlang/otp/wiki/Writing-good-commit-messages -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Thu Nov 18 16:10:09 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 16:10:09 +0100 Subject: [erlang-patches] Allow user to specify the IP address epmd binds to In-Reply-To: <20101115152705.GB6008624@CIS.FU-Berlin.DE> References: <20101115152705.GB6008624@CIS.FU-Berlin.DE> Message-ID: 2010/11/15 Holger Wei? : > This adds an epmd option (and an environment variable) to specify the IP > address(es) epmd should listen on: > > git fetch git://github.com/weiss/otp.git epmd-bind-to-address Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Thu Nov 18 16:12:58 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 16:12:58 +0100 Subject: [erlang-patches] Fix typo in the epmd documentation In-Reply-To: <20101117100145.GA6595387@CIS.FU-Berlin.DE> References: <20101117100145.GA6595387@CIS.FU-Berlin.DE> Message-ID: 2010/11/17 Holger Wei? : > This fixes a minor typo (which shows up twice) in the epmd manual: > > git fetch git://github.com/weiss/otp.git fix-epmd-doc-typo > Thanks! I will include correction in the 'dev' branch. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Thu Nov 18 16:21:51 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Thu, 18 Nov 2010 16:21:51 +0100 Subject: [erlang-patches] Fix epmd's dbg_perror() output In-Reply-To: <20101117154537.GE6008624@CIS.FU-Berlin.DE> References: <20101117154537.GE6008624@CIS.FU-Berlin.DE> Message-ID: 2010/11/17 Holger Wei? : > When epmd prints an error message via dbg_perror(), the dbg_gen_printf() > function is supposed to append the error message which corresponds to > the current errno value. The following commit fixes the problem that > errno has been reset to zero (by erts_snprintf()) before it is used: > > git fetch git://github.com/weiss/otp.git fix-epmd-perror Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From kostis@REDACTED Thu Nov 18 16:32:40 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Thu, 18 Nov 2010 17:32:40 +0200 Subject: asn1: shut off dialyzer warnings Message-ID: <4CE54718.5090303@cs.ntua.gr> git fetch git://github.com/kostis/otp.git asn1-dialyzer-fixes Kostis From th.lachmann@REDACTED Thu Nov 18 18:44:13 2010 From: th.lachmann@REDACTED (Thomas Lachmann) Date: Thu, 18 Nov 2010 18:44:13 +0100 Subject: [erlang-patches] Fix binary:matches/2,3 when called on empty binary In-Reply-To: References: <20101116233108.67e4b013@optd.heidelberg.local> Message-ID: <20101118184413.59ad0aa6@optd.heidelberg.local> > Reading only your commit messages (ignoring the information in > your email), I can't understand why this patch is useful and what > problem it fixes. Also, it seems it would be better to combine the > three commits to one. > > Here is our guidelines for writing good commit messages: > > https://github.com/erlang/otp/wiki/Writing-good-commit-messages > Okay, I combined the three patches into one and tried to write a better commit message. git fetch git://github.com/thlachmann/otp.git fix_binary_matches I hope this version is better? Regards, Thomas From bgustavsson@REDACTED Mon Nov 22 15:33:58 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Mon, 22 Nov 2010 15:33:58 +0100 Subject: [erlang-patches] asn1: shut off dialyzer warnings In-Reply-To: <4CE54718.5090303@cs.ntua.gr> References: <4CE54718.5090303@cs.ntua.gr> Message-ID: 2010/11/18 Kostis Sagonas : > git fetch git://github.com/kostis/otp.git asn1-dialyzer-fixes Thanks! Will include in pu. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Mon Nov 22 15:55:42 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Mon, 22 Nov 2010 15:55:42 +0100 Subject: [erlang-patches] Fix binary:matches/2,3 when called on empty binary In-Reply-To: <20101118184413.59ad0aa6@optd.heidelberg.local> References: <20101116233108.67e4b013@optd.heidelberg.local> <20101118184413.59ad0aa6@optd.heidelberg.local> Message-ID: 2010/11/18 Thomas Lachmann : >> Here is our guidelines for writing good commit messages: >> >> https://github.com/erlang/otp/wiki/Writing-good-commit-messages >> > > Okay, I combined the three patches into one and tried to write a better > commit message. > > git fetch git://github.com/thlachmann/otp.git fix_binary_matches > > I hope this version is better? Thanks! That is better. However, the maintainer of the binary module (and the reviewer of your patch) informed me that has already fixed the bug (in a branch that will be included in R14B01 but has not been merged to dev yet). -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From bgustavsson@REDACTED Mon Nov 22 16:38:38 2010 From: bgustavsson@REDACTED (=?UTF-8?Q?Bj=C3=B6rn_Gustavsson?=) Date: Mon, 22 Nov 2010 16:38:38 +0100 Subject: What's cooking in erlang/otp (2010-11-22) Message-ID: The next release will be R14B01, expected to be released December 8. Feature branches sent in from now on are unlikely to be included in R14B01. Bug fixes may still make it, depending on the application, the severity of the bug, and how unlikely the bug fix is to break something. We will try to review and include into the R14B01 release some more of the branches currently in 'pu'. ------------------------------------------------------------ [Graduated] * ao/mod_auth-doc-typos (inets) (2010-11-11) 1 commit + Fix escaped xml character and a missing closing tag in mod_auth.xml (0709e6e) * bf/mnesia-doc-fixes (mnesia) (2010-11-01) 3 commits + doc: "works like" instead of "works as" + missing like (4e0a65b) + remove '\011' from mnesia doc (0d66208) + fix typo in mnesia doc (61b173e) * ks/dialyzer-fixes (dialyzer) (2010-11-07) 1 commit + dialyzer: Speed up analysis of nested list comprehensions (5c1dd79) * ks/edoc-dialyzer-fixes (edoc) (2010-11-15) 1 commit + Fix various dialyzer warnings (e1f67dd) * ks/erl_types-fixes (dialyzer, hipe) (2010-11-06) 1 commit + erl_types: Fix pretty rare crashes and an infinite loop (5c59d90) * ks/file_open-mode (hipe, kernel, stdlib) (2010-10-12) 1 commit + Add the {encoding, _} options to file:open/2's modes (6751329) * ks/hipe-patches (hipe) (2010-11-09) 1 commit + hipe: Update types and specs (6083a1a) * ks/init-spec-fixes (erts) (2010-11-06) 1 commit + init: Fix two erroneous specs (ef0fbe0) * ml/re-manpage-cleanup (stdlib) (2010-10-29) 1 commit + Improve the 're' manpage by correcting typos and rewording (278ab91) * ms/ei-fix-node-name-overflow (erl_interface) (2010-10-24) 1 commit + ei: check the length of the node name (cea0698) * ms/ei-fixes (erl_interface) (2010-10-28) 2 commits + ei: check memory was allocated (9dae2c9) + ei: error if return value of ei_alloc_big is NULL (3a1c680) * pg/fix-system_info-cpu_topology-segfault (erts) (2010-10-02) 1 commit + Fix crash with erlang:system_info({cpu_topology,junk}) (f8201e5) * pg/freebsd-cpu-affinity-and-topology (erts) (2010-10-03) 1 commit + Add support for CPU affinity & topology detection on FreeBSD 8 (667409a) * sf/erts_de_busy_limit (erts) (2010-10-22) 1 commit + Add flag-based setting for the distribution buffer busy limit (8faf174) * ta/fix-ethread-void-return (erts) (2010-10-29) 1 commit + ethread: do not return from void ethr_atomic_set_relb (5ca6bc6) ------------------------------------------------------------ [New topics] * hw/call-chmod-without-f (asn1, common_test, compiler, cosFileTransfer, crypto, debugger, docbuilder, edoc, erl_interface, erts, et, inets, inviso, kernel, megaco, mnesia, orber, parsetools, percept, public_key, reltool, runtime_tools, snmp, ssl, stdlib, syntax_tools, test_server, tools) (2010-11-15) 1 commit - Call chmod without the "-f" flag (7ed11a8) * hw/epmd-bind-to-address (erts) (2010-11-10) 1 commit - Allow user to specify the IP address epmd binds to (bcf3b3d) * hw/fix-epmd-perror (erts) (2010-11-13) 1 commit - Fix epmd's dbg_perror() output (b363d7d) * ks/asn1-dialyzer-fixes (asn1) (2010-11-18) 1 commit - Shut off some dialyzer warnings (508a6d2) ------------------------------------------------------------ [Stalled] * dc/update-INSTALL-WIN32.md (otp) (2010-09-19) 1 commit - Doc update to latest dependencies & how to compile with free VS2008 Express (8e8061c) Waiting for an update by the topic author. * jn/gen_stream (stdlib) (2010-09-05) 5 commits - Use erlang:process_info(Pid, links) to determine if gen_stream managed worker processes are leaked (b2386df) - Move gen_stream internal process test to after termination of gen_stream parent (f1d8a97) - Add calls to code loader in every test to verify code loader still running (ac6cbba) - Track gen_stream processes directly for accurate test results (38a4083) - Patch dev to reproduce jn/gen_stream (7694a74) . Add new gen_stream behaviour for efficiently consuming serial streams (65f3db8) This topic branch has a failing test case: shell_SUITE:start_restricted_from_shell; We have now tested with and without this topic branch and when it is present that test case fails. We consider it proved to be guilty. The test case does not fail when run standalone so it seems to be tricky... Also, some of its own test cases fail sporadicly. Action expected from: Topic author. * jp/dependencies_makefile (compiler, erts) (2009-12-14) 1 commit - Add dependencies Makefile generation to erlc(1) and compile(3) (4945add) Approved in principle by the OTP Technical Board; now awaits a closer review of the implementation. Action expected from: Bj?rn Gustavsson (the reviewer) ------------------------------------------------------------ [Cooking] * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits - Avoid crash by skipping compilation_SUITE:on_load/1 (8592a02) - Inline less aggressively for native-code compilation (e699ad4) - Crudely fix return type for the lists:key{search,find,member}/3 (2b72202) - seq_trace_SUITE: Don't native-compile (2712344) - Disable native code if on_load is used (e8d0ea4) - andor_SUITE: Don't native-compile (e25ef8c) This branch contains temporary workarounds to avoid failing test cases and is never intended to graduate. * bw/efile_exists (erts) (2010-10-07) 1 commit - prim_file:exists/{1,2} which is lightweight file existence check (7203932) * bw/gitignore (otp) (2010-10-05) 1 commit - Add win32 specific build artifacts to .gitignore (834cd98) * bw/tv-render-fix (tv) (2010-10-06) 1 commit - tv: Allow table viewer to display refs, ports and small binaries (5eff630) * bw/win32-file-linking (erts) (2010-10-04) 1 commit - Add Win32 support for hard and symbolic file system links (1f6d7c8) * bw/win32-laa (erts) (2010-10-06) 1 commit - Added win32 large address aware link option (8bb6f48) * cg/fix-prng (stdlib) (2010-10-06) 1 commit - Fix a bug in the implementation of the pseudo-random number generator (863ec4d) * fm/httpc-upload-body-streaming (inets) (2010-10-05) 2 commits - httpc: add option to do automatic chunked transfer-encoding (6951ed1) - httpc: allow streaming of PUT and POST request bodies (f9ec3cb) * gc/gen-format-status-improvements (stdlib) (2010-06-12) 1 commit - Fix format_status bug for unregistered gen_event processes (95ed86f) * jf/run_erl-disable-flow-control (erts) (2010-03-05) 1 commit - Teach run_erl RUN_ERL_DISABLE_FLOWCNTRL for disabling flow control (d0775cd) * jr/windows-file-append (erts) (2010-09-30) 1 commit - Fix appending to large files (>4GB) on Windows (6aae439) * km/pool_connect-to-running-nodes (stdlib) (2010-09-02) 1 commit - Change pool module to attempt to attach to nodes that are already running (a9f4cbc) * mh/dialyzer-full-path-option (dialyzer) (2010-09-15) 1 commit - Dialyzer: add --fullpath option for printing full paths in warnings (3703ea6) * ml/add-os-pid-to-port-info (erts) (2010-08-19) 1 commit - Extend erlang:port_info/1,2 to show the OS pid of a spawned process (b2d85bf) * pg/des-cfb-functions (crypto) (2010-10-16) 1 commit - Add DES and Triple DES cipher feedback (CFB) mode functions (2c79ae7) * pg/fix-hibernate-with-hipe (erts, otp) (2010-09-27) 1 commit - Fix several bugs related to hibernate/3 and HiPE (babd761) * pg/honor-start-type-in-rel-files (sasl) (2010-06-06) 1 commit - Honor start type in .rel files when building relup files (7599900) * sa/callback-attr (compiler, inets, kernel, otp, stdlib) (2010-06-08) 7 commits - Add callback specs into 'application' module in kernel (87d4f70) - Add callback specs to tftp module following internet documentation (2ac8ea7) - Add callback specs to inets_service module following possibly deprecated comments (58a362d) - Add '-callback' attributes in stdlib's behaviours (4a64017) - Update primary bootstrap (d0e761a) - Automatically generate 'behaviour_info' function from '-callback' attributes (991da40) - Add '-callback' attribute to language syntax (d5cba37) * sb/make-files-like-erlc (tools) (2010-05-18) 1 commit - Change make:files to behave more like erlc (5e9d051) * sg/fix-diskless-booted-relup (sasl) (2010-09-19) 1 commit - Remove traces of release_handler reading from filesystem when it has Masters list (54cb5df) * sv/epmd-check-listen (erts) (2010-07-14) 1 commit - check return value of epmd server listen() call (c5c8baa) * ta/asn1-reporting (asn1) (2010-04-23) 1 commit - asn1ct: Make formatting of errors and warnings consistent (93face2) * ta/ensure-dot-ssh-exists (ssh) (2010-09-02) 1 commit - ssh: ensure ~/.ssh exists (2c14d90) * ta/fix-native-looping (kernel) (2010-10-04) 1 commit - error_handler: add no_native compiler directive (fb5e332) * ta/sendfile (erts, kernel) (2010-09-06) 1 commit - Implement file:sendfile (c652dda) * ts/cover-with-export_all (tools) (2010-09-23) 1 commit - add user specified compiler options on form reloading (eb02beb) * uw/xmerl-expand-simple (xmerl) (2010-10-25) 1 commit - Track parents when expanding #xmlElement records (9f4c1ee) ------------------------------------------------------------ [Dropped] * mp/supervisor-transient-children-fix (stdlib) (2010-10-29) 1 commit . Fix supervisor's transient children restart strategy (c70c6fc) Not backwards compatible. Breaks mnesia and possibly other applications. -- Bj?rn Gustavsson, Erlang/OTP, Ericsson AB From aronisstav@REDACTED Mon Nov 22 19:24:23 2010 From: aronisstav@REDACTED (Stavros Aronis) Date: Mon, 22 Nov 2010 20:24:23 +0200 Subject: Fix a minor typo in Dialyzer Message-ID: I found a minor typo in Dialyzer's warnings about opaque term usage and fixed it in this patch. git fetch git://github.com/aronisstav/otp.git Stavros Aronis From aronisstav@REDACTED Mon Nov 22 19:30:05 2010 From: aronisstav@REDACTED (Stavros Aronis) Date: Mon, 22 Nov 2010 20:30:05 +0200 Subject: Fix a minor typo in Dialyzer Message-ID: Sorry, forgot to fill-in the branch... git fetch fix-dialyzer-typo git://github.com/aronisstav/otp.git Stavros Aronis From michael.santos@REDACTED Thu Nov 25 01:35:46 2010 From: michael.santos@REDACTED (Michael Santos) Date: Wed, 24 Nov 2010 19:35:46 -0500 Subject: [PATCH] array: prevent crash Message-ID: <20101125003546.GA26430@ecn.lan> Add a guard to avoid an infinite loop if a float or negative integer is used in the record. --- lib/stdlib/src/array.erl | 12 ++++++++---- lib/stdlib/test/array_SUITE.erl | 8 ++++++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/lib/stdlib/src/array.erl b/lib/stdlib/src/array.erl index 83576c9..72bd977 100644 --- a/lib/stdlib/src/array.erl +++ b/lib/stdlib/src/array.erl @@ -766,7 +766,7 @@ set_get_test_() -> to_list(#array{size = 0}) -> []; -to_list(#array{size = N, elements = E, default = D}) -> +to_list(#array{size = N, elements = E, default = D}) when is_integer(N), N >= 0 -> to_list_1(E, D, N - 1); to_list(_) -> erlang:error(badarg). @@ -826,7 +826,9 @@ to_list_test_() -> to_list(set(N0+1,1,set(0,1,new({default,0}))))), ?_assert([1|lists:duplicate(N0*3,0)++[1]] =:= to_list(set((N0*3)+1,1,set(0,1,new({default,0}))))), - ?_assertError(badarg, to_list(no_array)) + ?_assertError(badarg, to_list(no_array)), + ?_assertError(badarg, to_list(#array{size = -1, elements = 0})), + ?_assertError(badarg, to_list(#array{size = 1.1, elements = 0})) ]. -endif. @@ -1021,7 +1023,7 @@ from_list_test_() -> to_orddict(#array{size = 0}) -> []; -to_orddict(#array{size = N, elements = E, default = D}) -> +to_orddict(#array{size = N, elements = E, default = D}) when is_integer(N), N >= 0 -> I = N - 1, to_orddict_1(E, I, D, I); to_orddict(_) -> @@ -1099,7 +1101,9 @@ to_orddict_test_() -> [{N0*2+1,1} | [{N,undefined}||N<-lists:seq(N0*2+2,N0*10)]] ++ [{N0*10+1,2}] =:= to_orddict(set(N0*10+1,2,set(N0*2+1,1,set(0,0,new()))))), - ?_assertError(badarg, to_orddict(no_array)) + ?_assertError(badarg, to_orddict(no_array)), + ?_assertError(badarg, to_orddict(#array{size = -1, elements = 0})), + ?_assertError(badarg, to_orddict(#array{size = 1.1, elements = 0})) ]. -endif. diff --git a/lib/stdlib/test/array_SUITE.erl b/lib/stdlib/test/array_SUITE.erl index e7cfc65..0a93dac 100644 --- a/lib/stdlib/test/array_SUITE.erl +++ b/lib/stdlib/test/array_SUITE.erl @@ -416,7 +416,9 @@ to_list_test_() -> to_list(set(N0+1,1,set(0,1,new({default,0}))))), ?_assert([1|lists:duplicate(N0*3,0)++[1]] =:= to_list(set((N0*3)+1,1,set(0,1,new({default,0}))))), - ?_assertError(badarg, to_list(no_array)) + ?_assertError(badarg, to_list(no_array)), + ?_assertError(badarg, to_list(#array{size = -1, elements = 0})), + ?_assertError(badarg, to_list(#array{size = 1.1, elements = 0})) ]. sparse_to_list_test_() -> @@ -488,7 +490,9 @@ to_orddict_test_() -> [{N0*2+1,1} | [{N,undefined}||N<-lists:seq(N0*2+2,N0*10)]] ++ [{N0*10+1,2}] =:= to_orddict(set(N0*10+1,2,set(N0*2+1,1,set(0,0,new()))))), - ?_assertError(badarg, to_orddict(no_array)) + ?_assertError(badarg, to_orddict(no_array)), + ?_assertError(badarg, to_orddict(#array{size = -1, elements = 0})), + ?_assertError(badarg, to_orddict(#array{size = 1.1, elements = 0})) ]. sparse_to_orddict_test_() -> -- 1.7.0.4 From michael.santos@REDACTED Thu Nov 25 01:38:04 2010 From: michael.santos@REDACTED (Michael Santos) Date: Wed, 24 Nov 2010 19:38:04 -0500 Subject: [PATCH] epmd: include host address in local access check Message-ID: <20101125003804.GA26451@ecn.lan> In FreeBSD jails, the source and destination address of connections to localhost are changed to be the IP address of the jail. Consider connections from the host's IP address to itself (e.g., the source and destination address match) to be local for the access control checks. Reported-By: tom@REDACTED --- erts/epmd/src/epmd_srv.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/erts/epmd/src/epmd_srv.c b/erts/epmd/src/epmd_srv.c index ef471a4..ace736b 100644 --- a/erts/epmd/src/epmd_srv.c +++ b/erts/epmd/src/epmd_srv.c @@ -736,6 +736,7 @@ static int conn_open(EpmdVars *g,int fd) for (i = 0; i < g->max_conn; i++) { if (g->conn[i].open == EPMD_FALSE) { struct sockaddr_in si; + struct sockaddr_in di; #ifdef HAVE_SOCKLEN_T socklen_t st; #else @@ -756,12 +757,16 @@ static int conn_open(EpmdVars *g,int fd) /* Determine if connection is from localhost */ if (getpeername(s->fd,(struct sockaddr*) &si,&st) || st < sizeof(si)) { - /* Failure to get peername is regarder as non local host */ + /* Failure to get peername is regarded as non local host */ s->local_peer = EPMD_FALSE; } else { + /* Only 127.x.x.x and connections from the host's IP address + allowed, no false positives */ s->local_peer = - ((((unsigned) ntohl(si.sin_addr.s_addr)) & 0xFF000000U) == - 0x7F000000U); /* Only 127.x.x.x allowed, no false positives */ + (((((unsigned) ntohl(si.sin_addr.s_addr)) & 0xFF000000U) == + 0x7F000000U) || + (getsockname(s->fd,(struct sockaddr*) &di,&st) ? + EPMD_FALSE : si.sin_addr.s_addr == di.sin_addr.s_addr)); } dbg_tty_printf(g,2,(s->local_peer) ? "Local peer connected" : "Non-local peer connected"); -- 1.7.0.4 From michael.santos@REDACTED Thu Nov 25 15:09:13 2010 From: michael.santos@REDACTED (Michael Santos) Date: Thu, 25 Nov 2010 09:09:13 -0500 Subject: [erlang-patches] [PATCH] array: prevent crash In-Reply-To: <4CEE1E21.6040101@erlang.org> References: <20101125003546.GA26430@ecn.lan> <4CEE1E21.6040101@erlang.org> Message-ID: <20101125140913.GA26701@ecn.lan> On Thu, Nov 25, 2010 at 09:28:17AM +0100, Dan Gudmundsson wrote: > Hmm > > I don't know why we should check that, the array record is created and maintained by > the array module, it is an opaque data type which the user should never touch. > > The size should be checked when creating the array so that it could never be a float > or less than 0. > > /Dan You are right, thanks for the feedback! From tuncer.ayaz@REDACTED Sat Nov 27 02:06:44 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sat, 27 Nov 2010 02:06:44 +0100 Subject: [PATCH] hipe: remove unused fun in erl_bif_types Message-ID: <1290820004-97540-1-git-send-email-tuncer.ayaz@gmail.com> Remove t_file_open_option() as it is unused since commit 6751329. --- lib/hipe/cerl/erl_bif_types.erl | 13 ------------- 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/lib/hipe/cerl/erl_bif_types.erl b/lib/hipe/cerl/erl_bif_types.erl index 696414e..cf96643 100644 --- a/lib/hipe/cerl/erl_bif_types.erl +++ b/lib/hipe/cerl/erl_bif_types.erl @@ -5000,19 +5000,6 @@ t_file_name() -> %% DeepList = [char() | atom() | DeepList] -- approximation below t_list(t_sup([t_atom(), t_string(), t_list()]))]). -t_file_open_option() -> - t_sup([t_atom('read'), - t_atom('write'), - t_atom('append'), - t_atom('raw'), - t_atom('binary'), - t_atom('delayed_write'), - t_atom('read_ahead'), - t_atom('compressed'), - t_tuple([t_atom('delayed_write'), - t_pos_integer(), t_non_neg_integer()]), - t_tuple([t_atom('read_ahead'), t_pos_integer()])]). - %% This lists all Posix errors that can occur in file:*/* functions t_file_posix_error() -> t_sup([t_atom('eacces'), From kostis@REDACTED Sat Nov 27 10:09:39 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Sat, 27 Nov 2010 11:09:39 +0200 Subject: [erlang-patches] [PATCH] hipe: remove unused fun in erl_bif_types In-Reply-To: <1290820004-97540-1-git-send-email-tuncer.ayaz@gmail.com> References: <1290820004-97540-1-git-send-email-tuncer.ayaz@gmail.com> Message-ID: <4CF0CAD3.4030005@cs.ntua.gr> Tuncer Ayaz wrote: > Remove t_file_open_option() as it is unused since commit 6751329. > --- > lib/hipe/cerl/erl_bif_types.erl | 13 ------------- Please disregard this patch. A bigger change to erl_bif_types concerning the 'file' module is underway. Kostis From tuncer.ayaz@REDACTED Sat Nov 27 10:56:20 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sat, 27 Nov 2010 10:56:20 +0100 Subject: [erlang-patches] [PATCH] hipe: remove unused fun in erl_bif_types In-Reply-To: <4CF0CAD3.4030005@cs.ntua.gr> References: <1290820004-97540-1-git-send-email-tuncer.ayaz@gmail.com> <4CF0CAD3.4030005@cs.ntua.gr> Message-ID: 2010/11/27 Kostis Sagonas: > Tuncer Ayaz wrote: >> >> Remove t_file_open_option() as it is unused since commit 6751329. >> --- >> ?lib/hipe/cerl/erl_bif_types.erl | ? 13 ------------- > > Please disregard this patch. ?A bigger change to erl_bif_types concerning > the 'file' module is underway. ACK. From glacjay@REDACTED Sun Nov 28 14:52:35 2010 From: glacjay@REDACTED (Jay True) Date: Sun, 28 Nov 2010 21:52:35 +0800 Subject: PKCS8 keyfile (without encryption) support Message-ID: git fetch git://github.com/glacjay/otp.git pkcs8 It allow you to use PKCS8 format keyfile. I haven't implement encrypted PKCS8 yet, cause I'm doubt that is the best way to implement it, or should I add a new interface function to public_key module? From kostis@REDACTED Mon Nov 29 01:05:11 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Mon, 29 Nov 2010 02:05:11 +0200 Subject: Fix some hard-coded type information about the 'file' and 'code' modules Message-ID: <4CF2EE37.4090209@cs.ntua.gr> Patch, concerning erl_bif_types, that should be included in the upcoming release: git fetch git://github.com/kostis/otp.git erl_bif_types-cleanup Kostis From burbas@REDACTED Mon Nov 29 15:08:13 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 29 Nov 2010 15:08:13 +0100 Subject: Fix some hard-coded type information about the 'file' and 'code' modules In-Reply-To: <4CF2EE37.4090209@cs.ntua.gr> References: <4CF2EE37.4090209@cs.ntua.gr> Message-ID: <4CF3B3CD.9020004@erlang.org> On 01/-10/-28163 08:59 PM, Kostis Sagonas wrote: > Patch, concerning erl_bif_types, that should be included in the > upcoming release: > > git fetch git://github.com/kostis/otp.git erl_bif_types-cleanup > > Kostis > Thank you, we will be including your patch in 'pu'. From burbas@REDACTED Mon Nov 29 17:43:16 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 29 Nov 2010 17:43:16 +0100 Subject: PKCS8 keyfile (without encryption) support In-Reply-To: References: Message-ID: <4CF3D824.8080807@erlang.org> On 01/-10/-28163 08:59 PM, Jay True wrote: > git fetch git://github.com/glacjay/otp.git pkcs8 > > It allow you to use PKCS8 format keyfile. I haven't implement > encrypted PKCS8 yet, cause I'm doubt that is the best way to implement > it, or should I add a new interface function to public_key module? > > Thanks for your patch. Can you explain a little more about your thoughts behind adding a new interface function? Before I can include your patch into 'pu', you have to provide some test cases for it. /Niclas Axelsson, Erlang/OTP From kostis@REDACTED Mon Nov 29 22:05:15 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Mon, 29 Nov 2010 23:05:15 +0200 Subject: dialyzer: Add support for multiple PLTs Message-ID: <4CF4158B.8060308@cs.ntua.gr> A functionality addition to dialyzer that should be included in the upcoming release: git fetch git://github.com/mariachris/otp.git plts Kostis From glacjay@REDACTED Tue Nov 30 07:10:10 2010 From: glacjay@REDACTED (Jay True) Date: Tue, 30 Nov 2010 14:10:10 +0800 Subject: PKCS8 keyfile (without encryption) support In-Reply-To: <4CF3D824.8080807@erlang.org> References: <4CF3D824.8080807@erlang.org> Message-ID: OK. As you know, PKCS8 is just a (plain or encrypted) container of the real content, such as an RSA private key or something else. When a client call the function public_key:pem_entry_decode/1,2 and get a PrivateKeyInfo or EncryptedPrivateKeyInfo, it can then call a new function public_key:pkcs8_decode/1,2 to get the actual content inside. For encrypted PKCS8 file, it may need more work than what I thought. Maybe when I finished all this, including test cases and documents, should I send a new pull request. From egil@REDACTED Tue Nov 30 11:07:45 2010 From: egil@REDACTED (=?UTF-8?B?QmrDtnJuLUVnaWwgRGFobGJlcmc=?=) Date: Tue, 30 Nov 2010 11:07:45 +0100 Subject: [erlang-patches] dialyzer: Add support for multiple PLTs In-Reply-To: <4CF4158B.8060308@cs.ntua.gr> References: <4CF4158B.8060308@cs.ntua.gr> Message-ID: <4CF4CCF1.8090006@erix.ericsson.se> On 2010-11-29 22:05, Kostis Sagonas wrote: > A functionality addition to dialyzer that should be included in the > upcoming release: > > git fetch git://github.com/mariachris/otp.git plts > > Kostis Thank you! I will include it into opu. Regards, Bj?rn-Egil Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > From burbas@REDACTED Tue Nov 30 17:43:20 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 30 Nov 2010 17:43:20 +0100 Subject: [erlang-patches] Re: PKCS8 keyfile (without encryption) support In-Reply-To: References: <4CF3D824.8080807@erlang.org> Message-ID: <4CF529A8.8020000@erlang.org> On 11/30/2010 07:10 AM, Jay True wrote: > OK. As you know, PKCS8 is just a (plain or encrypted) container of the > real content, such as an RSA private key or something else. When a > client call the function public_key:pem_entry_decode/1,2 and get a > PrivateKeyInfo or EncryptedPrivateKeyInfo, it can then call a new > function public_key:pkcs8_decode/1,2 to get the actual content inside. > > For encrypted PKCS8 file, it may need more work than what I thought. > > Maybe when I finished all this, including test cases and documents, > should I send a new pull request. > Yes, just send us a new pull request when you have added the test cases. Thanks. /Niclas Axelsson > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > From imi.horvath@REDACTED Tue Nov 30 21:19:24 2010 From: imi.horvath@REDACTED (Imre Horvath) Date: Tue, 30 Nov 2010 21:19:24 +0100 Subject: week number support Message-ID: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> Dear Erlang/OTP Team! I have started a project on GitHub because I needed the ISO Week Number for a given date and I wanted it in Erlang. Since the calendar module in the stdlib-1.17.1 application of Erlang/OTP R14B did not provide this functionality, I decided to write it myself. It's based on the calendar module and was tested successfully with eunit. Though currently it's not in a fork of erlang/otp but in a separate repository https://github.com/imrehorvath/iso_8601_erl you might want to consider including it into OTP if you think it would be useful! Best regards, Imre