From hm@REDACTED Wed Dec 1 10:43:13 2010 From: hm@REDACTED (=?ISO-8859-1?Q?H=E5kan_Mattsson?=) Date: Wed, 1 Dec 2010 10:43:13 +0100 Subject: [erlang-patches] week number support In-Reply-To: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> References: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> Message-ID: On Tue, Nov 30, 2010 at 9:19 PM, Imre Horvath wrote: > Dear Erlang/OTP Team! > > I have started a project on GitHub because I needed the ISO Week Number for a given date > and I wanted it in Erlang. Since the calendar module in the stdlib-1.17.1 application of > Erlang/OTP R14B did not provide this functionality, I decided to write it myself. It's based > on the calendar module and was tested successfully with eunit. > > Though currently it's not in a fork of erlang/otp but in a separate repository > https://github.com/imrehorvath/iso_8601_erl you might want to consider including it into OTP > if you think it would be useful! The Eflex application does also implement the algorithm in ISO8601 to calculate week numbers. Given a date it returns the week number (and the actual year that the week belongs to). See eflex_lib:week_of_the_year/1 in https://github.com/hawk/eflex/blob/master/src/eflex_lib.erl When I initially wrote Eflex my intention was to include THE week calculation algorithm in the calandar module, but when I detected that ISO8601 just was one of many algorithms I dropped that idea. Different parts of the world uses different week numbering algorithms. There are several different just in Europe. /H?kan From fdmanana@REDACTED Wed Dec 1 13:47:56 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 1 Dec 2010 12:47:56 +0000 Subject: [erlang-patches] [PATCH] httpc module - allow streaming of bodies for PUT and POST requests In-Reply-To: References: Message-ID: Please refetch. I committed 2 more changes that simplify both the implementation and interface. git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming thanks 2010/10/13 Bj?rn Gustavsson : > 2010/10/12 Filipe David Manana : >> Hi, >> >> In the previous patch I forgot to add the documentation for the new >> chunkify function body parameter. >> I updated my git branch with it: >> >> git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming >> > > Thanks! Updated. I combined your new commit with the > previous commit. > > -- > Bj?rn Gustavsson, Erlang/OTP, Ericsson AB > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From imi.horvath@REDACTED Wed Dec 1 15:56:46 2010 From: imi.horvath@REDACTED (Imre Horvath) Date: Wed, 1 Dec 2010 15:56:46 +0100 Subject: [erlang-patches] week number support In-Reply-To: References: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> Message-ID: Dear H?kan! Yes, you are right, I found the same while doing my research. There are several different methods to calculate the week number. That's the reason I also did not wanted to put it into the calendar module. Same like you. I specifically needed the ISO Week Number, that's why I implemented it and put it into a separate module the iso_8601.erl This module currently contains only the implementation for the ISO Week Date, not more. Later it can be extended to cover more parts of the standard. What I had in mind is that OTP could include support for the ISO 8601 and this could be a initial partial implementation. But it's up to the OTP Team to decide if they want to include this in some form or not. Support for calculating other week numbers is out of scope of my contribution. Best regards, Imre 2010/12/1 H?kan Mattsson > On Tue, Nov 30, 2010 at 9:19 PM, Imre Horvath > wrote: > > Dear Erlang/OTP Team! > > > > I have started a project on GitHub because I needed the ISO Week Number > for a given date > > and I wanted it in Erlang. Since the calendar module in the stdlib-1.17.1 > application of > > Erlang/OTP R14B did not provide this functionality, I decided to write it > myself. It's based > > on the calendar module and was tested successfully with eunit. > > > > Though currently it's not in a fork of erlang/otp but in a separate > repository > > https://github.com/imrehorvath/iso_8601_erl you might want to consider > including it into OTP > > if you think it would be useful! > > The Eflex application does also implement the algorithm in ISO8601 to > calculate week numbers. > Given a date it returns the week number (and the actual year that the > week belongs to). > See eflex_lib:week_of_the_year/1 in > https://github.com/hawk/eflex/blob/master/src/eflex_lib.erl > > When I initially wrote Eflex my intention was to include THE week > calculation algorithm in the > calandar module, but when I detected that ISO8601 just was one of many > algorithms I > dropped that idea. Different parts of the world uses different week > numbering algorithms. > There are several different just in Europe. > > /H?kan > From fdmanana@REDACTED Wed Dec 1 18:20:49 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 1 Dec 2010 17:20:49 +0000 Subject: [PATH] - add file:allocate/3 Message-ID: Hello, The following patch adds file:allocate/3, a wrapper for the POSIX syscall posix_fadvise. git fetch git fetch git://github.com/fdmanana/otp.git posix_fallocate thanks -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From fdmanana@REDACTED Wed Dec 1 18:45:48 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 1 Dec 2010 17:45:48 +0000 Subject: [erlang-patches] [PATCH] httpc module - allow streaming of bodies for PUT and POST requests In-Reply-To: References: Message-ID: For easier management, I squashed all the commits into a new branch: git fetch git://github.com/fdmanana/otp.git httpc_upload_streaming thanks 2010/12/1 Filipe David Manana : > Please refetch. I committed 2 more changes that simplify both the > implementation and interface. > > git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming > > thanks > > 2010/10/13 Bj?rn Gustavsson : >> 2010/10/12 Filipe David Manana : >>> Hi, >>> >>> In the previous patch I forgot to add the documentation for the new >>> chunkify function body parameter. >>> I updated my git branch with it: >>> >>> git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming >>> >> >> Thanks! Updated. I combined your new commit with the >> previous commit. >> >> -- >> Bj?rn Gustavsson, Erlang/OTP, Ericsson AB >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >> >> > > > > -- > Filipe David Manana, > fdmanana@REDACTED, fdmanana@REDACTED > > "Reasonable men adapt themselves to the world. > ?Unreasonable men adapt the world to themselves. > ?That's why all progress depends on unreasonable men." > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From fdmanana@REDACTED Wed Dec 1 18:46:55 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 1 Dec 2010 17:46:55 +0000 Subject: [PATH] - add file:allocate/3 In-Reply-To: References: Message-ID: On Wed, Dec 1, 2010 at 5:20 PM, Filipe David Manana wrote: > Hello, > > The following patch adds file:allocate/3, a wrapper for the POSIX > syscall posix_fadvise. Here I meant posix_fallocate. Thanks Tuncer for noticing the error. > > git fetch git fetch git://github.com/fdmanana/otp.git posix_fallocate > > thanks > > -- > Filipe David Manana, > fdmanana@REDACTED, fdmanana@REDACTED > > "Reasonable men adapt themselves to the world. > ?Unreasonable men adapt the world to themselves. > ?That's why all progress depends on unreasonable men." > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From dmitriy.kargapolov@REDACTED Wed Dec 1 21:33:43 2010 From: dmitriy.kargapolov@REDACTED (Dmitriy Kargapolov) Date: Wed, 1 Dec 2010 15:33:43 -0500 Subject: Fwd: [erlang-questions] SNMP AGENT-CAPABILITIES In-Reply-To: References: <20101201.130926.74904160.mbj@tail-f.com> Message-ID: Patch proposed allowing to compile and use (in limited way - see below) AGENT-CAPABILITIES macro in the MIBs. git fetch git://github.com/xoid/otp.git agent_capabilities Thanks. ---------- Forwarded message ---------- From: Dmitriy Kargapolov Date: Wed, Dec 1, 2010 at 3:21 PM Subject: Re: [erlang-questions] SNMP AGENT-CAPABILITIES To: Martin Bjorklund Cc: erlang-questions@REDACTED Hi Martin, On Wed, Dec 1, 2010 at 7:09 AM, Martin Bjorklund wrote: > Hi, > > Dmitriy Kargapolov wrote: > > Trying to improve SNMP agent for some app written in Erlang, I found that > > Erlang MIB compiler does not support AGENT-CAPABILITIES statement which > is > > actually a macro from SNMPv2-CONF. > > Normally, an invocation of the AGENT-CAPABILITIES macro is specified > in a separate document from the normal MIB modules. It documents how > a certain agent (or family of agents) conforms to a set of MIB > modules. > Compiler is indifferent to the layout and AGENT-CAPABILITIES location. It just did not recognize this construct. > Do you mean that you want the MIB compiler to support this use case? > If so, what exactly do you want the compiler to do? > In some (odd) cases you get files with both normal MIB modules, and an > AGENT-CAPABILITIES invocation in the same file. Is this the use case > you want to support? > >From SNMP agent perspective, it is enough to register OID of the AGENT-CAPABILITIES object, so I would later to use smpa:name_to_oid/1 to resolve its name and snmpa/add_agent_caps/2 to add this OID to sysORTable... This is exactly what I implemented in my minimalistic patch. >From SNMP manager perspective it would be nice to have access to the whole content of the AGENT-CAPABILITIES construct. To make possible to decide which part of features of agent have to be supported in manager at runtime. I understand that this task requires a bit more time (which I do not have), so its ok to leave this for future, if needed. > I have modified the MIB compiler to "support" this macro. The grammar > builds a record of the information, and then the compiler ignores this > record. Some day I should make it available in git... > > > /martin > I have published my changes to the branch agent_capabilities at git:// github.com/xoid/otp.git. From burbas@REDACTED Thu Dec 2 17:34:29 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Thu, 2 Dec 2010 17:34:29 +0100 Subject: [erlang-patches] Fwd: [erlang-questions] SNMP AGENT-CAPABILITIES In-Reply-To: References: <20101201.130926.74904160.mbj@tail-f.com> Message-ID: <4CF7CA95.4030805@erlang.org> On 12/01/2010 09:33 PM, Dmitriy Kargapolov wrote: > Patch proposed allowing to compile and use (in limited way - see below) > AGENT-CAPABILITIES macro in the MIBs. > > git fetch git://github.com/xoid/otp.git agent_capabilities > > Thanks. > > ---------- Forwarded message ---------- > From: Dmitriy Kargapolov > Date: Wed, Dec 1, 2010 at 3:21 PM > Subject: Re: [erlang-questions] SNMP AGENT-CAPABILITIES > To: Martin Bjorklund > Cc: erlang-questions@REDACTED > > > Hi Martin, > > On Wed, Dec 1, 2010 at 7:09 AM, Martin Bjorklund wrote: > > >> Hi, >> >> Dmitriy Kargapolov wrote: >> >>> Trying to improve SNMP agent for some app written in Erlang, I found that >>> Erlang MIB compiler does not support AGENT-CAPABILITIES statement which >>> >> is >> >>> actually a macro from SNMPv2-CONF. >>> >> Normally, an invocation of the AGENT-CAPABILITIES macro is specified >> in a separate document from the normal MIB modules. It documents how >> a certain agent (or family of agents) conforms to a set of MIB >> modules. >> >> > Compiler is indifferent to the layout and AGENT-CAPABILITIES location. It > just did not recognize this construct. > > > >> Do you mean that you want the MIB compiler to support this use case? >> If so, what exactly do you want the compiler to do? >> >> > In some (odd) cases you get files with both normal MIB modules, and an > >> AGENT-CAPABILITIES invocation in the same file. Is this the use case >> you want to support? >> >> > > From SNMP agent perspective, it is enough to register OID of the > AGENT-CAPABILITIES object, so I would later to use smpa:name_to_oid/1 to > resolve its name and snmpa/add_agent_caps/2 to add this OID to sysORTable... > This is exactly what I implemented in my minimalistic patch. > > > From SNMP manager perspective it would be nice to have access to the whole > content of the AGENT-CAPABILITIES construct. To make possible to decide > which part of features of agent have to be supported in manager at runtime. > I understand that this task requires a bit more time (which I do not have), > so its ok to leave this for future, if needed. > > > >> I have modified the MIB compiler to "support" this macro. The grammar >> builds a record of the information, and then the compiler ignores this >> record. Some day I should make it available in git... >> >> >> /martin >> >> > I have published my changes to the branch agent_capabilities at git:// > github.com/xoid/otp.git. > > Hi Dmitriy, Your patch does not compile on my machine. Here is my output from the compilation: erlc -W -o . -o. snmpc_mib_gram.yrl erlc -W +debug_info -I../../include -Dversion=\"4.18\" +'{parse_transform,sys_pre_attributes}' +'{attribute,insert,app_vsn,"snmp-4.18"}' -I/otp/lib/stdlib -o../../ebin snmpc_mib_gram.erl erlc -W +debug_info -I../../include -Dversion=\"4.18\" +'{parse_transform,sys_pre_attributes}' +'{attribute,insert,app_vsn,"snmp-4.18"}' -I/otp/lib/stdlib -o../../ebin snmpc.erl ./snmpc.erl:1022: function l/2 undefined make[3]: *** [../../ebin/snmpc.beam] Error 1 Please check the error and when you have a solution, let me know. As it is now I can not include this patch into 'pu'. /Niclas Axelsson, Erlang/OTP From dmitriy.kargapolov@REDACTED Thu Dec 2 17:54:59 2010 From: dmitriy.kargapolov@REDACTED (Dmitriy Kargapolov) Date: Thu, 2 Dec 2010 11:54:59 -0500 Subject: [erlang-patches] Fwd: [erlang-questions] SNMP AGENT-CAPABILITIES In-Reply-To: <4CF7CA95.4030805@erlang.org> References: <20101201.130926.74904160.mbj@tail-f.com> <4CF7CA95.4030805@erlang.org> Message-ID: It has been fixed. Please try again. Thanks. On Thu, Dec 2, 2010 at 11:34 AM, Niclas Axelsson wrote: > On 12/01/2010 09:33 PM, Dmitriy Kargapolov wrote: > >> Patch proposed allowing to compile and use (in limited way - see below) >> AGENT-CAPABILITIES macro in the MIBs. >> >> git fetch git://github.com/xoid/otp.git agent_capabilities >> >> Thanks. >> >> ---------- Forwarded message ---------- >> From: Dmitriy Kargapolov >> Date: Wed, Dec 1, 2010 at 3:21 PM >> Subject: Re: [erlang-questions] SNMP AGENT-CAPABILITIES >> To: Martin Bjorklund >> Cc: erlang-questions@REDACTED >> >> >> Hi Martin, >> >> On Wed, Dec 1, 2010 at 7:09 AM, Martin Bjorklund wrote: >> >> >> >>> Hi, >>> >>> Dmitriy Kargapolov wrote: >>> >>> >>>> Trying to improve SNMP agent for some app written in Erlang, I found >>>> that >>>> Erlang MIB compiler does not support AGENT-CAPABILITIES statement which >>>> >>>> >>> is >>> >>> >>>> actually a macro from SNMPv2-CONF. >>>> >>>> >>> Normally, an invocation of the AGENT-CAPABILITIES macro is specified >>> in a separate document from the normal MIB modules. It documents how >>> a certain agent (or family of agents) conforms to a set of MIB >>> modules. >>> >>> >>> >> Compiler is indifferent to the layout and AGENT-CAPABILITIES location. It >> just did not recognize this construct. >> >> >> >> >>> Do you mean that you want the MIB compiler to support this use case? >>> If so, what exactly do you want the compiler to do? >>> >>> >>> >> In some (odd) cases you get files with both normal MIB modules, and an >> >> >>> AGENT-CAPABILITIES invocation in the same file. Is this the use case >>> you want to support? >>> >>> >>> >> > From SNMP agent perspective, it is enough to register OID of the >> AGENT-CAPABILITIES object, so I would later to use smpa:name_to_oid/1 to >> resolve its name and snmpa/add_agent_caps/2 to add this OID to >> sysORTable... >> This is exactly what I implemented in my minimalistic patch. >> >> > From SNMP manager perspective it would be nice to have access to the >> whole >> content of the AGENT-CAPABILITIES construct. To make possible to decide >> which part of features of agent have to be supported in manager at >> runtime. >> I understand that this task requires a bit more time (which I do not >> have), >> so its ok to leave this for future, if needed. >> >> >> >> >>> I have modified the MIB compiler to "support" this macro. The grammar >>> builds a record of the information, and then the compiler ignores this >>> record. Some day I should make it available in git... >>> >>> >>> /martin >>> >>> >>> >> I have published my changes to the branch agent_capabilities at git:// >> github.com/xoid/otp.git. >> >> >> > Hi Dmitriy, > > Your patch does not compile on my machine. Here is my output from the > compilation: > > erlc -W -o . -o. snmpc_mib_gram.yrl > erlc -W +debug_info -I../../include -Dversion=\"4.18\" > +'{parse_transform,sys_pre_attributes}' > +'{attribute,insert,app_vsn,"snmp-4.18"}' -I/otp/lib/stdlib -o../../ebin > snmpc_mib_gram.erl > erlc -W +debug_info -I../../include -Dversion=\"4.18\" > +'{parse_transform,sys_pre_attributes}' > +'{attribute,insert,app_vsn,"snmp-4.18"}' -I/otp/lib/stdlib -o../../ebin > snmpc.erl > ./snmpc.erl:1022: function l/2 undefined > make[3]: *** [../../ebin/snmpc.beam] Error 1 > > Please check the error and when you have a solution, let me know. > As it is now I can not include this patch into 'pu'. > > /Niclas Axelsson, Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > From burbas@REDACTED Fri Dec 3 09:34:50 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Fri, 3 Dec 2010 09:34:50 +0100 Subject: [erlang-patches] Fwd: [erlang-questions] SNMP AGENT-CAPABILITIES In-Reply-To: References: <20101201.130926.74904160.mbj@tail-f.com> <4CF7CA95.4030805@erlang.org> Message-ID: <4CF8ABAA.1060800@erlang.org> On 12/02/2010 05:54 PM, Dmitriy Kargapolov wrote: > It has been fixed. Please try again. > Thanks. > Thanks. Will include your patch in 'pu'. /Niclas Axelsson, Erlang/OTP From burbas@REDACTED Fri Dec 3 10:03:09 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Fri, 3 Dec 2010 10:03:09 +0100 Subject: [erlang-patches] Re: [PATH] - add file:allocate/3 In-Reply-To: References: Message-ID: <4CF8B24D.6000207@erlang.org> On 12/01/2010 06:46 PM, Filipe David Manana wrote: > On Wed, Dec 1, 2010 at 5:20 PM, Filipe David Manana wrote: > >> Hello, >> >> The following patch adds file:allocate/3, a wrapper for the POSIX >> syscall posix_fadvise. >> > Here I meant posix_fallocate. > Thanks Tuncer for noticing the error >> git fetch git fetch git://github.com/fdmanana/otp.git posix_fallocate >> >> thanks >> >> -- >> Filipe David Manana, >> fdmanana@REDACTED, fdmanana@REDACTED >> >> "Reasonable men adapt themselves to the world. >> Unreasonable men adapt the world to themselves. >> That's why all progress depends on unreasonable men." >> >> Thank you. I will include it into 'pu'. /Niclas Axelsson, Erlang/OTP From raimo+erlang-patches@REDACTED Fri Dec 3 17:00:53 2010 From: raimo+erlang-patches@REDACTED (Raimo Niskanen) Date: Fri, 3 Dec 2010 17:00:53 +0100 Subject: What's cooking in erlang/otp (2010-12-03) Message-ID: <20101203160050.F076014A1@fingolfin.du.uab.ericsson.se> The next release will be R14B01, expected to be released December 8. Feature branches sent in from now on are unlikely to be included in R14B01. Bug fixes may still make it, depending on the application, the severity of the bug, and how unlikely the bug fix is to break something. We will try to review and include into the R14B01 release some more of the branches currently in 'pu'. ------------------------------------------------------------ [Graduated] * bw/gitignore (otp) (2010-10-05) 1 commit + Add win32 specific build artifacts to .gitignore (834cd98) * bw/win32-file-linking (erts) (2010-10-04) 1 commit + Add Win32 support for hard and symbolic file system links (1f6d7c8) * bw/win32-laa (erts) (2010-10-06) 1 commit + Added win32 large address aware link option (8bb6f48) * dc/update-INSTALL-WIN32.md (otp) (2010-09-19) 1 commit + Doc update to latest dependencies & how to compile with free VS2008 Express (8e8061c) ------------------------------------------------------------ [New topics] * dk/agent-capabilities (snmp) (2010-12-01) 1 commit - AGENT-CAPABILITIES handling added to SNMP mib compiler (17c3b19) * fm/posix-fallocate (erts, kernel) (2010-12-01) 1 commit - Added file:allocate/3. This function allocates space for a file. It only has effect in POSIX platforms that implement the posix_fallocate system call. (ea3dfb9) * ms/epmd-local-access-check (erts) (2010-11-24) 1 commit - epmd: include host address in local access check (5b68030) ------------------------------------------------------------ [Stalled] * jn/gen_stream (stdlib) (2010-09-05) 5 commits - Use erlang:process_info(Pid, links) to determine if gen_stream managed worker processes are leaked (b2386df) - Move gen_stream internal process test to after termination of gen_stream parent (f1d8a97) - Add calls to code loader in every test to verify code loader still running (ac6cbba) - Track gen_stream processes directly for accurate test results (38a4083) - Patch dev to reproduce jn/gen_stream (7694a74) . Add new gen_stream behaviour for efficiently consuming serial streams (65f3db8) This topic branch has a failing test case: shell_SUITE:start_restricted_from_shell; We have now tested with and without this topic branch and when it is present that test case fails. We consider it proved to be guilty. The test case does not fail when run standalone so it seems to be tricky... Also, some of its own test cases fail sporadicly. Action expected from: Topic author. * jp/dependencies_makefile (compiler, erts) (2009-12-14) 1 commit - Add dependencies Makefile generation to erlc(1) and compile(3) (4945add) Approved in principle by the OTP Technical Board; now awaits a closer review of the implementation. Action expected from: Bj??rn Gustavsson (the reviewer) ------------------------------------------------------------ [Cooking] * bg/temp-hipe-fixes (compiler, hipe, kernel) (2010-03-15) 6 commits - Avoid crash by skipping compilation_SUITE:on_load/1 (8592a02) - Inline less aggressively for native-code compilation (e699ad4) - Crudely fix return type for the lists:key{search,find,member}/3 (2b72202) - seq_trace_SUITE: Don't native-compile (2712344) - Disable native code if on_load is used (e8d0ea4) - andor_SUITE: Don't native-compile (e25ef8c) This branch contains temporary workarounds to avoid failing test cases and is never intended to graduate. * bw/efile_exists (erts) (2010-10-07) 1 commit - prim_file:exists/{1,2} which is lightweight file existence check (7203932) * bw/tv-render-fix (tv) (2010-10-06) 1 commit - tv: Allow table viewer to display refs, ports and small binaries (5eff630) * cg/fix-prng (stdlib) (2010-10-06) 1 commit - Fix a bug in the implementation of the pseudo-random number generator (863ec4d) * fm/httpc-upload-body-streaming (inets) (2010-10-05) 2 commits - httpc: add option to do automatic chunked transfer-encoding (6951ed1) - httpc: allow streaming of PUT and POST request bodies (f9ec3cb) * gc/gen-format-status-improvements (stdlib) (2010-06-12) 1 commit - Fix format_status bug for unregistered gen_event processes (95ed86f) * hw/call-chmod-without-f (asn1, common_test, compiler, cosFileTransfer, crypto, debugger, docbuilder, edoc, erl_interface, erts, et, inets, inviso, kernel, megaco, mnesia, orber, parsetools, percept, public_key, reltool, runtime_tools, snmp, ssl, stdlib, syntax_tools, test_server, tools) (2010-11-15) 1 commit - Call chmod without the "-f" flag (7ed11a8) * hw/epmd-bind-to-address (erts) (2010-11-10) 1 commit - Allow user to specify the IP address epmd binds to (bcf3b3d) * hw/fix-epmd-perror (erts) (2010-11-13) 1 commit - Fix epmd's dbg_perror() output (b363d7d) * jf/run_erl-disable-flow-control (erts) (2010-03-05) 1 commit - Teach run_erl RUN_ERL_DISABLE_FLOWCNTRL for disabling flow control (d0775cd) * km/pool_connect-to-running-nodes (stdlib) (2010-09-02) 1 commit - Change pool module to attempt to attach to nodes that are already running (a9f4cbc) * ks/asn1-dialyzer-fixes (asn1) (2010-11-18) 1 commit - Shut off some dialyzer warnings (508a6d2) * mh/dialyzer-full-path-option (dialyzer) (2010-09-15) 1 commit - Dialyzer: add --fullpath option for printing full paths in warnings (3703ea6) * ml/add-os-pid-to-port-info (erts) (2010-08-19) 1 commit - Extend erlang:port_info/1,2 to show the OS pid of a spawned process (b2d85bf) * pg/des-cfb-functions (crypto) (2010-10-16) 1 commit - Add DES and Triple DES cipher feedback (CFB) mode functions (2c79ae7) * pg/fix-hibernate-with-hipe (erts, otp) (2010-09-27) 1 commit - Fix several bugs related to hibernate/3 and HiPE (babd761) * pg/honor-start-type-in-rel-files (sasl) (2010-06-06) 1 commit - Honor start type in .rel files when building relup files (7599900) * sa/callback-attr (compiler, inets, kernel, otp, stdlib) (2010-06-08) 7 commits - Add callback specs into 'application' module in kernel (85ae9d7) - Add callback specs to tftp module following internet documentation (019e6d1) - Add callback specs to inets_service module following possibly deprecated comments (575c7af) - Add '-callback' attributes in stdlib's behaviours (a9da5cc) - Update primary bootstrap (d5d255b) - Automatically generate 'behaviour_info' function from '-callback' attributes (1155c86) - Add '-callback' attribute to language syntax (1a1cc4b) * sb/make-files-like-erlc (tools) (2010-05-18) 1 commit - Change make:files to behave more like erlc (5e9d051) * sg/fix-diskless-booted-relup (sasl) (2010-09-19) 1 commit - Remove traces of release_handler reading from filesystem when it has Masters list (54cb5df) * sv/epmd-check-listen (erts) (2010-07-14) 1 commit - check return value of epmd server listen() call (c5c8baa) * ta/asn1-reporting (asn1) (2010-04-23) 1 commit - asn1ct: Make formatting of errors and warnings consistent (93face2) * ta/ensure-dot-ssh-exists (ssh) (2010-09-02) 1 commit - ssh: ensure ~/.ssh exists (2c14d90) * ta/sendfile (erts, kernel) (2010-09-06) 1 commit - Implement file:sendfile (c652dda) * ts/cover-with-export_all (tools) (2010-09-23) 1 commit - add user specified compiler options on form reloading (eb02beb) * uw/xmerl-expand-simple (xmerl) (2010-10-25) 1 commit - Track parents when expanding #xmlElement records (9f4c1ee) From mchris@REDACTED Sat Dec 4 00:22:17 2010 From: mchris@REDACTED (Maria Christaki) Date: Fri, 3 Dec 2010 23:22:17 -0000 Subject: [erlang-patches] dialyzer: Add support for multiple PLTs Message-ID: <201012032322.oB3NMHTK013953@diomedes.noc.ntua.gr> The multiple-PLT patch was amended to include the updated documentation. However, it seems that I didn't make the amend on time and the patch was committed on the dev branch with the old documentation. For this reason, I have created another patch with dialyzer's new documentation: git fetch git://github.com/mariachris/otp.git dialyzer_doc Thank you, Maria Kostis Sagonas said: > A functionality addition to dialyzer that should be included in the > upcoming release: > > git fetch git://github.com/mariachris/otp.git plts > > Kostis > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > > -- From tuncer.ayaz@REDACTED Sat Dec 4 17:44:49 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sat, 4 Dec 2010 17:44:49 +0100 Subject: [PATCH] Set WINVER and _WIN32_WINNT to 0x0501 Message-ID: <1291481089-22974-1-git-send-email-tuncer.ayaz@gmail.com> The Windows implementation of inet:getifaddrs/0 depends on WINVER >= 0x0501. Update WINVER and _WIN32_WINNT definitions accordingly. --- erts/configure.in | 2 +- lib/erl_interface/configure.in | 2 +- lib/wx/configure.in | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/erts/configure.in b/erts/configure.in index 8d629c2..7820a6b 100644 --- a/erts/configure.in +++ b/erts/configure.in @@ -389,7 +389,7 @@ case $host_os in win32) # The ethread library requires _WIN32_WINNT of at least 0x0403. # -D_WIN32_WINNT=* from CPPFLAGS is saved in ETHR_DEFS. - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500 -DWINVER=0x0500" + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501 -DWINVER=0x0501" # _USE_32BIT_TIME_T is needed when using VC++ 2005 (ctime() will fail # otherwise since we pass it a 32-bit value). # diff --git a/lib/erl_interface/configure.in b/lib/erl_interface/configure.in index 72ac8c7..0bb94e5 100644 --- a/lib/erl_interface/configure.in +++ b/lib/erl_interface/configure.in @@ -288,7 +288,7 @@ case "$threads_disabled" in ;; win32_threads) EI_THREADS="true" - THR_DEFS="$THR_DEFS -D_WIN32_WINNT=0x0500 -DWINVER=0x0500" + THR_DEFS="$THR_DEFS -D_WIN32_WINNT=0x0501 -DWINVER=0x0501" ;; pthread) EI_THREADS="true" diff --git a/lib/wx/configure.in b/lib/wx/configure.in index f7128db..ada52f9 100755 --- a/lib/wx/configure.in +++ b/lib/wx/configure.in @@ -145,14 +145,14 @@ case $host_os in CPPFLAGS="$CPPFLAGS -D_MACOSX $PTHR_CFLAGS" ;; mingw32) - CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0500 -D_WINDOWS -D_UNICODE -DUNICODE" - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500" + CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0501 -D_WINDOWS -D_UNICODE -DUNICODE" + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501" AC_MSG_WARN([Reverting to 32-bit time_t]) CPPFLAGS="$CPPFLAGS -D_USE_32BIT_TIME_T" ;; win32) - CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0500 -D_WINDOWS -D_UNICODE -DUNICODE" - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500" + CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0501 -D_WINDOWS -D_UNICODE -DUNICODE" + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501" ;; *) CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE $PTHR_CFLAGS" From tuncer.ayaz@REDACTED Sun Dec 5 00:08:52 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sun, 5 Dec 2010 00:08:52 +0100 Subject: [erlang-patches] sendfile() In-Reply-To: References: Message-ID: 2010/11/9 Bj?rn Gustavsson : > 2010/11/1 Tuncer Ayaz : >> 2010/10/20 Tuncer Ayaz : >>> 2010/10/20 Bj?rn Gustavsson : >>>> Refetched. >> >> Please refetch. Now also with Windows support using TransmitFile(). >> > > Refetched. Please refetch. Now using SetFilePointerEx in win_efile.c. From kostis@REDACTED Sun Dec 5 00:54:09 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Sun, 05 Dec 2010 01:54:09 +0200 Subject: [erlang-patches] dialyzer: Add support for multiple PLTs In-Reply-To: <201012032322.oB3NMHTK013953@diomedes.noc.ntua.gr> References: <201012032322.oB3NMHTK013953@diomedes.noc.ntua.gr> Message-ID: <4CFAD4A1.4040908@cs.ntua.gr> Maria Christaki wrote: > The multiple-PLT patch was amended to include the updated documentation. > However, it seems that I didn't make the amend on time and the patch was > committed on the dev branch with the old documentation. For this reason, I > have created another patch with dialyzer's new documentation: > > git fetch git://github.com/mariachris/otp.git dialyzer_doc This patch should be included in R14B01. It's safe to include it directly into 'dev' since it only affects documentation files (and it has info on the new dialyzer version). Kostis > Kostis Sagonas said: > >> A functionality addition to dialyzer that should be included in the >> upcoming release: >> >> git fetch git://github.com/mariachris/otp.git plts >> >> Kostis >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED From jay@REDACTED Sat Dec 4 19:30:28 2010 From: jay@REDACTED (jay@REDACTED) Date: Sat, 4 Dec 2010 10:30:28 -0800 Subject: R15A schedule Message-ID: <5a9bed4d16f31556e078e617ec8cafea.squirrel@duomark.com> I finally have time to look into the shell_SUITE conflict caused by gen_stream. I believe all other issues are resolved. What is the schedule for R15A release? jay From burbas@REDACTED Mon Dec 6 10:40:19 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 6 Dec 2010 10:40:19 +0100 Subject: [erlang-patches] week number support In-Reply-To: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> References: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> Message-ID: <4CFCAF83.9080600@erlang.org> On 11/30/2010 09:19 PM, Imre Horvath wrote: > Dear Erlang/OTP Team! > > I have started a project on GitHub because I needed the ISO Week Number for a given date and I wanted it in Erlang. Since the calendar module in the stdlib-1.17.1 application of Erlang/OTP R14B did not provide this functionality, I decided to write it myself. It's based on the calendar module and was tested successfully with eunit. > > Though currently it's not in a fork of erlang/otp but in a separate repository https://github.com/imrehorvath/iso_8601_erl you might want to consider including it into OTP if you think it would be useful! > > Best regards, > Imre > Hi Imre, Thanks for your contribution, but we can not include it into 'pu' as it is now. You need to follow the instructions (https://github.com/erlang/otp/wiki/submitting-patches), and since this is a new feature you also need to provide some test cases. Best regards, Niclas Axelsson, Erlang/OTP From imi.horvath@REDACTED Mon Dec 6 13:56:47 2010 From: imi.horvath@REDACTED (Imre Horvath) Date: Mon, 6 Dec 2010 13:56:47 +0100 Subject: [erlang-patches] week number support In-Reply-To: <4CFCAF83.9080600@erlang.org> References: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> <4CFCAF83.9080600@erlang.org> Message-ID: Hi Niclas! Thanks for the reply! I will then make my contribution "compatible" first based on the instructions provided and will notify you when ready! Best regards, Imre On Mon, Dec 6, 2010 at 10:40 AM, Niclas Axelsson wrote: > On 11/30/2010 09:19 PM, Imre Horvath wrote: > >> Dear Erlang/OTP Team! >> >> I have started a project on GitHub because I needed the ISO Week Number >> for a given date and I wanted it in Erlang. Since the calendar module in the >> stdlib-1.17.1 application of Erlang/OTP R14B did not provide this >> functionality, I decided to write it myself. It's based on the calendar >> module and was tested successfully with eunit. >> >> Though currently it's not in a fork of erlang/otp but in a separate >> repository https://github.com/imrehorvath/iso_8601_erl you might want to >> consider including it into OTP if you think it would be useful! >> >> Best regards, >> Imre >> >> > Hi Imre, > > Thanks for your contribution, but we can not include it into 'pu' as it is > now. > You need to follow the instructions ( > https://github.com/erlang/otp/wiki/submitting-patches), and > since this is a new feature you also need to provide some test cases. > > Best regards, > Niclas Axelsson, Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > From burbas@REDACTED Mon Dec 6 14:39:31 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 6 Dec 2010 14:39:31 +0100 Subject: [erlang-patches] dialyzer: Add support for multiple PLTs In-Reply-To: <201012032322.oB3NMHTK013953@diomedes.noc.ntua.gr> References: <201012032322.oB3NMHTK013953@diomedes.noc.ntua.gr> Message-ID: <4CFCE793.2000709@erlang.org> On 12/04/2010 12:22 AM, Maria Christaki wrote: > The multiple-PLT patch was amended to include the updated documentation. > However, it seems that I didn't make the amend on time and the patch was > committed on the dev branch with the old documentation. For this reason, I > have created another patch with dialyzer's new documentation: > > git fetch git://github.com/mariachris/otp.git dialyzer_doc > > Thank you, > Maria > > Kostis Sagonas said: > > >> A functionality addition to dialyzer that should be included in the >> upcoming release: >> >> git fetch git://github.com/mariachris/otp.git plts >> >> Kostis >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >> >> >> >> > > > Thank you Maria. It's now included in 'dev'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Mon Dec 6 16:05:50 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 6 Dec 2010 16:05:50 +0100 Subject: [erlang-patches] [PATCH] Set WINVER and _WIN32_WINNT to 0x0501 In-Reply-To: <1291481089-22974-1-git-send-email-tuncer.ayaz@gmail.com> References: <1291481089-22974-1-git-send-email-tuncer.ayaz@gmail.com> Message-ID: <4CFCFBCE.1050906@erlang.org> On 12/04/2010 05:44 PM, Tuncer Ayaz wrote: > The Windows implementation of inet:getifaddrs/0 depends on > WINVER>= 0x0501. Update WINVER and _WIN32_WINNT definitions > accordingly. > --- > erts/configure.in | 2 +- > lib/erl_interface/configure.in | 2 +- > lib/wx/configure.in | 8 ++++---- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/erts/configure.in b/erts/configure.in > index 8d629c2..7820a6b 100644 > --- a/erts/configure.in > +++ b/erts/configure.in > @@ -389,7 +389,7 @@ case $host_os in > win32) > # The ethread library requires _WIN32_WINNT of at least 0x0403. > # -D_WIN32_WINNT=* from CPPFLAGS is saved in ETHR_DEFS. > - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500 -DWINVER=0x0500" > + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501 -DWINVER=0x0501" > # _USE_32BIT_TIME_T is needed when using VC++ 2005 (ctime() will fail > # otherwise since we pass it a 32-bit value). > # > diff --git a/lib/erl_interface/configure.in b/lib/erl_interface/configure.in > index 72ac8c7..0bb94e5 100644 > --- a/lib/erl_interface/configure.in > +++ b/lib/erl_interface/configure.in > @@ -288,7 +288,7 @@ case "$threads_disabled" in > ;; > win32_threads) > EI_THREADS="true" > - THR_DEFS="$THR_DEFS -D_WIN32_WINNT=0x0500 -DWINVER=0x0500" > + THR_DEFS="$THR_DEFS -D_WIN32_WINNT=0x0501 -DWINVER=0x0501" > ;; > pthread) > EI_THREADS="true" > diff --git a/lib/wx/configure.in b/lib/wx/configure.in > index f7128db..ada52f9 100755 > --- a/lib/wx/configure.in > +++ b/lib/wx/configure.in > @@ -145,14 +145,14 @@ case $host_os in > CPPFLAGS="$CPPFLAGS -D_MACOSX $PTHR_CFLAGS" > ;; > mingw32) > - CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0500 -D_WINDOWS -D_UNICODE -DUNICODE" > - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500" > + CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0501 -D_WINDOWS -D_UNICODE -DUNICODE" > + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501" > AC_MSG_WARN([Reverting to 32-bit time_t]) > CPPFLAGS="$CPPFLAGS -D_USE_32BIT_TIME_T" > ;; > win32) > - CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0500 -D_WINDOWS -D_UNICODE -DUNICODE" > - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500" > + CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0501 -D_WINDOWS -D_UNICODE -DUNICODE" > + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501" > ;; > *) > CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE $PTHR_CFLAGS" > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thank you, Tuncer. Will include this into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From jesper.louis.andersen@REDACTED Mon Dec 6 16:42:08 2010 From: jesper.louis.andersen@REDACTED (Jesper Louis Andersen) Date: Mon, 6 Dec 2010 16:42:08 +0100 Subject: [erlang-patches] week number support In-Reply-To: <4CFCAF83.9080600@erlang.org> References: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> <4CFCAF83.9080600@erlang.org> Message-ID: On Mon, Dec 6, 2010 at 10:40 AM, Niclas Axelsson wrote: > Hi Imre, > > Thanks for your contribution, but we can not include it into 'pu' as it is > now. > You need to follow the instructions > (https://github.com/erlang/otp/wiki/submitting-patches), and > since this is a new feature you also need to provide some test cases. I have a rather haphazard repository for parsing/unparsing of RFC 3339 "Inet Time" data (which is a subset of ISO8601), see https://github.com/jlouis/erl-webstuff which I wanted to plug earlier in this thread as there are some overlap. The main problem with the code is that I have not used it an *anger* for anything, so the API is probably not very good. It does have an inverse/one-way-isomorphic quickcheck property test though. I never envisioned it to be part of Erlang/OTP though - but contact me if you decide to use parts of it so I can release it under the EPLICENSE and avoid license-problems of any kind. -- J. From burbas@REDACTED Mon Dec 6 17:36:59 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 6 Dec 2010 17:36:59 +0100 Subject: [erlang-patches] sendfile() In-Reply-To: References: Message-ID: <4CFD112B.704@erlang.org> On 12/05/2010 12:08 AM, Tuncer Ayaz wrote: > 2010/11/9 Bj?rn Gustavsson: > >> 2010/11/1 Tuncer Ayaz: >> >>> 2010/10/20 Tuncer Ayaz: >>> >>>> 2010/10/20 Bj?rn Gustavsson: >>>> >>>>> Refetched. >>>>> >>> Please refetch. Now also with Windows support using TransmitFile(). >>> >>> >> Refetched. >> > Please refetch. Now using SetFilePointerEx in win_efile.c. > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > Thanks Tuncer. It's refetched. Regards, Niclas Axelsson, Erlang/OTP From tpodowd@REDACTED Tue Dec 7 03:40:33 2010 From: tpodowd@REDACTED (Thomas O'Dowd) Date: Tue, 07 Dec 2010 11:40:33 +0900 Subject: Improve pad character handling in base64 MIME decoding functions Message-ID: <1291689633.9415.3570.camel@rocky> Hi all, This is my first patch to OTP. Hopefully, I've ticked all the boxes. Here is the git fetch request: git fetch git://github.com/tpodowd/otp.git base64_mime_decoding This patch fixes some of the problems we've run into when decoding base64 encoded text generated by various email clients. Most of the issues are related to to many padding characters at the end of the text. A typical example is "abcd====" where the trailing padding is all extraneous. After reading RFC4648, I decided that we should implement the MAY clauses for MIME base64 decoding. This patch breaks one existing unit test. - %% One pad, followed by ignored text - <<"Hello World">> = base64:mime_decode(<<"SGVsb)(G8gV29ybGQ=apa">>), + %% One pad to ignore, followed by more text + <<"Hello World!!">> = base64:mime_decode(<<"SGVsb)(G8gV29ybGQ=h IQ= =">>), In the old test the trailing "apa" text is ignored as it follows a pad character. RFC4648 states that we MAY ignore pad characters that are followed by further text by treating them the same as illegal characters. As such, I have left the pad as-is and followed it up with the same number of valid base64 characters but which decode to something a bit more friendlier and added the proper "==" padding to correctly terminate the encoded stream. Given the new test, the old implementation would still return <<"Hello World">> without the trailing "!!". I took the liberty of adding more tests and also added tests for the two different implementations for mime_decode/1 and mime_decode_to_string/1. All base64 tests pass currently. Best regards, Tom. From burbas@REDACTED Tue Dec 7 09:12:42 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 7 Dec 2010 09:12:42 +0100 Subject: [erlang-patches] [PATCH] Set WINVER and _WIN32_WINNT to 0x0501 In-Reply-To: <4CFCFBCE.1050906@erlang.org> References: <1291481089-22974-1-git-send-email-tuncer.ayaz@gmail.com> <4CFCFBCE.1050906@erlang.org> Message-ID: <4CFDEC7A.6070206@erlang.org> On 12/06/2010 04:05 PM, Niclas Axelsson wrote: > On 12/04/2010 05:44 PM, Tuncer Ayaz wrote: >> The Windows implementation of inet:getifaddrs/0 depends on >> WINVER>= 0x0501. Update WINVER and _WIN32_WINNT definitions >> accordingly. >> --- >> erts/configure.in | 2 +- >> lib/erl_interface/configure.in | 2 +- >> lib/wx/configure.in | 8 ++++---- >> 3 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/erts/configure.in b/erts/configure.in >> index 8d629c2..7820a6b 100644 >> --- a/erts/configure.in >> +++ b/erts/configure.in >> @@ -389,7 +389,7 @@ case $host_os in >> win32) >> # The ethread library requires _WIN32_WINNT of at least 0x0403. >> # -D_WIN32_WINNT=* from CPPFLAGS is saved in ETHR_DEFS. >> - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500 -DWINVER=0x0500" >> + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501 -DWINVER=0x0501" >> # _USE_32BIT_TIME_T is needed when using VC++ 2005 (ctime() >> will fail >> # otherwise since we pass it a 32-bit value). >> # >> diff --git a/lib/erl_interface/configure.in >> b/lib/erl_interface/configure.in >> index 72ac8c7..0bb94e5 100644 >> --- a/lib/erl_interface/configure.in >> +++ b/lib/erl_interface/configure.in >> @@ -288,7 +288,7 @@ case "$threads_disabled" in >> ;; >> win32_threads) >> EI_THREADS="true" >> - THR_DEFS="$THR_DEFS -D_WIN32_WINNT=0x0500 -DWINVER=0x0500" >> + THR_DEFS="$THR_DEFS -D_WIN32_WINNT=0x0501 -DWINVER=0x0501" >> ;; >> pthread) >> EI_THREADS="true" >> diff --git a/lib/wx/configure.in b/lib/wx/configure.in >> index f7128db..ada52f9 100755 >> --- a/lib/wx/configure.in >> +++ b/lib/wx/configure.in >> @@ -145,14 +145,14 @@ case $host_os in >> CPPFLAGS="$CPPFLAGS -D_MACOSX $PTHR_CFLAGS" >> ;; >> mingw32) >> - CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0500 -D_WINDOWS -D_UNICODE >> -DUNICODE" >> - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500" >> + CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0501 -D_WINDOWS -D_UNICODE >> -DUNICODE" >> + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501" >> AC_MSG_WARN([Reverting to 32-bit time_t]) >> CPPFLAGS="$CPPFLAGS -D_USE_32BIT_TIME_T" >> ;; >> win32) >> - CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0500 -D_WINDOWS -D_UNICODE >> -DUNICODE" >> - CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0500" >> + CFLAGS="$CFLAGS -DWIN32 -DWINVER=0x0501 -D_WINDOWS -D_UNICODE >> -DUNICODE" >> + CPPFLAGS="$CPPFLAGS -D_WIN32_WINNT=0x0501" >> ;; >> *) >> CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE $PTHR_CFLAGS" >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thank you, Tuncer. Will include this into 'pu'. > > Regards, > Niclas Axelsson, Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED Hi again, A correction from my last answer. We will not include your patch into 'pu' since your patch will drop the support for Windows 2000. Regards, Niclas Axelsson, Erlang/OTP From tuncer.ayaz@REDACTED Tue Dec 7 12:10:14 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Tue, 7 Dec 2010 12:10:14 +0100 Subject: [erlang-patches] [PATCH] Set WINVER and _WIN32_WINNT to 0x0501 In-Reply-To: <4CFDEC7A.6070206@erlang.org> References: <1291481089-22974-1-git-send-email-tuncer.ayaz@gmail.com> <4CFCFBCE.1050906@erlang.org> <4CFDEC7A.6070206@erlang.org> Message-ID: On Tue, Dec 7, 2010 at 9:12 AM, Niclas Axelsson wrote: > > Hi again, > A correction from my last answer. We will not include your patch > into 'pu' since your patch will drop the support for Windows 2000. Yes that's right and I pondered whether I should mention that in the commit message. Guess I should have :). Reading the docs about the features used it said Windows XP or Windows Server 2003 are the minimum required versions. I've had another less straight-forward fix in my mind but went with the simple and obvious patch just to correct the build failure so that I could build and test the sendfile change to win_efile. Raimo told me you guys already solved the issue internally. Thanks again. Looking forward to see your solution. From burbas@REDACTED Wed Dec 8 10:06:44 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 8 Dec 2010 10:06:44 +0100 Subject: [erlang-patches] Improve pad character handling in base64 MIME decoding functions In-Reply-To: <1291689633.9415.3570.camel@rocky> References: <1291689633.9415.3570.camel@rocky> Message-ID: <4CFF4AA4.6020802@erlang.org> On 12/07/2010 03:40 AM, Thomas O'Dowd wrote: > Hi all, > > This is my first patch to OTP. Hopefully, I've ticked all the boxes. > > Here is the git fetch request: > git fetch git://github.com/tpodowd/otp.git base64_mime_decoding > > This patch fixes some of the problems we've run into when decoding > base64 encoded text generated by various email clients. Most of the > issues are related to to many padding characters at the end of the text. > A typical example is "abcd====" where the trailing padding is all > extraneous. > > After reading RFC4648, I decided that we should implement the MAY > clauses for MIME base64 decoding. > > This patch breaks one existing unit test. > > - %% One pad, followed by ignored text > -<<"Hello World">> = base64:mime_decode(<<"SGVsb)(G8gV29ybGQ=apa">>), > + %% One pad to ignore, followed by more text > +<<"Hello World!!">> = base64:mime_decode(<<"SGVsb)(G8gV29ybGQ=h IQ= =">>), > > In the old test the trailing "apa" text is ignored as it follows a pad > character. RFC4648 states that we MAY ignore pad characters that are followed > by further text by treating them the same as illegal characters. As such, I > have left the pad as-is and followed it up with the same number of valid > base64 characters but which decode to something a bit more friendlier and > added the proper "==" padding to correctly terminate the encoded stream. > > Given the new test, the old implementation would still return<<"Hello World">> > without the trailing "!!". > > I took the liberty of adding more tests and also added tests for the two > different implementations for mime_decode/1 and mime_decode_to_string/1. All > base64 tests pass currently. > > Best regards, > > Tom. > > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thank you, Tom. Will include your patch into 'pu'. But since it breaks the behaviour (and might not be backwards compatible), I can not guarantee it will be merged into 'dev'. Regards, Niclas Axelsson, Erlang/OTP From fdmanana@REDACTED Wed Dec 8 12:38:44 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 8 Dec 2010 11:38:44 +0000 Subject: [erlang-patches] [PATCH] httpc module - allow streaming of bodies for PUT and POST requests In-Reply-To: References: Message-ID: Any particular reason why nobody from the OTP team made the refetch? thanks 2010/12/1 Filipe David Manana : > For easier management, I squashed all the commits into a new branch: > > git fetch git://github.com/fdmanana/otp.git httpc_upload_streaming > > thanks > > 2010/12/1 Filipe David Manana : >> Please refetch. I committed 2 more changes that simplify both the >> implementation and interface. >> >> git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming >> >> thanks >> >> 2010/10/13 Bj?rn Gustavsson : >>> 2010/10/12 Filipe David Manana : >>>> Hi, >>>> >>>> In the previous patch I forgot to add the documentation for the new >>>> chunkify function body parameter. >>>> I updated my git branch with it: >>>> >>>> git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming >>>> >>> >>> Thanks! Updated. I combined your new commit with the >>> previous commit. >>> >>> -- >>> Bj?rn Gustavsson, Erlang/OTP, Ericsson AB >>> >>> ________________________________________________________________ >>> erlang-patches (at) erlang.org mailing list. >>> See http://www.erlang.org/faq.html >>> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >>> >>> >> >> >> >> -- >> Filipe David Manana, >> fdmanana@REDACTED, fdmanana@REDACTED >> >> "Reasonable men adapt themselves to the world. >> ?Unreasonable men adapt the world to themselves. >> ?That's why all progress depends on unreasonable men." >> > > > > -- > Filipe David Manana, > fdmanana@REDACTED, fdmanana@REDACTED > > "Reasonable men adapt themselves to the world. > ?Unreasonable men adapt the world to themselves. > ?That's why all progress depends on unreasonable men." > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From burbas@REDACTED Wed Dec 8 13:28:15 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 8 Dec 2010 13:28:15 +0100 Subject: [erlang-patches] [PATCH] httpc module - allow streaming of bodies for PUT and POST requests In-Reply-To: References: Message-ID: <4CFF79DF.3050901@erlang.org> On 12/08/2010 12:38 PM, Filipe David Manana wrote: > Any particular reason why nobody from the OTP team made the refetch? > > thanks > > 2010/12/1 Filipe David Manana: > >> For easier management, I squashed all the commits into a new branch: >> >> git fetch git://github.com/fdmanana/otp.git httpc_upload_streaming >> >> thanks >> >> 2010/12/1 Filipe David Manana: >> >>> Please refetch. I committed 2 more changes that simplify both the >>> implementation and interface. >>> >>> git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming >>> >>> thanks >>> >>> 2010/10/13 Bj?rn Gustavsson: >>> >>>> 2010/10/12 Filipe David Manana: >>>> >>>>> Hi, >>>>> >>>>> In the previous patch I forgot to add the documentation for the new >>>>> chunkify function body parameter. >>>>> I updated my git branch with it: >>>>> >>>>> git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming >>>>> >>>>> >>>> Thanks! Updated. I combined your new commit with the >>>> previous commit. >>>> >>>> -- >>>> Bj?rn Gustavsson, Erlang/OTP, Ericsson AB >>>> >>>> ________________________________________________________________ >>>> erlang-patches (at) erlang.org mailing list. >>>> See http://www.erlang.org/faq.html >>>> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >>>> >>>> >>>> >>> >>> >>> -- >>> Filipe David Manana, >>> fdmanana@REDACTED, fdmanana@REDACTED >>> >>> "Reasonable men adapt themselves to the world. >>> Unreasonable men adapt the world to themselves. >>> That's why all progress depends on unreasonable men." >>> >>> >> >> >> -- >> Filipe David Manana, >> fdmanana@REDACTED, fdmanana@REDACTED >> >> "Reasonable men adapt themselves to the world. >> Unreasonable men adapt the world to themselves. >> That's why all progress depends on unreasonable men." >> >> > > > Hi Filipe, Sorry for the long wait. I will refetch your patch. Regards, Niclas Axelsson, Erlang/OTP From fdmanana@REDACTED Wed Dec 8 13:35:48 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 8 Dec 2010 12:35:48 +0000 Subject: [erlang-patches] [PATCH] httpc module - allow streaming of bodies for PUT and POST requests In-Reply-To: <4CFF79DF.3050901@erlang.org> References: <4CFF79DF.3050901@erlang.org> Message-ID: Thanks Niclas. Just wanted to know if the patch didn't follow some necessary rule/convention. regards, 2010/12/8 Niclas Axelsson : > On 12/08/2010 12:38 PM, Filipe David Manana wrote: >> >> Any particular reason why nobody from the OTP team made the refetch? >> >> thanks >> >> 2010/12/1 Filipe David Manana: >> >>> >>> For easier management, I squashed all the commits into a new branch: >>> >>> git fetch git://github.com/fdmanana/otp.git httpc_upload_streaming >>> >>> thanks >>> >>> 2010/12/1 Filipe David Manana: >>> >>>> >>>> Please refetch. I committed 2 more changes that simplify both the >>>> implementation and interface. >>>> >>>> git fetch git://github.com/fdmanana/otp.git httpc_upload_body_streaming >>>> >>>> thanks >>>> >>>> 2010/10/13 Bj?rn Gustavsson: >>>> >>>>> >>>>> 2010/10/12 Filipe David Manana: >>>>> >>>>>> >>>>>> Hi, >>>>>> >>>>>> In the previous patch I forgot to add the documentation for the new >>>>>> chunkify function body parameter. >>>>>> I updated my git branch with it: >>>>>> >>>>>> git fetch git://github.com/fdmanana/otp.git >>>>>> httpc_upload_body_streaming >>>>>> >>>>>> >>>>> >>>>> Thanks! Updated. I combined your new commit with the >>>>> previous commit. >>>>> >>>>> -- >>>>> Bj?rn Gustavsson, Erlang/OTP, Ericsson AB >>>>> >>>>> ________________________________________________________________ >>>>> erlang-patches (at) erlang.org mailing list. >>>>> See http://www.erlang.org/faq.html >>>>> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Filipe David Manana, >>>> fdmanana@REDACTED, fdmanana@REDACTED >>>> >>>> "Reasonable men adapt themselves to the world. >>>> ?Unreasonable men adapt the world to themselves. >>>> ?That's why all progress depends on unreasonable men." >>>> >>>> >>> >>> >>> -- >>> Filipe David Manana, >>> fdmanana@REDACTED, fdmanana@REDACTED >>> >>> "Reasonable men adapt themselves to the world. >>> ?Unreasonable men adapt the world to themselves. >>> ?That's why all progress depends on unreasonable men." >>> >>> >> >> >> > > Hi Filipe, > Sorry for the long wait. I will refetch your patch. > > Regards, > Niclas Axelsson, Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From tpodowd@REDACTED Thu Dec 9 02:51:07 2010 From: tpodowd@REDACTED (Thomas O'Dowd) Date: Thu, 09 Dec 2010 10:51:07 +0900 Subject: [erlang-patches] Improve pad character handling in base64 MIME decoding functions In-Reply-To: <4CFF4AA4.6020802@erlang.org> References: <1291689633.9415.3570.camel@rocky> <4CFF4AA4.6020802@erlang.org> Message-ID: <1291859467.9415.3674.camel@rocky> On Wed, 2010-12-08 at 10:06 +0100, Niclas Axelsson wrote: > Thank you, Tom. Will include your patch into 'pu'. But since it breaks the > behaviour (and might not be backwards compatible), I can not guarantee > it will > be merged into 'dev'. > > Regards, > Niclas Axelsson, Erlang/OTP Hi Niclas, Thanks for your time! Btw. I also noticed some inconsistencies in the older implementation between mime_decode_to_string/1 and mime_decode/1 when I was reading the code and deciding how to fixing the padding character handling. The inconsistency happens when 2 padding characters would be required to complete the data but more data is found between the 2 padding characters. 1> base64:mime_decode(<<"ab=cd=">>). <<"i">> 2> base64:mime_decode_to_string(<<"ab=cd=">>). ** exception error: no function clause matching base64:b64d_ok(eq) in function base64:decode/2 With the new patch the result is consistent between the two functions (although the result is different as it decodes more). 1> base64:mime_decode(<<"ab=cd=">>). <<105,183,29>> 2> base64:mime_decode_to_string(<<"ab=cd=">>). [105,183,29] Also, previously in the two pad case, the code also skips extra trailing padding but for any other case it doesn't. Here is an example. Note that it works for 3, but not for 4 and 5. 3> base64:mime_decode(<<"ab======">>). <<"i">> 4> base64:mime_decode(<<"abc=====">>). ** exception error: no match of right hand side value <<105,183,0:2>> in function base64:mime_decode_binary/2 5> base64:mime_decode(<<"abcd====">>). ** exception error: no match of right hand side value <<105,183,29>> in function base64:mime_decode_binary/2 The patch fixes this inconsistency also. 3> base64:mime_decode(<<"ab======">>). <<"i">> 4> base64:mime_decode(<<"abc=====">>). <<"i?">> 5> base64:mime_decode(<<"abcd====">>). <<105,183,29>> Regarding backwards compatibility, extra pad characters either embedded in the MIME base64 encoded stream or at the end of the stream is quite rare as a good base64 encoder should never generate such data. So backwards compatibility should not be a major concern in this respect I think. FYI, my other favourite language Python can decode each of the examples I listed above with the same results as the new patch. So that is nice. Haven't tried other languages. >>> base64.decodestring("abcd====") 'i\xb7\x1d' >>> base64.decodestring("abc====") 'i\xb7' >>> base64.decodestring("ab====") 'i' >>> base64.decodestring("ab=cd=") 'i\xb7\x1d' Sorry for the long mail but just thought the extra information might help. Tom. From tuncer.ayaz@REDACTED Thu Dec 9 16:13:53 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Thu, 9 Dec 2010 16:13:53 +0100 Subject: Fix a couple typos in filename encoding docs Message-ID: git fetch git://github.com/tuncer/otp.git typos From burbas@REDACTED Fri Dec 10 10:38:56 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Fri, 10 Dec 2010 10:38:56 +0100 Subject: [erlang-patches] Fix a couple typos in filename encoding docs In-Reply-To: References: Message-ID: <4D01F530.8020607@erlang.org> On 12/09/2010 04:13 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git typos > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thanks Tuncer. Will include your patch into 'dev'. Regards, Niclas Axelsson, Erlang/OTP From boris.muehmer@REDACTED Fri Dec 10 16:26:40 2010 From: boris.muehmer@REDACTED (Boris =?ISO-8859-1?Q?M=FChmer?=) Date: Fri, 10 Dec 2010 16:26:40 +0100 Subject: Fix for Makefile.in invoking xref_mod_app.escript Message-ID: <1291994800.3298.79.camel@yang> This fix modifies "Makefile.in" in such a way, that the target mod2app doesn't invoke the Erlang script "xref_mod_app.escript" using the program "env", but instead uses the local "escript" program for the call. The reason for the fix is, that either "env" can't find "escript" (Erlang isn't installed, or is at a location where it can't be found) or an outdated version of escript might be called. And here it is: git fetch git://github.com/bsmr/otp.git fix_makefile_in_for_xref_mod_app_escript Besides, sorry for the long name. - boris From burbas@REDACTED Fri Dec 10 16:43:53 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Fri, 10 Dec 2010 16:43:53 +0100 Subject: [erlang-patches] Fix for Makefile.in invoking xref_mod_app.escript In-Reply-To: <1291994800.3298.79.camel@yang> References: <1291994800.3298.79.camel@yang> Message-ID: <4D024AB9.7030603@erlang.org> On 12/10/2010 04:26 PM, Boris M?hmer wrote: > This fix modifies "Makefile.in" in such a way, that the target mod2app > doesn't invoke the Erlang script "xref_mod_app.escript" using the > program "env", but instead uses the local "escript" program for the > call. > > The reason for the fix is, that either "env" can't find > "escript" (Erlang isn't installed, or is at a location where it can't be > found) or an outdated version of escript might be called. > > And here it is: > > git fetch git://github.com/bsmr/otp.git fix_makefile_in_for_xref_mod_app_escript > > > Besides, sorry for the long name. > > > - boris > > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Hi Boris, Thank you for the patch, I will include it into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From vbatichko@REDACTED Fri Dec 10 17:41:05 2010 From: vbatichko@REDACTED (Vitaliy Batichko) Date: Fri, 10 Dec 2010 18:41:05 +0200 Subject: Some ei & erl_interface fixes Message-ID: Hi, This branch contains some fixes and support for formatting char, erlang PID for ei_format function. Please find below description for each commit. Fetch command: git fetch git://github.com/bva/otp.git ei_exts commit 384b85a75212cf73253f901a8c88d4286a5962ba Author: Vitaliy Batichko Date: ? Fri Dec 10 16:38:13 2010 +0200 ? ?Fix wrong erl_compare_ext result comparing lists ? ?Function erl_compare_ext of erl_interface library returns ? ?1 instead -1 when comparing lists like [0] and [0, 1000]. ? ?Credits to: Evgeny Khirin erlios.com> commit 7992d6a6bfa0f460f8663c2d72d07b60755a4857 Author: Vitaliy Batichko Date: ? Mon Nov 29 20:42:28 2010 +0200 ? ?Correct erl_global{register, unregister} functions ? ?C node needs DFLAG_DIST_MONITOR flag set when connecting, ? ?and support for processing monitoring start/end messages ? ?received from counterpart, to make global registration ? ?actually work. commit 95392e693e210189df82173c9bcd345b58b004fe Author: Vitaliy Batichko Date: ? Tue Nov 23 18:44:24 2010 +0200 ? ?Add PID (~p) type parameters to ei_format commit ad5b84bd154e27d9e4db3af12b8b4326c564b2bf Author: Vitaliy Batichko Date: ? Tue Nov 23 17:08:01 2010 +0200 ? ?Add char (~c) type parameters to ei_format From markus@REDACTED Fri Dec 10 19:14:08 2010 From: markus@REDACTED (Markus Knofe) Date: Fri, 10 Dec 2010 19:14:08 +0100 Subject: [PATCH] Fix list returned by net_kernel:epmd_module Message-ID: <4D026DF0.1020908@knofe.net> Function epmd_module of net_kernel returns a list instead of an atom, when the epmd_module-flag is used. --- lib/kernel/src/net_kernel.erl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/kernel/src/net_kernel.erl b/lib/kernel/src/net_kernel.erl index f5e2820..6c2e0f5 100644 --- a/lib/kernel/src/net_kernel.erl +++ b/lib/kernel/src/net_kernel.erl @@ -1254,7 +1254,7 @@ protocol_childspecs([H|T]) -> epmd_module() -> case init:get_argument(epmd_module) of {ok,[[Module]]} -> - Module; + list_to_atom(Module); _ -> erl_epmd end. -- 1.7.1 From tuncer.ayaz@REDACTED Sat Dec 11 20:05:52 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sat, 11 Dec 2010 20:05:52 +0100 Subject: [erlang-patches] [PATCH] ssh: ensure ~/.ssh exists In-Reply-To: References: <1283462802-98683-1-git-send-email-tuncer.ayaz@gmail.com> <1283511162-8340-1-git-send-email-tuncer.ayaz@gmail.com> Message-ID: 2010/9/3 Bj?rn Gustavsson: > On Fri, Sep 3, 2010 at 12:52 PM, Tuncer Ayaz wrote: >> Make sure that ~/.ssh exists before trying to open files like >> ~/.ssh/known_hosts. >> >> Reported-By: Daniel Goertzen >> --- > > Thanks! Will include in pu. git fetch git://github.com/tuncer/otp.git ssh-ensure-userdir Please refetch. Removed local chmod/2 in favor of file:change_mode/2. From matthias@REDACTED Sun Dec 12 23:52:22 2010 From: matthias@REDACTED (Matthias Lang) Date: Sun, 12 Dec 2010 23:52:22 +0100 Subject: trivial patch: be more informative when exiting due to EOF Message-ID: <20101212225222.GA3819@corelatus.se> Hi, git fetch git://github.com/matthiasl/otp.git better-error-message-on-shell-input-eof Be more helpful when the shell encounters EOF The shell terminates the VM when EOF is hit on stdin. Give the user a better clue about what's happened and how to avoid the problem. Useful for people who run Erlang from 'cron' or '.forward' (If you do this: >erl -s some_module go -s init stop < /dev/null then some_module:go() will get called and killed a bit later. The old error message didn't give much of a clue as to what was going on.) Matt ---------------------------------------------------------------------- diff --git a/lib/stdlib/src/shell.erl b/lib/stdlib/src/shell.erl index ebb221c..c156cb7 100644 --- a/lib/stdlib/src/shell.erl +++ b/lib/stdlib/src/shell.erl @@ -280,10 +280,14 @@ server_loop(N0, Eval_0, Bs00, RT, Ds00, History0, Results0) -> [N]), server_loop(N0, Eval0, Bs0, RT, Ds0, History0, Results0); {eof,_EndLine} -> - fwrite_severity(fatal, <<"Terminating erlang (~w)">>, [node()]), + fwrite_severity(fatal, <<"EOF on stdin (did you mean to use " + "-noinput?). Terminating erlang (~w)">>, + [node()]), halt(); eof -> - fwrite_severity(fatal, <<"Terminating erlang (~w)">>, [node()]), + fwrite_severity(fatal, <<"EOF on stdin (did you mean to use " + "-noinput?). Terminating erlang (~w)">>, + [node()]), halt() end. From fdmanana@REDACTED Mon Dec 13 16:17:18 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Mon, 13 Dec 2010 15:17:18 +0000 Subject: [PATCH] - module dict man page Message-ID: The following trivial patch fixes two grammar errors and one inconsistency in the man page of the 'dict' module. git fetch git://github.com/fdmanana/otp.git dict_man_page Thanks. -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From burbas@REDACTED Mon Dec 13 17:38:35 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 13 Dec 2010 17:38:35 +0100 Subject: [erlang-patches] [PATCH] ssh: ensure ~/.ssh exists In-Reply-To: References: <1283462802-98683-1-git-send-email-tuncer.ayaz@gmail.com> <1283511162-8340-1-git-send-email-tuncer.ayaz@gmail.com> Message-ID: <4D064C0B.6020105@erlang.org> On 12/11/2010 08:05 PM, Tuncer Ayaz wrote: > 2010/9/3 Bj?rn Gustavsson: > >> On Fri, Sep 3, 2010 at 12:52 PM, Tuncer Ayaz wrote: >> >>> Make sure that ~/.ssh exists before trying to open files like >>> ~/.ssh/known_hosts. >>> >>> Reported-By: Daniel Goertzen >>> --- >>> >> Thanks! Will include in pu. >> > git fetch git://github.com/tuncer/otp.git ssh-ensure-userdir > > Please refetch. Removed local chmod/2 in favor of file:change_mode/2. > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > Thanks Tuncer, Your patch is refetched and included in 'pu'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Mon Dec 13 17:38:38 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 13 Dec 2010 17:38:38 +0100 Subject: [erlang-patches] Some ei & erl_interface fixes In-Reply-To: References: Message-ID: <4D064C0E.3090502@erlang.org> On 12/10/2010 05:41 PM, Vitaliy Batichko wrote: > Hi, > > This branch contains some fixes and support for > formatting char, erlang PID for ei_format function. > > Please find below description for each commit. > > Fetch command: > git fetch git://github.com/bva/otp.git ei_exts > > > > commit 384b85a75212cf73253f901a8c88d4286a5962ba > Author: Vitaliy Batichko > Date: Fri Dec 10 16:38:13 2010 +0200 > > Fix wrong erl_compare_ext result comparing lists > > Function erl_compare_ext of erl_interface library returns > 1 instead -1 when comparing lists like [0] and [0, 1000]. > > Credits to: Evgeny Khirin erlios.com> > > commit 7992d6a6bfa0f460f8663c2d72d07b60755a4857 > Author: Vitaliy Batichko > Date: Mon Nov 29 20:42:28 2010 +0200 > > Correct erl_global{register, unregister} functions > > C node needs DFLAG_DIST_MONITOR flag set when connecting, > and support for processing monitoring start/end messages > received from counterpart, to make global registration > actually work. > > commit 95392e693e210189df82173c9bcd345b58b004fe > Author: Vitaliy Batichko > Date: Tue Nov 23 18:44:24 2010 +0200 > > Add PID (~p) type parameters to ei_format > > commit ad5b84bd154e27d9e4db3af12b8b4326c564b2bf > Author: Vitaliy Batichko > Date: Tue Nov 23 17:08:01 2010 +0200 > > Add char (~c) type parameters to ei_format > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED Hi Vitaliy, Thanks for your patch. Will include it into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Mon Dec 13 17:38:41 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 13 Dec 2010 17:38:41 +0100 Subject: [erlang-patches] [PATCH] - module dict man page In-Reply-To: References: Message-ID: <4D064C11.6060504@erlang.org> On 12/13/2010 04:17 PM, Filipe David Manana wrote: > The following trivial patch fixes two grammar errors and one > inconsistency in the man page of the 'dict' module. > > git fetch git://github.com/fdmanana/otp.git dict_man_page > > Thanks. > > > Thanks Filipe, Will include it into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From fdmanana@REDACTED Mon Dec 13 19:07:15 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Mon, 13 Dec 2010 18:07:15 +0000 Subject: [erlang-patches] [PATCH] - module dict man page In-Reply-To: <4D064C11.6060504@erlang.org> References: <4D064C11.6060504@erlang.org> Message-ID: Can you please refetch? I noticied that the 'orddict' man page suffers the exact same issues (a copy-paste curse :) and made another commit to the branch. Thanks On Mon, Dec 13, 2010 at 4:38 PM, Niclas Axelsson wrote: > On 12/13/2010 04:17 PM, Filipe David Manana wrote: >> >> The following trivial patch fixes two grammar errors and one >> inconsistency in the man page of the 'dict' module. >> >> git fetch git://github.com/fdmanana/otp.git dict_man_page >> >> Thanks. >> >> >> > > Thanks Filipe, > Will include it into 'pu'. > > Regards, > Niclas Axelsson, Erlang/OTP > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From tuncer.ayaz@REDACTED Tue Dec 14 00:11:03 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Tue, 14 Dec 2010 00:11:03 +0100 Subject: Fix two typos in erlsrv log messages Message-ID: git fetch git://github.com/tuncer/otp.git erlsrv-typos From burbas@REDACTED Tue Dec 14 10:01:58 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 14 Dec 2010 10:01:58 +0100 Subject: [erlang-patches] [PATCH] - module dict man page In-Reply-To: References: <4D064C11.6060504@erlang.org> Message-ID: <4D073286.70601@erlang.org> On 12/13/2010 07:07 PM, Filipe David Manana wrote: > Can you please refetch? > > I noticied that the 'orddict' man page suffers the exact same issues > (a copy-paste curse :) and made another commit to the branch. > > Thanks > > On Mon, Dec 13, 2010 at 4:38 PM, Niclas Axelsson wrote: > >> On 12/13/2010 04:17 PM, Filipe David Manana wrote: >> >>> The following trivial patch fixes two grammar errors and one >>> inconsistency in the man page of the 'dict' module. >>> >>> git fetch git://github.com/fdmanana/otp.git dict_man_page >>> >>> Thanks. >>> >>> >>> >>> >> Thanks Filipe, >> Will include it into 'pu'. >> >> Regards, >> Niclas Axelsson, Erlang/OTP >> >> > > > Thanks Filipe. I have refetched your branch. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Tue Dec 14 10:09:59 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 14 Dec 2010 10:09:59 +0100 Subject: [erlang-patches] trivial patch: be more informative when exiting due to EOF In-Reply-To: <20101212225222.GA3819@corelatus.se> References: <20101212225222.GA3819@corelatus.se> Message-ID: <4D073467.5060402@erlang.org> On 12/12/2010 11:52 PM, Matthias Lang wrote: > Hi, > > git fetch git://github.com/matthiasl/otp.git better-error-message-on-shell-input-eof > > Be more helpful when the shell encounters EOF > > The shell terminates the VM when EOF is hit on stdin. Give the > user a better clue about what's happened and how to avoid the > problem. Useful for people who run Erlang from 'cron' or '.forward' > > (If you do this: > > >erl -s some_module go -s init stop< /dev/null > > then some_module:go() will get called and killed a bit later. The old > error message didn't give much of a clue as to what was going on.) > > Matt > > ---------------------------------------------------------------------- > > diff --git a/lib/stdlib/src/shell.erl b/lib/stdlib/src/shell.erl > index ebb221c..c156cb7 100644 > --- a/lib/stdlib/src/shell.erl > +++ b/lib/stdlib/src/shell.erl > @@ -280,10 +280,14 @@ server_loop(N0, Eval_0, Bs00, RT, Ds00, History0, Results0) -> > [N]), > server_loop(N0, Eval0, Bs0, RT, Ds0, History0, Results0); > {eof,_EndLine} -> > - fwrite_severity(fatal,<<"Terminating erlang (~w)">>, [node()]), > + fwrite_severity(fatal,<<"EOF on stdin (did you mean to use" > + "-noinput?). Terminating erlang (~w)">>, > + [node()]), > halt(); > eof -> > - fwrite_severity(fatal,<<"Terminating erlang (~w)">>, [node()]), > + fwrite_severity(fatal,<<"EOF on stdin (did you mean to use" > + "-noinput?). Terminating erlang (~w)">>, > + [node()]), > halt() > end. > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thanks Matthias, Will include your patch into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Tue Dec 14 10:11:32 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 14 Dec 2010 10:11:32 +0100 Subject: [erlang-patches] Fix two typos in erlsrv log messages In-Reply-To: References: Message-ID: <4D0734C4.3000309@erlang.org> On 12/14/2010 12:11 AM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git erlsrv-typos > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thanks Tuncer, I will merge your branch into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From imi.horvath@REDACTED Tue Dec 14 23:26:26 2010 From: imi.horvath@REDACTED (Imre Horvath) Date: Tue, 14 Dec 2010 23:26:26 +0100 Subject: [erlang-patches] week number support In-Reply-To: References: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> <4CFCAF83.9080600@erlang.org> Message-ID: Hi Niclas! Hi OTP Team! I have added the missing support for calculating the week number to the calendar module in the stdlib application. This implementation conforms to the ISO 8601 hence the name iso week number. Implementation is added, test suit for calendar extended with test case and also the documentation of calendar has been updated. Testing was successful. Please fetch! git fetch git://github.com/imrehorvath/otp.git iso_8601_erl Best regards, Imre From burbas@REDACTED Wed Dec 15 09:56:16 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 15 Dec 2010 09:56:16 +0100 Subject: [erlang-patches] week number support In-Reply-To: References: <430CE66B-5C3C-42F6-9620-ADDC84427CA5@gmail.com> <4CFCAF83.9080600@erlang.org> Message-ID: <4D0882B0.8040202@erlang.org> On 12/14/2010 11:26 PM, Imre Horvath wrote: > Hi Niclas! Hi OTP Team! > > I have added the missing support for calculating the week number to > the calendar module in the stdlib application. > > This implementation conforms to the ISO 8601 hence the name iso week > number. > > Implementation is added, test suit for calendar extended with test > case and also the documentation of calendar has been updated. > > Testing was successful. > > Please fetch! > > git fetch git://github.com/imrehorvath/otp.git > iso_8601_erl > > Best regards, > ImreHi Thanks Imre, Your patch looks good so I will include it into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From spawn.think@REDACTED Wed Dec 15 11:36:27 2010 From: spawn.think@REDACTED (Ahmed Omar) Date: Wed, 15 Dec 2010 11:36:27 +0100 Subject: Fix for a race condition in percept Message-ID: Fixes a race condition found in percept_db start/1 function. When function start/1 finds an instance of percept_db running, it will send a message to stop it and spawn a process to start a new one, which leads to a race condition. The function will return {restarted, pid()} but the pid() will die once it tries to create the ets table. git fetch git://github.com/spawnthink/otp.git percept_race_cond -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think From burbas@REDACTED Wed Dec 15 11:52:56 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 15 Dec 2010 11:52:56 +0100 Subject: [erlang-patches] Fix for a race condition in percept In-Reply-To: References: Message-ID: <4D089E08.7030001@erlang.org> On 12/15/2010 11:36 AM, Ahmed Omar wrote: > Fixes a race condition found in percept_db start/1 function. > > When function start/1 finds an instance of percept_db running, it will > send a message to stop it and spawn a process to start a new one, > which leads to a race condition. > The function will return {restarted, pid()} but the pid() will die > once it tries to create the ets table. > > > git fetch git://github.com/spawnthink/otp.git percept_race_cond > > Hi Ahmed, Thanks for your patch. Will include it into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Wed Dec 15 12:04:24 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 15 Dec 2010 12:04:24 +0100 Subject: [erlang-patches] [PATCH] Fix list returned by net_kernel:epmd_module In-Reply-To: <4D026DF0.1020908@knofe.net> References: <4D026DF0.1020908@knofe.net> Message-ID: <4D08A0B8.2000703@erlang.org> On 12/10/2010 07:14 PM, Markus Knofe wrote: > Function epmd_module of net_kernel returns a list > instead of an atom, when the epmd_module-flag is used. > --- > lib/kernel/src/net_kernel.erl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/kernel/src/net_kernel.erl b/lib/kernel/src/net_kernel.erl > index f5e2820..6c2e0f5 100644 > --- a/lib/kernel/src/net_kernel.erl > +++ b/lib/kernel/src/net_kernel.erl > @@ -1254,7 +1254,7 @@ protocol_childspecs([H|T]) -> > epmd_module() -> > case init:get_argument(epmd_module) of > {ok,[[Module]]} -> > - Module; > + list_to_atom(Module); > _ -> > erl_epmd > end. > Thanks Markus, I will include your patch into 'pu'. Regards, Niclas Axelsson From fdmanana@REDACTED Wed Dec 15 12:51:57 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 15 Dec 2010 11:51:57 +0000 Subject: [PATCH] - unix_efile.c bad arg type passed to strncat call Message-ID: The following patch fixes the type of the third argument passed to a call to strncat (should be of type size_t and not size_t *). git fetch git://github.com/fdmanana/otp.git unix_efile_readdir_fix Thanks. -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From burbas@REDACTED Wed Dec 15 13:12:46 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 15 Dec 2010 13:12:46 +0100 Subject: [erlang-patches] [PATCH] - unix_efile.c bad arg type passed to strncat call In-Reply-To: References: Message-ID: <4D08B0BE.3090804@erlang.org> On 12/15/2010 12:51 PM, Filipe David Manana wrote: > The following patch fixes the type of the third argument passed to a > call to strncat (should be of type size_t and not size_t *). > > git fetch git://github.com/fdmanana/otp.git unix_efile_readdir_fix > > Thanks. > Hi Filipe, Thanks for your patch. Will include it into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From roques@REDACTED Wed Dec 15 23:48:43 2010 From: roques@REDACTED (Christian von Roques) Date: Wed, 15 Dec 2010 18:48:43 -0400 Subject: inets/httpc: Polish documentation Message-ID: <87mxo67ius.fsf@pepper.mti.ag> git pull git://github.com/roques/otp.git httpc-docs From jesper.louis.andersen@REDACTED Thu Dec 16 04:03:14 2010 From: jesper.louis.andersen@REDACTED (Jesper Louis Andersen) Date: Thu, 16 Dec 2010 04:03:14 +0100 Subject: Fix wrong spec for ets:new/2 in HiPE/dialyzer Message-ID: Hi, The HiPE dialyzer forgot to add some cases for the new Tweak options like 'compressed' so it reports errors in lines using them. Any caller using, e.g., ets:new(foo, [{read_concurrency, true}, compressed]), will be a non-returning function to the dialyzer because neither of the Option values are in its success typing hardcoding in erl_bif_types.erl. To fix it, please fetch git fetch git://github.com/jlouis/otp.git fix-hipe-spec-ets-new As this is my first patch, please get back to me if anything is inadequate. I have attempted to follow the guide, but may have overlooked something in the process. The code survives a compile, but I have not run the release tests on it. -- J. From kostis@REDACTED Thu Dec 16 10:20:37 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Thu, 16 Dec 2010 11:20:37 +0200 Subject: [erlang-patches] Fix wrong spec for ets:new/2 in HiPE/dialyzer In-Reply-To: References: Message-ID: <4D09D9E5.5070706@cs.ntua.gr> Jesper Louis Andersen wrote: > ... To fix it, please fetch > > git fetch git://github.com/jlouis/otp.git fix-hipe-spec-ets-new > > As this is my first patch, please get back to me if anything is > inadequate. I have attempted to follow the guide, but may have > overlooked something in the process. The code survives a compile, but > I have not run the release tests on it. Thanks for noticing this and for your patch. Your Erlang code is ok, but please change some things in the comment: - adding extra spaces and the trailing | in the line which reads: Option = Type | Access | named_table | {keypos,Pos} | is totally unnecessary -- and the | is arguably wrong there - use boolean() instead of bool() and integer() instead of int(). The OTP documentation should be updated to use the proper names of these types. If you do these changes, your patch can be included as is in 'dev'. Thanks again, Kostis From spawn.think@REDACTED Thu Dec 16 11:47:47 2010 From: spawn.think@REDACTED (Ahmed Omar) Date: Thu, 16 Dec 2010 11:47:47 +0100 Subject: percept stop_webserver fix Message-ID: Fixes a bug found in percept:stop_webserver/1, where it doesn't stop the webserver completely percept:stop_webserver/1 will only stop the httpd service in inets, but not the percept_httpd process. As a result, when trying to start the webserver again it will return {error, already_started}. Test case was updated to simulate this case and fix is included to stop the webserver in a consistent way wether stop_webserver/0 or stop_webserver/1 was used. git fetch git://github.com/spawnthink/otp.git *percept_web_stop* -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think From fdmanana@REDACTED Thu Dec 16 12:26:05 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Thu, 16 Dec 2010 11:26:05 +0000 Subject: [PATCH] - grammar and typo fixes for the httpc module man page Message-ID: The following patch fixes a few grammar errors and typos in the httpc module man page: git fetch git://github.com/fdmanana/otp.git httpc_man_page_fixes best regards, -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From jesper.louis.andersen@REDACTED Thu Dec 16 13:24:40 2010 From: jesper.louis.andersen@REDACTED (Jesper Louis Andersen) Date: Thu, 16 Dec 2010 13:24:40 +0100 Subject: [erlang-patches] Fix wrong spec for ets:new/2 in HiPE/dialyzer In-Reply-To: <4D09D9E5.5070706@cs.ntua.gr> References: <4D09D9E5.5070706@cs.ntua.gr> Message-ID: On Thu, Dec 16, 2010 at 10:20, Kostis Sagonas wrote: > > Your Erlang code is ok, but please change some things in the comment: > > ?- adding extra spaces and the trailing | in the line which reads: > ? ? ? ?Option = Type | Access | ?named_table ?| ?{keypos,Pos} ?| > ? is totally unnecessary -- and the | is arguably wrong there Good catch, fixed. > ?- use boolean() instead of bool() and integer() instead of int(). > ? The OTP documentation should be updated to use the proper names > ? of these types. Fixed in the comments. I agree that there is a need to walk through the documentation and update any appearance of bool() with boolean(). Part of the reason bool() is still used by people is due to this terminology use in documentation. A quick git grep on bool\(\) suggest that there are around 3000 places to fix, as an upper bound (there may be considerably less, but not more). A daunting task, if one also need to check formatting. > If you do these changes, your patch can be included as is in 'dev'. I'll let cooking be up to you to decide :) Personally I was aiming for a cooking in 'pu' first - mind you, I have not executed the test cases on it, partially because I don't know what tests to narrow it down to. It would seem easy to include in 'pu' for a batch of testing and then just grad it to 'dev'. But as I said, your call. Ammended patch is refetchable at, git fetch git://github.com/jlouis/otp.git fix-hipe-spec-ets-new -- J. From burbas@REDACTED Thu Dec 16 17:13:49 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Thu, 16 Dec 2010 17:13:49 +0100 Subject: [erlang-patches] inets/httpc: Polish documentation In-Reply-To: <87mxo67ius.fsf@pepper.mti.ag> References: <87mxo67ius.fsf@pepper.mti.ag> Message-ID: <4D0A3ABD.4020508@erlang.org> On 12/15/2010 11:48 PM, Christian von Roques wrote: > git pull git://github.com/roques/otp.git httpc-docs > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thanks Christian, Will include your patch into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Thu Dec 16 17:46:17 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Thu, 16 Dec 2010 17:46:17 +0100 Subject: [erlang-patches] percept stop_webserver fix In-Reply-To: References: Message-ID: <4D0A4259.6050309@erlang.org> On 12/16/2010 11:47 AM, Ahmed Omar wrote: > Fixes a bug found in percept:stop_webserver/1, where it doesn't stop the > webserver completely > > > percept:stop_webserver/1 will only stop the httpd service in inets, but not > the percept_httpd process. As a result, when trying to start the webserver > again it will return {error, already_started}. Test case was updated to > simulate this case and fix is included to stop the webserver in a consistent > way wether stop_webserver/0 or stop_webserver/1 was used. > > git fetch git://github.com/spawnthink/otp.git *percept_web_stop* > > Thanks Ahmed, Will include your patch into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Thu Dec 16 17:46:59 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Thu, 16 Dec 2010 17:46:59 +0100 Subject: [erlang-patches] [PATCH] - grammar and typo fixes for the httpc module man page In-Reply-To: References: Message-ID: <4D0A4283.20108@erlang.org> On 12/16/2010 12:26 PM, Filipe David Manana wrote: > The following patch fixes a few grammar errors and typos in the httpc > module man page: > > git fetch git://github.com/fdmanana/otp.git httpc_man_page_fixes > > best regards, > > Hi Filipe, Christian von Roques posted a patch yesterday that also corrected the grammar of the httpc man page. There was a lot of similarities between your patch and Christians, but you had some fixes that Christian may have missed so I will include your fix into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From fdmanana@REDACTED Thu Dec 16 19:21:17 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Thu, 16 Dec 2010 18:21:17 +0000 Subject: [erlang-patches] [PATCH] - grammar and typo fixes for the httpc module man page In-Reply-To: <4D0A4283.20108@erlang.org> References: <4D0A4283.20108@erlang.org> Message-ID: On Thu, Dec 16, 2010 at 4:46 PM, Niclas Axelsson wrote: > On 12/16/2010 12:26 PM, Filipe David Manana wrote: >> >> The following patch fixes a few grammar errors and typos in the httpc >> module man page: >> >> git ?fetch ?git://github.com/fdmanana/otp.git ?httpc_man_page_fixes >> >> best regards, >> >> > > Hi Filipe, > > Christian von Roques posted a patch yesterday that also corrected the > grammar of the > httpc man page. There was a lot of similarities between your patch and > Christians, but > you had some fixes that Christian may have missed so I will include your fix > into 'pu'. Ok, thanks. I hadn't noticed of Christian's submission, otherwise would have submitted only the extra corrections. regards, > > Regards, > Niclas Axelsson, Erlang/OTP > > > > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From spawn.think@REDACTED Thu Dec 16 22:50:10 2010 From: spawn.think@REDACTED (Ahmed Omar) Date: Thu, 16 Dec 2010 22:50:10 +0100 Subject: [erlang-patches] percept stop_webserver fix In-Reply-To: <4D0A4259.6050309@erlang.org> References: <4D0A4259.6050309@erlang.org> Message-ID: Extended the test case to verify both stopping functions , please refetch On Thu, Dec 16, 2010 at 5:46 PM, Niclas Axelsson wrote: > On 12/16/2010 11:47 AM, Ahmed Omar wrote: > >> Fixes a bug found in percept:stop_webserver/1, where it doesn't stop the >> webserver completely >> >> >> percept:stop_webserver/1 will only stop the httpd service in inets, but >> not >> the percept_httpd process. As a result, when trying to start the webserver >> again it will return {error, already_started}. Test case was updated to >> simulate this case and fix is included to stop the webserver in a >> consistent >> way wether stop_webserver/0 or stop_webserver/1 was used. >> >> git fetch git://github.com/spawnthink/otp.git *percept_web_stop* >> >> >> > Thanks Ahmed, > > Will include your patch into 'pu'. > > Regards, > Niclas Axelsson, Erlang/OTP > -- Best Regards, - Ahmed Omar http://nl.linkedin.com/in/adiaa Follow me on twitter @spawn_think From fdmanana@REDACTED Fri Dec 17 13:48:44 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Fri, 17 Dec 2010 12:48:44 +0000 Subject: Possible supervisor patch Message-ID: Hi, I find it useful to be able to restart a supervisor child with arguments different from those specified in the MFA component of the original child spec. Is this completely against the principles of OTP supervisors/servers, or something that may be added? I made a quick and tiny patch that adds this feature and is working as I want: https://github.com/fdmanana/otp/commit/a80f39109292c915ce56ea86b7e036b581f686b2 If someone from the OTP team confirms this might be considered for inclusion, I'll be glad to refine it if necessary. best regards, -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From robert.virding@REDACTED Sat Dec 18 15:58:02 2010 From: robert.virding@REDACTED (Robert Virding) Date: Sat, 18 Dec 2010 14:58:02 +0000 (GMT) Subject: [erlang-questions] Possible supervisor patch In-Reply-To: Message-ID: <49603530.214391292684282829.JavaMail.root@zimbra> You can do it today with: restart_child(Sup, Id, NewSpec) -> supervisor:terminate_child(Sup, Id), supervisor:delete_child(Sup, Id), supervisor:start_child(Sup, NewSpec). BUT, it would not be guaranteed to be an atomic operation and it is up to the caller to ensure that the id remains the same. Robert ----- "Filipe David Manana" wrote: > Hi, > > I find it useful to be able to restart a supervisor child with > arguments different from those specified in the MFA component of the > original child spec. > Is this completely against the principles of OTP supervisors/servers, > or something that may be added? > > I made a quick and tiny patch that adds this feature and is working as > I want: > > https://github.com/fdmanana/otp/commit/a80f39109292c915ce56ea86b7e036b581f686b2 > > If someone from the OTP team confirms this might be considered for > inclusion, I'll be glad to refine it if necessary. > > best regards, > > -- > Filipe David Manana, > fdmanana@REDACTED, fdmanana@REDACTED > > "Reasonable men adapt themselves to the world. > ?Unreasonable men adapt the world to themselves. > ?That's why all progress depends on unreasonable men." > > ________________________________________________________________ > erlang-questions (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-questions-unsubscribe@REDACTED -- Robert Virding, Erlang Solutions Ltd. From fdmanana@REDACTED Sat Dec 18 16:57:10 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Sat, 18 Dec 2010 15:57:10 +0000 Subject: [erlang-patches] Re: [erlang-questions] Possible supervisor patch In-Reply-To: <49603530.214391292684282829.JavaMail.root@zimbra> References: <49603530.214391292684282829.JavaMail.root@zimbra> Message-ID: Exactly, that was my workaround, and the motivation for that patch was exactly to make it atomic. Thanks On Sat, Dec 18, 2010 at 2:58 PM, Robert Virding wrote: > You can do it today with: > > restart_child(Sup, Id, NewSpec) -> > ? ?supervisor:terminate_child(Sup, Id), > ? ?supervisor:delete_child(Sup, Id), > ? ?supervisor:start_child(Sup, NewSpec). > > BUT, it would not be guaranteed to be an atomic operation and it is up to the caller to ensure that the id remains the same. > > Robert > > ----- "Filipe David Manana" wrote: > >> Hi, >> >> I find it useful to be able to restart a supervisor child with >> arguments different from those specified in the MFA component of the >> original child spec. >> Is this completely against the principles of OTP supervisors/servers, >> or something that may be added? >> >> I made a quick and tiny patch that adds this feature and is working as >> I want: >> >> https://github.com/fdmanana/otp/commit/a80f39109292c915ce56ea86b7e036b581f686b2 >> >> If someone from the OTP team confirms this might be considered for >> inclusion, I'll be glad to refine it if necessary. >> >> best regards, >> >> -- >> Filipe David Manana, >> fdmanana@REDACTED, fdmanana@REDACTED >> >> "Reasonable men adapt themselves to the world. >> ?Unreasonable men adapt the world to themselves. >> ?That's why all progress depends on unreasonable men." >> >> ________________________________________________________________ >> erlang-questions (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-questions-unsubscribe@REDACTED > > -- > Robert Virding, Erlang Solutions Ltd. > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From aronisstav@REDACTED Sat Dec 18 18:37:14 2010 From: aronisstav@REDACTED (Stavros Aronis) Date: Sat, 18 Dec 2010 19:37:14 +0200 Subject: Fix a bug in the handling of 'or' BIF by Dialyzer Message-ID: Dialyzer had a minor issue when the arguments of the built-in function 'or' had the fixed value 'false'. This patch deals with it. git fetch git://github.com/aronisstav/otp.git dialyzer-or-fix From kostis@REDACTED Sun Dec 19 00:04:41 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Sun, 19 Dec 2010 01:04:41 +0200 Subject: [erlang-patches] Fix a bug in the handling of 'or' BIF by Dialyzer In-Reply-To: References: Message-ID: <4D0D3E09.10705@cs.ntua.gr> Stavros Aronis wrote: > Dialyzer had a minor issue when the arguments of the built-in function 'or' > had the fixed value 'false'. This patch deals with it. > > git fetch git://github.com/aronisstav/otp.git dialyzer-or-fix Can I ask that this is put directly into 'dev' ? Kostis From gliptak@REDACTED Mon Dec 20 00:02:18 2010 From: gliptak@REDACTED (=?ISO-8859-1?B?R+Fib3IgTGlwdOFr?=) Date: Sun, 19 Dec 2010 18:02:18 -0500 Subject: [erlang-questions] Erlang Start-Up File (.erlang) In-Reply-To: References: <20101213194727.GB41563@h216-235-12-173.host.egate.net> Message-ID: I updated the docs with these sections. git fetch git://github.com/gliptak/otp.git doterlangdocs Please include in pu. Thanks On Tue, Dec 14, 2010 at 20:39, Ryan Zezeski wrote: > On Mon, Dec 13, 2010 at 2:47 PM, Vance Shipley wrote: > >> I have looked high and low but can no longer find anywhere >> where the start-up file .erlang is documented. ?It used to >> be in the Getting Started with Erlang User's Guide but does >> not seem to be there now. >> >> -- >> ? ? ? ?-Vance >> > > I found it in some old documentation via Google, but I couldn't locate it in > the current docs. > > http://www.erlang.org/documentation/doc-5.2/doc/getting_started/getting_started.html > > It's mentioned under section 1.7.1. ?It worked for me on R14B. > > -Ryan > From burbas@REDACTED Mon Dec 20 11:25:51 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 20 Dec 2010 11:25:51 +0100 Subject: [erlang-patches] percept stop_webserver fix In-Reply-To: References: <4D0A4259.6050309@erlang.org> Message-ID: <4D0F2F2F.7060703@erlang.org> On 12/16/2010 10:50 PM, Ahmed Omar wrote: > Extended the test case to verify both stopping functions , please refetch > > On Thu, Dec 16, 2010 at 5:46 PM, Niclas Axelsson wrote: > > >> On 12/16/2010 11:47 AM, Ahmed Omar wrote: >> >> >>> Fixes a bug found in percept:stop_webserver/1, where it doesn't stop the >>> webserver completely >>> >>> >>> percept:stop_webserver/1 will only stop the httpd service in inets, but >>> not >>> the percept_httpd process. As a result, when trying to start the webserver >>> again it will return {error, already_started}. Test case was updated to >>> simulate this case and fix is included to stop the webserver in a >>> consistent >>> way wether stop_webserver/0 or stop_webserver/1 was used. >>> >>> git fetch git://github.com/spawnthink/otp.git *percept_web_stop* >>> >>> >>> >>> >> Thanks Ahmed, >> >> Will include your patch into 'pu'. >> >> Regards, >> Niclas Axelsson, Erlang/OTP >> >> > > > Thanks Ahmed, I have refetched your branch. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Mon Dec 20 12:04:50 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 20 Dec 2010 12:04:50 +0100 Subject: [erlang-patches] Re: [erlang-questions] Erlang Start-Up File (.erlang) In-Reply-To: References: <20101213194727.GB41563@h216-235-12-173.host.egate.net> Message-ID: <4D0F3852.3090905@erlang.org> On 12/20/2010 12:02 AM, G?bor Lipt?k wrote: > I updated the docs with these sections. > > git fetch git://github.com/gliptak/otp.git doterlangdocs > > Please include in pu. > > Thanks > > On Tue, Dec 14, 2010 at 20:39, Ryan Zezeski wrote: > >> On Mon, Dec 13, 2010 at 2:47 PM, Vance Shipley wrote: >> >> >>> I have looked high and low but can no longer find anywhere >>> where the start-up file .erlang is documented. It used to >>> be in the Getting Started with Erlang User's Guide but does >>> not seem to be there now. >>> >>> -- >>> -Vance >>> >>> >> I found it in some old documentation via Google, but I couldn't locate it in >> the current docs. >> >> http://www.erlang.org/documentation/doc-5.2/doc/getting_started/getting_started.html >> >> It's mentioned under section 1.7.1. It worked for me on R14B. >> >> -Ryan >> >> > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > Thanks G?bor, Will include your patch into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From kostis@REDACTED Mon Dec 20 12:05:32 2010 From: kostis@REDACTED (Kostis Sagonas) Date: Mon, 20 Dec 2010 13:05:32 +0200 Subject: [erlang-patches] Fix wrong spec for ets:new/2 in HiPE/dialyzer In-Reply-To: References: <4D09D9E5.5070706@cs.ntua.gr> Message-ID: <4D0F387C.901@cs.ntua.gr> Jesper Louis Andersen wrote: > On Thu, Dec 16, 2010 at 10:20, Kostis Sagonas wrote: >> Your Erlang code is ok, but please change some things in the comment: >> >> ... > >> If you do these changes, your patch can be included as is in 'dev'. > > I'll let cooking be up to you to decide :) Personally I was aiming for > a cooking in 'pu' first - mind you, I have not executed the test cases > on it, partially because I don't know what tests to narrow it down to. > It would seem easy to include in 'pu' for a batch of testing and then > just grad it to 'dev'. But as I said, your call. > > Ammended patch is refetchable at, > > git fetch git://github.com/jlouis/otp.git fix-hipe-spec-ets-new I've tested this patch and it is OK. It can be included as is in 'dev'. Kostis From burbas@REDACTED Mon Dec 20 17:27:08 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Mon, 20 Dec 2010 17:27:08 +0100 Subject: [erlang-patches] Fix a bug in the handling of 'or' BIF by Dialyzer In-Reply-To: <4D0D3E09.10705@cs.ntua.gr> References: <4D0D3E09.10705@cs.ntua.gr> Message-ID: <4D0F83DC.9040709@erlang.org> On 12/19/2010 12:04 AM, Kostis Sagonas wrote: > Stavros Aronis wrote: >> Dialyzer had a minor issue when the arguments of the built-in >> function 'or' >> had the fixed value 'false'. This patch deals with it. >> >> git fetch git://github.com/aronisstav/otp.git dialyzer-or-fix > > > Can I ask that this is put directly into 'dev' ? > > Kostis > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED Hi Stavros and Kostis, We want to take it for a spin in our nightly builds first, so I will include it into 'pu' for now. I will push it to 'dev' tomorrow if the builds and tests where ok. Regards, Niclas Axelsson, Erlang/OTP From nox@REDACTED Mon Dec 20 19:09:00 2010 From: nox@REDACTED (nox) Date: Mon, 20 Dec 2010 19:09:00 +0100 Subject: Fixes and improvements for xmerl Message-ID: <8B822A73-CB56-4885-8040-5A2C17967BC6@dev-extend.eu> Hi there, I need to implement xml-c14n [1] and xmldsig-core [2] specs for a client of mine and I have stumbled upon some bugs and shortcomings in xmerl. So I fixed them, and I hope I'll have done it well. git fetch git://github.com/nox/otp.git better-xmerl The commit messages should be pretty self-explenatory but feel free to ask any question. Regards. -- Anthony Ramine Dev:Extend http://dev-extend.eu From burbas@REDACTED Tue Dec 21 09:32:34 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 21 Dec 2010 09:32:34 +0100 Subject: [erlang-patches] Fixes and improvements for xmerl In-Reply-To: <8B822A73-CB56-4885-8040-5A2C17967BC6@dev-extend.eu> References: <8B822A73-CB56-4885-8040-5A2C17967BC6@dev-extend.eu> Message-ID: <4D106622.2010600@erlang.org> On 12/20/2010 07:09 PM, nox wrote: > Hi there, > > I need to implement xml-c14n [1] and xmldsig-core [2] specs for a client of mine and I have stumbled upon some bugs and shortcomings in xmerl. So I fixed them, and I hope I'll have done it well. > > git fetch git://github.com/nox/otp.git better-xmerl > > The commit messages should be pretty self-explenatory but feel free to ask any question. > > Regards. > > > -- > Anthony Ramine > Dev:Extend > http://dev-extend.eu > > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > Thanks Anthony, Will include this into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Tue Dec 21 15:44:05 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 21 Dec 2010 15:44:05 +0100 Subject: [erlang-patches] Fix a bug in the handling of 'or' BIF by Dialyzer In-Reply-To: <4D0D3E09.10705@cs.ntua.gr> References: <4D0D3E09.10705@cs.ntua.gr> Message-ID: <4D10BD35.70002@erlang.org> On 12/19/2010 12:04 AM, Kostis Sagonas wrote: > Stavros Aronis wrote: >> Dialyzer had a minor issue when the arguments of the built-in >> function 'or' >> had the fixed value 'false'. This patch deals with it. >> >> git fetch git://github.com/aronisstav/otp.git dialyzer-or-fix > > > Can I ask that this is put directly into 'dev' ? > > Kostis > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED Hi Stavros and Kostis, The patch is now included in 'dev'. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Tue Dec 21 15:50:00 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 21 Dec 2010 15:50:00 +0100 Subject: [erlang-patches] Fix wrong spec for ets:new/2 in HiPE/dialyzer In-Reply-To: <4D0F387C.901@cs.ntua.gr> References: <4D09D9E5.5070706@cs.ntua.gr> <4D0F387C.901@cs.ntua.gr> Message-ID: <4D10BE98.9080602@erlang.org> On 12/20/2010 12:05 PM, Kostis Sagonas wrote: > Jesper Louis Andersen wrote: >> On Thu, Dec 16, 2010 at 10:20, Kostis Sagonas wrote: >>> Your Erlang code is ok, but please change some things in the comment: >>> >>> ... >> >>> If you do these changes, your patch can be included as is in 'dev'. >> >> I'll let cooking be up to you to decide :) Personally I was aiming for >> a cooking in 'pu' first - mind you, I have not executed the test cases >> on it, partially because I don't know what tests to narrow it down to. >> It would seem easy to include in 'pu' for a batch of testing and then >> just grad it to 'dev'. But as I said, your call. >> >> Ammended patch is refetchable at, >> >> git fetch git://github.com/jlouis/otp.git fix-hipe-spec-ets-new > > I've tested this patch and it is OK. It can be included as is in 'dev'. > > Kostis > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED Hi Jesper and Kostis, The patch took a ride in the 'pu' branch during the night for testing purposes. All went well and the patch is now included in 'dev'. Regards, Niclas Axelsson, Erlang/OTP From nox@REDACTED Wed Dec 22 11:49:37 2010 From: nox@REDACTED (nox) Date: Wed, 22 Dec 2010 11:49:37 +0100 Subject: UTF-8 in "What's cooking in erlang/otp" page Message-ID: Hi there, There is some mojibake [1] in the "What's cooking in erlang/otp" generated page when the comment about a topic branch contains multibyte characters (like Bj?rn Gustavsson's name). Here is a very simple patch to fix that. git fetch git://github.com/nox/otp.git meta-utf8 Regards, [1] http://en.wikipedia.org/wiki/Mojibake -- Anthony Ramine Dev:Extend http://dev-extend.eu From burbas@REDACTED Wed Dec 22 11:58:46 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 22 Dec 2010 11:58:46 +0100 Subject: [erlang-patches] UTF-8 in "What's cooking in erlang/otp" page In-Reply-To: References: Message-ID: <4D11D9E6.7060707@erlang.org> On 12/22/2010 11:49 AM, nox wrote: > Hi there, > > There is some mojibake [1] in the "What's cooking in erlang/otp" generated page when the comment about a topic branch contains multibyte characters (like Bj?rn Gustavsson's name). > Here is a very simple patch to fix that. > > git fetch git://github.com/nox/otp.git meta-utf8 > > Regards, > > [1] http://en.wikipedia.org/wiki/Mojibake > > -- > Anthony Ramine > Dev:Extend > http://dev-extend.eu > > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > Thanks Anthony, Your fix is okay, but the script you have changed (page) is actually responsible for the "Currently in the 'pu' branch" page. Please change the commit message, so people does not need to be confused. Regards, Niclas Axelsson, Erlang/OTP From nox@REDACTED Wed Dec 22 12:21:48 2010 From: nox@REDACTED (nox) Date: Wed, 22 Dec 2010 12:21:48 +0100 Subject: [erlang-patches] UTF-8 in "What's cooking in erlang/otp" page In-Reply-To: <4D11D9E6.7060707@erlang.org> References: <4D11D9E6.7060707@erlang.org> Message-ID: Le 22 d?c. 2010 ? 11:58, Niclas Axelsson a ?crit : > On 12/22/2010 11:49 AM, nox wrote: >> Hi there, >> >> There is some mojibake [1] in the "What's cooking in erlang/otp" generated page when the comment about a topic branch contains multibyte characters (like Bj?rn Gustavsson's name). >> Here is a very simple patch to fix that. >> >> git fetch git://github.com/nox/otp.git meta-utf8 >> >> Regards, >> >> [1] http://en.wikipedia.org/wiki/Mojibake >> >> -- >> Anthony Ramine >> Dev:Extend >> http://dev-extend.eu >> >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >> >> > Thanks Anthony, > > Your fix is okay, but the script you have changed (page) is actually responsible for > the "Currently in the 'pu' branch" page. Please change the commit message, so people does not > need to be confused. > > Regards, > Niclas Axelsson, Erlang/OTP Done. -- Anthony Ramine Dev:Extend http://dev-extend.eu From burbas@REDACTED Wed Dec 22 12:25:42 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Wed, 22 Dec 2010 12:25:42 +0100 Subject: [erlang-patches] UTF-8 in "What's cooking in erlang/otp" page In-Reply-To: References: <4D11D9E6.7060707@erlang.org> Message-ID: <4D11E036.7020405@erlang.org> On 12/22/2010 12:21 PM, nox wrote: > Le 22 d?c. 2010 ? 11:58, Niclas Axelsson a ?crit : > > >> On 12/22/2010 11:49 AM, nox wrote: >> >>> Hi there, >>> >>> There is some mojibake [1] in the "What's cooking in erlang/otp" generated page when the comment about a topic branch contains multibyte characters (like Bj?rn Gustavsson's name). >>> Here is a very simple patch to fix that. >>> >>> git fetch git://github.com/nox/otp.git meta-utf8 >>> >>> Regards, >>> >>> [1] http://en.wikipedia.org/wiki/Mojibake >>> >>> -- >>> Anthony Ramine >>> Dev:Extend >>> http://dev-extend.eu >>> >>> >>> ________________________________________________________________ >>> erlang-patches (at) erlang.org mailing list. >>> See http://www.erlang.org/faq.html >>> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >>> >>> >>> >> Thanks Anthony, >> >> Your fix is okay, but the script you have changed (page) is actually responsible for >> the "Currently in the 'pu' branch" page. Please change the commit message, so people does not >> need to be confused. >> >> Regards, >> Niclas Axelsson, Erlang/OTP >> > Done. > > -- > Anthony Ramine > Dev:Extend > http://dev-extend.eu > > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > Thanks Anthony. Will give it a spin first, and then include it into the 'META'-branch. Regards, Niclas Axelsson, Erlang/OTP From fdmanana@REDACTED Wed Dec 22 16:03:16 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Wed, 22 Dec 2010 15:03:16 +0000 Subject: [erlang-patches] Re: [erlang-questions] Possible supervisor patch In-Reply-To: References: <49603530.214391292684282829.JavaMail.root@zimbra> Message-ID: Can I get someone from the OTP team to comment on this as well? thanks On Sat, Dec 18, 2010 at 3:57 PM, Filipe David Manana wrote: > Exactly, that was my workaround, and the motivation for that patch was > exactly to make it atomic. > > Thanks > > On Sat, Dec 18, 2010 at 2:58 PM, Robert Virding > wrote: >> You can do it today with: >> >> restart_child(Sup, Id, NewSpec) -> >> ? ?supervisor:terminate_child(Sup, Id), >> ? ?supervisor:delete_child(Sup, Id), >> ? ?supervisor:start_child(Sup, NewSpec). >> >> BUT, it would not be guaranteed to be an atomic operation and it is up to the caller to ensure that the id remains the same. >> >> Robert >> >> ----- "Filipe David Manana" wrote: >> >>> Hi, >>> >>> I find it useful to be able to restart a supervisor child with >>> arguments different from those specified in the MFA component of the >>> original child spec. >>> Is this completely against the principles of OTP supervisors/servers, >>> or something that may be added? >>> >>> I made a quick and tiny patch that adds this feature and is working as >>> I want: >>> >>> https://github.com/fdmanana/otp/commit/a80f39109292c915ce56ea86b7e036b581f686b2 >>> >>> If someone from the OTP team confirms this might be considered for >>> inclusion, I'll be glad to refine it if necessary. >>> >>> best regards, >>> >>> -- >>> Filipe David Manana, >>> fdmanana@REDACTED, fdmanana@REDACTED >>> >>> "Reasonable men adapt themselves to the world. >>> ?Unreasonable men adapt the world to themselves. >>> ?That's why all progress depends on unreasonable men." >>> >>> ________________________________________________________________ >>> erlang-questions (at) erlang.org mailing list. >>> See http://www.erlang.org/faq.html >>> To unsubscribe; mailto:erlang-questions-unsubscribe@REDACTED >> >> -- >> Robert Virding, Erlang Solutions Ltd. >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >> >> > > > > -- > Filipe David Manana, > fdmanana@REDACTED, fdmanana@REDACTED > > "Reasonable men adapt themselves to the world. > ?Unreasonable men adapt the world to themselves. > ?That's why all progress depends on unreasonable men." > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From tuncer.ayaz@REDACTED Sun Dec 26 18:00:13 2010 From: tuncer.ayaz@REDACTED (Tuncer Ayaz) Date: Sun, 26 Dec 2010 18:00:13 +0100 Subject: Fix a couple typos in driver_entry(3) Message-ID: git fetch git://github.com/tuncer/otp.git driver_entry-typos From burbas@REDACTED Tue Dec 28 09:04:52 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 28 Dec 2010 09:04:52 +0100 Subject: [erlang-patches] Fix a couple typos in driver_entry(3) In-Reply-To: References: Message-ID: <4D199A24.1060405@erlang.org> On 12/26/2010 06:00 PM, Tuncer Ayaz wrote: > git fetch git://github.com/tuncer/otp.git driver_entry-typos > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > Thanks Tuncer, Will include it into 'pu'. Regards, Niclas Axelsson, Erlang/OTP From fdmanana@REDACTED Tue Dec 28 12:08:14 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Tue, 28 Dec 2010 11:08:14 +0000 Subject: [erlang-patches] Re: [PATH] - add file:allocate/3 In-Reply-To: <4CF8B24D.6000207@erlang.org> References: <4CF8B24D.6000207@erlang.org> Message-ID: Good morning, Could you please refetch from this new branch: git fetch git://github.com/fdmanana/otp.git file_allocate_2 I simplified the interface and improved the implementation. See the git commit comment for more details. Tested on Linux and Mac OS X. best regards, On Fri, Dec 3, 2010 at 9:03 AM, Niclas Axelsson wrote: > On 12/01/2010 06:46 PM, Filipe David Manana wrote: >> >> On Wed, Dec 1, 2010 at 5:20 PM, Filipe David Manana >> ?wrote: >> >>> >>> Hello, >>> >>> The following patch adds file:allocate/3, a wrapper for the POSIX >>> syscall posix_fadvise. >>> >> >> Here I meant posix_fallocate. >> Thanks Tuncer for noticing the error >>> >>> git fetch git fetch git://github.com/fdmanana/otp.git posix_fallocate >>> >>> thanks >>> >>> -- >>> Filipe David Manana, >>> fdmanana@REDACTED, fdmanana@REDACTED >>> >>> "Reasonable men adapt themselves to the world. >>> ?Unreasonable men adapt the world to themselves. >>> ?That's why all progress depends on unreasonable men." >>> >>> > > Thank you. I will include it into 'pu'. > > /Niclas Axelsson, Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From burbas@REDACTED Tue Dec 28 12:36:57 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 28 Dec 2010 12:36:57 +0100 Subject: [erlang-patches] Re: [PATH] - add file:allocate/3 In-Reply-To: References: <4CF8B24D.6000207@erlang.org> Message-ID: <4D19CBD9.9080606@erlang.org> On 12/28/2010 12:08 PM, Filipe David Manana wrote: > Good morning, > > Could you please refetch from this new branch: > > git fetch git://github.com/fdmanana/otp.git file_allocate_2 > > I simplified the interface and improved the implementation. See the > git commit comment for more details. > Tested on Linux and Mac OS X. > > best regards, > > On Fri, Dec 3, 2010 at 9:03 AM, Niclas Axelsson wrote: > >> On 12/01/2010 06:46 PM, Filipe David Manana wrote: >> >>> On Wed, Dec 1, 2010 at 5:20 PM, Filipe David Manana >>> wrote: >>> >>> >>>> Hello, >>>> >>>> The following patch adds file:allocate/3, a wrapper for the POSIX >>>> syscall posix_fadvise. >>>> >>>> >>> Here I meant posix_fallocate. >>> Thanks Tuncer for noticing the error >>> >>>> git fetch git fetch git://github.com/fdmanana/otp.git posix_fallocate >>>> >>>> thanks >>>> >>>> -- >>>> Filipe David Manana, >>>> fdmanana@REDACTED, fdmanana@REDACTED >>>> >>>> "Reasonable men adapt themselves to the world. >>>> Unreasonable men adapt the world to themselves. >>>> That's why all progress depends on unreasonable men." >>>> >>>> >>>> >> Thank you. I will include it into 'pu'. >> >> /Niclas Axelsson, Erlang/OTP >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >> >> >> > > > Thanks. Your branch is refetched. Regards, Niclas Axelsson, Erlang/OTP From fdmanana@REDACTED Tue Dec 28 12:44:05 2010 From: fdmanana@REDACTED (Filipe David Manana) Date: Tue, 28 Dec 2010 11:44:05 +0000 Subject: [erlang-patches] Re: [PATH] - add file:allocate/3 In-Reply-To: <4D19CBD9.9080606@erlang.org> References: <4CF8B24D.6000207@erlang.org> <4D19CBD9.9080606@erlang.org> Message-ID: Thanks Niclas. A new feature like this, how long does it normally take to get into 'dev'? Does it necessarily have to wait for the next major release (R15) ? regards, On Tue, Dec 28, 2010 at 11:36 AM, Niclas Axelsson wrote: > On 12/28/2010 12:08 PM, Filipe David Manana wrote: >> >> Good morning, >> >> Could you please refetch from this new branch: >> >> git fetch git://github.com/fdmanana/otp.git file_allocate_2 >> >> I simplified the interface and improved the implementation. See the >> git commit comment for more details. >> Tested on Linux and Mac OS X. >> >> best regards, >> >> On Fri, Dec 3, 2010 at 9:03 AM, Niclas Axelsson ?wrote: >> >>> >>> On 12/01/2010 06:46 PM, Filipe David Manana wrote: >>> >>>> >>>> On Wed, Dec 1, 2010 at 5:20 PM, Filipe David Manana >>>> ?wrote: >>>> >>>> >>>>> >>>>> Hello, >>>>> >>>>> The following patch adds file:allocate/3, a wrapper for the POSIX >>>>> syscall posix_fadvise. >>>>> >>>>> >>>> >>>> Here I meant posix_fallocate. >>>> Thanks Tuncer for noticing the error >>>> >>>>> >>>>> git fetch git fetch git://github.com/fdmanana/otp.git posix_fallocate >>>>> >>>>> thanks >>>>> >>>>> -- >>>>> Filipe David Manana, >>>>> fdmanana@REDACTED, fdmanana@REDACTED >>>>> >>>>> "Reasonable men adapt themselves to the world. >>>>> ?Unreasonable men adapt the world to themselves. >>>>> ?That's why all progress depends on unreasonable men." >>>>> >>>>> >>>>> >>> >>> Thank you. I will include it into 'pu'. >>> >>> /Niclas Axelsson, Erlang/OTP >>> >>> ________________________________________________________________ >>> erlang-patches (at) erlang.org mailing list. >>> See http://www.erlang.org/faq.html >>> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >>> >>> >>> >> >> >> > > Thanks. > Your branch is refetched. > > Regards, > Niclas Axelsson, Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED > > -- Filipe David Manana, fdmanana@REDACTED, fdmanana@REDACTED "Reasonable men adapt themselves to the world. ?Unreasonable men adapt the world to themselves. ?That's why all progress depends on unreasonable men." From burbas@REDACTED Tue Dec 28 14:20:12 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 28 Dec 2010 14:20:12 +0100 Subject: [erlang-patches] Re: [erlang-questions] Possible supervisor patch In-Reply-To: References: <49603530.214391292684282829.JavaMail.root@zimbra> Message-ID: <4D19E40C.5030809@erlang.org> On 12/22/2010 04:03 PM, Filipe David Manana wrote: > Can I get someone from the OTP team to comment on this as well? > > thanks > > On Sat, Dec 18, 2010 at 3:57 PM, Filipe David Manana > wrote: > >> > Exactly, that was my workaround, and the motivation for that patch was >> > exactly to make it atomic. >> > >> > Thanks >> Hi Filipe, I will try and find someone who can review your patch, but during Christmas and new year most of the people working here are on vacation. It can take a couple of weeks before you will get feedback. Regards, Niclas Axelsson, Erlang/OTP From burbas@REDACTED Tue Dec 28 14:27:39 2010 From: burbas@REDACTED (Niclas Axelsson) Date: Tue, 28 Dec 2010 14:27:39 +0100 Subject: [erlang-patches] Re: [PATH] - add file:allocate/3 In-Reply-To: References: <4CF8B24D.6000207@erlang.org> <4D19CBD9.9080606@erlang.org> Message-ID: <4D19E5CB.2040201@erlang.org> On 12/28/2010 12:44 PM, Filipe David Manana wrote: > Thanks Niclas. > A new feature like this, how long does it normally take to get into > 'dev'? Does it necessarily have to wait for the next major release > (R15) ? > > regards, > It depends on the patch, but it is our intention to try and handle branches in 'pu' quickly and then merge approved patches into 'dev'. A large patch or a patch with new features, like yours, normally takes a little longer to process. I don't think you'll have to wait for the next major release before receiving feedback from us. Regards, Niclas Axelsson, Erlang/OTP From nick@REDACTED Tue Dec 28 16:40:28 2010 From: nick@REDACTED (Niclas Eklund) Date: Tue, 28 Dec 2010 16:40:28 +0100 Subject: [erlang-patches] [PATCH] ssh: ensure ~/.ssh exists In-Reply-To: <4D064C0B.6020105@erlang.org> References: <1283462802-98683-1-git-send-email-tuncer.ayaz@gmail.com> <1283511162-8340-1-git-send-email-tuncer.ayaz@gmail.com> <4D064C0B.6020105@erlang.org> Message-ID: Hello Tuncer! You patch will be included in R14B02/ssh-2.0.4. Best Regards, Niclas E @ Erlang/OTP On Mon, 13 Dec 2010, Niclas Axelsson wrote: > On 12/11/2010 08:05 PM, Tuncer Ayaz wrote: >> 2010/9/3 Bj?rn Gustavsson: >> >>> On Fri, Sep 3, 2010 at 12:52 PM, Tuncer Ayaz wrote: >>> >>>> Make sure that ~/.ssh exists before trying to open files like >>>> ~/.ssh/known_hosts. >>>> >>>> Reported-By: Daniel Goertzen >>>> --- >>>> >>> Thanks! Will include in pu. >>> >> git fetch git://github.com/tuncer/otp.git ssh-ensure-userdir >> >> Please refetch. Removed local chmod/2 in favor of file:change_mode/2. >> >> ________________________________________________________________ >> erlang-patches (at) erlang.org mailing list. >> See http://www.erlang.org/faq.html >> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >> >> > Thanks Tuncer, > Your patch is refetched and included in 'pu'. > > Regards, > Niclas Axelsson, Erlang/OTP > > ________________________________________________________________ > erlang-patches (at) erlang.org mailing list. > See http://www.erlang.org/faq.html > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED >