From nicolas.niclausse@REDACTED Mon Mar 22 19:26:22 2004 From: nicolas.niclausse@REDACTED (Nicolas Niclausse) Date: Mon, 22 Mar 2004 19:26:22 +0100 Subject: bug report & patch for snmp_mgr Message-ID: <87fzc0n3g1.fsf@schultze.ird.idealx.com> Hello, I've found a bug in the snmp_mgr module (R9C on linux 2.6 kernel) The man page say: start(Options) start_link(Options) -> void() [...] * {receive_type, pdu | msg} - defines the format of delivered messages. Default is pdu. but : 4> snmp_mgr:start_link([{agent,"localhost"},{agent_udp, 161},quiet ]). {ok,<0.41.0>} 5> snmp_mgr:stop(). ok 6> snmp_mgr:start_link([{agent,"localhost"},{agent_udp, 161},quiet,{receive_type, msg} ]). {error,{invalid_option,{receive_type,msg}}} ** exited: {invalid_option,{receive_type,msg}} ** The following patch resolve the problem: -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: snmp_mgr.diff URL: -------------- next part -------------- -- Nicolas NICLAUSSE IDEALX S.A.S. T?l:01 44 42 00 00 http://IDEALX.com/ From d.love@REDACTED Tue Mar 30 18:02:30 2004 From: d.love@REDACTED (Dave Love) Date: Tue, 30 Mar 2004 17:02:30 +0100 Subject: various fixes for erlang.el Message-ID: This patch is on top of the one I just sent for doc fixes, for more substantial issues. Some of these are to support Emacs 21 features and others are cleanups. I didn't think it was worth trying to separate out the components. It is against version 2.4.12 of erlang.el, which I should also have said about the previous one, sorry. Explanations: * Regexp-opt is unused (which isn't a real problem unless it's not autoloaded in earlier versions -- I don't remember); * `defalias' should normally be used instead of `fset' so that the definition's location is recorded. (Some of this involved with tags should be changed anyway, but I haven't got round to that); * I used advice for set-visited-file-name, which is cleaner and assumed elsewhere in the file, though it's bad to have to advise it at all -- I'll look at doing something better; * The unload hook allows the right things to be undone if the package is unloaded in Emacs 21. * The erlang-align-arrows and erlang-generate-new-clause changes avoid some consing; * The erlang-skel-mail-address change fixes the case when you've customized user-mail-address. I'm not convinced the problem in the comment before it is a real one; * The extra variables in erlang-mode-variables are to DTRT in Emacs 21, along with not overriding some global keybindings and defining a special mark function; * erlang-current-defun is a function which allows add-log to work sensibly. I think the Emacs 18 stuff should be cleaned out entirely. This file wouldn't even load into Emacs 18, and trying to support it would be silly. In fact, I don't think it's worth catering for Emacs 19 either, and not doing so would allow use of Custom, for instance, as well as allowing several cleanups. The use of things like `(funcall (symbol-function 'set) ...)' is bizarre. If it's there to avoid warnings, I'm sure it's not worth it. Also it would be better to require `cl' at compile time to get things like `unless', `push' and `caddr'. -------------- next part -------------- A non-text attachment was scrubbed... Name: erlang-patch-2 Type: text/x-patch Size: 11121 bytes Desc: not available URL: From d.love@REDACTED Tue Mar 30 18:11:20 2004 From: d.love@REDACTED (Dave Love) Date: Tue, 30 Mar 2004 17:11:20 +0100 Subject: fix for erlang.el compilation stuff in Emacs 21 Message-ID: At least in Emacs 21, C-x ` won't find an error from a compilation in the shell buffer because `compilation-setup' doesn't get called. This fixes it cleanly by using compilation-minor-mode and maintaining the shell keybindings. It shouldn't have any effect on XEmacs or Emacs 20, but I've only tested it in Emacs 21. It's against version 2.4.12, on top of my previous two patches. -------------- next part -------------- A non-text attachment was scrubbed... Name: erlang-patch-3 Type: text/x-patch Size: 3190 bytes Desc: not available URL: