[eeps] [erlang-patches] EEP37: Funs with names

[Anthony Ramine]

Hello,

I've opened two issues at wrangler and erlide:

	https://github.com/RefactoringTools/wrangler/issues/48
	https://github.com/erlide/erlide/issues/121

I've also patched pmod_transform (I feel sullied) to make it support named funs:

	git fetch https://github.com/nox/pmod_transform eep37

	https://github.com/nox/pmod_transform/compare/erlang:master...eep37
	https://github.com/nox/pmod_transform/compare/erlang:master...eep37.patch

Regards,

Le 14 sept. 2013 à 13:44, Anthony Ramine a écrit :

> Hello,
> 
> A quick review of tool support for EEP37:
> 
> * Editors
> 
> Emacs: Steve Vinoski patched erlang.el and I added his commit to my branch, thank you Steve! [1]
> Sublime Text: Sublime-Erlang has been patched by myself a long time ago. [2]
> Vim: requires patching, but I have no idea which syntax files are used by the community.
> 
> * Parse transforms
> 
> syntax_tools and every tool using it: any parse transform using erl_syntax and erl_syntax_lib does not need to be patched.
> lager: its parse transform does a dirty hack using `tuple_to_list/1` to traverse unknown AST nodes, no patch needed. [3]
> Wrangler and other refactoring tools: needs patching and could probably use a few new transformations related to named funs.
> 
> * OTP tools
> 
> My implementation teaches the following tools about named funs:
> 
> - the compiler stack (obviously)
> - cover
> - QLC
> - xref
> - the shell
> 
> Dialyzer does not need to be patched as it operates on the Core Erlang AST which already had named funs.
> 
> [1] https://github.com/nox/otp/commit/405c0e7a111d5debc693c61ed8c2d311fc0201ca
> [2] https://github.com/fjl/Sublime-Erlang/pull/19
> [3] https://github.com/basho/lager/blob/2965c23f46301afeb7d62f6fbac99b3ab367f6b2/src/lager_transform.erl#L196-199
> 
> Regards,
> 
> Le 10 sept. 2013 à 16:59, Anthony Ramine a écrit :
> 
>> Sweet. Maybe that's a good occasion to compile a list of community tools operating on code?
>> 
>> -- 
>> Anthony Ramine
>> 
>> Le 10 sept. 2013 à 14:41, Kenneth Lundin <kenneth.lundin@REDACTED> a écrit :
>> 
>>> Sorry for the delay.
>>> 
>>> Anyway , we decided  that the Fun with names implementation can be included in the R17 release which is
>>> scheduled for Q1 2014.
>>> 
>>> We have to look into the impact on tools. The additional syntax might confuse some of the tools working on source code.
>>> 
>>> /Kenneth, Erlang/OTP, Ericsson
>>> 
>>> 
>>> On Tue, Sep 10, 2013 at 10:52 AM, Tony Rogvall <tony@REDACTED> wrote:
>>> Give the dog his bone ;-)
>>> 
>>> /Tony
>>> 
>>> On 10 sep 2013, at 10:28, Anthony Ramine <n.oxyde@REDACTED> wrote:
>>> 
>>>> And of which today this tomorrow is supposed to be? :p
>>>> 
>>>> Le 5 sept. 2013 à 16:50, Kenneth Lundin a écrit :
>>>> 
>>>>> Hi,
>>>>> 
>>>>> Yes, we have dicussed this on our technical board, I don't have the exact outcome
>>>>> at hand but can give more info tomorrow. As far as I remember it was a positive verdict.
>>>>> 
>>>>> /Kenneth, Erlang/OTP Ericsson
>>>>> 
>>>>> Den 5 sep 2013 11:56 skrev "Anthony Ramine" <n.oxyde@REDACTED>:
>>>>> Ping?
>>>>> 
>>>>> --
>>>>> Anthony Ramine
>>>>> 
>>>>> Le 2 juil. 2013 à 10:12, Anthony Ramine a écrit :
>>>>> 
>>>>>> Did you discuss it yet? :)
>>>>>> 
>>>>>> --
>>>>>> Anthony Ramine
>>>>>> 
>>>>>> Le 19 juin 2013 à 15:16, Björn Gustavsson a écrit :
>>>>>> 
>>>>>>> The OTP Technical Board will discuss EEP37
>>>>>>> at its next meeting.
>>>>>>> 
>>>>>>> 
>>>>>>> On Fri, Jun 7, 2013 at 6:24 PM, Anthony Ramine <n.oxyde@REDACTED> wrote:
>>>>>>> Ping?
>>>>>>> 
>>>>>>> --
>>>>>>> Anthony Ramine
>>>>>>> 
>>>>>>> Le 21 avr. 2013 à 22:17, Anthony Ramine a écrit :
>>>>>>> 
>>>>>>>> Hello,
>>>>>>>> 
>>>>>>>> Any ETA for a review?
>>>>>>>> 
>>>>>>>> Regards,
>>>>>>>> 
>>>>>>>> On Wed, Mar 20, 2013 at 3:33 PM, Fredrik <fredrik@REDACTED> wrote:
>>>>>>>>> On 03/20/2013 03:30 PM, Anthony Ramine wrote:
>>>>>>>>>> 
>>>>>>>>>> Rebased! :)
>>>>>>>>>> 
>>>>>>>>>> Does it mean it may be included before R17? Branch maint is for minor
>>>>>>>>>> releases, right?
>>>>>>>>>> 
>>>>>>>>> Right now im collecting all the patches active at the moment in pu. That
>>>>>>>>> does not mean it will be included in a minor release. :)
>>>>>>>>> 
>>>>>>>>> --
>>>>>>>>> 
>>>>>>>>> BR Fredrik Gustafsson
>>>>>>>>> Erlang OTP Team
>>>>>>>>> 
>>>>>>> 
>>>>>>> _______________________________________________
>>>>>>> eeps mailing list
>>>>>>> eeps@REDACTED
>>>>>>> http://erlang.org/mailman/listinfo/eeps
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> Björn Gustavsson, Erlang/OTP, Ericsson AB
>>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> eeps mailing list
>>>>> eeps@REDACTED
>>>>> http://erlang.org/mailman/listinfo/eeps
>>>> 
>>>> _______________________________________________
>>>> eeps mailing list
>>>> eeps@REDACTED
>>>> http://erlang.org/mailman/listinfo/eeps
>>> 
>>> "Installing applications can lead to corruption over time. Applications gradually write over each other's libraries, partial upgrades occur, user and system errors happen, and minute changes may be unnoticeable and difficult to fix"
>>> 
>>> 
>>> 
>>> 
>