<div dir="ltr">Hi Anthony<br><br>I may get a chance to look at this over the weekend and will definitely shout if I need help. :)<br><br>Regards,<br>  Cobus<br><br>On Thursday, 19 June 2014 11:50:18 UTC+2, Anthony Ramine  wrote:<blockquote class="gmail_quote" style="margin: 0;margin-left: 0.8ex;border-left: 1px #ccc solid;padding-left: 1ex;"><div dir="auto"><div>Yay for stdlib additions!</div><div><br></div><div>Cobus: if you need help with Git or contributing to the test suited and whatnot, feel free to come on IRC where people (myself included) will be very happy to help.<br><br>-- <div>Anthony Ramine</div></div><div><br>Le 19 juin 2014 à 11:10, Siri Hansen <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="6S4-AIZ2_58J" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">erlan...@gmail.com</a>> a écrit :<br><br></div><blockquote type="cite"><div><div dir="ltr">Hi Cobus!<div><br></div><div>We have had a look at your code, and we think that this is indeed something that you could contribute to the gb_trees module (we do not want a new module for this). A pull request is the way to go. Please follow these guidelines: <a href="https://github.com/erlang/otp/wiki/submitting-patches" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Ferlang%2Fotp%2Fwiki%2Fsubmitting-patches\46sa\75D\46sntz\0751\46usg\75AFQjCNFJtViiwYIi8XOhZdtGFoOXZ1e0lQ';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Ferlang%2Fotp%2Fwiki%2Fsubmitting-patches\46sa\75D\46sntz\0751\46usg\75AFQjCNFJtViiwYIi8XOhZdtGFoOXZ1e0lQ';return true;">https://github.<wbr>com/erlang/otp/wiki/<wbr>submitting-patches</a>.</div>
<div><br></div><div>Please note that tests must be done using common_test (stdlib/test/dict_SUITE.erl) and documentation must be added to stdlib/doc/src/gb_trees.xml.</div><div><br></div><div>Best Regards</div><div>/siri</div>
</div><div><br><br><div class="gmail_quote">2014-04-22 20:42 GMT+02:00 Cobus Carstens <span dir="ltr"><<a href="javascript:" target="_blank" gdf-obfuscated-mailto="6S4-AIZ2_58J" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">cobus.c...@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all<br>
<br>
I wrote 4 utility functions[1] that allows searching a gb_tree for:<br>
- the smallest key greater than the specified one<br>
- the smallest key greater or equal to the specified one<br>
- the greatest key smaller than the specified one<br>
- the greatest key smaller or equal to the specified one.<br>
<br>
This is nothing special, but my question (mostly directed to the OTP<br>
people) is: Would this be something that I can contribute to the<br>
gb_trees module (or maybe a gb_trees_utils module)? Would a<br>
pull-request suffice?<br>
<br>
[1] For those interested, the implementation can be found at:<br>
<a href="https://github.com/cobusc/erlang_gb_trees_utils" target="_blank" onmousedown="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcobusc%2Ferlang_gb_trees_utils\46sa\75D\46sntz\0751\46usg\75AFQjCNE9E9Y27wI7og33Hoc7L4JgEx7smg';return true;" onclick="this.href='https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fcobusc%2Ferlang_gb_trees_utils\46sa\75D\46sntz\0751\46usg\75AFQjCNE9E9Y27wI7og33Hoc7L4JgEx7smg';return true;">https://github.com/cobusc/<wbr>erlang_gb_trees_utils</a><br>
<br>
Regards,<br>
  Cobus<br>
______________________________<wbr>_________________<br>
erlang-questions mailing list<br>
<a href="javascript:" target="_blank" gdf-obfuscated-mailto="6S4-AIZ2_58J" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">erlang-q...@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-questions" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Ferlang.org%2Fmailman%2Flistinfo%2Ferlang-questions\46sa\75D\46sntz\0751\46usg\75AFQjCNH15VBDH9qL9o1Zx3x6ZeLmwvUvTg';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Ferlang.org%2Fmailman%2Flistinfo%2Ferlang-questions\46sa\75D\46sntz\0751\46usg\75AFQjCNH15VBDH9qL9o1Zx3x6ZeLmwvUvTg';return true;">http://erlang.org/mailman/<wbr>listinfo/erlang-questions</a><br>
</blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>______________________________<wbr>_________________</span><br><span>erlang-questions mailing list</span><br><span><a href="javascript:" target="_blank" gdf-obfuscated-mailto="6S4-AIZ2_58J" onmousedown="this.href='javascript:';return true;" onclick="this.href='javascript:';return true;">erlang-q...@erlang.org</a></span><br><span><a href="http://erlang.org/mailman/listinfo/erlang-questions" target="_blank" onmousedown="this.href='http://www.google.com/url?q\75http%3A%2F%2Ferlang.org%2Fmailman%2Flistinfo%2Ferlang-questions\46sa\75D\46sntz\0751\46usg\75AFQjCNH15VBDH9qL9o1Zx3x6ZeLmwvUvTg';return true;" onclick="this.href='http://www.google.com/url?q\75http%3A%2F%2Ferlang.org%2Fmailman%2Flistinfo%2Ferlang-questions\46sa\75D\46sntz\0751\46usg\75AFQjCNH15VBDH9qL9o1Zx3x6ZeLmwvUvTg';return true;">http://erlang.org/mailman/<wbr>listinfo/erlang-questions</a></span><br></div></blockquote></div></blockquote></div>