<br>>>It appears that you looked at eno's version of the parser. <br>
<br>Yes. Sorry, I didn't see your email. In fact, I still don't see it, only the reply from Jan Lehnardt. Did you cc the list?<br><br><br>>>I've implemented some of these suggestions and get a bit of a speed increase.<br>
<br>Cool. I notice the numbers in Jan's email.<br><br>My reference baseline is JSON:XS. <a href="http://search.cpan.org/dist/JSON-XS/">http://search.cpan.org/dist/JSON-XS/</a> <br><br>It would be interesting to compare performance with that. I'll do that. Please can you send me a link to your code?<br>
<br><br>>>1. use the control callback<br><br>Interesting. For a very large document that's presumably going block the VM, but for small documents it might well be the fastest. If that's true, the Erlang side should check the input document size and choose the communication mechanism accordingly. <br>
<br><br>>>2, I actually hacked yajl a bit to decode utf-8 data into the same buffer it's reading from<br>
specifically to avoid any memcpy stuff. The downside is that this<br>
destroys the original binary term.<br><br>I wonder if that is safe on the data you get from control(). The docs don't seem to say. The pointer is a char* not a const char*, but that might simply be oversight.<br><br>
<br>>>With some more hacking on yajl, it's possible that we could change around the<br>
original unicode buffer stuff to decode all unicode strings into a<br>
single buffer and then reference that buffer etc.<br><br>Yes you could allocate a single driver binary of conservative size, incrementally fill it with data (using sub-binary references in the constructed term) and then realloc the binary to the final size (if it is too large) at the end. Good idea. I thought I read somewhere that Yajl will only copy strings that have unicode characters, so this method would presumably only copy those strings. All ascii/latin1 strings (most I would imagine) wouldn't need to be copied (if outputv were used).<br>
<br><br>If that doesn't get performance close to JSON:XS then it might be worth ditching Yajl and adapting the C portion of JSON:XS. (Fortunately Perl internally works with unicode strings as utf8, so even the unicode part should be directly applicable). However, I haven't yet looked at the JSON:XS implementation at all.<br>
<br><br>>>I hadn't heard of EDTK prior to now, I'll take a look in the near future.<br>
<br>It's the Erlang Driver Toolkit. Originally written by Scott Lystig Fritchie. It's a code generator. It allows you to write XML file with a declaration of a C API, and it will generate an Erlang driver for that library, that works in both linked-in and spawned-program modes. A major feature is that it tracks resources allocated by the library, and guarantees correct cleanup (including ordering constraints). Another major feature is the concept of a 'port coordinator', used to allow efficient access to a single port instance if creating one per Erlang process is too expensive (as it is with BerkeleyDB).<br>
<br>I enhanced it a quite lot (inc. private threadpools) to implement a production-quality Berkeley DB driver (which also supports replication).<br><br>EDTK only works on Linux at the moment. Some people made a lot of progress with an OS-X port, but I never heard if it was finished. A Win32 port is feasible, esp. now that R12B exposes portable variants of the pthread primitives, but would be a fair amount of work.<br>
<br>The code (and a couple of papers/presenations) is here: <a href="http://www.snookles.com/erlang/edtk/">http://www.snookles.com/erlang/edtk/</a><br>License is BSD.<br><br>Chris<br><br><br><div class="gmail_quote">On Mon, Jan 26, 2009 at 6:31 PM, Paul Davis <span dir="ltr"><<a href="mailto:paul.joseph.davis@gmail.com">paul.joseph.davis@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">On Mon, Jan 26, 2009 at 8:52 PM, Chris Newcombe<br>
<<a href="mailto:chris.newcombe@gmail.com">chris.newcombe@gmail.com</a>> wrote:<br>
> Hi Enrico,<br>
><br>
> I'm looking for a faster JSON parser too, and was about to tackle this, so<br>
> thanks for sharing your work. (I found that Erlang, even with +native<br>
> compilation, takes ~800 millsecs to parse a 1MB JSON document, where as perl<br>
> JSON:XS (in C) takes 5 milliseconds for the same data. The reverse encoding<br>
> is just as bad.)<br>
><br>
> I haven't tried your code yet, but I did glance briefly at it:<br>
> I noticed a couple of things that I suspect are bottlenecks:<br>
><br>
> - the code using the 'output()' callback in the driver entry structure to<br>
> receive the input JSON document. That means that Erlang is having to copy<br>
> the input.<br>
> - the code returns the encoded result via driver_output2() (rather than<br>
> driver_output_binary or driver_outputv). This means that the encoded<br>
> response is being copied.<br>
> - the code generates the result Erlang term via ei_x_encode*. This<br>
> copies the string data, and also encodes it to Erlang's external-term format<br>
> (which is rather similar to a binary form of JSON). The Erlang side then<br>
> has to decode from the external-term format via (and erlang:binary_to_term<br>
> on the receiving end).<br>
><br>
<br>
</div>It appears that you looked at eno's version of the parser. I've<br>
implemented some of these suggestions and get a bit of a speed<br>
increase.<br>
<br>
My specifics were:<br>
<br>
1. use the control callback<br>
2. driver_send_term to send an ErlDrvTermData array back<br>
<div class="Ih2E3d"><br>
> I think it is possible to avoid all of these, and hopefully achieve<br>
> JSON:XS-level speed mentioned above.<br>
> e.g.<br>
><br>
> 1. Use outputv() to receive the input JSON document as one large binary<br>
> (no copying). e.g. If the data was received via gen_tcp socket in binary<br>
> mode, only small binary header pointing to the data would be sent to the<br>
> driver.<br>
><br>
> 2. Parse with yaj, and generate the result term with the little<br>
> term-construction language definef for driver_output_term() see<br>
> <a href="http://www.erlang.org/doc/man/erl_driver.html#driver_output_term" target="_blank">http://www.erlang.org/doc/man/erl_driver.html#driver_output_term</a><br>
> In particular, using ERL_DRV_BINARY strings (keys and values) can be<br>
> sub-binaries of the original input-binary, so there is no copying.<br>
><br>
> 3. Send the result back to Erlang via driver_send_term or<br>
> driver_output_term. This directly transfers ownership of the constructed<br>
> term to the VM, so there is<br>
> a) no copying, of either the term structure, or the key/value<br>
> strings (which are still sub-binaries of the larger input binary)<br>
> and b) no encoding or decoding through an intermediate format (i.e. no use<br>
> of the external term format)<br>
><br>
> 5. Use EDTK for all of the boilerplate. This implements the above<br>
> outputv / driver_send_term mechanism, but with one current problem.<br>
> Currently the size of the result term is very limited (it's only been used<br>
> for sending small results). I would need to make that dynamic. (This is<br>
> the main reason I haven't done it yet -- might require some surgery).<br>
><br>
<br>
</div>I'm pretty sure I'm using all of these with the exception of the<br>
outputv callback. Following along point number 2, I actually hacked<br>
yajl a bit to decode utf-8 data into the same buffer it's reading from<br>
specifically to avoid any memcpy stuff. The downside is that this<br>
destroys the original binary term.<br>
<br>
The way I read your explanation, this means that I'm not actually<br>
destroying the binary that erlang is using so this would be ok but at<br>
the cost of making the large memcpy in the erlang VM. With some more<br>
hacking on yajl, it's possible that we could change around the<br>
original unicode buffer stuff to decode all unicode strings into a<br>
single buffer and then reference that buffer etc.<br>
<div class="Ih2E3d"><br>
<br>
> One consequence of making sub-binaries of the larger input binary is that<br>
> the larger input binary cannot be garbage-collected until every key and<br>
> value sub-binary has been destroyed. That may cause excessive memory usage<br>
> in some scenarios. So I'm planning on implementing an option to create<br>
> copies for keys and/or values. However, that only causes 1 copy, as step<br>
> (3) can still transfer the new binaries back to Erlang without copying the<br>
> data.<br>
><br>
> However, I'm not sure when I'll get to tackle this -- perhaps in the next<br>
> few weeks, but it might be further out than that.<br>
><br>
<br>
</div>I hadn't heard of EDTK prior to now, I'll take a look in the near future.<br>
<div><div></div><div class="Wj3C7c"><br>
><br>
>>> . I need some hints regarding "parallel execution".<br>
><br>
>>> The native driver does not support multithreading (and why should it? It<br>
>>> only<br>
>>> complicates things where OTP can do that kind of stuff by itself<br>
>>> already.)<br>
><br>
> This very much depends. Erlang 'multithreading' is at the Erlang<br>
> process-level only (i.e. Erlang has its own process scheduler). If Erlang<br>
> calls a driver, then by default the OS thread running the erlang process<br>
> scheduler is blocked until the driver returns.<br>
><br>
> That's fine for short operations, but e.g. if parsing a really huge JSON<br>
> object, you don't want to block the Erlang scheduler for tens/hundreds of<br>
> milliseconds (literally the entire VM is stalled, or part of the VM in SMP<br>
> mode, when there are multiple scheduler OS threads).<br>
><br>
> Drivers can use driver_async() to run work in a separate thread-pool, to<br>
> avoid blocking the scheduler. However, other Erlang drivers use that thread<br>
> pool for significant slow tasks, e.g. file IO.<br>
><br>
> EDTK implements private thread-pools to work around that problem. My plan<br>
> was to test the size of the input JSON document and do a blocking operation<br>
> if it is small (say a < 100KB) and a threadpool operation otherwise.<br>
><br>
><br>
>>>With the current code the driver gets loaded only once.<br>
><br>
> That's fine.<br>
><br>
><br>
>>>Therefore on a multicore machine only one CPU gets really used.<br>
><br>
> If you are not running Erlang in SMP mode then it will only use a single CPU<br>
> for driver operations unless you use the driver_async() feature or private<br>
> threadpools like EDTK.<br>
><br>
> If you are running in SMP mode with more than one scheduler OS thread, then<br>
> the level of driver concurrency depends on the 'locking mode' for the<br>
> driver. By default conservative 'driver-level' locking is used, as many<br>
> drivers were written before SMP was implemented and are not thread-safe.<br>
> However, if your driver is thread-safe then you can easily switch to<br>
> port-level locking, and if multiple Erlang processes each have their own<br>
> open port using the driver, then Erlang scheduler threads can call the<br>
> driver simultaneously. However, if you do this you still need to worry<br>
> about the effects of blocking the Erlang VM schedulers for any significant<br>
> amount of time. That's why private threadpools are still important.<br>
><br>
> From <a href="http://www.erlang.org/doc/man/erl_driver.html" target="_blank">http://www.erlang.org/doc/man/erl_driver.html</a><br>
><br>
> "In the runtime system with SMP support, drivers are locked either on<br>
> driver level or port level (driver instance level). By default driver level<br>
> locking will be used, i.e., only one emulator thread will execute code in<br>
> the driver at a time. If port level locking is used, multiple emulator<br>
> threads may execute code in the driver at the same time. There will only be<br>
> one thread at a time calling driver call-backs corresponding to the same<br>
> port, though. In order to enable port level locking set the<br>
> ERL_DRV_FLAG_USE_PORT_LOCKING driver flag in the driver_entry used by the<br>
> driver. When port level locking is used it is the responsibility of the<br>
> driver writer to synchronize all accesses to data shared by the ports<br>
> (driver instances)."<br>
><br>
<br>
</div></div>Yeah, this one bit me in the ass by not realizing what the flag meant.<br>
Turns out zero means lock harder, not no locking...<br>
<div class="Ih2E3d"><br>
> I hope this helps,<br>
><br>
> Chris<br>
><br>
<br>
</div>Thanks for your help. At some point I'll poke at changing the control<br>
-> outputv call back to see if there's a noticeable speedup. If so<br>
then I imagine it'd be time to look at working on the yajl internals<br>
to save time when unicode is a factor.<br>
<br>
Thanks again,<br>
<font color="#888888">Paul Davis<br>
</font><div><div></div><div class="Wj3C7c"><br>
><br>
> On Sun, Jan 25, 2009 at 1:49 PM, Enrico Thierbach<br>
> <<a href="mailto:enrico.thierbach@googlemail.com">enrico.thierbach@googlemail.com</a>> wrote:<br>
>><br>
>> Hi guys,<br>
>><br>
>> I have just finished what I would call the first stage of the native<br>
>> JSON parser implementation. This is the state as of now at<br>
>> <a href="http://github.com/pboy/eep0018/" target="_blank">http://github.com/pboy/eep0018/</a>, Please see the readme file.<br>
>><br>
>> In short, this is the status:<br>
>><br>
>> - I parse everything that comes along like mochijson2 and rabbitmq<br>
>> - optionally I can parse according to eep0018<br>
>> - my code runs 6 times as fast as mochijson2/rabbitmq at JSON input<br>
>> of a certain size, and is usally not slower on very small JSON input.<br>
>><br>
>> jan tried the module along with couchdb, and find one issue regarding<br>
>> UTF8 characters; besides of that everything seemed to run fine and<br>
>> much faster. The utf8 parsing issue is resolved (or better: worked<br>
>> around: the JSON parser and the CouchDB tests have different ideas on<br>
>> what is valid UTF8).<br>
>><br>
>> What would be next?<br>
>><br>
>> 1. I would like to invite you all to review and try the code.<br>
>><br>
>> 2. I need some hints regarding "parallel execution". The native driver<br>
>> does not support multithreading (and why should it? It only<br>
>> complicates things where OTP can do that kind of stuff by itself<br>
>> already.) With the current code the driver gets loaded only once.<br>
>> Therefore on a multicore machine only one CPU gets really used. Is it<br>
>> somehow possible to load the driver multiple times? The only way I see<br>
>> so far is having the driver compiled and installed multiple times with<br>
>> different names; but I guess there is a better way. The code itself<br>
>> should luckily run in a parallel situation.<br>
>><br>
>> 3. and finally I'll have to tackle the Erlang->JSON issue. I don't<br>
>> expect a speedup as big.<br>
>><br>
>> Please see my next mail for some comments on EEP0018.<br>
>><br>
>> /eno<br>
>><br>
>> ====================================================================<br>
>> A wee piece of ruby every monday: <a href="http://1rad.wordpress.com/" target="_blank">http://1rad.wordpress.com/</a><br>
>> _______________________________________________<br>
>> erlang-questions mailing list<br>
>> <a href="mailto:erlang-questions@erlang.org">erlang-questions@erlang.org</a><br>
>> <a href="http://www.erlang.org/mailman/listinfo/erlang-questions" target="_blank">http://www.erlang.org/mailman/listinfo/erlang-questions</a><br>
><br>
><br>
</div></div></blockquote></div><br>